plugin_framework, test plugin manager, uninstall is not fully tested

Signed-off-by: fufesou <shuanglongchen@yeah.net>

flutter/lib/plugin/manager.dart

@@ -144,17 +144,20 @@ class PluginInfo with ChangeNotifier {
   SourceInfo sourceInfo;
   Meta meta;
   String installedVersion; // It is empty if not installed.
-  DateTime installTime;
+  String failedMsg;
   String invalidReason; // It is empty if valid.
 
   PluginInfo({
     required this.sourceInfo,
     required this.meta,
     required this.installedVersion,
-    required this.installTime,
     required this.invalidReason,
+    this.failedMsg = '',
   });
 
+  bool get installed => installedVersion.isNotEmpty;
+  bool get needUpdate => installed && installedVersion != meta.version;
+
   void update(PluginInfo plugin) {
     assert(plugin.meta.id == meta.id, 'Plugin id not match');
     if (plugin.meta.id != meta.id) {
@@ -164,10 +167,28 @@ class PluginInfo with ChangeNotifier {
     sourceInfo = plugin.sourceInfo;
     meta = plugin.meta;
     installedVersion = plugin.installedVersion;
-    installTime = plugin.installTime;
     invalidReason = plugin.invalidReason;
     notifyListeners();
   }
+
+  void setInstall(String msg) {
+    if (msg == "finished") {
+      msg = '';
+    }
+    failedMsg = msg;
+    if (msg.isEmpty) {
+      installedVersion = meta.version;
+    }
+    notifyListeners();
+  }
+
+  void setUninstall(String msg) {
+    failedMsg = msg;
+    if (msg.isEmpty) {
+      installedVersion = '';
+    }
+    notifyListeners();
+  }
 }
 
 class PluginManager with ChangeNotifier {
@@ -194,11 +215,27 @@ class PluginManager with ChangeNotifier {
       _handlePluginList(evt['plugin_list']);
     } else if (evt['plugin_update'] != null) {
       _handlePluginUpdate(evt['plugin_update']);
+    } else if (evt['plugin_install'] != null && evt['id'] != null) {
+      _handlePluginInstall(evt['id'], evt['plugin_install']);
+    } else if (evt['plugin_uninstall'] != null && evt['id'] != null) {
+      _handlePluginUninstall(evt['id'], evt['plugin_uninstall']);
     } else {
       debugPrint('Failed to handle manager event: $evt');
     }
   }
 
+  void _sortPlugins() {
+    plugins.sort((a, b) {
+      if (a.installed) {
+        return -1;
+      } else if (b.installed) {
+        return 1;
+      } else {
+        return 0;
+      }
+    });
+  }
+
   void _handlePluginUpdate(Map<String, dynamic> evt) {
     final plugin = _getPluginFromEvent(evt);
     if (plugin == null) {
@@ -207,6 +244,8 @@ class PluginManager with ChangeNotifier {
     for (var i = 0; i < _plugins.length; i++) {
       if (_plugins[i].meta.id == plugin.meta.id) {
         _plugins[i].update(plugin);
+        _sortPlugins();
+        notifyListeners();
         return;
       }
     }
@@ -225,9 +264,32 @@ class PluginManager with ChangeNotifier {
     } catch (e) {
       debugPrint('Failed to decode $e,  plugin list \'$pluginList\'');
     }
+    _sortPlugins();
     notifyListeners();
   }
 
+  void _handlePluginInstall(String id, String msg) {
+    for (var i = 0; i < _plugins.length; i++) {
+      if (_plugins[i].meta.id == id) {
+        _plugins[i].setInstall(msg);
+        _sortPlugins();
+        notifyListeners();
+        return;
+      }
+    }
+  }
+
+  void _handlePluginUninstall(String id, String msg) {
+    for (var i = 0; i < _plugins.length; i++) {
+      if (_plugins[i].meta.id == id) {
+        _plugins[i].setUninstall(msg);
+        _sortPlugins();
+        notifyListeners();
+        return;
+      }
+    }
+  }
+
   PluginInfo? _getPluginFromEvent(Map<String, dynamic> evt) {
     final s = evt['source'];
     assert(s != null, 'Source is null');
@@ -273,19 +335,10 @@ class PluginManager with ChangeNotifier {
       publishInfo:
           PublishInfo(lastReleased: lastReleased, published: published),
     );
-
-    late DateTime installTime;
-    try {
-      installTime =
-          DateTime.parse(evt['install_time'] ?? '1970-01-01T00+00:00');
-    } catch (e) {
-      installTime = DateTime.utc(1970);
-    }
     return PluginInfo(
       sourceInfo: source,
       meta: meta,
       installedVersion: evt['installed_version'],
-      installTime: installTime,
       invalidReason: evt['invalid_reason'] ?? '',
     );
   }

flutter/lib/plugin/widgets/desktop_settings.dart

@@ -28,10 +28,13 @@ class DesktopSettingsCard extends StatefulWidget {
 
 class _DesktopSettingsCardState extends State<DesktopSettingsCard> {
   PluginInfo get plugin => widget.plugin;
-  bool get installed => plugin.installedVersion.isNotEmpty;
+  bool get installed => plugin.installed;
+
+  bool isEnabled = false;
 
   @override
   Widget build(BuildContext context) {
+    isEnabled = bind.pluginIsEnabled(id: plugin.meta.id);
     return Row(
       children: [
         Flexible(
@@ -70,7 +73,7 @@ class _DesktopSettingsCardState extends State<DesktopSettingsCard> {
       child: Row(
         children: [
           Text(
-            translate(widget.plugin.meta.name),
+            widget.plugin.meta.name,
             textAlign: TextAlign.start,
             style: const TextStyle(
               fontSize: _kTitleFontSize,
@@ -95,24 +98,25 @@ class _DesktopSettingsCardState extends State<DesktopSettingsCard> {
     return Container(
       child: ElevatedButton(
         onPressed: onPressed,
-        child: Text(label),
+        child: Text(translate(label)),
       ),
     );
   }
 
   Widget headerInstallEnable() {
-    final installButton = headerButton(installed ? 'uninstall' : 'install', () {
-      bind.pluginInstall(
-        id: plugin.meta.id,
-        b: !installed,
-      );
-    });
+    final installButton = headerButton(
+      installed ? 'Uninstall' : 'Install',
+      () {
+        bind.pluginInstall(
+          id: plugin.meta.id,
+          b: !installed,
+        );
+      },
+    );
 
     if (installed) {
-      final needUpdate =
-          plugin.installedVersion.compareTo(plugin.meta.version) < 0;
-      final updateButton = needUpdate
-          ? headerButton('update', () {
+      final updateButton = plugin.needUpdate
+          ? headerButton('Update', () {
               bind.pluginInstall(
                 id: plugin.meta.id,
                 b: !installed,
@@ -120,10 +124,9 @@ class _DesktopSettingsCardState extends State<DesktopSettingsCard> {
             })
           : Container();
 
-      final isEnabled = bind.pluginIsEnabled(id: plugin.meta.id);
       final enableButton = !installed
           ? Container()
-          : headerButton(isEnabled ? 'disable' : 'enable', () {
+          : headerButton(isEnabled ? 'Disable' : 'Enable', () {
               if (isEnabled) {
                 clearPlugin(plugin.meta.id);
               }
@@ -175,7 +178,7 @@ class _DesktopSettingsCardState extends State<DesktopSettingsCard> {
   }
 
   Widget more() {
-    if (!installed) {
+    if (!(installed && isEnabled)) {
       return Container();
     }