From afdaeb3d3458029538f3b37a084f019c22f85aa7 Mon Sep 17 00:00:00 2001
From: Gustav <Guarzo.eve@gmail.com>
Date: Thu, 30 Jan 2025 15:11:58 -0700
Subject: [PATCH] fix: design feedback patch

---
 .../SystemKillsContent/SystemKillsContent.tsx        |  2 +-
 .../SystemKills/components/CompactKillRow.tsx        |  2 +-
 .../widgets/SystemKills/components/FullKillRow.tsx   | 12 +++---------
 .../SystemKills/components/KillRowSubInfo.tsx        |  8 ++++----
 .../SystemKills/components/SystemKillRow.module.scss |  8 +++++++-
 5 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/SystemKillsContent/SystemKillsContent.tsx b/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/SystemKillsContent/SystemKillsContent.tsx
index 65a79baf..67d74793 100644
--- a/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/SystemKillsContent/SystemKillsContent.tsx
+++ b/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/SystemKillsContent/SystemKillsContent.tsx
@@ -28,7 +28,7 @@ export const SystemKillsContent: React.FC<SystemKillsContentProps> = ({
     <div
       className={clsx(
         'flex flex-col w-full text-stone-200 text-xs transition-all duration-300',
-        compact ? 'gap-0.5 p-1' : 'gap-1 p-1',
+        compact ? 'p-1' : 'p-1',
       )}
     >
       {sortedKills.map(kill => {
diff --git a/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/CompactKillRow.tsx b/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/CompactKillRow.tsx
index 9a4392e5..946c7c64 100644
--- a/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/CompactKillRow.tsx
+++ b/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/CompactKillRow.tsx
@@ -61,7 +61,7 @@ export const CompactKillRow: React.FC<CompactKillRowProps> = ({ killDetails, sys
   return (
     <div
       className={clsx(
-        'h-10 flex items-center border-b border-stone-700 px-1',
+        'h-10 flex items-center border-b border-stone-800',
         'text-xs whitespace-nowrap overflow-hidden leading-none',
       )}
     >
diff --git a/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/FullKillRow.tsx b/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/FullKillRow.tsx
index bee516c4..b7847e64 100644
--- a/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/FullKillRow.tsx
+++ b/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/FullKillRow.tsx
@@ -61,14 +61,8 @@ export const FullKillRow: React.FC<FullKillRowProps> = ({ killDetails, systemNam
   const attackerSubscript = getAttackerSubscript(killDetails);
 
   return (
-    <div
-      className={clsx(
-        classes.killRowContainer,
-        'h-16 w-full justify-between items-start bg-stone-900 hover:bg-stone-800 text-sm',
-        'border border-stone-800 rounded-[4px]',
-      )}
-    >
-      <div className="flex items-start gap-2 pl-1 min-w-0 pt-1 h-full">
+    <div className={clsx(classes.killRowContainer, 'h-18 w-full justify-between items-start text-sm py-[4px]')}>
+      <div className="flex items-start gap-1 min-w-0 h-full">
         {victimShipUrl && (
           <div className="relative shrink-0 w-14 h-14 overflow-hidden">
             <a
@@ -111,7 +105,7 @@ export const FullKillRow: React.FC<FullKillRowProps> = ({ killDetails, systemNam
         </div>
       </div>
 
-      <div className="flex items-start gap-2 pr-1 pt-1 min-w-0 h-full">
+      <div className="flex items-start gap-2 min-w-0 h-full">
         <div className="flex flex-col items-end leading-4 min-w-0 overflow-hidden text-right">
           {!attackerIsNpc && (
             <div className="truncate font-semibold">
diff --git a/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/KillRowSubInfo.tsx b/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/KillRowSubInfo.tsx
index e784c73d..250b5900 100644
--- a/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/KillRowSubInfo.tsx
+++ b/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/KillRowSubInfo.tsx
@@ -27,7 +27,7 @@ export const KillRowSubInfo: React.FC<KillRowSubInfoProps> = ({
   }
 
   return (
-    <div className="flex items-start gap-2 h-full">
+    <div className="flex items-start gap-1 h-full">
       {victimPortraitUrl && victimCharacterId && (
         <a
           href={zkillLink('character', victimCharacterId)}
@@ -42,13 +42,13 @@ export const KillRowSubInfo: React.FC<KillRowSubInfoProps> = ({
           />
         </a>
       )}
-      <div className="flex flex-col h-full">
+      <div className="flex flex-col h-full justify-between">
         {victimCorpLogoUrl && victimCorpId && (
           <a
             href={zkillLink('corporation', victimCorpId)}
             target="_blank"
             rel="noopener noreferrer"
-            className="shrink-0 h-1/2"
+            className="shrink-0 h-[26px]"
           >
             <img
               src={victimCorpLogoUrl}
@@ -62,7 +62,7 @@ export const KillRowSubInfo: React.FC<KillRowSubInfoProps> = ({
             href={zkillLink('alliance', victimAllianceId)}
             target="_blank"
             rel="noopener noreferrer"
-            className="shrink-0 h-1/2"
+            className="shrink-0 h-[26px]"
           >
             <img
               src={victimAllianceLogoUrl}
diff --git a/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/SystemKillRow.module.scss b/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/SystemKillRow.module.scss
index dd46c3ac..b4819f57 100644
--- a/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/SystemKillRow.module.scss
+++ b/assets/js/hooks/Mapper/components/mapInterface/widgets/SystemKills/components/SystemKillRow.module.scss
@@ -1,5 +1,11 @@
 .killRowContainer {
-  @apply flex items-center border-b border-stone-700 whitespace-nowrap overflow-hidden;
+  @apply flex items-center whitespace-nowrap overflow-hidden;
+
+  &:not(:last-child) {
+    @apply border-b border-stone-800;
+  }
+
+  @apply bg-transparent transition-all hover:bg-stone-900 hover:border-stone-700;
 }
 
 .killRowImage {