lee/Recordly
1
0
Fork 0
mirror of https://github.com/webadderallorg/Recordly.git synced 2026-09-24 14:55:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: cursor DPI normalization for Windows/Linux scaled displays

Browse Source 
On non-macOS platforms, platform APIs (iohook, GetWindowRect, xwininfo)
return physical pixel coordinates while Electron returns DIP coordinates.
Apply scaleFactor correction so cursor normalization uses a consistent
coordinate space. Fixes ~30-40px cursor offset on Windows 11 and Linux
Mint when display scaling is >100%.

Also fixes winget-releaser workflow (use v2 tag instead of invalid @latest).
This commit is contained in:
webadderall
2026-04-09 15:58:17 +10:00
parent b6859efd82
commit 646dcf92f0
2 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/winget-releaser.yml
+1 -1
View File
@@ -6,7 +6,7 @@ jobs:
publish:
runs-on: windows-latest
steps:
- uses: vedantmgoyal9/winget-releaser@latest
- uses: vedantmgoyal9/winget-releaser@v2
with:
identifier: Webadderall.Recordly
installers-regex: 'windows\-x64\.exe'
electron/ipc/handlers.ts
+13 -5
View File
@@ -3425,18 +3425,26 @@ function getNormalizedCursorPoint() {
const isLinuxCacheFresh = !!linuxCursorCache
&& Date.now() - linuxCursorCache.updatedAt <= 1000
// On Windows/Linux, platform APIs (iohook, GetWindowRect, xwininfo) return
// physical pixel coordinates, while Electron's getCursorScreenPoint() and
// display.bounds return DIP (logical) coordinates. Apply a DPI correction
// so all values are in the same coordinate space before normalizing.
const sf = process.platform !== 'darwin'
? (getScreen().getPrimaryDisplay().scaleFactor || 1)
: 1
const cursor = isLinuxCacheFresh
? { x: linuxCursorCache.x, y: linuxCursorCache.y }
? { x: linuxCursorCache.x / sf, y: linuxCursorCache.y / sf }
: fallbackCursor
const windowBounds = selectedSource?.id?.startsWith('window:') ? selectedWindowBounds : null
if (windowBounds) {
const width = Math.max(1, windowBounds.width)
const height = Math.max(1, windowBounds.height)
const width = Math.max(1, windowBounds.width / sf)
const height = Math.max(1, windowBounds.height / sf)
return {
cx: clamp((cursor.x - windowBounds.x) / width, 0, 1),
cy: clamp((cursor.y - windowBounds.y) / height, 0, 1),
cx: clamp((cursor.x - windowBounds.x / sf) / width, 0, 1),
cy: clamp((cursor.y - windowBounds.y / sf) / height, 0, 1),
}
}