lee/Recordly
1
0
Fork 0
mirror of https://github.com/webadderallorg/Recordly.git synced 2026-09-25 23:35:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(timeline): prevent clip regions from overlapping during drag/resize

Browse Source 
The hasOverlap function in TimelineEditor checked zoom, trim, speed, and
audio regions for overlap but was missing clip regions entirely. This
caused clips to freely overlap each other when dragged or resized,
leading to playback bugs when trimmed clips intersected.

Add clip region overlap detection so the existing clampToNeighbours
logic in TimelineWrapper correctly constrains clip boundaries.

Closes #166
This commit is contained in:
webadderall
2026-04-09 23:25:00 +10:00
parent 6703e6fb63
commit 68999b1605
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/video-editor/timeline/TimelineEditor.tsx
+7 -2
View File
@@ -967,6 +967,7 @@ export default function TimelineEditor({
// Determine which row the item belongs to
const isZoomItem = zoomRegions.some(r => r.id === excludeId);
const isTrimItem = trimRegions.some(r => r.id === excludeId);
const isClipItem = clipRegions.some(r => r.id === excludeId);
const isAnnotationItem = annotationRegions.some(r => r.id === excludeId);
const isSpeedItem = speedRegions.some(r => r.id === excludeId);
const isAudioItem = audioRegions.some(r => r.id === excludeId);
@@ -976,7 +977,7 @@ export default function TimelineEditor({
}
// Helper to check overlap against a specific set of regions
const checkOverlap = (regions: (ZoomRegion | TrimRegion | SpeedRegion | AudioRegion)[]) => {
const checkOverlap = (regions: (ZoomRegion | TrimRegion | ClipRegion | SpeedRegion | AudioRegion)[]) => {
return regions.some((region) => {
if (region.id === excludeId) return false;
// True overlap: regions actually intersect (not just adjacent)
@@ -992,6 +993,10 @@ export default function TimelineEditor({
return checkOverlap(trimRegions);
}
if (isClipItem) {
return checkOverlap(clipRegions);
}
if (isSpeedItem) {
return checkOverlap(speedRegions);
}
@@ -1001,7 +1006,7 @@ export default function TimelineEditor({
}
return false;
}, [zoomRegions, trimRegions, annotationRegions, speedRegions, audioRegions]);
}, [zoomRegions, trimRegions, clipRegions, annotationRegions, speedRegions, audioRegions]);
// Keep newly added timeline regions at the original short default instead of
// scaling them with the full recording length.