lee/Recordly
1
0
Fork 0
mirror of https://github.com/webadderallorg/Recordly.git synced 2026-09-24 23:05:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't let webcam teardown block native stop IPC

Browse Source 
Start webcam stop as a guarded promise so a rejection can't prevent
stopNativeScreenRecording from running. The webcam result is awaited
only after the native stop path completes.
This commit is contained in:
webadderall
2026-04-20 22:29:28 +10:00
parent 66a5ef3e27
commit 99f8ef0ae9
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/hooks/useScreenRecorder/recordingStopHelpers.ts
+5 -1
View File
@@ -26,7 +26,10 @@ export async function stopNativeRecordingSession(options: StopRecordingOptions)
options.showRecordingFinalizationToast();
const micFallbackBlobPromise = stopMicFallbackRecorder(options.refs);
const webcamPath = await stopWebcamRecorder(options.refs);
const webcamPathPromise = stopWebcamRecorder(options.refs).catch((error) => {
console.warn("Failed to stop webcam recorder:", error);
return null;
});
const isNativeWindows = options.refs.nativeWindowsRecording.current;
options.markRecordingResumed(Date.now());
const pauseSegments = options.refs.pauseSegmentsRef.current.slice();
@@ -82,6 +85,7 @@ export async function stopNativeRecordingSession(options: StopRecordingOptions)
finalPath = muxResult?.path ?? result.path;
}
const webcamPath = await webcamPathPromise;
await options.storeMicrophoneSidecar(micFallbackBlobPromise, finalPath);
await options.finalizeRecordingSession(finalPath, webcamPath);
return true;