mirror of
https://github.com/webadderallorg/Recordly.git
synced 2026-11-09 07:23:14 +00:00
fix: address motion blur review feedback
This commit is contained in:
1 parent
7c97867020
commit
bb3450f401
7 files changed
+21
-14
No files matched your search
@@ -5282,18 +5282,21 @@ export default function VideoEditor() {
|
||||
<DialogContent className="max-w-md bg-editor-dialog border-foreground/10 text-foreground">
|
||||
<DialogHeader>
|
||||
<DialogTitle>
|
||||
Nothing's broken, but we won't be able to render an animated
|
||||
cursor overlay.
|
||||
{t(
|
||||
"editor.nativeCaptureUnavailable.title",
|
||||
"Nothing’s broken, but we won’t be able to render an animated cursor overlay.",
|
||||
)}
|
||||
</DialogTitle>
|
||||
<DialogDescription className="text-muted-foreground">
|
||||
Your device does not support native capture. This could be for a variety of
|
||||
reasons we haven't figured out yet. This doesn't break Recordly,
|
||||
but it does make cursor smoothening impossible.
|
||||
{t(
|
||||
"editor.nativeCaptureUnavailable.description",
|
||||
"Your device does not support native capture. This could be for a variety of reasons we haven’t figured out yet. This doesn’t break Recordly, but it does make cursor smoothing impossible.",
|
||||
)}
|
||||
</DialogDescription>
|
||||
</DialogHeader>
|
||||
<DialogFooter>
|
||||
<Button onClick={() => setNativeCaptureUnavailableModalOpen(false)}>
|
||||
Okay
|
||||
{t("editor.nativeCaptureUnavailable.confirm", "Okay")}
|
||||
</Button>
|
||||
</DialogFooter>
|
||||
</DialogContent>
|
||||
|
||||
@@ -1299,7 +1299,7 @@ const VideoPlayback = forwardRef<VideoPlaybackRef, VideoPlaybackProps>(
|
||||
motionBlurStateRef.current = createMotionBlurState();
|
||||
videoEffectsContainer.filters =
|
||||
zoomMotionBlur > 0 ? [motionBlurFilter, zoomBlurFilter] : null;
|
||||
}, [zoomMotionBlur]);
|
||||
}, [videoPath, zoomMotionBlur]);
|
||||
|
||||
useEffect(() => {
|
||||
zoomMotionBlurTuningRef.current = zoomMotionBlurTuning;
|
||||
|
||||
@@ -376,7 +376,7 @@ export function normalizeProjectEditor(editor: Partial<ProjectEditorState>): Pro
|
||||
(editor as Partial<ProjectEditorState>).zoomTemporalMotionBlur,
|
||||
)
|
||||
? clamp((editor as Partial<ProjectEditorState>).zoomTemporalMotionBlur as number, 0, 2)
|
||||
: 0;
|
||||
: normalizedZoomMotionBlur;
|
||||
const normalizedBackgroundBlur = isFiniteNumber(
|
||||
(editor as Partial<ProjectEditorState>).backgroundBlur,
|
||||
)
|
||||
|
||||
@@ -113,6 +113,11 @@
|
||||
"project": {
|
||||
"untitled": "Untitled"
|
||||
},
|
||||
"nativeCaptureUnavailable": {
|
||||
"title": "Nothing’s broken, but we won’t be able to render an animated cursor overlay.",
|
||||
"description": "Your device does not support native capture. This could be for a variety of reasons we haven’t figured out yet. This doesn’t break Recordly, but it does make cursor smoothing impossible.",
|
||||
"confirm": "Okay"
|
||||
},
|
||||
"exportStatus": {
|
||||
"exporting": "Exporting",
|
||||
"renderingFile": "Rendering your file.",
|
||||
|
||||
@@ -113,6 +113,11 @@
|
||||
"project": {
|
||||
"untitled": "Sin título"
|
||||
},
|
||||
"nativeCaptureUnavailable": {
|
||||
"title": "Nada está roto, pero no podremos renderizar una superposición de cursor animada.",
|
||||
"description": "Tu dispositivo no es compatible con la captura nativa. Esto puede deberse a varias razones que todavía no hemos identificado. Recordly seguirá funcionando, pero hará imposible el suavizado del cursor.",
|
||||
"confirm": "Entendido"
|
||||
},
|
||||
"exportStatus": {
|
||||
"exporting": "Exportando",
|
||||
"renderingFile": "Renderizando tu archivo.",
|
||||
|
||||
@@ -78,8 +78,6 @@ import { ForwardFrameSource } from "./forwardFrameSource";
|
||||
import { resolveMediaElementSource } from "./localMediaSource";
|
||||
import { buildTemporalSamplePlanUs, getTemporalMotionBlurConfig } from "./temporalMotionBlur";
|
||||
|
||||
const TEMPORAL_ZOOM_MOTION_BLUR_ENABLED = false;
|
||||
|
||||
interface FrameRenderConfig {
|
||||
width: number;
|
||||
height: number;
|
||||
@@ -1278,7 +1276,6 @@ export class FrameRenderer {
|
||||
}
|
||||
|
||||
const temporalSnapshot =
|
||||
TEMPORAL_ZOOM_MOTION_BLUR_ENABLED &&
|
||||
(this.config.zoomTemporalMotionBlur ?? 0) > 0 &&
|
||||
typeof frameDurationUs === "number" &&
|
||||
frameDurationUs > 0
|
||||
|
||||
@@ -94,8 +94,6 @@ import {
|
||||
} from "./shadowProfile";
|
||||
import { buildTemporalSamplePlanUs, getTemporalMotionBlurConfig } from "./temporalMotionBlur";
|
||||
|
||||
const TEMPORAL_ZOOM_MOTION_BLUR_ENABLED = false;
|
||||
|
||||
import type { ExportRenderBackend } from "./types";
|
||||
|
||||
interface FrameRenderConfig {
|
||||
@@ -2719,7 +2717,6 @@ export class FrameRenderer {
|
||||
}
|
||||
|
||||
const temporalSnapshot =
|
||||
TEMPORAL_ZOOM_MOTION_BLUR_ENABLED &&
|
||||
(this.config.zoomTemporalMotionBlur ?? 0) > 0 &&
|
||||
typeof frameDurationUs === "number" &&
|
||||
frameDurationUs > 0
|
||||
|
||||
Reference in new issue
Block a user