lee/Recordly
1
0
Fork 0
mirror of https://github.com/webadderallorg/Recordly.git synced 2026-09-25 23:35:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #558 from webadderallorg/fix/cuda-inline-audio-validation

Browse Source 
fix(export): reject silent cuda inline audio
This commit is contained in:
Phạm Thị Minh Hồng
2026-05-22 19:54:10 +07:00
committed by GitHub
parent d7dde21d73 61bbaab7da
commit fb4e2d9c09
2 changed files with 49 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
electron/ipc/export/native-video.test.ts
+41
View File
@@ -1078,6 +1078,47 @@ describe("validateNvidiaCudaExportSummary", () => {
expect(issues).toEqual([]);
});
it("rejects inline-audio CUDA output when the helper does not produce audio", () => {
const issues = validateNvidiaCudaExportSummary(
{
success: true,
targetFrames: 300,
durationSec: 10,
nativeSummary: {
success: true,
frames: 300,
sourceTimestampMode: "pts",
selectionStage: "timestamp-mapped-callback",
},
outputVideo: { duration: "9.999900", nb_frames: "300" },
},
{ durationSec: 10, targetFrames: 300, requiresTimelineSync: true },
);
expect(issues).toEqual(["missing output audio stream"]);
});
it("rejects inline-audio CUDA output when the probed audio stream is empty", () => {
const issues = validateNvidiaCudaExportSummary(
{
success: true,
targetFrames: 300,
durationSec: 10,
nativeSummary: {
success: true,
frames: 300,
sourceTimestampMode: "pts",
selectionStage: "timestamp-mapped-callback",
},
outputVideo: { duration: "9.999900", nb_frames: "300" },
outputAudio: { duration: "0.000000" },
},
{ durationSec: 10, targetFrames: 300, requiresTimelineSync: true },
);
expect(issues).toEqual(["output audio duration is not positive"]);
});
it("accepts audio CUDA output when the helper reports PTS-aligned selection", () => {
const issues = validateNvidiaCudaExportSummary(
{
electron/ipc/export/native-video.ts
+8
View File
@@ -433,6 +433,13 @@ export function validateNvidiaCudaExportSummary(
if (expected.requiresTimelineSync && !isNvidiaCudaTimestampAlignedSummary(summary)) {
issues.push("CUDA timeline mode is not timestamp-aligned for audio export");
}
if (expected.requiresTimelineSync) {
if (!summary.outputAudio) {
issues.push("missing output audio stream");
} else if (outputAudioDurationSec !== null && outputAudioDurationSec <= 0) {
issues.push("output audio duration is not positive");
}
}
if (nativeFrames === null) {
issues.push("missing native frame count");
} else if (nativeFrames < minimumFrames) {
@@ -455,6 +462,7 @@ export function validateNvidiaCudaExportSummary(
}
if (
outputAudioDurationSec !== null &&
outputAudioDurationSec > 0 &&
Math.abs(outputAudioDurationSec - expectedDurationSec) > durationToleranceSec
) {
issues.push(