lee/backrest
1
0
Fork 0
mirror of https://github.com/garethgeorge/backrest.git synced 2026-05-03 19:40:30 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

fix: improve exported prometheus metrics for task execution and status (#684)
Build Snapshot Release / build (push) Has been cancelled
Details
Release Please / release-please (push) Has been cancelled
Details
Test / test-nix (push) Has been cancelled
Details
Test / test-win (push) Has been cancelled
Details

Browse Source
This commit is contained in:
Thibault Cohen
2025-02-26 01:55:22 -05:00
committed by GitHub
parent 988700d575
commit 8bafe7ea35
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/metric/metric.go
+14 -1
View File
@@ -38,6 +38,10 @@ func initRegistry() *Registry {
Name: "backrest_tasks_run_total",
Help: "The total number of tasks run",
}, append(slices.Clone(commonDims), "task_type", "status")),
lastTaskStatus: prometheus.NewGaugeVec(prometheus.GaugeOpts{
Name: "backrest_last_task_status",
Help: "The status of the last task",
}, append(slices.Clone(commonDims), "task_type", "status")),
}
registry.reg.MustRegister(registry.backupBytesProcessed)
@@ -45,6 +49,7 @@ func initRegistry() *Registry {
registry.reg.MustRegister(registry.backupFileWarnings)
registry.reg.MustRegister(registry.tasksDuration)
registry.reg.MustRegister(registry.tasksRun)
registry.reg.MustRegister(registry.lastTaskStatus)
return registry
}
@@ -60,6 +65,7 @@ type Registry struct {
backupFileWarnings *prometheus.GaugeVec
tasksDuration *prometheus.GaugeVec
tasksRun *prometheus.CounterVec
lastTaskStatus *prometheus.GaugeVec
}
func (r *Registry) Handler() http.Handler {
@@ -73,7 +79,14 @@ func (r *Registry) RecordTaskRun(repoID, planID, taskType string, duration_secs
if planID == "" {
planID = "_unassociated_"
}
r.tasksRun.DeletePartialMatch(prometheus.Labels{"repo_id": repoID, "plan_id": planID, "task_type": taskType})
r.lastTaskStatus.DeletePartialMatch(prometheus.Labels{"repo_id": repoID, "plan_id": planID, "task_type": taskType})
if status == "success" {
r.lastTaskStatus.WithLabelValues(repoID, planID, taskType, status).Set(0)
} else if status == "failed" {
r.lastTaskStatus.WithLabelValues(repoID, planID, taskType, status).Set(1)
} else {
r.lastTaskStatus.WithLabelValues(repoID, planID, taskType, status).Set(-1)
}
r.tasksRun.WithLabelValues(repoID, planID, taskType, status).Inc()
r.tasksDuration.WithLabelValues(repoID, planID, taskType).Set(duration_secs)
}