lee/caprover
1
0
Fork 0
mirror of https://github.com/caprover/caprover synced 2026-09-26 00:25:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed dockerhub authentication

Browse Source
This commit is contained in:
Kasra Bigdeli
2021-08-16 16:59:20 -07:00
parent fc3dc4f97a
commit 0a9af7c99b
1 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/user/DockerRegistryHelper.ts
+18 -10
View File
@@ -133,18 +133,26 @@ class DockerRegistryHelper {
}
}
// if none of the registries explicitly relates to the image name, try the official one
for (let index = 0; index < regs.length; index++) {
const element = regs[index]
if (element.registryDomain === 'registry-1.docker.io') {
return {
serveraddress: element.registryDomain,
username: element.registryUser,
password: element.registryPassword,
// email: CaptainConstants.defaultEmail, // email is optional
// if none of the registries explicitly relates to the image name, and no other explicit domain is defined,
// try Docker Hub registry as the default
if (
imageName.split('/').length == 2 || // user/image is from Docker Hub
imageName.split('/')[0].endsWith('.docker.io') || // registry-1.docker.io/user/image is from Docker Hub
imageName.split('/')[0] === 'docker.io' || // registry-1.docker.io/user/image is from Docker Hub
imageName.split('/')[0].endsWith('.docker.com') || // hub.docker.com/user/image is from Docker Hub
imageName.split('/')[0] === 'docker.io' // hub.docker.com/user/image is from Docker Hub
)
for (let index = 0; index < regs.length; index++) {
const element = regs[index]
if (element.registryDomain === 'registry-1.docker.io') {
return {
serveraddress: element.registryDomain,
username: element.registryUser,
password: element.registryPassword,
// email: CaptainConstants.defaultEmail, // email is optional
}
}
}
}
return undefined
})