mirror of
https://github.com/caprover/caprover
synced 2025-10-30 01:57:03 +00:00
Merge pull request #2350 from rosano/patch-1
Some checks failed
Run build / build (push) Has been cancelled
Run formatter / check-code-formatting (push) Has been cancelled
Run lint / run-lint (push) Has been cancelled
Build and push the edge image / run-pre-checks (push) Has been cancelled
Build and push the edge image / build-publish-docker-hub (push) Has been cancelled
Some checks failed
Run build / build (push) Has been cancelled
Run formatter / check-code-formatting (push) Has been cancelled
Run lint / run-lint (push) Has been cancelled
Build and push the edge image / run-pre-checks (push) Has been cancelled
Build and push the edge image / build-publish-docker-hub (push) Has been cancelled
Fix typo
This commit is contained in:
2
.github/pull_request_template.md
vendored
2
.github/pull_request_template.md
vendored
@@ -6,7 +6,7 @@ Please make sure you have read [contribution guidelines](https://github.com/capr
|
||||
|
||||
### Most important items
|
||||
|
||||
- Make sure to communicate your proposed changes ob our Slack channel beforehand.
|
||||
- Make sure to communicate your proposed changes on our Slack channel beforehand.
|
||||
- Large PRs (50+ lines of code) will get rejected due to increased difficulty for review - unless they have been communicated beforehand with project maintainers.
|
||||
- **Refactoring work will get rejected** unless it's been communicated with project's maintainers **beforehand**. There is a thousand ways to write the same code. Every time a code is changed, there is a potential for a new bug. We don't want to refactor the code just for the sake of refactoring.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user