zh_TW - zh_Hant_TW fixes and tests re #3737

2026-09-25 23:06:51 +00:00 · 2026-01-15 11:02:50 +01:00
parent f4e178955c
commit 89fb57c2e0
5 changed files with 21 additions and 3 deletions
@@ -29,7 +29,7 @@ def get_timeago_locale(flask_locale):
    """
    locale_map = {
        'zh': 'zh_CN',      # Chinese Simplified
-        'zh_Hant_TW': 'zh_TW',  # Flask-Babel normalizes zh_TW to zh_Hant_TW
+        'zh_TW': 'zh_Hant_TW',  # Flask-Babel normalizes zh_TW to zh_Hant_TW
        'pt': 'pt_PT',      # Portuguese (Portugal)
        'sv': 'sv_SE',      # Swedish
        'no': 'nb_NO',      # Norwegian Bokmål
@@ -54,7 +54,7 @@ LANGUAGE_DATA = {
    'it': {'flag': 'fi fi-it fis', 'name': 'Italiano'},
    'ja': {'flag': 'fi fi-jp fis', 'name': '日本語'},
    'zh': {'flag': 'fi fi-cn fis', 'name': '中文 (简体)'},
-    'zh_TW': {'flag': 'fi fi-tw fis', 'name': '繁體中文'},
+    'zh_Hant_TW': {'flag': 'fi fi-tw fis', 'name': '繁體中文'},
    'ru': {'flag': 'fi fi-ru fis', 'name': 'Русский'},
    'pl': {'flag': 'fi fi-pl fis', 'name': 'Polski'},
    'nl': {'flag': 'fi fi-nl fis', 'name': 'Nederlands'},
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html lang="{{ get_locale() }}" data-darkmode="{{ get_darkmode_state() }}">
+<html lang="{{ get_locale()|replace('_', '-') }}" data-darkmode="{{ get_darkmode_state() }}">

  <head>
    <meta charset="utf-8" >
@@ -3,6 +3,24 @@
 from flask import url_for
 from .util import live_server_setup

+def test_zh_TW(client, live_server, measure_memory_usage, datastore_path):
+
+    res = client.get(
+        url_for("set_language", locale="zh"), # Simplified chinese
+        follow_redirects=True
+    )
+    assert "选择语言".encode() in res.data
+
+
+    res = client.get(
+        url_for("set_language", locale="zh_Hant_TW"), # Traditional
+        follow_redirects=True
+    )
+    # HTML follows BCP 47 language tag rules, not underscore-based locale formats.
+    assert b'<html lang="zh-Hant-TW"' in res.data
+
+    assert '選擇語言'.encode() in res.data
+

 def test_language_switching(client, live_server, measure_memory_usage, datastore_path):
    """