lee/changedetection.io
1
0
Fork 0
mirror of https://github.com/dgtlmoon/changedetection.io.git synced 2026-09-25 06:46:11 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Re #148 - Always set something for {base_url} so we dont send possibly an empty body/title notification which could break some services.

Browse Source
This commit is contained in:
dgtlmoon
2021-07-22 20:09:42 +10:00
parent f3ba051df4
commit dfbc9bfc53
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/notification.py
+7 -5
View File
@@ -39,11 +39,13 @@ def create_notification_parameters(n_object):
base_url = os.getenv('BASE_URL', '').strip('"')
watch_url = n_object['watch_url']
if base_url != '':
diff_url = "{}/diff/{}".format(base_url, uuid)
preview_url = "{}/preview/{}".format(base_url, uuid)
else:
diff_url = preview_url = ''
# Re #148 - Some people have just {base_url} in the body or title, but this may break some notification services
# like 'Join', so it's always best to atleast set something obvious so that they are not broken.
if base_url == '':
base_url = "<base-url-env-var-not-set>"
diff_url = "{}/diff/{}".format(base_url, uuid)
preview_url = "{}/preview/{}".format(base_url, uuid)
return {
'base_url': base_url,