Possible RSS watch UUID bugfix

MANIFEST.in

@@ -11,7 +11,6 @@ recursive-include changedetectionio/realtime *
 recursive-include changedetectionio/static *
 recursive-include changedetectionio/templates *
 recursive-include changedetectionio/tests *
-recursive-include changedetectionio/translations *
 recursive-include changedetectionio/widgets *
 prune changedetectionio/static/package-lock.json
 prune changedetectionio/static/styles/node_modules

changedetectionio/__init__.py

@@ -2,7 +2,7 @@
 
 # Read more https://github.com/dgtlmoon/changedetection.io/wiki
 # Semver means never use .01, or 00. Should be .1.
-__version__ = '0.52.4'
+__version__ = '0.52.1'
 
 from changedetectionio.strtobool import strtobool
 from json.decoder import JSONDecodeError

changedetectionio/async_update_worker.py

@@ -1,4 +1,5 @@
 from blinker import signal
+
 from .processors.exceptions import ProcessorException
 import changedetectionio.content_fetchers.exceptions as content_fetchers_exceptions
 from changedetectionio.processors.text_json_diff.processor import FilterNotFoundInResponse
@@ -8,6 +9,7 @@ from changedetectionio.flask_app import watch_check_update
 import asyncio
 import importlib
 import os
+import queue
 import time
 
 from loguru import logger

changedetectionio/blueprint/browser_steps/__init__.py

@@ -21,154 +21,31 @@ from changedetectionio.flask_app import login_optionally_required
 from loguru import logger
 
 browsersteps_sessions = {}
-browsersteps_watch_to_session = {}  # Maps watch_uuid -> browsersteps_session_id
 io_interface_context = None
 import json
 import hashlib
 from flask import Response
 import asyncio
 import threading
-import time
-
-# Dedicated event loop for ALL browser steps sessions
-_browser_steps_loop = None
-_browser_steps_thread = None
-_browser_steps_loop_lock = threading.Lock()
-
-def _start_browser_steps_loop():
-    """Start a dedicated event loop for browser steps in its own thread"""
-    global _browser_steps_loop
-
-    # Create and set the event loop for this thread
-    loop = asyncio.new_event_loop()
-    asyncio.set_event_loop(loop)
-    _browser_steps_loop = loop
-
-    logger.debug("Browser steps event loop started")
-
-    try:
-        # Run the loop forever - handles all browsersteps sessions
-        loop.run_forever()
-    except Exception as e:
-        logger.error(f"Browser steps event loop error: {e}")
-    finally:
-        try:
-            # Cancel all remaining tasks
-            pending = asyncio.all_tasks(loop)
-            for task in pending:
-                task.cancel()
-
-            # Wait for tasks to finish cancellation
-            if pending:
-                loop.run_until_complete(asyncio.gather(*pending, return_exceptions=True))
-        except Exception as e:
-            logger.debug(f"Error during browser steps loop cleanup: {e}")
-        finally:
-            loop.close()
-            logger.debug("Browser steps event loop closed")
-
-def _ensure_browser_steps_loop():
-    """Ensure the browser steps event loop is running"""
-    global _browser_steps_loop, _browser_steps_thread
-
-    with _browser_steps_loop_lock:
-        if _browser_steps_thread is None or not _browser_steps_thread.is_alive():
-            logger.debug("Starting browser steps event loop thread")
-            _browser_steps_thread = threading.Thread(
-                target=_start_browser_steps_loop,
-                daemon=True,
-                name="BrowserStepsEventLoop"
-            )
-            _browser_steps_thread.start()
-
-            # Wait for the loop to be ready
-            timeout = 5.0
-            start_time = time.time()
-            while _browser_steps_loop is None:
-                if time.time() - start_time > timeout:
-                    raise RuntimeError("Browser steps event loop failed to start")
-                time.sleep(0.01)
-
-            logger.debug("Browser steps event loop thread started and ready")
 
 def run_async_in_browser_loop(coro):
-    """Run async coroutine using the dedicated browser steps event loop"""
-    _ensure_browser_steps_loop()
-
-    if _browser_steps_loop and not _browser_steps_loop.is_closed():
-        logger.debug("Browser steps using dedicated event loop")
-        future = asyncio.run_coroutine_threadsafe(coro, _browser_steps_loop)
+    """Run async coroutine using the existing async worker event loop"""
+    from changedetectionio import worker_handler
+    
+    # Use the existing async worker event loop instead of creating a new one
+    if worker_handler.USE_ASYNC_WORKERS and worker_handler.async_loop and not worker_handler.async_loop.is_closed():
+        logger.debug("Browser steps using existing async worker event loop")
+        future = asyncio.run_coroutine_threadsafe(coro, worker_handler.async_loop)
         return future.result()
     else:
-        raise RuntimeError("Browser steps event loop is not available")
-
-def cleanup_expired_sessions():
-    """Remove expired browsersteps sessions and cleanup their resources"""
-    global browsersteps_sessions, browsersteps_watch_to_session
-
-    expired_session_ids = []
-
-    # Find expired sessions
-    for session_id, session_data in browsersteps_sessions.items():
-        browserstepper = session_data.get('browserstepper')
-        if browserstepper and browserstepper.has_expired:
-            expired_session_ids.append(session_id)
-
-    # Cleanup expired sessions
-    for session_id in expired_session_ids:
-        logger.debug(f"Cleaning up expired browsersteps session {session_id}")
-        session_data = browsersteps_sessions[session_id]
-
-        # Cleanup playwright resources asynchronously
-        browserstepper = session_data.get('browserstepper')
-        if browserstepper:
-            try:
-                run_async_in_browser_loop(browserstepper.cleanup())
-            except Exception as e:
-                logger.error(f"Error cleaning up session {session_id}: {e}")
-
-        # Remove from sessions dict
-        del browsersteps_sessions[session_id]
-
-        # Remove from watch mapping
-        for watch_uuid, mapped_session_id in list(browsersteps_watch_to_session.items()):
-            if mapped_session_id == session_id:
-                del browsersteps_watch_to_session[watch_uuid]
-                break
-
-    if expired_session_ids:
-        logger.info(f"Cleaned up {len(expired_session_ids)} expired browsersteps session(s)")
-
-def cleanup_session_for_watch(watch_uuid):
-    """Cleanup a specific browsersteps session for a watch UUID"""
-    global browsersteps_sessions, browsersteps_watch_to_session
-
-    session_id = browsersteps_watch_to_session.get(watch_uuid)
-    if not session_id:
-        logger.debug(f"No browsersteps session found for watch {watch_uuid}")
-        return
-
-    logger.debug(f"Cleaning up browsersteps session {session_id} for watch {watch_uuid}")
-
-    session_data = browsersteps_sessions.get(session_id)
-    if session_data:
-        browserstepper = session_data.get('browserstepper')
-        if browserstepper:
-            try:
-                run_async_in_browser_loop(browserstepper.cleanup())
-            except Exception as e:
-                logger.error(f"Error cleaning up session {session_id} for watch {watch_uuid}: {e}")
-
-        # Remove from sessions dict
-        del browsersteps_sessions[session_id]
-
-    # Remove from watch mapping
-    del browsersteps_watch_to_session[watch_uuid]
-
-    logger.debug(f"Cleaned up session for watch {watch_uuid}")
-
-    # Opportunistically cleanup any other expired sessions
-    cleanup_expired_sessions()
+        # Fallback: create a new event loop (for sync workers or if async loop not available)
+        logger.debug("Browser steps creating temporary event loop")
+        loop = asyncio.new_event_loop()
+        asyncio.set_event_loop(loop)
+        try:
+            return loop.run_until_complete(coro)
+        finally:
+            loop.close()
 
 def construct_blueprint(datastore: ChangeDetectionStore):
     browser_steps_blueprint = Blueprint('browser_steps', __name__, template_folder="templates")
@@ -246,9 +123,6 @@ def construct_blueprint(datastore: ChangeDetectionStore):
         if not watch_uuid:
             return make_response('No Watch UUID specified', 500)
 
-        # Cleanup any existing session for this watch
-        cleanup_session_for_watch(watch_uuid)
-
         logger.debug("Starting connection with playwright")
         logger.debug("browser_steps.py connecting")
 
@@ -257,10 +131,6 @@ def construct_blueprint(datastore: ChangeDetectionStore):
             browsersteps_sessions[browsersteps_session_id] = run_async_in_browser_loop(
                 start_browsersteps_session(watch_uuid)
             )
-
-            # Store the mapping of watch_uuid -> browsersteps_session_id
-            browsersteps_watch_to_session[watch_uuid] = browsersteps_session_id
-
         except Exception as e:
             if 'ECONNREFUSED' in str(e):
                 return make_response('Unable to start the Playwright Browser session, is sockpuppetbrowser running? Network configuration is OK?', 401)

changedetectionio/blueprint/settings/templates/settings.html

@@ -86,10 +86,6 @@
             <div class="tab-pane-inner" id="notifications">
                 <fieldset>
                     {{ render_common_settings_form(form.application.form, emailprefix, settings_application, extra_notification_token_placeholder_info) }}
-                </fieldset>
-                 <fieldset class="pure-group">
-                    {{ render_checkbox_field(form.application.form.notification_html_word_diff_enabled) }}
-                    <span class="pure-form-message-inline">HTML notifications - Use "word by word" difference where possible.</span>
                 </fieldset>
                 <div class="pure-control-group" id="notification-base-url">
                     {{ render_field(form.application.form.base_url, class="m-d") }}

changedetectionio/blueprint/tags/templates/groups-overview.html

@@ -50,8 +50,7 @@
                 <td>{{ "{:,}".format(tag_count[uuid]) if uuid in tag_count else 0 }}</td>
                 <td class="title-col inline"> <a href="{{url_for('watchlist.index', tag=uuid) }}">{{ tag.title }}</a></td>
                 <td>
-                    <a class="pure-button pure-button-primary" href="{{ url_for('tags.form_tag_edit', uuid=uuid) }}">{{ _('Edit') }}</a>
-                    <a href="{{ url_for('ui.form_watch_checknow', tag=uuid) }}" class="pure-button pure-button-primary" >{{ _('Recheck') }}</a>
+                    <a class="pure-button pure-button-primary" href="{{ url_for('tags.form_tag_edit', uuid=uuid) }}">{{ _('Edit') }}</a>&nbsp;
                     <a class="pure-button button-error"
                        href="{{ url_for('tags.delete', uuid=uuid) }}"
                        data-requires-confirm

changedetectionio/blueprint/ui/edit.py

@@ -238,13 +238,6 @@ def construct_blueprint(datastore: ChangeDetectionStore, update_q, queuedWatchMe
             datastore.data['watching'][uuid] = watch_class(datastore_path=datastore.datastore_path, default=datastore.data['watching'][uuid])
             flash(gettext("Updated watch - unpaused!") if request.args.get('unpause_on_save') else gettext("Updated watch."))
 
-            # Cleanup any browsersteps session for this watch
-            try:
-                from changedetectionio.blueprint.browser_steps import cleanup_session_for_watch
-                cleanup_session_for_watch(uuid)
-            except Exception as e:
-                logger.debug(f"Error cleaning up browsersteps session: {e}")
-
             # Re #286 - We wait for syncing new data to disk in another thread every 60 seconds
             # But in the case something is added we should save straight away
             datastore.needs_write_urgent = True
@@ -332,6 +325,8 @@ def construct_blueprint(datastore: ChangeDetectionStore, update_q, queuedWatchMe
                     'url': url_for('rss.rss_single_watch', uuid=watch['uuid'], token=app_rss_token)
                 },
                 'settings_application': datastore.data['settings']['application'],
+                'system_has_playwright_configured': os.getenv('PLAYWRIGHT_DRIVER_URL'),
+                'system_has_webdriver_configured': os.getenv('WEBDRIVER_URL'),
                 'ui_edit_stats_extras': collect_ui_edit_stats_extras(watch),
                 'visual_selector_data_ready': datastore.visualselector_data_is_ready(watch_uuid=uuid),
                 'timezone_default_config': datastore.data['settings']['application'].get('scheduler_timezone_default'),

changedetectionio/blueprint/ui/templates/edit.html

@@ -206,7 +206,7 @@ Math: {{ 1 + 1 }}") }}
 
             <div class="tab-pane-inner" id="browser-steps">
             {% if capabilities.supports_browser_steps %}
-               {% if true %}
+               {% if visual_selector_data_ready %}
                 <img class="beta-logo" src="{{url_for('static_content', group='images', filename='beta-logo.png')}}" alt="New beta functionality">
                 <fieldset>
                     <div class="pure-control-group">

changedetectionio/content_fetchers/playwright.py

@@ -1,4 +1,3 @@
-import gc
 import json
 import os
 from urllib.parse import urlparse
@@ -186,33 +185,20 @@ class fetcher(Fetcher):
         super().screenshot_step(step_n=step_n)
         screenshot = await capture_full_page_async(page=self.page, screenshot_format=self.screenshot_format)
 
-        # Request GC immediately after screenshot to free memory
-        # Screenshots can be large and browser steps take many of them
-        await self.page.request_gc()
 
         if self.browser_steps_screenshot_path is not None:
             destination = os.path.join(self.browser_steps_screenshot_path, 'step_{}.jpeg'.format(step_n))
             logger.debug(f"Saving step screenshot to {destination}")
             with open(destination, 'wb') as f:
                 f.write(screenshot)
-            # Clear local reference to allow screenshot bytes to be collected
-            del screenshot
-            gc.collect()
 
     async def save_step_html(self, step_n):
         super().save_step_html(step_n=step_n)
         content = await self.page.content()
-
-        # Request GC after getting page content
-        await self.page.request_gc()
-
         destination = os.path.join(self.browser_steps_screenshot_path, 'step_{}.html'.format(step_n))
         logger.debug(f"Saving step HTML to {destination}")
         with open(destination, 'w', encoding='utf-8') as f:
             f.write(content)
-        # Clear local reference
-        del content
-        gc.collect()
 
     async def run(self,
                   fetch_favicon=True,
@@ -319,12 +305,6 @@ class fetcher(Fetcher):
 
             if self.status_code != 200 and not ignore_status_codes:
                 screenshot = await capture_full_page_async(self.page, screenshot_format=self.screenshot_format)
-                # Cleanup before raising to prevent memory leak
-                await self.page.close()
-                await context.close()
-                await browser.close()
-                # Force garbage collection to release Playwright resources immediately
-                gc.collect()
                 raise Non200ErrorCodeReceived(url=url, status_code=self.status_code, screenshot=screenshot)
 
             if not empty_pages_are_a_change and len((await self.page.content()).strip()) == 0:
@@ -333,52 +313,48 @@ class fetcher(Fetcher):
                 await browser.close()
                 raise EmptyReply(url=url, status_code=response.status)
 
-            # Wrap remaining operations in try/finally to ensure cleanup
+            # Run Browser Steps here
+            if self.browser_steps_get_valid_steps():
+                await self.iterate_browser_steps(start_url=url)
+
+            await self.page.wait_for_timeout(extra_wait * 1000)
+
+            now = time.time()
+            # So we can find an element on the page where its selector was entered manually (maybe not xPath etc)
+            if current_include_filters is not None:
+                await self.page.evaluate("var include_filters={}".format(json.dumps(current_include_filters)))
+            else:
+                await self.page.evaluate("var include_filters=''")
+            await self.page.request_gc()
+
+            # request_gc before and after evaluate to free up memory
+            # @todo browsersteps etc
+            MAX_TOTAL_HEIGHT = int(os.getenv("SCREENSHOT_MAX_HEIGHT", SCREENSHOT_MAX_HEIGHT_DEFAULT))
+            self.xpath_data = await self.page.evaluate(XPATH_ELEMENT_JS, {
+                "visualselector_xpath_selectors": visualselector_xpath_selectors,
+                "max_height": MAX_TOTAL_HEIGHT
+            })
+            await self.page.request_gc()
+
+            self.instock_data = await self.page.evaluate(INSTOCK_DATA_JS)
+            await self.page.request_gc()
+
+            self.content = await self.page.content()
+            await self.page.request_gc()
+            logger.debug(f"Scrape xPath element data in browser done in {time.time() - now:.2f}s")
+
+
+            # Bug 3 in Playwright screenshot handling
+            # Some bug where it gives the wrong screenshot size, but making a request with the clip set first seems to solve it
+            # JPEG is better here because the screenshots can be very very large
+
+            # Screenshots also travel via the ws:// (websocket) meaning that the binary data is base64 encoded
+            # which will significantly increase the IO size between the server and client, it's recommended to use the lowest
+            # acceptable screenshot quality here
             try:
-                # Run Browser Steps here
-                if self.browser_steps_get_valid_steps():
-                    await self.iterate_browser_steps(start_url=url)
-
-                    await self.page.wait_for_timeout(extra_wait * 1000)
-
-                now = time.time()
-                # So we can find an element on the page where its selector was entered manually (maybe not xPath etc)
-                if current_include_filters is not None:
-                    await self.page.evaluate("var include_filters={}".format(json.dumps(current_include_filters)))
-                else:
-                    await self.page.evaluate("var include_filters=''")
-                await self.page.request_gc()
-
-                # request_gc before and after evaluate to free up memory
-                # @todo browsersteps etc
-                MAX_TOTAL_HEIGHT = int(os.getenv("SCREENSHOT_MAX_HEIGHT", SCREENSHOT_MAX_HEIGHT_DEFAULT))
-                self.xpath_data = await self.page.evaluate(XPATH_ELEMENT_JS, {
-                    "visualselector_xpath_selectors": visualselector_xpath_selectors,
-                    "max_height": MAX_TOTAL_HEIGHT
-                })
-                await self.page.request_gc()
-
-                self.instock_data = await self.page.evaluate(INSTOCK_DATA_JS)
-                await self.page.request_gc()
-
-                self.content = await self.page.content()
-                await self.page.request_gc()
-                logger.debug(f"Scrape xPath element data in browser done in {time.time() - now:.2f}s")
-
-
-                # Bug 3 in Playwright screenshot handling
-                # Some bug where it gives the wrong screenshot size, but making a request with the clip set first seems to solve it
-                # JPEG is better here because the screenshots can be very very large
-
-                # Screenshots also travel via the ws:// (websocket) meaning that the binary data is base64 encoded
-                # which will significantly increase the IO size between the server and client, it's recommended to use the lowest
-                # acceptable screenshot quality here
                 # The actual screenshot - this always base64 and needs decoding! horrible! huge CPU usage
                 self.screenshot = await capture_full_page_async(page=self.page, screenshot_format=self.screenshot_format)
 
-            except ScreenshotUnavailable:
-                # Re-raise screenshot unavailable exceptions
-                raise
             except Exception as e:
                 # It's likely the screenshot was too long/big and something crashed
                 raise ScreenshotUnavailable(url=url, status_code=self.status_code)
@@ -413,10 +389,6 @@ class fetcher(Fetcher):
                     pass
                 browser = None
 
-                # Force Python GC to release Playwright resources immediately
-                # Playwright objects can have circular references that delay cleanup
-                gc.collect()
-
 
 # Plugin registration for built-in fetcher
 class PlaywrightFetcherPlugin:

changedetectionio/content_fetchers/webdriver_selenium.py

@@ -15,7 +15,7 @@ class fetcher(Fetcher):
     proxy_url = None
 
     # Capability flags
-    supports_browser_steps = False
+    supports_browser_steps = True
     supports_screenshots = True
     supports_xpath_element_data = True
 

changedetectionio/forms.py

@@ -991,7 +991,6 @@ class globalSettingsApplicationForm(commonSettingsForm):
                            render_kw={"placeholder": os.getenv('BASE_URL', 'Not set')}
                            )
     empty_pages_are_a_change =  BooleanField(_l('Treat empty pages as a change?'), default=False)
-    notification_html_word_diff_enabled = BooleanField(_l('Notification HTML as word-by-word difference'), default=True, validators=[validators.Optional()])
     fetch_backend = RadioField(_l('Fetch Method'), default="html_requests", choices=content_fetchers.available_fetchers(), validators=[ValidateContentFetcherIsReady()])
     global_ignore_text = StringListField(_l('Ignore Text'), [ValidateListRegex()])
     global_subtractive_selectors = StringListField(_l('Remove elements'), [ValidateCSSJSONXPATHInput(allow_json=False)])

changedetectionio/languages.py

@@ -29,7 +29,6 @@ def get_timeago_locale(flask_locale):
     """
     locale_map = {
         'zh': 'zh_CN',      # Chinese Simplified
-        'zh_Hant_TW': 'zh_TW',  # Flask-Babel normalizes zh_TW to zh_Hant_TW
         'pt': 'pt_PT',      # Portuguese (Portugal)
         'sv': 'sv_SE',      # Swedish
         'no': 'nb_NO',      # Norwegian Bokmål

changedetectionio/model/App.py

@@ -49,7 +49,6 @@ class model(dict):
                     'ssim_threshold': '0.96',  # Default SSIM threshold for screenshot comparison
                     'notification_body': default_notification_body,
                     'notification_format': default_notification_format,
-                    'notification_html_word_diff': True,
                     'notification_title': default_notification_title,
                     'notification_urls': [], # Apprise URL list
                     'pager_size': 50,

changedetectionio/notification/handler.py

@@ -309,9 +309,6 @@ def process_notification(n_object: NotificationContextData, datastore):
     if not isinstance(n_object, NotificationContextData):
         raise TypeError(f"Expected NotificationContextData, got {type(n_object)}")
 
-    if not n_object.get('notification_urls'):
-        return None
-
     now = time.time()
     if n_object.get('notification_timestamp'):
         logger.trace(f"Time since queued {now-n_object['notification_timestamp']:.3f}s")
@@ -351,15 +348,16 @@ def process_notification(n_object: NotificationContextData, datastore):
     apprise.plugins.N_MGR.remove('discord')
     apprise.plugins.N_MGR.add(NotifyDiscordCustom, schemas='discord')
 
-    # Should always be false for 'text' mode or its too hard to read, otherwise it's a setting (for html style).
-    word_diff_enable = requested_output_format_original == 'text' or (
-                n_object.get('notification_html_word_diff_enabled', True) and requested_output_format_original.startswith('html'))
+    if not n_object.get('notification_urls'):
+        return None
 
     n_object.update(add_rendered_diff_to_notification_vars(
         notification_scan_text=n_object.get('notification_body', '')+n_object.get('notification_title', ''),
         current_snapshot=n_object.get('current_snapshot'),
         prev_snapshot=n_object.get('prev_snapshot'),
-        word_diff=word_diff_enable
+        # Should always be false for 'text' mode or its too hard to read
+        # But otherwise, this could be some setting
+        word_diff=False if requested_output_format_original == 'text' else True,
         )
     )
 

changedetectionio/notification_service.py

@@ -250,7 +250,6 @@ class NotificationService:
         if n_object.get('notification_format') == USE_SYSTEM_DEFAULT_NOTIFICATION_FORMAT_FOR_WATCH:
             n_object['notification_format'] = self.datastore.data['settings']['application'].get('notification_format')
 
-        n_object['notification_html_word_diff_enabled'] = self.datastore.data['settings']['application'].get('notification_html_word_diff_enabled', True)
 
         triggered_text = ''
         if len(trigger_text):

changedetectionio/templates/_common_fields.html

@@ -1,5 +1,5 @@
 
-{% from '_helpers.html' import render_field, render_checkbox_field %}
+{% from '_helpers.html' import render_field %}
 
 {% macro show_token_placeholders(extra_notification_token_placeholder_info, suffix="") %}
 
@@ -8,7 +8,9 @@
             <span class="pure-form-message-inline">
         Body for all notifications &dash; You can use <a target="newwindow" href="https://jinja.palletsprojects.com/en/3.0.x/templates/">Jinja2</a> templating in the notification title, body and URL, and tokens from below.
     </span><br>
-        <div data-target="#notification-tokens-info{{ suffix }}" class="toggle-show pure-button button-tag button-xsmall">Show extra help and tokens</div>
+        <div data-target="#notification-tokens-info{{ suffix }}" class="toggle-show pure-button button-tag button-xsmall">Show
+            token/placeholders
+        </div>
     </div>
     <div class="pure-controls" style="display: none;" id="notification-tokens-info{{ suffix }}">
         <table class="pure-table" id="token-table">
@@ -103,30 +105,11 @@
                 {% endif %}
             </tbody>
         </table>
-        <br>
-        <div class="pure-form-message-inline">
+
+        <span class="pure-form-message-inline">
         Warning: Contents of <code>{{ '{{diff}}' }}</code>, <code>{{ '{{diff_removed}}' }}</code>, and <code>{{ '{{diff_added}}' }}</code> depend on how the difference algorithm perceives the change. <br>
-        For example, an addition or removal could be perceived as a change in some cases. <a target="newwindow"  href="https://github.com/dgtlmoon/changedetection.io/wiki/Using-the-%7B%7Bdiff%7D%7D,-%7B%7Bdiff_added%7D%7D,-and-%7B%7Bdiff_removed%7D%7D-notification-tokens">More Here</a> <br>
-        </div>
-    <br><br>
-        <div class="pure-form-message-inline">
-            <ul>
-                <li><span class="pure-form-message-inline">
-                For JSON payloads, use <strong>|tojson</strong> without quotes for automatic escaping, for example - <code>{ "name": {{ '{{ watch_title|tojson }}' }} }</code>
-            </span></li>
-                <li><span class="pure-form-message-inline">
-                URL encoding, use <strong>|urlencode</strong>, for example - <code>gets://hook-website.com/test.php?title={{ '{{ watch_title|urlencode }}' }}</code>
-            </span></li>
-                <li><span class="pure-form-message-inline">
-                Regular-expression replace, use <strong>|regex_replace</strong>, for example -   <code>{{ "{{ \"hello world 123\" | regex_replace('[0-9]+', 'no-more-numbers') }}" }}</code>
-            </span></li>
-                <li><span class="pure-form-message-inline">
-                For a complete reference of all Jinja2 built-in filters, users can refer to the <a
-                        href="https://jinja.palletsprojects.com/en/3.1.x/templates/#builtin-filters">https://jinja.palletsprojects.com/en/3.1.x/templates/#builtin-filters</a>
-            </span></li>
-            </ul>
-            <br>
-        </div>
+        For example, an addition or removal could be perceived as a change in some cases. <a target="newwindow" href="https://github.com/dgtlmoon/changedetection.io/wiki/Using-the-%7B%7Bdiff%7D%7D,-%7B%7Bdiff_added%7D%7D,-and-%7B%7Bdiff_removed%7D%7D-notification-tokens">More Here</a> <br>
+        </span>
     </div>
 {%  endmacro %}
 
@@ -168,11 +151,28 @@
                                 {{ render_field(form.notification_title, class="m-d notification-title", placeholder=settings_application['notification_title']) }}
                                 <span class="pure-form-message-inline">Title for all notifications</span>
                             </div>
-                            <div>
+                            <div class="pure-control-group">
                                 {{ render_field(form.notification_body , rows=5, class="notification-body", placeholder=settings_application['notification_body']) }}
                                 {{ show_token_placeholders(extra_notification_token_placeholder_info=extra_notification_token_placeholder_info) }}
+                                <div class="pure-form-message-inline">
+                                    <ul>
+                                    <li><span class="pure-form-message-inline">
+                                        For JSON payloads, use <strong>|tojson</strong> without quotes for automatic escaping, for example - <code>{ "name": {{ '{{ watch_title|tojson }}' }} }</code>
+                                    </span></li>
+                                    <li><span class="pure-form-message-inline">
+                                        URL encoding, use <strong>|urlencode</strong>, for example - <code>gets://hook-website.com/test.php?title={{ '{{ watch_title|urlencode }}' }}</code>
+                                    </span></li>
+                                    <li><span class="pure-form-message-inline">
+                                        Regular-expression replace, use <strong>|regex_replace</strong>, for example -   <code>{{ "{{ \"hello world 123\" | regex_replace('[0-9]+', 'no-more-numbers') }}" }}</code>
+                                    </span></li>
+                                    <li><span class="pure-form-message-inline">
+                                        For a complete reference of all Jinja2 built-in filters, users can refer to the <a href="https://jinja.palletsprojects.com/en/3.1.x/templates/#builtin-filters">https://jinja.palletsprojects.com/en/3.1.x/templates/#builtin-filters</a>
+                                    </span></li>
+                                    </ul>
+                                    <br>
+                                </div>
                             </div>
-                            <div>
+                            <div class="">
                                 {{ render_field(form.notification_format , class="notification-format") }}
                                 <span class="pure-form-message-inline">Format for all notifications</span>
                             </div>

changedetectionio/tests/test_live_preview.py

@@ -25,13 +25,12 @@ def test_content_filter_live_preview(client, live_server, measure_memory_usage,
 
     test_url = url_for('test_endpoint', _external=True)
 
-
-    uuid = client.application.config.get('DATASTORE').add_watch(url=test_url)
-    res = client.get(url_for("ui.form_watch_checknow"), follow_redirects=True)
-    assert b'Queued 1 watch for rechecking.' in res.data
-   
-    wait_for_all_checks(client)
-
+    res = client.post(
+        url_for("ui.ui_views.form_quick_watch_add"),
+        data={"url": test_url, "tags": ''},
+        follow_redirects=True
+    )
+    uuid = next(iter(live_server.app.config['DATASTORE'].data['watching']))
     res = client.post(
         url_for("ui.ui_edit.edit_page", uuid=uuid),
         data={

changedetectionio/tests/test_notification.py

@@ -532,7 +532,7 @@ def test_single_send_test_notification_on_watch(client, live_server, measure_mem
         assert 'Current snapshot: Example text: example test' in x
     os.unlink(os.path.join(datastore_path, "notification.txt"))
 
-def _test_color_notifications(client, notification_body_token, datastore_path, word_diff_enabled = True):
+def _test_color_notifications(client, notification_body_token, datastore_path):
 
     set_original_response(datastore_path=datastore_path)
 
@@ -551,7 +551,6 @@ def _test_color_notifications(client, notification_body_token, datastore_path, w
             "application-minutes_between_check": 180,
             "application-notification_body": notification_body_token,
             "application-notification_format": "htmlcolor",
-            "application-notification_html_word_diff_enabled": 'y' if word_diff_enabled else '',
             "application-notification_urls": test_notification_url,
             "application-notification_title": "New ChangeDetection.io Notification - {{ watch_url }}",
         },
@@ -560,13 +559,17 @@ def _test_color_notifications(client, notification_body_token, datastore_path, w
     assert b'Settings updated' in res.data
 
     test_url = url_for('test_endpoint', _external=True)
-    uuid = client.application.config.get('DATASTORE').add_watch(url=test_url)
-    res = client.get(url_for("ui.form_watch_checknow"), follow_redirects=True)
-    assert b'Queued 1 watch for rechecking.' in res.data
+    res = client.post(
+        url_for("ui.ui_views.form_quick_watch_add"),
+        data={"url": test_url, "tags": 'nice one'},
+        follow_redirects=True
+    )
+
+    assert b"Watch added" in res.data
 
     wait_for_all_checks(client)
-    extras='XXX ' if word_diff_enabled else ''
-    set_modified_response(datastore_path=datastore_path, extras=extras)
+
+    set_modified_response(datastore_path=datastore_path)
 
 
     res = client.get(url_for("ui.form_watch_checknow"), follow_redirects=True)
@@ -576,13 +579,9 @@ def _test_color_notifications(client, notification_body_token, datastore_path, w
     wait_for_notification_endpoint_output(datastore_path=datastore_path)
 
     with open(os.path.join(datastore_path, "notification.txt"), 'r') as f:
-        contents = f.read()
+        x = f.read()
         s = f'<span style="{HTML_CHANGED_STYLE}" role="note" aria-label="Changed text" title="Changed text">Which is across multiple lines</span><br>'
-        assert s in contents
-        if word_diff_enabled:
-            assert '>XXX</span>' in contents
-        else:
-            assert '>XXX</span>' not in contents
+        assert s in x
 
     client.get(
         url_for("ui.form_delete", uuid="all"),
@@ -591,12 +590,6 @@ def _test_color_notifications(client, notification_body_token, datastore_path, w
 
 # Just checks the format of the colour notifications was correct
 def test_html_color_notifications(client, live_server, measure_memory_usage, datastore_path):
-    # Word-level diff only triggers when difflib.SequenceMatcher identifies a single-line to single-line replacement.
-    # If you have multiple changed lines close together, you need at least 1 unchanged content line (not empty) between them to
-    # prevent them from being grouped into a multi-line replacement that falls back to line-level diff.
+    _test_color_notifications(client, '{{diff}}',datastore_path=datastore_path)
+    _test_color_notifications(client, '{{diff_full}}',datastore_path=datastore_path)
 
-    _test_color_notifications(client, '{{diff}}',datastore_path=datastore_path, word_diff_enabled = True)
-    _test_color_notifications(client, '{{diff_full}}',datastore_path=datastore_path, word_diff_enabled = True)
-
-    _test_color_notifications(client, '{{diff}}',datastore_path=datastore_path, word_diff_enabled = False)
-    _test_color_notifications(client, '{{diff_full}}',datastore_path=datastore_path, word_diff_enabled = False)

changedetectionio/tests/util.py

@@ -7,7 +7,7 @@ import logging
 import time
 import os
 
-def set_original_response(datastore_path, extra_title='', extras=''):
+def set_original_response(datastore_path, extra_title=''):
     test_return_data = f"""<html>
     <head><title>head title{extra_title}</title></head>
     <body>
@@ -15,9 +15,6 @@ def set_original_response(datastore_path, extra_title='', extras=''):
      <p>Which is across multiple lines</p>
      <br>
      So let's see what happens.  <br>
-     with more text that helps word-diff if needed<br>
-     and more text that helps word-diff if needed<br>
-     and even more text {extras}that helps word-diff if needed<br>     
      <span class="foobar-detection" style='display:none'></span>
      </body>
      </html>
@@ -27,17 +24,14 @@ def set_original_response(datastore_path, extra_title='', extras=''):
         f.write(test_return_data)
     return None
 
-def set_modified_response(datastore_path, extras=''):
-    test_return_data =f"""<html>
+def set_modified_response(datastore_path):
+    test_return_data = """<html>
     <head><title>modified head title</title></head>
     <body>
      Some initial text<br>
      <p>which has this one new line</p>
      <br>
      So let's see what happens.  <br>
-     with more text that helps word-diff if needed<br>
-     and more text that helps word-diff if needed<br>
-     and even more text {extras}that helps word-diff if needed<br>     
      </body>
      </html>
     """
@@ -98,8 +92,8 @@ def wait_for_notification_endpoint_output(datastore_path):
     #@todo - could check the apprise object directly instead of looking for this file
     from os.path import isfile
     notification_file = os.path.join(datastore_path, "notification.txt")
-    for i in range(1, 100):
-        time.sleep(0.3)
+    for i in range(1, 20):
+        time.sleep(1)
         if isfile(notification_file):
             return True
 

changedetectionio/tests/visualselector/test_fetch_data.py

@@ -144,6 +144,7 @@ def test_basic_browserstep(client, live_server, measure_memory_usage, datastore_
 
 def test_non_200_errors_report_browsersteps(client, live_server, measure_memory_usage, datastore_path):
 
+
     four_o_four_url =  url_for('test_endpoint', status_code=404, _external=True)
     four_o_four_url = four_o_four_url.replace('localhost.localdomain', 'cdio')
     four_o_four_url = four_o_four_url.replace('localhost', 'cdio')
@@ -185,65 +186,3 @@ def test_non_200_errors_report_browsersteps(client, live_server, measure_memory_
         url_for("ui.form_delete", uuid="all"),
         follow_redirects=True
     )
-
-def test_browsersteps_edit_UI_startsession(client, live_server, measure_memory_usage, datastore_path):
-
-    assert os.getenv('PLAYWRIGHT_DRIVER_URL'), "Needs PLAYWRIGHT_DRIVER_URL set for this test"
-
-    # Add a watch first
-    test_url = url_for('test_interactive_html_endpoint', _external=True)
-    test_url = test_url.replace('localhost.localdomain', 'cdio')
-    test_url = test_url.replace('localhost', 'cdio')
-
-    uuid = client.application.config.get('DATASTORE').add_watch(url=test_url, extras={'fetch_backend': 'html_webdriver', 'paused': True})
-
-    # Test starting a browsersteps session
-    res = client.get(
-        url_for("browser_steps.browsersteps_start_session", uuid=uuid),
-        follow_redirects=True
-    )
-
-    assert res.status_code == 200
-    assert res.is_json
-    json_data = res.get_json()
-    assert 'browsersteps_session_id' in json_data
-    assert json_data['browsersteps_session_id']  # Not empty
-
-    browsersteps_session_id = json_data['browsersteps_session_id']
-
-    # Verify the session exists in browsersteps_sessions
-    from changedetectionio.blueprint.browser_steps import browsersteps_sessions, browsersteps_watch_to_session
-    assert browsersteps_session_id in browsersteps_sessions
-    assert uuid in browsersteps_watch_to_session
-    assert browsersteps_watch_to_session[uuid] == browsersteps_session_id
-
-    # Verify browsersteps UI shows up on edit page
-    res = client.get(url_for("ui.ui_edit.edit_page", uuid=uuid))
-    assert b'browsersteps-click-start' in res.data, "Browsersteps manual UI shows up"
-
-    # Session should still exist after GET (not cleaned up yet)
-    assert browsersteps_session_id in browsersteps_sessions
-    assert uuid in browsersteps_watch_to_session
-
-    # Test cleanup happens on save (POST)
-    res = client.post(
-        url_for("ui.ui_edit.edit_page", uuid=uuid),
-        data={
-            "url": test_url,
-            "tags": "",
-            'fetch_backend': "html_webdriver",
-            "time_between_check_use_default": "y",
-        },
-        follow_redirects=True
-    )
-    assert b"Updated watch" in res.data
-
-    # NOW verify the session was cleaned up after save
-    assert browsersteps_session_id not in browsersteps_sessions
-    assert uuid not in browsersteps_watch_to_session
-
-    # Cleanup
-    client.get(
-        url_for("ui.form_delete", uuid="all"),
-        follow_redirects=True
-    )