Attempt to handle #text

Visual Selector - handle small bug where whitespace after the filter caused it to not be visualised
Misc fixes
2025-11-04 08:34:57 +00:00 · 2023-11-13 18:09:53 +01:00 · 2023-11-13 18:04:31 +01:00 · 2023-11-13 17:35:29 +01:00
4 changed files with 20 additions and 9 deletions
--- a/changedetectionio/forms.py
+++ b/changedetectionio/forms.py
@@ -351,7 +351,7 @@ class ValidateCSSJSONXPATHInput(object):
                    raise ValidationError("XPath not permitted in this field!")
                from lxml import etree, html
                tree = html.fromstring("<html></html>")
-                line = line.replace('xpath1:', '')
+                line = re.sub(r'^xpath1:', '', line)

                try:
                    tree.xpath(line.strip())
--- a/changedetectionio/res/xpath_element_scraper.js
+++ b/changedetectionio/res/xpath_element_scraper.js
@@ -170,9 +170,12 @@ if (include_filters.length) {

        try {
            // is it xpath?
-            if (f.startsWith('/') || f.startsWith('xpath:')) {
-                q = document.evaluate(f.replace('xpath:', ''), document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;
+            if (f.startsWith('/') || f.startsWith('xpath')) {
+                var qry_f = f.replace(/xpath(:|\d:)/, '')
+                console.log("[xpath] Scanning for included filter " + qry_f)
+                q = document.evaluate(qry_f, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;
            } else {
+                console.log("[css] Scanning for included filter " + f)
                q = document.querySelector(f);
            }
        } catch (e) {
@@ -182,8 +185,18 @@ if (include_filters.length) {
        }

        if (q) {
+            // Try to resolve //something/text() back to its /something so we can atleast get the bounding box
+            try {
+                if (typeof q.nodeName == 'string' && q.nodeName === '#text') {
+                    q = q.parentElement
+                }
+            } catch (e) {
+                console.log(e)
+                console.log("xpath_element_scraper: #text resolver")
+            }
+
            // #1231 - IN the case XPath attribute filter is applied, we will have to traverse up and find the element.
-            if (q.hasOwnProperty('getBoundingClientRect')) {
+            if (typeof q.getBoundingClientRect == 'function') {
                bbox = q.getBoundingClientRect();
                console.log("xpath_element_scraper: Got filter element, scroll from top was " + scroll_y)
            } else {
@@ -192,7 +205,8 @@ if (include_filters.length) {
                    bbox = q.ownerElement.getBoundingClientRect();
                    console.log("xpath_element_scraper: Got filter by ownerElement element, scroll from top was " + scroll_y)
                } catch (e) {
-                    console.log("xpath_element_scraper: error looking up ownerElement")
+                    console.log(e)
+                    console.log("xpath_element_scraper: error looking up q.ownerElement")
                }
            }
        }
--- a/changedetectionio/static/js/visual-selector.js
+++ b/changedetectionio/static/js/visual-selector.js
@@ -149,7 +149,7 @@ $(document).ready(function () {
            // @todo In the future paint all that match
            for (const c of current_default_xpath) {
                for (var i = selector_data['size_pos'].length; i !== 0; i--) {
-                    if (selector_data['size_pos'][i - 1].xpath === c) {
+                    if (selector_data['size_pos'][i - 1].xpath.trim() === c.trim()) {
                        console.log("highlighting " + c);
                        current_selected_i = i - 1;
                        highlight_current_selected_i();
--- a/changedetectionio/tests/test_extract_regex.py
+++ b/changedetectionio/tests/test_extract_regex.py
@@ -227,9 +227,6 @@ def test_regex_error_handling(client, live_server):
        follow_redirects=True
    )

-    with open('/tmp/fuck.html', 'wb') as f:
-        f.write(res.data)
-
    assert b'is not a valid regular expression.' in res.data

    res = client.get(url_for("form_delete", uuid="all"), follow_redirects=True)
Author	SHA1	Message	Date
dgtlmoon	3647fb822b	Attempt to handle #text	2023-11-13 18:09:53 +01:00
dgtlmoon	9ec00f4752	Visual Selector - handle small bug where whitespace after the filter caused it to not be visualised	2023-11-13 18:04:31 +01:00
dgtlmoon	465ff6ee44	Misc fixes	2023-11-13 17:35:29 +01:00