Adding random tips

changedetectionio/__init__.py

@@ -112,9 +112,9 @@ def sigshutdown_handler(_signo, _stack_frame):
         from changedetectionio.flask_app import update_q, notification_q
         update_q.close()
         notification_q.close()
-        logger.debug("Queues closed successfully")
+        logger.debug("Janus queues closed successfully")
     except Exception as e:
-        logger.critical(f"CRITICAL: Failed to close queues: {e}")
+        logger.critical(f"CRITICAL: Failed to close janus queues: {e}")
     
     # Shutdown socketio server fast
     from changedetectionio.flask_app import socketio_server
@@ -124,9 +124,13 @@ def sigshutdown_handler(_signo, _stack_frame):
         except Exception as e:
             logger.error(f"Error shutting down Socket.IO server: {str(e)}")
     
-    # With immediate persistence, all data is already saved
-    logger.success('All data already persisted (immediate commits enabled).')
-
+    # Save data quickly - force immediate save using abstract method
+    try:
+        datastore.force_save_all()
+        logger.success('Fast sync to storage complete.')
+    except Exception as e:
+        logger.error(f"Error syncing to storage: {str(e)}")
+    
     sys.exit()
 
 def print_help():
@@ -182,6 +186,7 @@ def main():
     from changedetectionio.flask_app import changedetection_app
 
     datastore_path = None
+    do_cleanup = False
     # Set a default logger level
     logger_level = 'DEBUG'
     include_default_watches = True
@@ -264,7 +269,7 @@ def main():
         i += 1
 
     try:
-        opts, args = getopt.getopt(cleaned_argv[1:], "6Csd:h:p:l:P:", "port")
+        opts, args = getopt.getopt(cleaned_argv[1:], "6Ccsd:h:p:l:P:", "port")
     except getopt.GetoptError as e:
         print_help()
         print(f'Error: {e}')
@@ -292,6 +297,10 @@ def main():
         if opt == '-d':
             datastore_path = arg
 
+        # Cleanup (remove text files that arent in the index)
+        if opt == '-c':
+            do_cleanup = True
+
         # Create the datadir if it doesnt exist
         if opt == '-C':
             create_datastore_dir = True
@@ -597,6 +606,10 @@ def main():
     else:
         logger.info("SIGUSR1 handler only registered on Linux, skipped.")
 
+    # Go into cleanup mode
+    if do_cleanup:
+        datastore.remove_unused_snapshots()
+
     app.config['datastore_path'] = datastore_path
 
 
@@ -605,7 +618,7 @@ def main():
         return dict(right_sticky="v{}".format(datastore.data['version_tag']),
                     new_version_available=app.config['NEW_VERSION_AVAILABLE'],
                     has_password=datastore.data['settings']['application']['password'] != False,
-                    socket_io_enabled=datastore.data['settings']['application'].get('ui', {}).get('socket_io_enabled', True),
+                    socket_io_enabled=datastore.data['settings']['application']['ui'].get('socket_io_enabled', True),
                     all_paused=datastore.data['settings']['application'].get('all_paused', False),
                     all_muted=datastore.data['settings']['application'].get('all_muted', False)
                     )

changedetectionio/api/Notifications.py

@@ -67,7 +67,7 @@ class Notifications(Resource):
 
         clean_urls = [url.strip() for url in notification_urls if isinstance(url, str)]
         self.datastore.data['settings']['application']['notification_urls'] = clean_urls
-        self.datastore.commit()
+        self.datastore.needs_write = True
 
         return {'notification_urls': clean_urls}, 200
         
@@ -95,7 +95,7 @@ class Notifications(Resource):
             abort(400, message="No matching notification URLs found.")
 
         self.datastore.data['settings']['application']['notification_urls'] = notification_urls
-        self.datastore.commit()
+        self.datastore.needs_write = True
 
         return 'OK', 204
     

changedetectionio/api/Tags.py

@@ -24,7 +24,8 @@ class Tag(Resource):
     @validate_openapi_request('getTag')
     def get(self, uuid):
         """Get data for a single tag/group, toggle notification muting, or recheck all."""
-        tag = self.datastore.data['settings']['application']['tags'].get(uuid)
+        from copy import deepcopy
+        tag = deepcopy(self.datastore.data['settings']['application']['tags'].get(uuid))
         if not tag:
             abort(404, message=f'No tag exists with the UUID of {uuid}')
 
@@ -61,12 +62,10 @@ class Tag(Resource):
                 return {'status': f'OK, queueing {len(watches_to_queue)} watches in background'}, 202
 
         if request.args.get('muted', '') == 'muted':
-            tag['notification_muted'] = True
-            tag.commit()
+            self.datastore.data['settings']['application']['tags'][uuid]['notification_muted'] = True
             return "OK", 200
         elif request.args.get('muted', '') == 'unmuted':
-            tag['notification_muted'] = False
-            tag.commit()
+            self.datastore.data['settings']['application']['tags'][uuid]['notification_muted'] = False
             return "OK", 200
 
         return tag
@@ -80,23 +79,11 @@ class Tag(Resource):
 
         # Delete the tag, and any tag reference
         del self.datastore.data['settings']['application']['tags'][uuid]
-
-        # Delete tag.json file if it exists
-        import os
-        tag_dir = os.path.join(self.datastore.datastore_path, uuid)
-        tag_json = os.path.join(tag_dir, "tag.json")
-        if os.path.exists(tag_json):
-            try:
-                os.unlink(tag_json)
-                logger.info(f"Deleted tag.json for tag {uuid}")
-            except Exception as e:
-                logger.error(f"Failed to delete tag.json for tag {uuid}: {e}")
-
+        
         # Remove tag from all watches
         for watch_uuid, watch in self.datastore.data['watching'].items():
             if watch.get('tags') and uuid in watch['tags']:
                 watch['tags'].remove(uuid)
-                watch.commit()
 
         return 'OK', 204
 
@@ -120,7 +107,7 @@ class Tag(Resource):
                 return str(e), 400
 
         tag.update(request.json)
-        tag.commit()
+        self.datastore.needs_write_urgent = True
 
         return "OK", 200
 

changedetectionio/api/Watch.py

@@ -66,46 +66,47 @@ class Watch(Resource):
     @validate_openapi_request('getWatch')
     def get(self, uuid):
         """Get information about a single watch, recheck, pause, or mute."""
-        # Get watch reference first (for pause/mute operations)
-        watch_obj = self.datastore.data['watching'].get(uuid)
-        if not watch_obj:
-            abort(404, message='No watch exists with the UUID of {}'.format(uuid))
+        import time
+        from copy import deepcopy
+        watch = None
+        # Retry up to 20 times if dict is being modified
+        # With sleep(0), this is fast: ~200µs best case, ~20ms worst case under heavy load
+        for attempt in range(20):
+            try:
+                watch = deepcopy(self.datastore.data['watching'].get(uuid))
+                break
+            except RuntimeError:
+                # Dict changed during deepcopy, retry after yielding to scheduler
+                # sleep(0) releases GIL and yields - no fixed delay, just lets other threads run
+                if attempt < 19:  # Don't yield on last attempt
+                    time.sleep(0)  # Yield to scheduler (microseconds, not milliseconds)
 
-        # Create a dict copy for JSON response (with lock for thread safety)
-        # This is much faster than deepcopy and doesn't copy the datastore reference
-        # WARNING: dict() is a SHALLOW copy - nested dicts are shared with original!
-        # Only safe because we only ADD scalar properties (line 97-101), never modify nested dicts
-        # If you need to modify nested dicts, use: from copy import deepcopy; watch = deepcopy(dict(watch_obj))
-        with self.datastore.lock:
-            watch = dict(watch_obj)
+        if not watch:
+            abort(404, message='No watch exists with the UUID of {}'.format(uuid))
 
         if request.args.get('recheck'):
             worker_pool.queue_item_async_safe(self.update_q, queuedWatchMetaData.PrioritizedItem(priority=1, item={'uuid': uuid}))
             return "OK", 200
         if request.args.get('paused', '') == 'paused':
-            watch_obj.pause()
-            watch_obj.commit()
+            self.datastore.data['watching'].get(uuid).pause()
             return "OK", 200
         elif request.args.get('paused', '') == 'unpaused':
-            watch_obj.unpause()
-            watch_obj.commit()
+            self.datastore.data['watching'].get(uuid).unpause()
             return "OK", 200
         if request.args.get('muted', '') == 'muted':
-            watch_obj.mute()
-            watch_obj.commit()
+            self.datastore.data['watching'].get(uuid).mute()
             return "OK", 200
         elif request.args.get('muted', '') == 'unmuted':
-            watch_obj.unmute()
-            watch_obj.commit()
+            self.datastore.data['watching'].get(uuid).unmute()
             return "OK", 200
 
         # Return without history, get that via another API call
         # Properties are not returned as a JSON, so add the required props manually
-        watch['history_n'] = watch_obj.history_n
+        watch['history_n'] = watch.history_n
         # attr .last_changed will check for the last written text snapshot on change
-        watch['last_changed'] = watch_obj.last_changed
-        watch['viewed'] = watch_obj.viewed
-        watch['link'] = watch_obj.link,
+        watch['last_changed'] = watch.last_changed
+        watch['viewed'] = watch.viewed
+        watch['link'] = watch.link,
 
         return watch
 
@@ -177,7 +178,6 @@ class Watch(Resource):
 
         # Update watch with regular (non-processor-config) fields
         watch.update(json_data)
-        watch.commit()
 
         # Save processor config to JSON file
         processors.save_processor_config(self.datastore, uuid, processor_config_data)
@@ -374,10 +374,10 @@ class WatchFavicon(Resource):
         favicon_filename = watch.get_favicon_filename()
         if favicon_filename:
             # Use cached MIME type detection
-            filepath = os.path.join(watch.data_dir, favicon_filename)
+            filepath = os.path.join(watch.watch_data_dir, favicon_filename)
             mime = get_favicon_mime_type(filepath)
 
-            response = make_response(send_from_directory(watch.data_dir, favicon_filename))
+            response = make_response(send_from_directory(watch.watch_data_dir, favicon_filename))
             response.headers['Content-type'] = mime
             response.headers['Cache-Control'] = 'max-age=300, must-revalidate'  # Cache for 5 minutes, then revalidate
             return response
@@ -424,14 +424,8 @@ class CreateWatch(Resource):
             except ValidationError as e:
                 return str(e), 400
 
-        # Handle processor-config-* fields separately (save to JSON, not watch)
-        from changedetectionio import processors
-
         extras = copy.deepcopy(json_data)
 
-        # Extract and remove processor config fields from extras
-        processor_config_data = processors.extract_processor_config_from_form_data(extras)
-
         # Because we renamed 'tag' to 'tags' but don't want to change the API (can do this in v2 of the API)
         tags = None
         if extras.get('tag'):
@@ -441,10 +435,6 @@ class CreateWatch(Resource):
         del extras['url']
 
         new_uuid = self.datastore.add_watch(url=url, extras=extras, tag=tags)
-
-        # Save processor config to separate JSON file
-        if new_uuid and processor_config_data:
-            processors.save_processor_config(self.datastore, new_uuid, processor_config_data)
         if new_uuid:
 # Dont queue because the scheduler will check that it hasnt been checked before anyway
 #            worker_pool.queue_item_async_safe(self.update_q, queuedWatchMetaData.PrioritizedItem(priority=1, item={'uuid': new_uuid}))

changedetectionio/api/__init__.py

@@ -12,17 +12,9 @@ schema = api_schema.build_watch_json_schema(watch_base_config)
 schema_create_watch = copy.deepcopy(schema)
 schema_create_watch['required'] = ['url']
 del schema_create_watch['properties']['last_viewed']
-# Allow processor_config_* fields (handled separately in endpoint)
-schema_create_watch['patternProperties'] = {
-    '^processor_config_': {'type': ['string', 'number', 'boolean', 'object', 'array', 'null']}
-}
 
 schema_update_watch = copy.deepcopy(schema)
 schema_update_watch['additionalProperties'] = False
-# Allow processor_config_* fields (handled separately in endpoint)
-schema_update_watch['patternProperties'] = {
-    '^processor_config_': {'type': ['string', 'number', 'boolean', 'object', 'array', 'null']}
-}
 
 # Tag schema is also based on watch_base since Tag inherits from it
 schema_tag = copy.deepcopy(schema)

changedetectionio/blueprint/backups/__init__.py

@@ -47,7 +47,7 @@ def create_backup(datastore_path, watches: dict):
 
         # Add any data in the watch data directory.
         for uuid, w in watches.items():
-            for f in Path(w.data_dir).glob('*'):
+            for f in Path(w.watch_data_dir).glob('*'):
                 zipObj.write(f,
                              # Use the full path to access the file, but make the file 'relative' in the Zip.
                              arcname=os.path.join(f.parts[-2], f.parts[-1]),
@@ -102,7 +102,8 @@ def construct_blueprint(datastore: ChangeDetectionStore):
             flash(gettext("Maximum number of backups reached, please remove some"), "error")
             return redirect(url_for('backups.index'))
 
-        # With immediate persistence, all data is already saved
+        # Be sure we're written fresh - force immediate save using abstract method
+        datastore.force_save_all()
         zip_thread = threading.Thread(
             target=create_backup,
             args=(datastore.datastore_path, datastore.data.get("watching")),

changedetectionio/blueprint/backups/templates/overview.html

@@ -3,10 +3,10 @@
     {% from '_helpers.html' import render_simple_field, render_field %}
     <div class="edit-form">
         <div class="box-wrap inner">
-            <h2>{{ _('Backups') }}</h2>
+            <h4>{{ _('Backups') }}</h4>
             {% if backup_running %}
                 <p>
-                    <span class="spinner"></span>&nbsp;<strong>{{ _('A backup is running!') }}</strong>
+                    <strong>{{ _('A backup is running!') }}</strong>
                 </p>
             {% endif %}
             <p>

changedetectionio/blueprint/browser_steps/__init__.py

@@ -285,8 +285,8 @@ def construct_blueprint(datastore: ChangeDetectionStore):
         watch = datastore.data['watching'].get(uuid)
         filename = f"step_before-{step_n}.jpeg" if request.args.get('type', '') == 'before' else f"step_{step_n}.jpeg"
 
-        if step_n and watch and os.path.isfile(os.path.join(watch.data_dir, filename)):
-            response = make_response(send_from_directory(directory=watch.data_dir, path=filename))
+        if step_n and watch and os.path.isfile(os.path.join(watch.watch_data_dir, filename)):
+            response = make_response(send_from_directory(directory=watch.watch_data_dir, path=filename))
             response.headers['Content-type'] = 'image/jpeg'
             response.headers['Cache-Control'] = 'no-cache, no-store, must-revalidate'
             response.headers['Pragma'] = 'no-cache'

changedetectionio/blueprint/price_data_follower/__init__.py

@@ -20,7 +20,6 @@ def construct_blueprint(datastore: ChangeDetectionStore, update_q: PriorityQueue
         datastore.data['watching'][uuid]['track_ldjson_price_data'] = PRICE_DATA_TRACK_ACCEPT
         datastore.data['watching'][uuid]['processor'] = 'restock_diff'
         datastore.data['watching'][uuid].clear_watch()
-        datastore.data['watching'][uuid].commit()
         worker_pool.queue_item_async_safe(update_q, queuedWatchMetaData.PrioritizedItem(priority=1, item={'uuid': uuid}))
         return redirect(url_for("watchlist.index"))
 
@@ -28,7 +27,6 @@ def construct_blueprint(datastore: ChangeDetectionStore, update_q: PriorityQueue
     @price_data_follower_blueprint.route("/<string:uuid>/reject", methods=['GET'])
     def reject(uuid):
         datastore.data['watching'][uuid]['track_ldjson_price_data'] = PRICE_DATA_TRACK_REJECT
-        datastore.data['watching'][uuid].commit()
         return redirect(url_for("watchlist.index"))
 
 

changedetectionio/blueprint/settings/__init__.py

@@ -1,9 +1,8 @@
 import os
 from copy import deepcopy
-from datetime import datetime, timedelta
+from datetime import datetime
 from zoneinfo import ZoneInfo, available_timezones
 import secrets
-import time
 import flask_login
 from flask import Blueprint, render_template, request, redirect, url_for, flash
 from flask_babel import gettext
@@ -75,13 +74,12 @@ def construct_blueprint(datastore: ChangeDetectionStore):
                     del (app_update['password'])
 
                 datastore.data['settings']['application'].update(app_update)
-
+                
                 # Handle dynamic worker count adjustment
                 old_worker_count = datastore.data['settings']['requests'].get('workers', 1)
                 new_worker_count = form.data['requests'].get('workers', 1)
 
                 datastore.data['settings']['requests'].update(form.data['requests'])
-                datastore.commit()
 
                 # Adjust worker count if it changed
                 if new_worker_count != old_worker_count:
@@ -111,11 +109,13 @@ def construct_blueprint(datastore: ChangeDetectionStore):
 
                 if not os.getenv("SALTED_PASS", False) and len(form.application.form.password.encrypted_password):
                     datastore.data['settings']['application']['password'] = form.application.form.password.encrypted_password
-                    datastore.commit()
+                    datastore.needs_write_urgent = True
                     flash(gettext("Password protection enabled."), 'notice')
                     flask_login.logout_user()
                     return redirect(url_for('watchlist.index'))
 
+                datastore.needs_write_urgent = True
+
                 # Also save plugin settings from the same form submission
                 plugin_tabs_list = get_plugin_settings_tabs()
                 for tab in plugin_tabs_list:
@@ -143,9 +143,6 @@ def construct_blueprint(datastore: ChangeDetectionStore):
         active_plugins = get_active_plugins()
         python_version = f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}"
 
-        # Calculate uptime in seconds
-        uptime_seconds = time.time() - datastore.start_time
-
         # Get plugin settings tabs and instantiate forms
         plugin_tabs = get_plugin_settings_tabs()
         plugin_forms = {}
@@ -164,7 +161,6 @@ def construct_blueprint(datastore: ChangeDetectionStore):
                                 active_plugins=active_plugins,
                                 api_key=datastore.data['settings']['application'].get('api_access_token'),
                                 python_version=python_version,
-                                uptime_seconds=uptime_seconds,
                                 available_timezones=sorted(available_timezones()),
                                 emailprefix=os.getenv('NOTIFICATION_MAIL_BUTTON_PREFIX', False),
                                 extra_notification_token_placeholder_info=datastore.get_unique_notification_token_placeholders_available(),
@@ -185,7 +181,7 @@ def construct_blueprint(datastore: ChangeDetectionStore):
     def settings_reset_api_key():
         secret = secrets.token_hex(16)
         datastore.data['settings']['application']['api_access_token'] = secret
-        datastore.commit()
+        datastore.needs_write_urgent = True
         flash(gettext("API Key was regenerated."))
         return redirect(url_for('settings.settings_page')+'#api')
         
@@ -202,7 +198,7 @@ def construct_blueprint(datastore: ChangeDetectionStore):
     def toggle_all_paused():
         current_state = datastore.data['settings']['application'].get('all_paused', False)
         datastore.data['settings']['application']['all_paused'] = not current_state
-        datastore.commit()
+        datastore.needs_write_urgent = True
 
         if datastore.data['settings']['application']['all_paused']:
             flash(gettext("Automatic scheduling paused - checks will not be queued."), 'notice')
@@ -216,7 +212,7 @@ def construct_blueprint(datastore: ChangeDetectionStore):
     def toggle_all_muted():
         current_state = datastore.data['settings']['application'].get('all_muted', False)
         datastore.data['settings']['application']['all_muted'] = not current_state
-        datastore.commit()
+        datastore.needs_write_urgent = True
 
         if datastore.data['settings']['application']['all_muted']:
             flash(gettext("All notifications muted."), 'notice')

changedetectionio/blueprint/settings/templates/settings.html

@@ -25,7 +25,7 @@
             <li class="tab"><a href="#ui-options">{{ _('UI Options') }}</a></li>
             <li class="tab"><a href="#api">{{ _('API') }}</a></li>
             <li class="tab"><a href="#rss">{{ _('RSS') }}</a></li>
-            <li class="tab"><a href="{{ url_for('backups.index') }}">{{ _('Backups') }}</a></li>
+            <li class="tab"><a href="{{ url_for('backups.index') }}" class="pure-menu-link">{{ _('Backups') }}</a></li>
             <li class="tab"><a href="#timedate">{{ _('Time & Date') }}</a></li>
             <li class="tab"><a href="#proxies">{{ _('CAPTCHA & Proxies') }}</a></li>
             {% if plugin_tabs %}
@@ -59,14 +59,6 @@
                         {{ _('Set to') }} <strong>0</strong> {{ _('to disable') }}
                         </span>
                     </div>
-                    <div class="pure-control-group">
-                        {{ render_field(form.application.form.history_snapshot_max_length, class="history_snapshot_max_length") }}
-                        <span class="pure-form-message-inline">{{ _('Limit collection of history snapshots for each watch to this number of history items.') }}
-                            <br>
-                        {{ _('Set to empty to disable / no limit') }}
-                        </span>
-                    </div>
-
                     <div class="pure-control-group">
                         {% if not hide_remove_pass %}
                             {% if current_user.is_authenticated %}
@@ -394,7 +386,6 @@ nav
                 {% endfor %}
             {% endif %}
             <div class="tab-pane-inner" id="info">
-                <p><strong>{{ _('Uptime:') }}</strong> {{ uptime_seconds|format_duration }}</p>
                 <p><strong>{{ _('Python version:') }}</strong> {{ python_version }}</p>
                 <p><strong>{{ _('Plugins active:') }}</strong></p>
                 {% if active_plugins %}

changedetectionio/blueprint/tags/__init__.py

@@ -57,10 +57,8 @@ def construct_blueprint(datastore: ChangeDetectionStore):
     @tags_blueprint.route("/mute/<string:uuid>", methods=['GET'])
     @login_optionally_required
     def mute(uuid):
-        tag = datastore.data['settings']['application']['tags'].get(uuid)
-        if tag:
-            tag['notification_muted'] = not tag['notification_muted']
-            tag.commit()
+        if datastore.data['settings']['application']['tags'].get(uuid):
+            datastore.data['settings']['application']['tags'][uuid]['notification_muted'] = not datastore.data['settings']['application']['tags'][uuid]['notification_muted']
         return redirect(url_for('tags.tags_overview_page'))
 
     @tags_blueprint.route("/delete/<string:uuid>", methods=['GET'])
@@ -70,17 +68,6 @@ def construct_blueprint(datastore: ChangeDetectionStore):
         if datastore.data['settings']['application']['tags'].get(uuid):
             del datastore.data['settings']['application']['tags'][uuid]
 
-        # Delete tag.json file if it exists
-        import os
-        tag_dir = os.path.join(datastore.datastore_path, uuid)
-        tag_json = os.path.join(tag_dir, "tag.json")
-        if os.path.exists(tag_json):
-            try:
-                os.unlink(tag_json)
-                logger.info(f"Deleted tag.json for tag {uuid}")
-            except Exception as e:
-                logger.error(f"Failed to delete tag.json for tag {uuid}: {e}")
-
         # Remove tag from all watches in background thread to avoid blocking
         def remove_tag_background(tag_uuid):
             """Background thread to remove tag from watches - discarded after completion."""
@@ -89,7 +76,6 @@ def construct_blueprint(datastore: ChangeDetectionStore):
                 for watch_uuid, watch in datastore.data['watching'].items():
                     if watch.get('tags') and tag_uuid in watch['tags']:
                         watch['tags'].remove(tag_uuid)
-                        watch.commit()
                         removed_count += 1
                 logger.info(f"Background: Tag {tag_uuid} removed from {removed_count} watches")
             except Exception as e:
@@ -112,7 +98,6 @@ def construct_blueprint(datastore: ChangeDetectionStore):
                 for watch_uuid, watch in datastore.data['watching'].items():
                     if watch.get('tags') and tag_uuid in watch['tags']:
                         watch['tags'].remove(tag_uuid)
-                        watch.commit()
                         unlinked_count += 1
                 logger.info(f"Background: Tag {tag_uuid} unlinked from {unlinked_count} watches")
             except Exception as e:
@@ -127,17 +112,6 @@ def construct_blueprint(datastore: ChangeDetectionStore):
     @tags_blueprint.route("/delete_all", methods=['GET'])
     @login_optionally_required
     def delete_all():
-        # Delete all tag.json files
-        import os
-        for tag_uuid in list(datastore.data['settings']['application']['tags'].keys()):
-            tag_dir = os.path.join(datastore.datastore_path, tag_uuid)
-            tag_json = os.path.join(tag_dir, "tag.json")
-            if os.path.exists(tag_json):
-                try:
-                    os.unlink(tag_json)
-                except Exception as e:
-                    logger.error(f"Failed to delete tag.json for tag {tag_uuid}: {e}")
-
         # Clear all tags from settings immediately
         datastore.data['settings']['application']['tags'] = {}
 
@@ -148,7 +122,6 @@ def construct_blueprint(datastore: ChangeDetectionStore):
             try:
                 for watch_uuid, watch in datastore.data['watching'].items():
                     watch['tags'] = []
-                    watch.commit()
                     cleared_count += 1
                 logger.info(f"Background: Cleared tags from {cleared_count} watches")
             except Exception as e:
@@ -229,10 +202,10 @@ def construct_blueprint(datastore: ChangeDetectionStore):
         if uuid == 'first':
             uuid = list(datastore.data['settings']['application']['tags'].keys()).pop()
 
-        tag = datastore.data['settings']['application']['tags'].get(uuid)
+        default = datastore.data['settings']['application']['tags'].get(uuid)
 
         form = group_restock_settings_form(formdata=request.form if request.method == 'POST' else None,
-                               data=tag,
+                               data=default,
                                extra_notification_tokens=datastore.get_unique_notification_tokens_available()
                                )
         # @todo subclass form so validation works
@@ -241,9 +214,9 @@ def construct_blueprint(datastore: ChangeDetectionStore):
 #                flash(','.join(l), 'error')
 #           return redirect(url_for('tags.form_tag_edit_submit', uuid=uuid))
 
-        tag.update(form.data)
-        tag['processor'] = 'restock_diff'
-        tag.commit()
+        datastore.data['settings']['application']['tags'][uuid].update(form.data)
+        datastore.data['settings']['application']['tags'][uuid]['processor'] = 'restock_diff'
+        datastore.needs_write_urgent = True
         flash(gettext("Updated"))
 
         return redirect(url_for('tags.tags_overview_page'))

changedetectionio/blueprint/ui/__init__.py

@@ -24,7 +24,7 @@ def _handle_operations(op, uuids, datastore, worker_pool, update_q, queuedWatchM
         for uuid in uuids:
             if datastore.data['watching'].get(uuid):
                 datastore.data['watching'][uuid]['paused'] = True
-                datastore.data['watching'][uuid].commit()
+                datastore.mark_watch_dirty(uuid)
         if emit_flash:
             flash(gettext("{} watches paused").format(len(uuids)))
 
@@ -32,7 +32,7 @@ def _handle_operations(op, uuids, datastore, worker_pool, update_q, queuedWatchM
         for uuid in uuids:
             if datastore.data['watching'].get(uuid):
                 datastore.data['watching'][uuid.strip()]['paused'] = False
-                datastore.data['watching'][uuid].commit()
+                datastore.mark_watch_dirty(uuid)
         if emit_flash:
             flash(gettext("{} watches unpaused").format(len(uuids)))
 
@@ -47,7 +47,7 @@ def _handle_operations(op, uuids, datastore, worker_pool, update_q, queuedWatchM
         for uuid in uuids:
             if datastore.data['watching'].get(uuid):
                 datastore.data['watching'][uuid]['notification_muted'] = True
-                datastore.data['watching'][uuid].commit()
+                datastore.mark_watch_dirty(uuid)
         if emit_flash:
             flash(gettext("{} watches muted").format(len(uuids)))
 
@@ -55,7 +55,7 @@ def _handle_operations(op, uuids, datastore, worker_pool, update_q, queuedWatchM
         for uuid in uuids:
             if datastore.data['watching'].get(uuid):
                 datastore.data['watching'][uuid]['notification_muted'] = False
-                datastore.data['watching'][uuid].commit()
+                datastore.mark_watch_dirty(uuid)
         if emit_flash:
             flash(gettext("{} watches un-muted").format(len(uuids)))
 
@@ -71,7 +71,7 @@ def _handle_operations(op, uuids, datastore, worker_pool, update_q, queuedWatchM
         for uuid in uuids:
             if datastore.data['watching'].get(uuid):
                 datastore.data['watching'][uuid]["last_error"] = False
-                datastore.data['watching'][uuid].commit()
+                datastore.mark_watch_dirty(uuid)
         if emit_flash:
             flash(gettext("{} watches errors cleared").format(len(uuids)))
 
@@ -92,7 +92,6 @@ def _handle_operations(op, uuids, datastore, worker_pool, update_q, queuedWatchM
                 datastore.data['watching'][uuid]['notification_body'] = None
                 datastore.data['watching'][uuid]['notification_urls'] = []
                 datastore.data['watching'][uuid]['notification_format'] = USE_SYSTEM_DEFAULT_NOTIFICATION_FORMAT_FOR_WATCH
-                datastore.data['watching'][uuid].commit()
         if emit_flash:
             flash(gettext("{} watches set to use default notification settings").format(len(uuids)))
 
@@ -108,7 +107,6 @@ def _handle_operations(op, uuids, datastore, worker_pool, update_q, queuedWatchM
                             datastore.data['watching'][uuid]['tags'] = []
 
                         datastore.data['watching'][uuid]['tags'].append(tag_uuid)
-                        datastore.data['watching'][uuid].commit()
         if emit_flash:
             flash(gettext("{} watches were tagged").format(len(uuids)))
 

changedetectionio/blueprint/ui/edit.py

@@ -197,11 +197,7 @@ def construct_blueprint(datastore: ChangeDetectionStore, update_q, queuedWatchMe
 
             # Recast it if need be to right data Watch handler
             watch_class = processors.get_custom_watch_obj_for_processor(form.data.get('processor'))
-            datastore.data['watching'][uuid] = watch_class(datastore_path=datastore.datastore_path, __datastore=datastore.data, default=datastore.data['watching'][uuid])
-
-            # Save the watch immediately
-            datastore.data['watching'][uuid].commit()
-
+            datastore.data['watching'][uuid] = watch_class(datastore_path=datastore.datastore_path, default=datastore.data['watching'][uuid])
             flash(gettext("Updated watch - unpaused!") if request.args.get('unpause_on_save') else gettext("Updated watch."))
 
             # Cleanup any browsersteps session for this watch
@@ -211,6 +207,10 @@ def construct_blueprint(datastore: ChangeDetectionStore, update_q, queuedWatchMe
             except Exception as e:
                 logger.debug(f"Error cleaning up browsersteps session: {e}")
 
+            # Re #286 - We wait for syncing new data to disk in another thread every 60 seconds
+            # But in the case something is added we should save straight away
+            datastore.needs_write_urgent = True
+
             # Do not queue on edit if its not within the time range
 
             # @todo maybe it should never queue anyway on edit...
@@ -337,9 +337,9 @@ def construct_blueprint(datastore: ChangeDetectionStore, update_q, queuedWatchMe
         if uuid == 'first':
             uuid = list(datastore.data['watching'].keys()).pop()
         watch = datastore.data['watching'].get(uuid)
-        if watch and watch.history.keys() and os.path.isdir(watch.data_dir):
+        if watch and watch.history.keys() and os.path.isdir(watch.watch_data_dir):
             latest_filename = list(watch.history.keys())[-1]
-            html_fname = os.path.join(watch.data_dir, f"{latest_filename}.html.br")
+            html_fname = os.path.join(watch.watch_data_dir, f"{latest_filename}.html.br")
             with open(html_fname, 'rb') as f:
                 if html_fname.endswith('.br'):
                     # Read and decompress the Brotli file
@@ -386,9 +386,6 @@ def construct_blueprint(datastore: ChangeDetectionStore, update_q, queuedWatchMe
                     s = re.sub(r'[0-9]+', r'\\d+', s)
                     datastore.data["watching"][uuid]['ignore_text'].append('/' + s + '/')
 
-            # Save the updated ignore_text
-            datastore.data["watching"][uuid].commit()
-
         return f"<a href={url_for('ui.ui_preview.preview_page', uuid=uuid)}>Click to preview</a>"
     
     return edit_blueprint

changedetectionio/blueprint/ui/templates/edit.html

@@ -115,13 +115,6 @@
                          {{ _('Sends a notification when the filter can no longer be seen on the page, good for knowing when the page changed and your filter will not work anymore.') }}
                         </span>
                     </div>
-                    <div class="pure-control-group">
-                        {{ render_field(form.history_snapshot_max_length, class="history_snapshot_max_length") }}
-                        <span class="pure-form-message-inline">{{ _('Limit collection of history snapshots for each watch to this number of history items.') }}
-                        <br>
-                        {{ _('Set to empty to use system settings default') }}
-                        </span>
-                    </div>
                     <div class="pure-control-group">
                         {{ render_ternary_field(form.use_page_title_in_list) }}
                     </div>

changedetectionio/blueprint/ui/views.py

@@ -26,7 +26,7 @@ def construct_blueprint(datastore: ChangeDetectionStore, update_q, queuedWatchMe
         add_paused = request.form.get('edit_and_watch_submit_button') != None
         from changedetectionio import processors
         processor = request.form.get('processor', processors.get_default_processor())
-        new_uuid = datastore.add_watch(url=url, tag=request.form.get('tags','').strip(), extras={'paused': add_paused, 'processor': processor})
+        new_uuid = datastore.add_watch(url=url, tag=request.form.get('tags').strip(), extras={'paused': add_paused, 'processor': processor})
 
         if new_uuid:
             if add_paused:
@@ -39,4 +39,4 @@ def construct_blueprint(datastore: ChangeDetectionStore, update_q, queuedWatchMe
 
         return redirect(url_for('watchlist.index', tag=request.args.get('tag','')))
 
-    return views_blueprint
+    return views_blueprint

changedetectionio/blueprint/watchlist/__init__.py

@@ -39,7 +39,7 @@ def construct_blueprint(datastore: ChangeDetectionStore, update_q, queuedWatchMe
             elif op == 'mute':
                 datastore.data['watching'][uuid].toggle_mute()
 
-            datastore.data['watching'][uuid].commit()
+            datastore.needs_write = True
             return redirect(url_for('watchlist.index', tag = active_tag_uuid))
 
         # Sort by last_changed and add the uuid which is usually the key..

changedetectionio/blueprint/watchlist/templates/watch-overview.html

@@ -14,46 +14,6 @@
 // Initialize Feather icons after the page loads
 document.addEventListener('DOMContentLoaded', function() {
     feather.replace();
-
-    // Intersection Observer for lazy loading favicons
-    // Only load favicon images when they enter the viewport
-    if ('IntersectionObserver' in window) {
-        const faviconObserver = new IntersectionObserver((entries, observer) => {
-            entries.forEach(entry => {
-                if (entry.isIntersecting) {
-                    const img = entry.target;
-                    const src = img.getAttribute('data-src');
-
-                    if (src) {
-                        // Load the actual favicon
-                        img.src = src;
-                        img.removeAttribute('data-src');
-                    }
-
-                    // Stop observing this image
-                    observer.unobserve(img);
-                }
-            });
-        }, {
-            // Start loading slightly before the image enters viewport
-            rootMargin: '50px',
-            threshold: 0.01
-        });
-
-        // Observe all lazy favicon images
-        document.querySelectorAll('.lazy-favicon').forEach(img => {
-            faviconObserver.observe(img);
-        });
-    } else {
-        // Fallback for older browsers: load all favicons immediately
-        document.querySelectorAll('.lazy-favicon').forEach(img => {
-            const src = img.getAttribute('data-src');
-            if (src) {
-                img.src = src;
-                img.removeAttribute('data-src');
-            }
-        });
-    }
 });
 </script>
 <style>
@@ -246,17 +206,8 @@ html[data-darkmode="true"] .watch-tag-list.tag-{{ class_name }} {
                 <td class="title-col inline">
                     <div class="flex-wrapper">
                     {% if 'favicons_enabled' not in ui_settings or ui_settings['favicons_enabled'] %}
-                        <div>
-                            {# Intersection Observer lazy loading: store real URL in data-src, load only when visible in viewport #}
-                            <img alt="Favicon thumbnail"
-                                 class="favicon lazy-favicon"
-                                 loading="lazy"
-                                 decoding="async"
-                                 fetchpriority="low"
-                                 {% if favicon %}
-                                 data-src="{{url_for('static_content', group='favicon', filename=watch.uuid)}}"
-                                 {% endif %}
-                                 src='data:image/svg+xml;utf8,%3Csvg xmlns="http://www.w3.org/2000/svg" width="7.087" height="7.087" viewBox="0 0 7.087 7.087"%3E%3Ccircle cx="3.543" cy="3.543" r="3.279" stroke="%23e1e1e1" stroke-width="0.45" fill="none" opacity="0.74"/%3E%3C/svg%3E'>
+                        <div>{# A page might have hundreds of these images, set IMG options for lazy loading, don't set SRC if we dont have it so it doesnt fetch the placeholder'  #}
+                            <img alt="Favicon thumbnail" class="favicon" loading="lazy" decoding="async" fetchpriority="low" {% if favicon %} src="{{url_for('static_content', group='favicon', filename=watch.uuid)}}" {% else %} src='data:image/svg+xml;utf8,%3Csvg xmlns="http://www.w3.org/2000/svg" width="7.087" height="7.087" viewBox="0 0 7.087 7.087"%3E%3Ccircle cx="3.543" cy="3.543" r="3.279" stroke="%23e1e1e1" stroke-width="0.45" fill="none" opacity="0.74"/%3E%3C/svg%3E' {%  endif %} >
                         </div>
                     {%  endif %}
                         <div>

changedetectionio/content_fetchers/playwright.py

@@ -1,4 +1,3 @@
-import asyncio
 import gc
 import json
 import os
@@ -350,7 +349,12 @@ class fetcher(Fetcher):
 
             if self.status_code != 200 and not ignore_status_codes:
                 screenshot = await capture_full_page_async(self.page, screenshot_format=self.screenshot_format, watch_uuid=watch_uuid, lock_viewport_elements=self.lock_viewport_elements)
-                # Finally block will handle cleanup
+                # Cleanup before raising to prevent memory leak
+                await self.page.close()
+                await context.close()
+                await browser.close()
+                # Force garbage collection to release Playwright resources immediately
+                gc.collect()
                 raise Non200ErrorCodeReceived(url=url, status_code=self.status_code, screenshot=screenshot)
 
             if not empty_pages_are_a_change and len((await self.page.content()).strip()) == 0:
@@ -366,7 +370,12 @@ class fetcher(Fetcher):
                     try:
                         await self.iterate_browser_steps(start_url=url)
                     except BrowserStepsStepException:
-                        # Finally block will handle cleanup
+                        try:
+                            await context.close()
+                            await browser.close()
+                        except Exception as e:
+                            # Fine, could be messy situation
+                            pass
                         raise
 
                     await self.page.wait_for_timeout(extra_wait * 1000)
@@ -415,40 +424,35 @@ class fetcher(Fetcher):
                 raise ScreenshotUnavailable(url=url, status_code=self.status_code)
 
             finally:
-                # Clean up resources properly with timeouts to prevent hanging
+                # Request garbage collection one more time before closing
                 try:
-                    if hasattr(self, 'page') and self.page:
-                        await self.page.request_gc()
-                        await asyncio.wait_for(self.page.close(), timeout=5.0)
-                        logger.debug(f"Successfully closed page for {url}")
-                except asyncio.TimeoutError:
-                    logger.warning(f"Timed out closing page for {url} (5s)")
-                except Exception as e:
-                    logger.warning(f"Error closing page for {url}: {e}")
-                finally:
-                    self.page = None
+                    await self.page.request_gc()
+                except:
+                    pass
+                
+                # Clean up resources properly
+                try:
+                    await self.page.request_gc()
+                except:
+                    pass
 
                 try:
-                    if context:
-                        await asyncio.wait_for(context.close(), timeout=5.0)
-                        logger.debug(f"Successfully closed context for {url}")
-                except asyncio.TimeoutError:
-                    logger.warning(f"Timed out closing context for {url} (5s)")
-                except Exception as e:
-                    logger.warning(f"Error closing context for {url}: {e}")
-                finally:
-                    context = None
+                    await self.page.close()
+                except:
+                    pass
+                self.page = None
 
                 try:
-                    if browser:
-                        await asyncio.wait_for(browser.close(), timeout=5.0)
-                        logger.debug(f"Successfully closed browser connection for {url}")
-                except asyncio.TimeoutError:
-                    logger.warning(f"Timed out closing browser connection for {url} (5s)")
-                except Exception as e:
-                    logger.warning(f"Error closing browser for {url}: {e}")
-                finally:
-                    browser = None
+                    await context.close()
+                except:
+                    pass
+                context = None
+
+                try:
+                    await browser.close()
+                except:
+                    pass
+                browser = None
 
                 # Force Python GC to release Playwright resources immediately
                 # Playwright objects can have circular references that delay cleanup

changedetectionio/content_fetchers/puppeteer.py

@@ -1,5 +1,4 @@
 import asyncio
-import gc
 import json
 import os
 import websockets.exceptions
@@ -222,36 +221,19 @@ class fetcher(Fetcher):
                 self.browser_connection_url += f"{r}--proxy-server={proxy_url}"
 
     async def quit(self, watch=None):
-        watch_uuid = watch.get('uuid') if watch else 'unknown'
-
-        # Close page
         try:
-            if hasattr(self, 'page') and self.page:
-                await asyncio.wait_for(self.page.close(), timeout=5.0)
-                logger.debug(f"[{watch_uuid}] Page closed successfully")
-        except asyncio.TimeoutError:
-            logger.warning(f"[{watch_uuid}] Timed out closing page (5s)")
+            await self.page.close()
+            del self.page
         except Exception as e:
-            logger.warning(f"[{watch_uuid}] Error closing page: {e}")
-        finally:
-            self.page = None
+            pass
 
-        # Close browser connection
         try:
-            if hasattr(self, 'browser') and self.browser:
-                await asyncio.wait_for(self.browser.close(), timeout=5.0)
-                logger.debug(f"[{watch_uuid}] Browser closed successfully")
-        except asyncio.TimeoutError:
-            logger.warning(f"[{watch_uuid}] Timed out closing browser (5s)")
+            await self.browser.close()
+            del self.browser
         except Exception as e:
-            logger.warning(f"[{watch_uuid}] Error closing browser: {e}")
-        finally:
-            self.browser = None
+            pass
 
-        logger.info(f"[{watch_uuid}] Cleanup puppeteer complete")
-
-        # Force garbage collection to release resources
-        gc.collect()
+        logger.info("Cleanup puppeteer complete.")
 
     async def fetch_page(self,
                          current_include_filters,
@@ -281,11 +263,9 @@ class fetcher(Fetcher):
         # Connect directly using the specified browser_ws_endpoint
         # @todo timeout
         try:
-            logger.debug(f"[{watch_uuid}] Connecting to browser at {self.browser_connection_url}")
             self.browser = await pyppeteer_instance.connect(browserWSEndpoint=self.browser_connection_url,
                                                             ignoreHTTPSErrors=True
                                                             )
-            logger.debug(f"[{watch_uuid}] Browser connected successfully")
         except websockets.exceptions.InvalidStatusCode as e:
             raise BrowserConnectError(msg=f"Error while trying to connect the browser, Code {e.status_code} (check your access, whitelist IP, password etc)")
         except websockets.exceptions.InvalidURI:
@@ -294,18 +274,7 @@ class fetcher(Fetcher):
             raise BrowserConnectError(msg=f"Error connecting to the browser - Exception '{str(e)}'")
 
         # more reliable is to just request a new page
-        try:
-            logger.debug(f"[{watch_uuid}] Creating new page")
-            self.page = await self.browser.newPage()
-            logger.debug(f"[{watch_uuid}] Page created successfully")
-        except Exception as e:
-            logger.error(f"[{watch_uuid}] Failed to create new page: {e}")
-            # Browser is connected but page creation failed - must cleanup browser
-            try:
-                await asyncio.wait_for(self.browser.close(), timeout=3.0)
-            except Exception as cleanup_error:
-                logger.error(f"[{watch_uuid}] Failed to cleanup browser after page creation failure: {cleanup_error}")
-            raise
+        self.page = await self.browser.newPage()
         
         # Add console handler to capture console.log from favicon fetcher
         #self.page.on('console', lambda msg: logger.debug(f"Browser console [{msg.type}]: {msg.text}"))
@@ -374,12 +343,6 @@ class fetcher(Fetcher):
             w = extra_wait - 2 if extra_wait > 4 else 2
             logger.debug(f"Waiting {w} seconds before calling Page.stopLoading...")
             await asyncio.sleep(w)
-
-            # Check if page still exists (might have been closed due to error during sleep)
-            if not self.page or not hasattr(self.page, '_client'):
-                logger.debug("Page already closed, skipping stopLoading")
-                return
-
             logger.debug("Issuing stopLoading command...")
             await self.page._client.send('Page.stopLoading')
             logger.debug("stopLoading command sent!")
@@ -405,9 +368,7 @@ class fetcher(Fetcher):
             asyncio.create_task(handle_frame_navigation())
             response = await self.page.goto(url, timeout=0)
             await asyncio.sleep(1 + extra_wait)
-            # Check if page still exists before sending command
-            if self.page and hasattr(self.page, '_client'):
-                await self.page._client.send('Page.stopLoading')
+            await self.page._client.send('Page.stopLoading')
 
             if response:
                 break
@@ -476,9 +437,15 @@ class fetcher(Fetcher):
         logger.debug(f"Screenshot format {self.screenshot_format}")
         self.screenshot = await capture_full_page(page=self.page, screenshot_format=self.screenshot_format, watch_uuid=watch_uuid, lock_viewport_elements=self.lock_viewport_elements)
 
-        # Force garbage collection - pyppeteer base64 decode creates temporary buffers
+        # Force aggressive memory cleanup - pyppeteer base64 decode creates temporary buffers
         import gc
         gc.collect()
+        # Release C-level memory from base64 decode back to OS
+        try:
+            import ctypes
+            ctypes.CDLL('libc.so.6').malloc_trim(0)
+        except Exception:
+            pass
         self.xpath_data = await self.page.evaluate(XPATH_ELEMENT_JS, {
             "visualselector_xpath_selectors": visualselector_xpath_selectors,
             "max_height": MAX_TOTAL_HEIGHT

changedetectionio/flask_app.py

@@ -266,47 +266,6 @@ def _jinja2_filter_seconds_precise(timestamp):
 
     return format(int(time.time()-timestamp), ',d')
 
-@app.template_filter('format_duration')
-def _jinja2_filter_format_duration(seconds):
-    """Format a duration in seconds into human readable string like '5 days, 3 hours, 30 minutes'"""
-    from datetime import timedelta
-
-    if not seconds or seconds < 0:
-        return gettext('0 seconds')
-
-    td = timedelta(seconds=int(seconds))
-
-    # Calculate components
-    years = td.days // 365
-    remaining_days = td.days % 365
-    months = remaining_days // 30
-    remaining_days = remaining_days % 30
-    weeks = remaining_days // 7
-    days = remaining_days % 7
-
-    hours = td.seconds // 3600
-    minutes = (td.seconds % 3600) // 60
-    secs = td.seconds % 60
-
-    # Build parts list
-    parts = []
-    if years > 0:
-        parts.append(f"{years} {gettext('year') if years == 1 else gettext('years')}")
-    if months > 0:
-        parts.append(f"{months} {gettext('month') if months == 1 else gettext('months')}")
-    if weeks > 0:
-        parts.append(f"{weeks} {gettext('week') if weeks == 1 else gettext('weeks')}")
-    if days > 0:
-        parts.append(f"{days} {gettext('day') if days == 1 else gettext('days')}")
-    if hours > 0:
-        parts.append(f"{hours} {gettext('hour') if hours == 1 else gettext('hours')}")
-    if minutes > 0:
-        parts.append(f"{minutes} {gettext('minute') if minutes == 1 else gettext('minutes')}")
-    if secs > 0 or not parts:
-        parts.append(f"{secs} {gettext('second') if secs == 1 else gettext('seconds')}")
-
-    return ", ".join(parts)
-
 @app.template_filter('fetcher_status_icons')
 def _jinja2_filter_fetcher_status_icons(fetcher_name):
     """Get status icon HTML for a given fetcher.
@@ -744,10 +703,10 @@ def changedetection_app(config=None, datastore_o=None):
             favicon_filename = watch.get_favicon_filename()
             if favicon_filename:
                 # Use cached MIME type detection
-                filepath = os.path.join(watch.data_dir, favicon_filename)
+                filepath = os.path.join(watch.watch_data_dir, favicon_filename)
                 mime = get_favicon_mime_type(filepath)
 
-                response = make_response(send_from_directory(watch.data_dir, favicon_filename))
+                response = make_response(send_from_directory(watch.watch_data_dir, favicon_filename))
                 response.headers['Content-type'] = mime
                 response.headers['Cache-Control'] = 'max-age=300, must-revalidate'  # Cache for 5 minutes, then revalidate
                 return response
@@ -848,7 +807,7 @@ def changedetection_app(config=None, datastore_o=None):
     app.register_blueprint(watchlist.construct_blueprint(datastore=datastore, update_q=update_q, queuedWatchMetaData=queuedWatchMetaData), url_prefix='')
 
     # Initialize Socket.IO server conditionally based on settings
-    socket_io_enabled = datastore.data['settings']['application'].get('ui', {}).get('socket_io_enabled', True)
+    socket_io_enabled = datastore.data['settings']['application']['ui'].get('socket_io_enabled', True)
     if socket_io_enabled and app.config.get('batch_mode'):
         socket_io_enabled = False
     if socket_io_enabled:

changedetectionio/forms.py

@@ -837,8 +837,6 @@ class processor_text_json_diff_form(commonSettingsForm):
     conditions = FieldList(FormField(ConditionFormRow), min_entries=1)  # Add rule logic here
     use_page_title_in_list = TernaryNoneBooleanField(_l('Use page <title> in list'), default=None)
 
-    history_snapshot_max_length = IntegerField(_l('Number of history items per watch to keep'), render_kw={"style": "width: 5em;"}, validators=[validators.Optional(), validators.NumberRange(min=2)])
-
     def extra_tab_content(self):
         return None
 
@@ -1036,8 +1034,6 @@ class globalSettingsApplicationForm(commonSettingsForm):
                                                                   render_kw={"style": "width: 5em;"},
                                                                   validators=[validators.NumberRange(min=0,
                                                                                                      message=_l("Should contain zero or more attempts"))])
-
-    history_snapshot_max_length = IntegerField(_l('Number of history items per watch to keep'), render_kw={"style": "width: 5em;"}, validators=[validators.Optional(), validators.NumberRange(min=2)])
     ui = FormField(globalSettingsApplicationUIForm)
 
 

changedetectionio/jinja2_custom/safe_jinja.py

@@ -52,13 +52,7 @@ def render(template_str, **args: t.Any) -> str:
     return output[:JINJA2_MAX_RETURN_PAYLOAD_SIZE]
 
 def render_fully_escaped(content):
-    """
-    Escape HTML content safely.
-
-    MEMORY LEAK FIX: Use markupsafe.escape() directly instead of creating
-    Jinja2 environments (was causing 1M+ compilations per page load).
-    Simpler, faster, and no concerns about environment state.
-    """
-    from markupsafe import escape
-    return str(escape(content))
+    env = jinja2.sandbox.ImmutableSandboxedEnvironment(autoescape=True)
+    template = env.from_string("{{ some_html|e }}")
+    return template.render(some_html=content)
 

changedetectionio/model/App.py

@@ -46,7 +46,6 @@ class model(dict):
                     'filter_failure_notification_threshold_attempts': _FILTER_FAILURE_THRESHOLD_ATTEMPTS_DEFAULT,
                     'global_ignore_text': [], # List of text to ignore when calculating the comparison checksum
                     'global_subtractive_selectors': [],
-                    'history_snapshot_max_length': None,
                     'ignore_whitespace': True,
                     'ignore_status_codes': False, #@todo implement, as ternary.
                     'ssim_threshold': '0.96',  # Default SSIM threshold for screenshot comparison

changedetectionio/model/Tag.py

@@ -1,50 +1,10 @@
-"""
-Tag/Group domain model for organizing and overriding watch settings.
 
-ARCHITECTURE NOTE: Configuration Override Hierarchy
-===================================================
-
-Tags can override Watch settings when overrides_watch=True.
-Current implementation requires manual checking in processors:
-
-    for tag_uuid in watch.get('tags'):
-        tag = datastore['settings']['application']['tags'][tag_uuid]
-        if tag.get('overrides_watch'):
-            restock_settings = tag.get('restock_settings', {})
-            break
-
-With Pydantic, this would be automatic via chain resolution:
-    Watch → Tag (first with overrides_watch) → Global
-
-See: Watch.py model docstring for full Pydantic architecture explanation
-See: processors/restock_diff/processor.py:184-192 for current manual implementation
-"""
-
-import os
 from changedetectionio.model import watch_base
-from changedetectionio.model.persistence import EntityPersistenceMixin
 
 
-class model(EntityPersistenceMixin, watch_base):
-    """
-    Tag domain model - groups watches and can override their settings.
-
-    Tags inherit from watch_base to reuse all the same fields as Watch.
-    When overrides_watch=True, tag settings take precedence over watch settings
-    for all watches in this tag/group.
-
-    Fields:
-        overrides_watch (bool): If True, this tag's settings override watch settings
-        title (str): Display name for this tag/group
-        uuid (str): Unique identifier
-        ... (all fields from watch_base can be set as tag-level overrides)
-
-    Resolution order when overrides_watch=True:
-        Watch.field → Tag.field (if overrides_watch) → Global.field
-    """
+class model(watch_base):
 
     def __init__(self, *arg, **kw):
-        # Parent class (watch_base) handles __datastore and __datastore_path
         super(model, self).__init__(*arg, **kw)
 
         self['overrides_watch'] = kw.get('default', {}).get('overrides_watch')
@@ -52,7 +12,3 @@ class model(EntityPersistenceMixin, watch_base):
         if kw.get('default'):
             self.update(kw['default'])
             del kw['default']
-
-    # _save_to_disk() method provided by EntityPersistenceMixin
-    # commit() and _get_commit_data() methods inherited from watch_base
-    # Tag uses default _get_commit_data() (includes all keys)

changedetectionio/model/Watch.py

@@ -1,37 +1,9 @@
-"""
-Watch domain model for change detection monitoring.
-
-ARCHITECTURE NOTE: Configuration Override Hierarchy
-===================================================
-
-This module implements Watch objects that inherit from dict (technical debt).
-The dream architecture would use Pydantic for:
-
-1. CHAIN RESOLUTION (Watch → Tag → Global Settings)
-   - Current: Manual resolution scattered across codebase
-   - Future: @computed_field properties with automatic resolution
-   - Examples: resolved_fetch_backend, resolved_restock_settings, etc.
-
-2. DATABASE BACKEND ABSTRACTION
-   - Current: Domain model tightly coupled to file-based JSON storage
-   - Future: Domain model (Pydantic) separate from persistence layer
-   - Enables: Easy migration to PostgreSQL, MongoDB, etc.
-
-3. TYPE SAFETY & VALIDATION
-   - Current: Dict access with no compile-time checks
-   - Future: Type hints, IDE autocomplete, validation at boundaries
-
-See class model docstring for detailed explanation and examples.
-See: processors/restock_diff/processor.py:184-192 for manual resolution example
-"""
-
 from blinker import signal
 from changedetectionio.validate_url import is_safe_valid_url
 
 from changedetectionio.strtobool import strtobool
 from changedetectionio.jinja2_custom import render as jinja_render
 from . import watch_base
-from .persistence import EntityPersistenceMixin
 import os
 import re
 from pathlib import Path
@@ -41,7 +13,7 @@ from .. import jinja2_custom as safe_jinja
 from ..html_tools import TRANSLATE_WHITESPACE_TABLE
 
 FAVICON_RESAVE_THRESHOLD_SECONDS=86400
-BROTLI_COMPRESS_SIZE_THRESHOLD = int(os.getenv('SNAPSHOT_BROTLI_COMPRESSION_THRESHOLD', 1024*20))
+BROTLI_COMPRESS_SIZE_THRESHOLD = int(os.getenv('SNAPSHOT_BROTLI_COMPRESSION_THRESHOLD', 1024))
 
 minimum_seconds_recheck_time = int(os.getenv('MINIMUM_SECONDS_RECHECK_TIME', 3))
 mtable = {'seconds': 1, 'minutes': 60, 'hours': 3600, 'days': 86400, 'weeks': 86400 * 7}
@@ -128,112 +100,17 @@ def _brotli_save(contents, filepath, mode=None, fallback_uncompressed=False):
             raise Exception(f"Brotli compression failed for {filepath}: {e}")
 
 
-class model(EntityPersistenceMixin, watch_base):
-    """
-    Watch domain model for monitoring URL changes.
-
-    Inherits from watch_base (which inherits dict) - see watch_base docstring for field documentation.
-
-    ## Configuration Override Hierarchy (Chain Resolution)
-
-    The dream architecture uses a 3-level resolution chain:
-        Watch settings → Tag/Group settings → Global settings
-
-    Current implementation is MANUAL (see processor.py:184-192 for example):
-        - Processors manually check watch.get('field')
-        - Then loop through watch.tags to find first tag with overrides_watch=True
-        - Finally fall back to datastore['settings']['application']['field']
-
-    FUTURE: Pydantic-based chain resolution would enable:
-
-        ```python
-        # Instead of manual resolution in every processor:
-        restock_settings = watch.get('restock_settings', {})
-        for tag_uuid in watch.get('tags'):
-            tag = datastore['settings']['application']['tags'][tag_uuid]
-            if tag.get('overrides_watch'):
-                restock_settings = tag.get('restock_settings', {})
-                break
-
-        # Clean computed properties with automatic resolution:
-        @computed_field
-        def resolved_restock_settings(self) -> dict:
-            if self.restock_settings:
-                return self.restock_settings
-            for tag_uuid in self.tags:
-                tag = self._datastore.get_tag(tag_uuid)
-                if tag.overrides_watch and tag.restock_settings:
-                    return tag.restock_settings
-            return self._datastore.settings.restock_settings or {}
-
-        # Usage: watch.resolved_restock_settings (automatic, type-safe, tested once)
-        ```
-
-    Benefits of Pydantic migration:
-        1. Single source of truth for resolution logic (not scattered across processors)
-        2. Type safety + IDE autocomplete (watch.resolved_fetch_backend vs dict navigation)
-        3. Database backend abstraction (domain model separate from persistence)
-        4. Automatic validation at boundaries
-        5. Self-documenting via type hints
-        6. Easy to test resolution independently
-
-    Resolution chain examples that would benefit:
-        - fetch_backend: watch → tag → global (see get_fetch_backend property)
-        - notification_urls: watch → tag → global
-        - time_between_check: watch → global (see threshold_seconds)
-        - restock_settings: watch → tag (see processors/restock_diff/processor.py:184-192)
-        - history_snapshot_max_length: watch → global (see save_history_blob:550-556)
-        - All processor_config_* settings could use tag overrides
-
-    ## Database Backend Abstraction with Pydantic
-
-    Current: Watch inherits dict, tightly coupled to file-based JSON storage
-    Future: Domain model (Watch) separate from persistence layer
-
-        ```python
-        # Domain model (database-agnostic)
-        class Watch(BaseModel):
-            uuid: str
-            url: str
-            # ... validation, business logic
-
-        # Pluggable backends
-        class DataStoreBackend(ABC):
-            def save_watch(self, watch: Watch): ...
-            def load_watch(self, uuid: str) -> Watch: ...
-
-        # Implementations: FileBackend, MongoBackend, PostgresBackend, etc.
-        ```
-
-    This would enable:
-        - Easy migration between storage backends (file → postgres → mongodb)
-        - Pydantic handles serialization/deserialization automatically
-        - Domain logic stays clean (no storage concerns in Watch methods)
-
-    ## Migration Path
-
-    Given existing codebase, incremental migration recommended:
-        1. Create Pydantic models alongside existing dict-based models
-        2. Add .to_pydantic() / .from_pydantic() bridge methods
-        3. Gradually migrate code to use Pydantic models
-        4. Remove dict inheritance once migration complete
-
-    See: watch_base docstring for technical debt discussion
-    See: processors/restock_diff/processor.py:184-192 for manual resolution example
-    See: Watch.py:550-556 for nested dict navigation that would become watch.resolved_*
-    """
+class model(watch_base):
     __newest_history_key = None
     __history_n = 0
     jitter_seconds = 0
 
     def __init__(self, *arg, **kw):
-        # Validate __datastore before calling parent (Watch requires it)
-        if not kw.get('__datastore'):
-            raise ValueError("Watch object requires '__datastore' reference - cannot access global settings without it")
-
-        # Parent class (watch_base) handles __datastore and __datastore_path
+        self.__datastore_path = kw.get('datastore_path')
+        if kw.get('datastore_path'):
+            del kw['datastore_path']
+            
         super(model, self).__init__(*arg, **kw)
-
         if kw.get('default'):
             self.update(kw['default'])
             del kw['default']
@@ -244,9 +121,6 @@ class model(EntityPersistenceMixin, watch_base):
         # Be sure the cached timestamp is ready
         bump = self.history
 
-    # Note: __deepcopy__, __getstate__, and __setstate__ are inherited from watch_base
-    # This prevents memory leaks by sharing __datastore reference instead of copying it
-
     @property
     def viewed(self):
         # Don't return viewed when last_viewed is 0 and newest_key is 0
@@ -259,6 +133,11 @@ class model(EntityPersistenceMixin, watch_base):
     def has_unviewed(self):
         return int(self.newest_history_key) > int(self['last_viewed']) and self.__history_n >= 2
 
+    def ensure_data_dir_exists(self):
+        if not os.path.isdir(self.watch_data_dir):
+            logger.debug(f"> Creating data dir {self.watch_data_dir}")
+            os.mkdir(self.watch_data_dir)
+
     @property
     def link(self):
 
@@ -314,8 +193,7 @@ class model(EntityPersistenceMixin, watch_base):
 
         # JSON Data, Screenshots, Textfiles (history index and snapshots), HTML in the future etc
         # But preserve processor config files (they're configuration, not history data)
-        # Use glob not rglob here for safety.
-        for item in pathlib.Path(str(self.data_dir)).glob("*.*"):
+        for item in pathlib.Path(str(self.watch_data_dir)).rglob("*.*"):
             # Skip processor config files
             if item.name in processor_config_files:
                 continue
@@ -352,30 +230,8 @@ class model(EntityPersistenceMixin, watch_base):
     @property
     def get_fetch_backend(self):
         """
-        Get the fetch backend for this watch with special case handling.
-
-        CHAIN RESOLUTION OPPORTUNITY:
-        Currently returns watch.fetch_backend directly, but doesn't implement
-        Watch → Tag → Global resolution chain. With Pydantic:
-
-        @computed_field
-        def resolved_fetch_backend(self) -> str:
-            # Special case: PDFs always use html_requests
-            if self.is_pdf:
-                return 'html_requests'
-
-            # Watch override
-            if self.fetch_backend and self.fetch_backend != 'system':
-                return self.fetch_backend
-
-            # Tag override (first tag with overrides_watch=True wins)
-            for tag_uuid in self.tags:
-                tag = self._datastore.get_tag(tag_uuid)
-                if tag.overrides_watch and tag.fetch_backend:
-                    return tag.fetch_backend
-
-            # Global default
-            return self._datastore.settings.fetch_backend
+        Like just using the `fetch_backend` key but there could be some logic
+        :return:
         """
         # Maybe also if is_image etc?
         # This is because chrome/playwright wont render the PDF in the browser and we will just fetch it and use pdf2html to see the text.
@@ -424,11 +280,11 @@ class model(EntityPersistenceMixin, watch_base):
         tmp_history = {}
 
         # In the case we are only using the watch for processing without history
-        if not self.data_dir:
+        if not self.watch_data_dir:
             return []
 
         # Read the history file as a dict
-        fname = os.path.join(self.data_dir, self.history_index_filename)
+        fname = os.path.join(self.watch_data_dir, self.history_index_filename)
         if os.path.isfile(fname):
             logger.debug(f"Reading watch history index for {self.get('uuid')}")
             with open(fname, "r", encoding='utf-8') as f:
@@ -441,13 +297,13 @@ class model(EntityPersistenceMixin, watch_base):
                         # Cross-platform: check for any path separator (works on Windows and Unix)
                         if os.sep not in v and '/' not in v and '\\' not in v:
                             # Relative filename only, no path separators
-                            v = os.path.join(self.data_dir, v)
+                            v = os.path.join(self.watch_data_dir, v)
                         else:
                             # It's possible that they moved the datadir on older versions
                             # So the snapshot exists but is in a different path
                             # Cross-platform: use os.path.basename instead of split('/')
                             snapshot_fname = os.path.basename(v)
-                            proposed_new_path = os.path.join(self.data_dir, snapshot_fname)
+                            proposed_new_path = os.path.join(self.watch_data_dir, snapshot_fname)
                             if not os.path.exists(v) and os.path.exists(proposed_new_path):
                                 v = proposed_new_path
 
@@ -464,7 +320,7 @@ class model(EntityPersistenceMixin, watch_base):
 
     @property
     def has_history(self):
-        fname = os.path.join(self.data_dir, self.history_index_filename)
+        fname = os.path.join(self.watch_data_dir, self.history_index_filename)
         return os.path.isfile(fname)
 
     @property
@@ -567,49 +423,16 @@ class model(EntityPersistenceMixin, watch_base):
         with open(filepath, 'r', encoding='utf-8', errors='ignore') as f:
             return f.read()
 
-    def _write_atomic(self, dest, data, mode='wb'):
+    def _write_atomic(self, dest, data):
         """Write data atomically to dest using a temp file"""
-        import tempfile
-        with tempfile.NamedTemporaryFile(mode, delete=False, dir=self.data_dir) as tmp:
-            tmp.write(data)
-            tmp.flush()
-            os.fsync(tmp.fileno())
-            tmp_path = tmp.name
-        os.replace(tmp_path, dest)
-
-    def history_trim(self, newest_n_items):
-        from pathlib import Path
-        import gc
-        # Sort by timestamp (key)
-        sorted_items = sorted(self.history.items(), key=lambda x: int(x[0]))
-
-        keep_part = dict(sorted_items[-newest_n_items:])
-        delete_part = dict(sorted_items[:-newest_n_items])
-        logger.info( f"[{self.get('uuid')}] Trimming history to most recent {newest_n_items} items, keeping {len(keep_part)} items deleting {len(delete_part)} items.")
-
-        if delete_part:
-            for item in delete_part.items():
-                try:
-                    Path(item[1]).unlink(missing_ok=True)
-                except Exception as e:
-                    logger.critical(f"{str(e)}")
-                finally:
-                    logger.debug(f"[{self.get('uuid')}] Deleted {item[1]} history snapshot")
-        try:
-            dest = os.path.join(self.data_dir, self.history_index_filename)
-            output = "\r\n".join(
-                f"{k},{Path(v).name}"
-                for k, v in keep_part.items()
-            )+"\r\n"
-            self._write_atomic(dest=dest, data=output, mode='w')
-        except Exception as e:
-            logger.critical(f"{str(e)}")
-        finally:
-            logger.debug(f"[{self.get('uuid')}] Updated history index {dest}")
-
-        # reimport
-        bump = self.history
-        gc.collect()
+        if not os.path.exists(dest):
+            import tempfile
+            with tempfile.NamedTemporaryFile('wb', delete=False, dir=self.watch_data_dir) as tmp:
+                tmp.write(data)
+                tmp.flush()
+                os.fsync(tmp.fileno())
+                tmp_path = tmp.name
+            os.replace(tmp_path, dest)
 
     # Save some text file to the appropriate path and bump the history
     # result_obj from fetch_site_status.run()
@@ -618,6 +441,7 @@ class model(EntityPersistenceMixin, watch_base):
         logger.trace(f"{self.get('uuid')} - Updating {self.history_index_filename} with timestamp {timestamp}")
 
         self.ensure_data_dir_exists()
+
         skip_brotli = strtobool(os.getenv('DISABLE_BROTLI_TEXT_SNAPSHOT', 'False'))
 
         # Binary data - detect file type and save without compression
@@ -635,7 +459,7 @@ class model(EntityPersistenceMixin, watch_base):
                 ext = 'bin'
 
             snapshot_fname = f"{snapshot_id}.{ext}"
-            dest = os.path.join(self.data_dir, snapshot_fname)
+            dest = os.path.join(self.watch_data_dir, snapshot_fname)
             self._write_atomic(dest, contents)
             logger.trace(f"Saved binary snapshot as {snapshot_fname} ({len(contents)} bytes)")
 
@@ -645,7 +469,7 @@ class model(EntityPersistenceMixin, watch_base):
                 # Compressed text
                 import brotli
                 snapshot_fname = f"{snapshot_id}.txt.br"
-                dest = os.path.join(self.data_dir, snapshot_fname)
+                dest = os.path.join(self.watch_data_dir, snapshot_fname)
 
                 if not os.path.exists(dest):
                     try:
@@ -656,16 +480,16 @@ class model(EntityPersistenceMixin, watch_base):
                         logger.error(f"{self.get('uuid')} - Brotli compression failed: {e}")
                         # Fallback to uncompressed
                         snapshot_fname = f"{snapshot_id}.txt"
-                        dest = os.path.join(self.data_dir, snapshot_fname)
+                        dest = os.path.join(self.watch_data_dir, snapshot_fname)
                         self._write_atomic(dest, contents.encode('utf-8'))
             else:
                 # Plain text
                 snapshot_fname = f"{snapshot_id}.txt"
-                dest = os.path.join(self.data_dir, snapshot_fname)
+                dest = os.path.join(self.watch_data_dir, snapshot_fname)
                 self._write_atomic(dest, contents.encode('utf-8'))
 
         # Append to history.txt atomically
-        index_fname = os.path.join(self.data_dir, self.history_index_filename)
+        index_fname = os.path.join(self.watch_data_dir, self.history_index_filename)
         index_line = f"{timestamp},{snapshot_fname}\n"
 
         with open(index_fname, 'a', encoding='utf-8') as f:
@@ -677,17 +501,6 @@ class model(EntityPersistenceMixin, watch_base):
         self.__newest_history_key = timestamp
         self.__history_n += 1
 
-        # MANUAL CHAIN RESOLUTION: Watch → Global
-        # With Pydantic, this would become: maxlen = watch.resolved_history_snapshot_max_length
-        # @computed_field def resolved_history_snapshot_max_length(self) -> Optional[int]:
-        #     if self.history_snapshot_max_length: return self.history_snapshot_max_length
-        #     if tag := self._get_override_tag(): return tag.history_snapshot_max_length
-        #     return self._datastore.settings.history_snapshot_max_length
-        maxlen = self.get('history_snapshot_max_length') or self.get_global_setting('application', 'history_snapshot_max_length')
-
-        if maxlen and self.__history_n and self.__history_n > maxlen:
-            self.history_trim(newest_n_items=maxlen)
-
         # @todo bump static cache of the last timestamp so we dont need to examine the file to set a proper ''viewed'' status
         return snapshot_fname
 
@@ -740,7 +553,7 @@ class model(EntityPersistenceMixin, watch_base):
         return not local_lines.issubset(existing_history)
 
     def get_screenshot(self):
-        fname = os.path.join(self.data_dir, "last-screenshot.png")
+        fname = os.path.join(self.watch_data_dir, "last-screenshot.png")
         if os.path.isfile(fname):
             return fname
 
@@ -755,7 +568,7 @@ class model(EntityPersistenceMixin, watch_base):
         if not favicon_fname:
             return True
         try:
-            fname = next(iter(glob.glob(os.path.join(self.data_dir, "favicon.*"))), None)
+            fname = next(iter(glob.glob(os.path.join(self.watch_data_dir, "favicon.*"))), None)
             logger.trace(f"Favicon file maybe found at {fname}")
             if os.path.isfile(fname):
                 file_age = int(time.time() - os.path.getmtime(fname))
@@ -788,7 +601,7 @@ class model(EntityPersistenceMixin, watch_base):
             base = "favicon"
             extension = "ico"
 
-        fname = os.path.join(self.data_dir, f"favicon.{extension}")
+        fname = os.path.join(self.watch_data_dir, f"favicon.{extension}")
 
         try:
             # validate=True makes sure the string only contains valid base64 chars
@@ -800,11 +613,6 @@ class model(EntityPersistenceMixin, watch_base):
                 try:
                     with open(fname, 'wb') as f:
                         f.write(decoded)
-
-                    # Invalidate favicon filename cache
-                    if hasattr(self, '_favicon_filename_cache'):
-                        delattr(self, '_favicon_filename_cache')
-
                     # A signal that could trigger the socket server to update the browser also
                     watch_check_update = signal('watch_favicon_bump')
                     if watch_check_update:
@@ -821,32 +629,20 @@ class model(EntityPersistenceMixin, watch_base):
         Find any favicon.* file in the current working directory
         and return the contents of the newest one.
 
-        MEMORY LEAK FIX: Cache the result to avoid repeated glob.glob() operations.
-        glob.glob() causes millions of fnmatch allocations when called for every watch on page load.
-
         Returns:
-            str: Basename of the newest favicon file, or None if not found.
+            bytes: Contents of the newest favicon file, or None if not found.
         """
-        # Check cache first (prevents 26M+ allocations from repeated glob operations)
-        cache_key = '_favicon_filename_cache'
-        if hasattr(self, cache_key):
-            return getattr(self, cache_key)
-
         import glob
 
         # Search for all favicon.* files
-        files = glob.glob(os.path.join(self.data_dir, "favicon.*"))
+        files = glob.glob(os.path.join(self.watch_data_dir, "favicon.*"))
 
         if not files:
-            result = None
-        else:
-            # Find the newest by modification time
-            newest_file = max(files, key=os.path.getmtime)
-            result = os.path.basename(newest_file)
+            return None
 
-        # Cache the result
-        setattr(self, cache_key, result)
-        return result
+        # Find the newest by modification time
+        newest_file = max(files, key=os.path.getmtime)
+        return os.path.basename(newest_file)
 
     def get_screenshot_as_thumbnail(self, max_age=3200):
         """Return path to a square thumbnail of the most recent screenshot.
@@ -862,7 +658,7 @@ class model(EntityPersistenceMixin, watch_base):
         import os
         import time
 
-        thumbnail_path = os.path.join(self.data_dir, "thumbnail.jpeg")
+        thumbnail_path = os.path.join(self.watch_data_dir, "thumbnail.jpeg")
         top_trim = 500  # Pixels from top of screenshot to use
 
         screenshot_path = self.get_screenshot()
@@ -913,7 +709,7 @@ class model(EntityPersistenceMixin, watch_base):
             return None
 
     def __get_file_ctime(self, filename):
-        fname = os.path.join(self.data_dir, filename)
+        fname = os.path.join(self.watch_data_dir, filename)
         if os.path.isfile(fname):
             return int(os.path.getmtime(fname))
         return False
@@ -938,9 +734,14 @@ class model(EntityPersistenceMixin, watch_base):
     def snapshot_error_screenshot_ctime(self):
         return self.__get_file_ctime('last-error-screenshot.png')
 
+    @property
+    def watch_data_dir(self):
+        # The base dir of the watch data
+        return os.path.join(self.__datastore_path, self['uuid']) if self.__datastore_path else None
+
     def get_error_text(self):
         """Return the text saved from a previous request that resulted in a non-200 error"""
-        fname = os.path.join(self.data_dir, "last-error.txt")
+        fname = os.path.join(self.watch_data_dir, "last-error.txt")
         if os.path.isfile(fname):
             with open(fname, 'r', encoding='utf-8') as f:
                 return f.read()
@@ -948,7 +749,7 @@ class model(EntityPersistenceMixin, watch_base):
 
     def get_error_snapshot(self):
         """Return path to the screenshot that resulted in a non-200 error"""
-        fname = os.path.join(self.data_dir, "last-error-screenshot.png")
+        fname = os.path.join(self.watch_data_dir, "last-error-screenshot.png")
         if os.path.isfile(fname):
             return fname
         return False
@@ -972,37 +773,6 @@ class model(EntityPersistenceMixin, watch_base):
     def toggle_mute(self):
         self['notification_muted'] ^= True
 
-    def _get_commit_data(self):
-        """
-        Prepare watch data for commit.
-
-        Excludes processor_config_* keys (stored in separate files).
-        Normalizes browser_steps to empty list if no meaningful steps.
-        """
-        import copy
-
-        # Get base snapshot with lock
-        lock = self._datastore.lock if self._datastore and hasattr(self._datastore, 'lock') else None
-
-        if lock:
-            with lock:
-                snapshot = dict(self)
-        else:
-            snapshot = dict(self)
-
-        # Exclude processor config keys (stored separately)
-        watch_dict = {k: copy.deepcopy(v) for k, v in snapshot.items() if not k.startswith('processor_config_')}
-
-        # Normalize browser_steps: if no meaningful steps, save as empty list
-        if not self.has_browser_steps:
-            watch_dict['browser_steps'] = []
-
-        return watch_dict
-
-    # _save_to_disk() method provided by EntityPersistenceMixin
-    # commit() method inherited from watch_base
-
-
     def extra_notification_token_values(self):
         # Used for providing extra tokens
         # return {'widget': 555}
@@ -1032,7 +802,7 @@ class model(EntityPersistenceMixin, watch_base):
                         if not csv_writer:
                             # A file on the disk can be transferred much faster via flask than a string reply
                             csv_output_filename = f"report-{self.get('uuid')}.csv"
-                            f = open(os.path.join(self.data_dir, csv_output_filename), 'w')
+                            f = open(os.path.join(self.watch_data_dir, csv_output_filename), 'w')
                             # @todo some headers in the future
                             #fieldnames = ['Epoch seconds', 'Date']
                             csv_writer = csv.writer(f,
@@ -1074,7 +844,7 @@ class model(EntityPersistenceMixin, watch_base):
 
     def save_error_text(self, contents):
         self.ensure_data_dir_exists()
-        target_path = os.path.join(self.data_dir, "last-error.txt")
+        target_path = os.path.join(self.watch_data_dir, "last-error.txt")
         with open(target_path, 'w', encoding='utf-8') as f:
             f.write(contents)
 
@@ -1083,9 +853,9 @@ class model(EntityPersistenceMixin, watch_base):
         import zlib
 
         if as_error:
-            target_path = os.path.join(str(self.data_dir), "elements-error.deflate")
+            target_path = os.path.join(str(self.watch_data_dir), "elements-error.deflate")
         else:
-            target_path = os.path.join(str(self.data_dir), "elements.deflate")
+            target_path = os.path.join(str(self.watch_data_dir), "elements.deflate")
 
         self.ensure_data_dir_exists()
 
@@ -1100,9 +870,9 @@ class model(EntityPersistenceMixin, watch_base):
     def save_screenshot(self, screenshot: bytes, as_error=False):
 
         if as_error:
-            target_path = os.path.join(self.data_dir, "last-error-screenshot.png")
+            target_path = os.path.join(self.watch_data_dir, "last-error-screenshot.png")
         else:
-            target_path = os.path.join(self.data_dir, "last-screenshot.png")
+            target_path = os.path.join(self.watch_data_dir, "last-screenshot.png")
 
         self.ensure_data_dir_exists()
 
@@ -1113,7 +883,7 @@ class model(EntityPersistenceMixin, watch_base):
 
     def get_last_fetched_text_before_filters(self):
         import brotli
-        filepath = os.path.join(self.data_dir, 'last-fetched.br')
+        filepath = os.path.join(self.watch_data_dir, 'last-fetched.br')
 
         if not os.path.isfile(filepath) or os.path.getsize(filepath) == 0:
             # If a previous attempt doesnt yet exist, just snarf the previous snapshot instead
@@ -1128,13 +898,13 @@ class model(EntityPersistenceMixin, watch_base):
 
     def save_last_text_fetched_before_filters(self, contents):
         import brotli
-        filepath = os.path.join(self.data_dir, 'last-fetched.br')
+        filepath = os.path.join(self.watch_data_dir, 'last-fetched.br')
         _brotli_save(contents, filepath, mode=brotli.MODE_TEXT, fallback_uncompressed=False)
 
     def save_last_fetched_html(self, timestamp, contents):
         self.ensure_data_dir_exists()
         snapshot_fname = f"{timestamp}.html.br"
-        filepath = os.path.join(self.data_dir, snapshot_fname)
+        filepath = os.path.join(self.watch_data_dir, snapshot_fname)
         _brotli_save(contents, filepath, mode=None, fallback_uncompressed=True)
         self._prune_last_fetched_html_snapshots()
 
@@ -1142,7 +912,7 @@ class model(EntityPersistenceMixin, watch_base):
         import brotli
 
         snapshot_fname = f"{timestamp}.html.br"
-        filepath = os.path.join(self.data_dir, snapshot_fname)
+        filepath = os.path.join(self.watch_data_dir, snapshot_fname)
         if os.path.isfile(filepath):
             with open(filepath, 'rb') as f:
                 return (brotli.decompress(f.read()).decode('utf-8'))
@@ -1157,7 +927,7 @@ class model(EntityPersistenceMixin, watch_base):
 
         for index, timestamp in enumerate(dates):
             snapshot_fname = f"{timestamp}.html.br"
-            filepath = os.path.join(self.data_dir, snapshot_fname)
+            filepath = os.path.join(self.watch_data_dir, snapshot_fname)
 
             # Keep only the first 2
             if index > 1 and os.path.isfile(filepath):
@@ -1168,7 +938,7 @@ class model(EntityPersistenceMixin, watch_base):
     def get_browsersteps_available_screenshots(self):
         "For knowing which screenshots are available to show the user in BrowserSteps UI"
         available = []
-        for f in Path(self.data_dir).glob('step_before-*.jpeg'):
+        for f in Path(self.watch_data_dir).glob('step_before-*.jpeg'):
             step_n=re.search(r'step_before-(\d+)', f.name)
             if step_n:
                 available.append(step_n.group(1))

changedetectionio/model/__init__.py

@@ -2,169 +2,12 @@ import os
 import uuid
 
 from changedetectionio import strtobool
-from .persistence import EntityPersistenceMixin
-
-__all__ = ['EntityPersistenceMixin', 'watch_base']
-
 USE_SYSTEM_DEFAULT_NOTIFICATION_FORMAT_FOR_WATCH = 'System default'
 CONDITIONS_MATCH_LOGIC_DEFAULT = 'ALL'
 
-
 class watch_base(dict):
-    """
-    Base watch domain model (inherits from dict for backward compatibility).
-
-    WARNING: This class inherits from dict, which violates proper encapsulation.
-    Dict inheritance is legacy technical debt that should be refactored to a proper
-    domain model (e.g., Pydantic BaseModel) for better type safety and validation.
-
-    TODO: Migrate to Pydantic BaseModel for:
-          - Type safety and IDE autocomplete
-          - Automatic validation
-          - Clear separation between domain model and serialization
-          - Database backend abstraction (file → postgres → mongodb)
-          - Configuration override chain resolution (Watch → Tag → Global)
-          - Immutability options
-          - Better testing
-
-    CHAIN RESOLUTION ARCHITECTURE:
-        The dream is a 3-level override hierarchy:
-            Watch settings → Tag/Group settings → Global settings
-
-        Current implementation: MANUAL resolution scattered across codebase
-        - Processors manually check watch.get('field')
-        - Loop through tags to find overrides_watch=True
-        - Fall back to datastore['settings']['application']['field']
-
-        Pydantic implementation: AUTOMATIC resolution via @computed_field
-        - Single source of truth for each setting's resolution logic
-        - Type-safe, testable, self-documenting
-        - Example: watch.resolved_fetch_backend (instead of nested dict navigation)
-
-        See: Watch.py model docstring for detailed Pydantic architecture plan
-        See: Tag.py model docstring for tag override explanation
-        See: processors/restock_diff/processor.py:184-192 for current manual example
-
-    Core Fields:
-        uuid (str): Unique identifier for this watch (auto-generated)
-        url (str): Target URL to monitor for changes
-        title (str|None): Custom display name (overrides page_title if set)
-        page_title (str|None): Title extracted from <title> tag of monitored page
-        tags (List[str]): List of tag UUIDs for categorization
-        tag (str): DEPRECATED - Old single-tag system, use tags instead
-
-    Check Configuration:
-        processor (str): Processor type ('text_json_diff', 'restock_diff', etc.)
-        fetch_backend (str): Fetcher to use ('system', 'html_requests', 'playwright', etc.)
-        method (str): HTTP method ('GET', 'POST', etc.)
-        headers (dict): Custom HTTP headers to send
-        proxy (str|None): Preferred proxy server
-        paused (bool): Whether change detection is paused
-
-    Scheduling:
-        time_between_check (dict): Check interval {'weeks': int, 'days': int, 'hours': int, 'minutes': int, 'seconds': int}
-        time_between_check_use_default (bool): Use global default interval if True
-        time_schedule_limit (dict): Weekly schedule limiting when checks can run
-            Structure: {
-                'enabled': bool,
-                'monday/tuesday/.../sunday': {
-                    'enabled': bool,
-                    'start_time': str ('HH:MM'),
-                    'duration': {'hours': str, 'minutes': str}
-                }
-            }
-
-    Content Filtering:
-        include_filters (List[str]): CSS/XPath selectors to extract content
-        subtractive_selectors (List[str]): Selectors to remove from content
-        ignore_text (List[str]): Text patterns to ignore in change detection
-        trigger_text (List[str]): Text/regex that must be present to trigger change
-        text_should_not_be_present (List[str]): Text that should NOT be present
-        extract_text (List[str]): Regex patterns to extract specific text after filtering
-
-    Text Processing:
-        trim_text_whitespace (bool): Strip leading/trailing whitespace
-        sort_text_alphabetically (bool): Sort lines alphabetically before comparison
-        remove_duplicate_lines (bool): Remove duplicate lines
-        check_unique_lines (bool): Compare against all history for unique lines
-        strip_ignored_lines (bool|None): Remove lines matching ignore patterns
-
-    Change Detection Filters:
-        filter_text_added (bool): Include added text in change detection
-        filter_text_removed (bool): Include removed text in change detection
-        filter_text_replaced (bool): Include replaced text in change detection
-
-    Browser Automation:
-        browser_steps (List[dict]): Browser automation steps for JS-heavy sites
-        browser_steps_last_error_step (int|None): Last step that caused error
-        webdriver_delay (int|None): Seconds to wait after page load
-        webdriver_js_execute_code (str|None): JavaScript to execute before extraction
-
-    Restock Detection:
-        in_stock_only (bool): Only trigger on in-stock transitions
-        follow_price_changes (bool): Monitor price changes
-        has_ldjson_price_data (bool|None): Whether page has LD-JSON price data
-        track_ldjson_price_data (str|None): Track LD-JSON price data ('ACCEPT', 'REJECT', None)
-        price_change_threshold_percent (float|None): Minimum price change % to trigger
-
-    Notifications:
-        notification_urls (List[str]): Apprise URLs for notifications
-        notification_title (str|None): Custom notification title template
-        notification_body (str|None): Custom notification body template
-        notification_format (str): Notification format (e.g., 'System default', 'Text', 'HTML')
-        notification_muted (bool): Disable notifications for this watch
-        notification_screenshot (bool): Include screenshot in notifications
-        notification_alert_count (int): Number of notifications sent
-        last_notification_error (str|None): Last notification error message
-        body (str|None): DEPRECATED? Legacy notification body field
-        filter_failure_notification_send (bool): Send notification on filter failures
-
-    History & State:
-        date_created (int|None): Unix timestamp of watch creation
-        last_checked (int): Unix timestamp of last check
-        last_viewed (int): History snapshot key of last user view
-        last_error (str|bool): Last error message or False if no error
-        check_count (int): Total number of checks performed
-        fetch_time (float): Duration of last fetch in seconds
-        consecutive_filter_failures (int): Counter for consecutive filter match failures
-        previous_md5 (str|bool): MD5 hash of previous content
-        previous_md5_before_filters (str|bool): MD5 hash before filters applied
-        history_snapshot_max_length (int|None): Max history snapshots to keep (None = use global)
-
-    Conditions:
-        conditions (dict): Custom conditions for change detection logic
-        conditions_match_logic (str): Logic operator ('ALL', 'ANY') for conditions
-
-    Metadata:
-        content-type (str|None): Content-Type from last fetch
-        remote_server_reply (str|None): Server header from last response
-        ignore_status_codes (List[int]|None): HTTP status codes to ignore
-        use_page_title_in_list (bool|None): Display page title in watch list (None = use system default)
-
-    Instance Attributes (not serialized):
-        __datastore: Reference to parent DataStore (set externally after creation)
-        data_dir: Filesystem path for this watch's data directory
-
-    Notes:
-        - Many fields default to None to distinguish "not set" from "set to default"
-        - When field is None, system-level defaults are used
-        - Processor-specific configs (e.g., processor_config_*) are NOT stored in watch.json
-          They are stored in separate {processor_name}.json files
-        - This class is used for both Watch and Tag objects (tags reuse the structure)
-    """
 
     def __init__(self, *arg, **kw):
-        # Store datastore reference (common to Watch and Tag)
-        # Use single underscore to avoid name mangling issues in subclasses
-        self._datastore = kw.get('__datastore')
-        if kw.get('__datastore'):
-            del kw['__datastore']
-
-        # Store datastore_path (common to Watch and Tag)
-        self._datastore_path = kw.get('datastore_path')
-        if kw.get('datastore_path'):
-            del kw['datastore_path']
-
         self.update({
             # Custom notification content
             # Re #110, so then if this is set to None, we know to use the default value instead
@@ -189,7 +32,6 @@ class watch_base(dict):
             'filter_text_replaced': True,
             'follow_price_changes': True,
             'has_ldjson_price_data': None,
-            'history_snapshot_max_length': None,
             'headers': {},  # Extra headers to send
             'ignore_text': [],  # List of text to ignore when calculating the comparison checksum
             'ignore_status_codes': None,
@@ -297,225 +139,4 @@ class watch_base(dict):
         super(watch_base, self).__init__(*arg, **kw)
 
         if self.get('default'):
-            del self['default']
-
-    def __deepcopy__(self, memo):
-        """
-        Custom deepcopy for all watch_base subclasses (Watch, Tag, etc.).
-
-        CRITICAL FIX: Prevents copying large reference objects like __datastore
-        which would cause exponential memory growth when Watch objects are deepcopied.
-
-        This is called by:
-        - api/Watch.py:76 (API endpoint)
-        - api/Tags.py:28 (Tags API)
-        - processors/base.py:26 (EVERY processor run)
-        - store/__init__.py:544 (clone watch)
-        - And other locations
-        """
-        from copy import deepcopy
-
-        # Create new instance without calling __init__
-        cls = self.__class__
-        new_obj = cls.__new__(cls)
-        memo[id(self)] = new_obj
-
-        # Copy the dict data (all the settings)
-        for key, value in self.items():
-            new_obj[key] = deepcopy(value, memo)
-
-        # Copy instance attributes dynamically
-        # This handles Watch-specific attrs (like __datastore) and any future subclass attrs
-        for attr_name in dir(self):
-            # Skip methods, special attrs, and dict keys
-            if attr_name.startswith('_') and not attr_name.startswith('__'):
-                # This catches _model__datastore, _model__history_n, etc.
-                try:
-                    attr_value = getattr(self, attr_name)
-
-                    # Special handling: Share references to large objects instead of copying
-                    # Examples: _datastore, __datastore, __app_reference, __global_settings, etc.
-                    if (attr_name == '_datastore' or
-                        attr_name.endswith('__datastore') or
-                        attr_name.endswith('__app')):
-                        # Share the reference (don't copy!) to prevent memory leaks
-                        setattr(new_obj, attr_name, attr_value)
-                    # Skip cache attributes - let them regenerate on demand
-                    elif 'cache' in attr_name.lower():
-                        pass  # Don't copy caches
-                    # Copy regular instance attributes
-                    elif not callable(attr_value):
-                        setattr(new_obj, attr_name, attr_value)
-                except AttributeError:
-                    pass  # Attribute doesn't exist in this instance
-
-        return new_obj
-
-    def __getstate__(self):
-        """
-        Custom pickle serialization for all watch_base subclasses.
-
-        Excludes large reference objects (like __datastore) from serialization.
-        """
-        # Get the dict data
-        state = dict(self)
-
-        # Collect instance attributes (excluding methods and large references)
-        instance_attrs = {}
-        for attr_name in dir(self):
-            if attr_name.startswith('_') and not attr_name.startswith('__'):
-                try:
-                    attr_value = getattr(self, attr_name)
-                    # Exclude large reference objects and caches from serialization
-                    if not (attr_name == '_datastore' or
-                           attr_name.endswith('__datastore') or
-                           attr_name.endswith('__app') or
-                           'cache' in attr_name.lower() or
-                           callable(attr_value)):
-                        instance_attrs[attr_name] = attr_value
-                except AttributeError:
-                    pass
-
-        if instance_attrs:
-            state['__instance_metadata__'] = instance_attrs
-
-        return state
-
-    def __setstate__(self, state):
-        """
-        Custom pickle deserialization for all watch_base subclasses.
-
-        WARNING: Large reference objects (like __datastore) are NOT restored!
-        Caller must restore these references after unpickling if needed.
-        """
-        # Extract metadata
-        metadata = state.pop('__instance_metadata__', {})
-
-        # Restore dict data
-        self.update(state)
-
-        # Restore instance attributes
-        for attr_name, attr_value in metadata.items():
-            setattr(self, attr_name, attr_value)
-
-    @property
-    def data_dir(self):
-        """
-        The base directory for this watch/tag data (property, computed from UUID).
-
-        Common property for both Watch and Tag objects.
-        Returns path like: /datastore/{uuid}/
-        """
-        return os.path.join(self._datastore_path, self['uuid']) if self._datastore_path else None
-
-    def ensure_data_dir_exists(self):
-        """
-        Create the data directory if it doesn't exist.
-
-        Common method for both Watch and Tag objects.
-        """
-        from loguru import logger
-        if not os.path.isdir(self.data_dir):
-            logger.debug(f"> Creating data dir {self.data_dir}")
-            os.mkdir(self.data_dir)
-
-    def get_global_setting(self, *path):
-        """
-        Get a setting from the global datastore configuration.
-
-        Args:
-            *path: Path to the setting (e.g., 'application', 'history_snapshot_max_length')
-
-        Returns:
-            The setting value, or None if not found
-
-        Example:
-            maxlen = self.get_global_setting('application', 'history_snapshot_max_length')
-        """
-        if not self._datastore:
-            return None
-
-        try:
-            value = self._datastore['settings']
-            for key in path:
-                value = value[key]
-            return value
-        except (KeyError, TypeError):
-            return None
-
-    def _get_commit_data(self):
-        """
-        Prepare data for commit (can be overridden by subclasses).
-
-        Returns:
-            dict: Data to serialize (filtered as needed by subclass)
-        """
-        import copy
-
-        # Acquire datastore lock to prevent concurrent modifications during copy
-        lock = self._datastore.lock if self._datastore and hasattr(self._datastore, 'lock') else None
-
-        if lock:
-            with lock:
-                snapshot = dict(self)
-        else:
-            snapshot = dict(self)
-
-        # Deep copy snapshot (slower, but done outside lock to minimize contention)
-        # Subclasses can override to filter keys (e.g., Watch excludes processor_config_*)
-        return {k: copy.deepcopy(v) for k, v in snapshot.items()}
-
-    def _save_to_disk(self, data_dict, uuid):
-        """
-        Save data to disk (must be implemented by subclasses).
-
-        Args:
-            data_dict: Dictionary to save
-            uuid: UUID for logging
-
-        Raises:
-            NotImplementedError: If subclass doesn't implement
-        """
-        raise NotImplementedError("Subclass must implement _save_to_disk()")
-
-    def commit(self):
-        """
-        Save this watch/tag immediately to disk using atomic write.
-
-        Common commit logic for Watch and Tag objects.
-        Subclasses override _get_commit_data() and _save_to_disk() for specifics.
-
-        Fire-and-forget: Logs errors but does not raise exceptions.
-        Data remains in memory even if save fails, so next commit will retry.
-        """
-        from loguru import logger
-
-        if not self.data_dir:
-            entity_type = self.__class__.__name__
-            logger.error(f"Cannot commit {entity_type} {self.get('uuid')} without datastore_path")
-            return
-
-        uuid = self.get('uuid')
-        if not uuid:
-            entity_type = self.__class__.__name__
-            logger.error(f"Cannot commit {entity_type} without UUID")
-            return
-
-        # Get data from subclass (may filter keys)
-        try:
-            data_dict = self._get_commit_data()
-        except Exception as e:
-            logger.error(f"Failed to prepare commit data for {uuid}: {e}")
-            return
-
-        # Save to disk via subclass implementation
-        try:
-            # Determine entity type from module name (Watch.py -> watch, Tag.py -> tag)
-            from changedetectionio.model.persistence import _determine_entity_type
-            entity_type = _determine_entity_type(self.__class__)
-            filename = f"{entity_type}.json"
-
-            self._save_to_disk(data_dict, uuid)
-            logger.debug(f"Committed {entity_type} {uuid} to {uuid}/{filename}")
-        except Exception as e:
-            logger.error(f"Failed to commit {uuid}: {e}")
+            del self['default']

changedetectionio/model/persistence.py

@@ -1,84 +0,0 @@
-"""
-Entity persistence mixin for Watch and Tag models.
-
-Provides file-based persistence using atomic writes.
-"""
-
-import functools
-import inspect
-
-
-@functools.lru_cache(maxsize=None)
-def _determine_entity_type(cls):
-    """
-    Determine entity type from class hierarchy (cached at class level).
-
-    Args:
-        cls: The class to inspect
-
-    Returns:
-        str: Entity type ('watch', 'tag', etc.)
-
-    Raises:
-        ValueError: If entity type cannot be determined
-    """
-    for base_class in inspect.getmro(cls):
-        module_name = base_class.__module__
-        if module_name.startswith('changedetectionio.model.'):
-            # Get last part after dot: "changedetectionio.model.Watch" -> "watch"
-            return module_name.split('.')[-1].lower()
-
-    raise ValueError(
-        f"Cannot determine entity type for {cls.__module__}.{cls.__name__}. "
-        f"Entity must inherit from a class in changedetectionio.model (Watch or Tag)."
-    )
-
-
-class EntityPersistenceMixin:
-    """
-    Mixin providing file persistence for watch_base subclasses (Watch, Tag, etc.).
-
-    This mixin provides the _save_to_disk() method required by watch_base.commit().
-    It automatically determines the correct filename and size limits based on class hierarchy.
-
-    Usage:
-        class model(EntityPersistenceMixin, watch_base):  # in Watch.py
-            pass
-
-        class model(EntityPersistenceMixin, watch_base):  # in Tag.py
-            pass
-    """
-
-    def _save_to_disk(self, data_dict, uuid):
-        """
-        Save entity to disk using atomic write.
-
-        Implements the abstract method required by watch_base.commit().
-        Automatically determines filename and size limits from class hierarchy.
-
-        Args:
-            data_dict: Dictionary to save
-            uuid: UUID for logging
-
-        Raises:
-            ValueError: If entity type cannot be determined from class hierarchy
-        """
-        # Import here to avoid circular dependency
-        from changedetectionio.store.file_saving_datastore import save_entity_atomic
-
-        # Determine entity type (cached at class level, not instance level)
-        entity_type = _determine_entity_type(self.__class__)
-
-        # Set filename and size limits based on entity type
-        filename = f'{entity_type}.json'
-        max_size_mb = 10 if entity_type == 'watch' else 1
-
-        # Save using generic function
-        save_entity_atomic(
-            self.data_dir,
-            uuid,
-            data_dict,
-            filename=filename,
-            entity_type=entity_type,
-            max_size_mb=max_size_mb
-        )

changedetectionio/processors/base.py

@@ -23,14 +23,7 @@ class difference_detection_processor():
     def __init__(self, datastore, watch_uuid):
         self.datastore = datastore
         self.watch_uuid = watch_uuid
-
-        # Create a stable snapshot of the watch for processing
-        # Why deepcopy?
-        # 1. Prevents "dict changed during iteration" errors if watch is modified during processing
-        # 2. Preserves Watch object with properties (.link, .is_pdf, etc.) - can't use dict()
-        # 3. Safe now: Watch.__deepcopy__() shares datastore ref (no memory leak) but copies dict data
         self.watch = deepcopy(self.datastore.data['watching'].get(watch_uuid))
-
         # Generic fetcher that should be extended (requests, playwright etc)
         self.fetcher = Fetcher()
 
@@ -193,12 +186,12 @@ class difference_detection_processor():
         import os
 
         watch = self.datastore.data['watching'].get(self.watch_uuid)
-        data_dir = watch.data_dir
+        watch_data_dir = watch.watch_data_dir
 
-        if not data_dir:
+        if not watch_data_dir:
             return {}
 
-        filepath = os.path.join(data_dir, filename)
+        filepath = os.path.join(watch_data_dir, filename)
 
         if not os.path.isfile(filepath):
             return {}
@@ -223,16 +216,16 @@ class difference_detection_processor():
         import os
 
         watch = self.datastore.data['watching'].get(self.watch_uuid)
-        data_dir = watch.data_dir
+        watch_data_dir = watch.watch_data_dir
 
-        if not data_dir:
-            logger.warning(f"Cannot save extra watch config {filename}: no data_dir")
+        if not watch_data_dir:
+            logger.warning(f"Cannot save extra watch config {filename}: no watch_data_dir")
             return
 
         # Ensure directory exists
         watch.ensure_data_dir_exists()
 
-        filepath = os.path.join(data_dir, filename)
+        filepath = os.path.join(watch_data_dir, filename)
 
         try:
             # If merge is enabled, read existing data first

changedetectionio/processors/image_ssim_diff/difference.py

@@ -414,7 +414,7 @@ def render(watch, datastore, request, url_for, render_template, flash, redirect)
 
     # Load historical data if available (for charts/visualization)
     comparison_data = {}
-    comparison_config_path = os.path.join(watch.data_dir, "visual_comparison_data.json")
+    comparison_config_path = os.path.join(watch.watch_data_dir, "visual_comparison_data.json")
     if os.path.isfile(comparison_config_path):
         try:
             with open(comparison_config_path, 'r') as f:

changedetectionio/processors/image_ssim_diff/edit_hook.py

@@ -90,7 +90,7 @@ def on_config_save(watch, processor_config, datastore):
             processor_config['auto_track_region'] = False
 
             # Remove old template file if exists
-            template_path = os.path.join(watch.data_dir, CROPPED_IMAGE_TEMPLATE_FILENAME)
+            template_path = os.path.join(watch.watch_data_dir, CROPPED_IMAGE_TEMPLATE_FILENAME)
             if os.path.exists(template_path):
                 os.remove(template_path)
                 logger.debug(f"Removed old template file: {template_path}")

changedetectionio/processors/restock_diff/processor.py

@@ -193,17 +193,18 @@ class perform_site_check(difference_detection_processor):
 
 
         itemprop_availability = {}
-        multiple_prices_found = False
 
         # Try built-in extraction first, this will scan metadata in the HTML
         try:
             itemprop_availability = get_itemprop_availability(self.fetcher.content)
         except MoreThanOnePriceFound as e:
-            # Don't raise immediately - let plugins try to handle this case
-            # Plugins might be able to determine which price is correct
-            logger.warning(f"Built-in detection found multiple prices on {watch.get('url')}, will try plugin override")
-            multiple_prices_found = True
-            itemprop_availability = {}
+            # Add the real data
+            raise ProcessorException(message="Cannot run, more than one price detected, this plugin is only for product pages with ONE product, try the content-change detection mode.",
+                                     url=watch.get('url'),
+                                     status_code=self.fetcher.get_last_status_code(),
+                                     screenshot=self.fetcher.screenshot,
+                                     xpath_data=self.fetcher.xpath_data
+                                     )
 
         # If built-in extraction didn't get both price AND availability, try plugin override
         # Only check plugin if this watch is using a fetcher that might provide better data
@@ -215,21 +216,9 @@ class perform_site_check(difference_detection_processor):
             from changedetectionio.pluggy_interface import get_itemprop_availability_from_plugin
             fetcher_name = watch.get('fetch_backend', 'html_requests')
 
-            # Resolve 'system' to the actual fetcher being used
-            # This allows plugins to work even when watch uses "system settings default"
-            if fetcher_name == 'system':
-                # Get the actual fetcher that was used (from self.fetcher)
-                # Fetcher class name gives us the actual backend (e.g., 'html_requests', 'html_webdriver')
-                actual_fetcher = type(self.fetcher).__name__
-                if 'html_requests' in actual_fetcher.lower():
-                    fetcher_name = 'html_requests'
-                elif 'webdriver' in actual_fetcher.lower() or 'playwright' in actual_fetcher.lower():
-                    fetcher_name = 'html_webdriver'
-                logger.debug(f"Resolved 'system' fetcher to actual fetcher: {fetcher_name}")
-
-            # Try plugin override - plugins can decide if they support this fetcher
-            if fetcher_name:
-                logger.debug(f"Calling extra plugins for getting item price/availability (fetcher: {fetcher_name})")
+            # Only try plugin override if not using system default (which might be anything)
+            if fetcher_name and fetcher_name != 'system':
+                logger.debug("Calling extra plugins for getting item price/availability")
                 plugin_availability = get_itemprop_availability_from_plugin(self.fetcher.content, fetcher_name, self.fetcher, watch.link)
 
                 if plugin_availability:
@@ -244,16 +233,6 @@ class perform_site_check(difference_detection_processor):
                 if not plugin_availability:
                     logger.debug("No item price/availability from plugins")
 
-        # If we had multiple prices and plugins also failed, NOW raise the exception
-        if multiple_prices_found and not itemprop_availability.get('price'):
-            raise ProcessorException(
-                message="Cannot run, more than one price detected, this plugin is only for product pages with ONE product, try the content-change detection mode.",
-                url=watch.get('url'),
-                status_code=self.fetcher.get_last_status_code(),
-                screenshot=self.fetcher.screenshot,
-                xpath_data=self.fetcher.xpath_data
-            )
-
         # Something valid in get_itemprop_availability() by scraping metadata ?
         if itemprop_availability.get('price') or itemprop_availability.get('availability'):
             # Store for other usage

changedetectionio/processors/text_json_diff/__init__.py

@@ -55,7 +55,7 @@ def prepare_filter_prevew(datastore, watch_uuid, form_data):
 
     tmp_watch = deepcopy(datastore.data['watching'].get(watch_uuid))
 
-    if tmp_watch and tmp_watch.history and os.path.isdir(tmp_watch.data_dir):
+    if tmp_watch and tmp_watch.history and os.path.isdir(tmp_watch.watch_data_dir):
         # Splice in the temporary stuff from the form
         form = forms.processor_text_json_diff_form(formdata=form_data if request.method == 'POST' else None,
                                                    data=form_data
@@ -64,11 +64,11 @@ def prepare_filter_prevew(datastore, watch_uuid, form_data):
         # Only update vars that came in via the AJAX post
         p = {k: v for k, v in form.data.items() if k in form_data.keys()}
         tmp_watch.update(p)
-        blank_watch_no_filters = watch_model(datastore_path=datastore.datastore_path, __datastore=datastore.data)
+        blank_watch_no_filters = watch_model()
         blank_watch_no_filters['url'] = tmp_watch.get('url')
 
         latest_filename = next(reversed(tmp_watch.history))
-        html_fname = os.path.join(tmp_watch.data_dir, f"{latest_filename}.html.br")
+        html_fname = os.path.join(tmp_watch.watch_data_dir, f"{latest_filename}.html.br")
         with open(html_fname, 'rb') as f:
             decompressed_data = brotli.decompress(f.read()).decode('utf-8') if html_fname.endswith('.br') else f.read().decode('utf-8')
 

changedetectionio/run_basic_tests.sh

@@ -67,7 +67,7 @@ echo "-------------------- Running rest of tests in parallel -------------------
 # REMOVE_REQUESTS_OLD_SCREENSHOTS disabled so that we can write a screenshot and send it in test_notifications.py without a real browser
 FETCH_WORKERS=2 REMOVE_REQUESTS_OLD_SCREENSHOTS=false \
 pytest tests/test_*.py \
-  -n 8 \
+  -n 18 \
   --dist=load \
   -vvv \
   -s \

changedetectionio/store/__init__.py

@@ -9,14 +9,18 @@ from flask import (
 )
 from flask_babel import gettext
 
-from ..model import App, Watch
-from copy import deepcopy
+from ..blueprint.rss import RSS_CONTENT_FORMAT_DEFAULT
+from ..html_tools import TRANSLATE_WHITESPACE_TABLE
+from ..model import App, Watch, USE_SYSTEM_DEFAULT_NOTIFICATION_FORMAT_FOR_WATCH
+from copy import deepcopy, copy
 from os import path, unlink
+from threading import Lock
 import json
 import os
 import re
 import secrets
 import sys
+import threading
 import time
 import uuid as uuid_builder
 from loguru import logger
@@ -31,9 +35,10 @@ except ImportError:
     HAS_ORJSON = False
 
 from ..processors import get_custom_watch_obj_for_processor
+from ..processors.restock_diff import Restock
 
 # Import the base class and helpers
-from .file_saving_datastore import FileSavingDataStore, load_all_watches, load_all_tags, save_watch_atomic, save_tag_atomic, save_json_atomic
+from .file_saving_datastore import FileSavingDataStore, load_all_watches, save_watch_atomic, save_json_atomic
 from .updates import DatastoreUpdatesMixin
 from .legacy_loader import has_legacy_datastore
 
@@ -56,7 +61,9 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
         # Should only be active for docker
         # logging.basicConfig(filename='/dev/stdout', level=logging.INFO)
         self.datastore_path = datastore_path
+        self.needs_write = False
         self.start_time = time.time()
+        self.stop_thread = False
         self.save_version_copy_json_db(version_tag)
         self.reload_state(datastore_path=datastore_path, include_default_watches=include_default_watches, version_tag=version_tag)
 
@@ -123,39 +130,19 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
                 self.__data['settings']['application'].update(settings_data['settings']['application'])
 
     def _rehydrate_tags(self):
-        """Rehydrate tag entities from stored data into Tag objects with restock_diff processor."""
-        from ..model import Tag
-
+        """Rehydrate tag entities from stored data."""
         for uuid, tag in self.__data['settings']['application']['tags'].items():
-            # Force processor to restock_diff for override functionality (technical debt)
-            tag['processor'] = 'restock_diff'
-
-            self.__data['settings']['application']['tags'][uuid] = Tag.model(
-                datastore_path=self.datastore_path,
-                __datastore=self.__data,
-                default=tag
+            self.__data['settings']['application']['tags'][uuid] = self.rehydrate_entity(
+                uuid, tag, processor_override='restock_diff'
             )
             logger.info(f"Tag: {uuid} {tag['title']}")
 
-    def _rehydrate_watches(self):
-        """Rehydrate watch entities from stored data (converts dicts to Watch objects)."""
-        watch_count = len(self.__data.get('watching', {}))
-        if watch_count == 0:
-            return
-
-        logger.info(f"Rehydrating {watch_count} watches...")
-        watching_rehydrated = {}
-        for uuid, watch_dict in self.__data.get('watching', {}).items():
-            watching_rehydrated[uuid] = self.rehydrate_entity(uuid, watch_dict)
-        self.__data['watching'] = watching_rehydrated
-        logger.success(f"Rehydrated {watch_count} watches into Watch objects")
-
 
     def _load_state(self):
         """
         Load complete datastore state from storage.
 
-        Orchestrates loading of settings, watches, and tags using polymorphic methods.
+        Orchestrates loading of settings and watches using polymorphic methods.
         """
         # Load settings
         settings_data = self._load_settings()
@@ -164,11 +151,7 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
         # Load watches (polymorphic - parent class method)
         self._load_watches()
 
-        # Load tags from individual tag.json files
-        # These will override any tags in settings (migration path)
-        self._load_tags()
-
-        # Rehydrate any remaining tags from settings (legacy/fallback)
+        # Rehydrate tags
         self._rehydrate_tags()
 
     def reload_state(self, datastore_path, include_default_watches, version_tag):
@@ -191,7 +174,7 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
         self.json_store_path = os.path.join(self.datastore_path, "changedetection.json")
 
         # Base definition for all watchers (deepcopy part of #569)
-        self.generic_definition = deepcopy(Watch.model(datastore_path=datastore_path, __datastore=self.__data, default={}))
+        self.generic_definition = deepcopy(Watch.model(datastore_path=datastore_path, default={}))
 
         # Load build SHA if available (Docker deployments)
         if path.isfile('changedetectionio/source.txt'):
@@ -235,53 +218,23 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
                 logger.critical(f"Legacy datastore detected at {self.datastore_path}/url-watches.json")
                 logger.critical("Migration will be triggered via update_26")
 
-                # Load the legacy datastore
+                # Load the legacy datastore to get its schema_version
                 from .legacy_loader import load_legacy_format
                 legacy_path = os.path.join(self.datastore_path, "url-watches.json")
-                legacy_data = load_legacy_format(legacy_path)
+                with open(legacy_path) as f:
+                    self.__data = json.load(f)
 
-                if not legacy_data:
+                if not self.__data:
                     raise Exception("Failed to load legacy datastore from url-watches.json")
 
-                # Merge legacy data with base_config defaults (preserves new fields like 'ui')
-                # self.__data already has App.model() defaults from line 190
-                logger.info("Merging legacy data with base_config defaults...")
-
-                # Apply top-level fields from legacy data
-                if 'app_guid' in legacy_data:
-                    self.__data['app_guid'] = legacy_data['app_guid']
-                if 'build_sha' in legacy_data:
-                    self.__data['build_sha'] = legacy_data['build_sha']
-                if 'version_tag' in legacy_data:
-                    self.__data['version_tag'] = legacy_data['version_tag']
-
-                # Apply watching data (complete replacement as these are user's watches)
-                if 'watching' in legacy_data:
-                    self.__data['watching'] = legacy_data['watching']
-
-                # Merge settings sections (preserves base_config defaults for missing fields)
-                if 'settings' in legacy_data:
-                    if 'headers' in legacy_data['settings']:
-                        self.__data['settings']['headers'].update(legacy_data['settings']['headers'])
-                    if 'requests' in legacy_data['settings']:
-                        self.__data['settings']['requests'].update(legacy_data['settings']['requests'])
-                    if 'application' in legacy_data['settings']:
-                        # CRITICAL: Use .update() to merge, not replace
-                        # This preserves new fields like 'ui' that exist in base_config
-                        self.__data['settings']['application'].update(legacy_data['settings']['application'])
-
-                # CRITICAL: Rehydrate watches from dicts into Watch objects
-                # This ensures watches have their methods available during migration
-                self._rehydrate_watches()
-
-                # update_26 will save watches to individual files and create changedetection.json
-                # Next startup will load from new format normally
+                # update_26 will load the legacy data again and migrate to new format
+                # Only run updates AFTER the legacy schema version (e.g., if legacy is at 25, only run 26+)
                 self.run_updates()
 
 
             else:
                 # Fresh install - create new datastore
-                logger.warning(f"No datastore found, creating new datastore at {self.datastore_path}")
+                logger.critical(f"No datastore found, creating new datastore at {self.datastore_path}")
 
                 # Set schema version to latest (no updates needed)
                 updates_available = self.get_updates_available()
@@ -319,19 +272,19 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
                 self.__data['app_guid'] = "test-" + str(uuid_builder.uuid4())
             else:
                 self.__data['app_guid'] = str(uuid_builder.uuid4())
-            self.commit()
+            self.mark_settings_dirty()
 
         # Ensure RSS access token exists
         if not self.__data['settings']['application'].get('rss_access_token'):
             secret = secrets.token_hex(16)
             self.__data['settings']['application']['rss_access_token'] = secret
-            self.commit()
+            self.mark_settings_dirty()
 
         # Ensure API access token exists
         if not self.__data['settings']['application'].get('api_access_token'):
             secret = secrets.token_hex(16)
             self.__data['settings']['application']['api_access_token'] = secret
-            self.commit()
+            self.mark_settings_dirty()
 
         # Handle password reset lockfile
         password_reset_lockfile = os.path.join(self.datastore_path, "removepassword.lock")
@@ -339,6 +292,9 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
             self.remove_password()
             unlink(password_reset_lockfile)
 
+        # Start the background save thread
+        self.start_save_thread()
+
     def rehydrate_entity(self, uuid, entity, processor_override=None):
         """Set the dict back to the dict Watch object"""
         entity['uuid'] = uuid
@@ -352,7 +308,7 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
         if entity.get('processor') != 'text_json_diff':
             logger.trace(f"Loading Watch object '{watch_class.__module__}.{watch_class.__name__}' for UUID {uuid}")
 
-        entity = watch_class(datastore_path=self.datastore_path, __datastore=self.__data, default=entity)
+        entity = watch_class(datastore_path=self.datastore_path, default=entity)
         return entity
 
     # ============================================================================
@@ -371,30 +327,13 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
         """
         Build settings data structure for saving.
 
-        Tags behavior depends on schema version:
-        - Before update_28 (schema < 28): Tags saved in settings for migration
-        - After update_28 (schema >= 28): Tags excluded from settings (in individual files)
-
         Returns:
             dict: Settings data ready for serialization
         """
-        import copy
-
-        # Deep copy settings to avoid modifying the original
-        settings_copy = copy.deepcopy(self.__data['settings'])
-
-        # Only exclude tags if we've already migrated them to individual files (schema >= 28)
-        # This ensures update_28 can migrate tags from settings
-        schema_version = self.__data['settings']['application'].get('schema_version', 0)
-        if schema_version >= 28:
-            # Tags are in individual tag.json files, don't save to settings
-            settings_copy['application']['tags'] = {}
-        # else: keep tags in settings for update_28 migration
-
         return {
-            'note': 'Settings file - watches are in {uuid}/watch.json, tags are in {uuid}/tag.json',
+            'note': 'Settings file - watches are stored in individual {uuid}/watch.json files',
             'app_guid': self.__data['app_guid'],
-            'settings': settings_copy,
+            'settings': self.__data['settings'],
             'build_sha': self.__data.get('build_sha'),
             'version_tag': self.__data.get('version_tag')
         }
@@ -412,7 +351,7 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
         """
         settings_data = self._build_settings_data()
         changedetection_json = os.path.join(self.datastore_path, "changedetection.json")
-        save_json_atomic(changedetection_json, settings_data, label="settings")
+        save_json_atomic(changedetection_json, settings_data, label="settings", max_size_mb=10)
 
     def _load_watches(self):
         """
@@ -422,46 +361,22 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
         Implementation of abstract method from FileSavingDataStore.
         Delegates to helper function and stores results in internal data structure.
         """
-        watching = load_all_watches(
+        watching, watch_hashes = load_all_watches(
             self.datastore_path,
-            self.rehydrate_entity
+            self.rehydrate_entity,
+            self._compute_hash
         )
 
         # Store loaded data
         self.__data['watching'] = watching
+        self._watch_hashes = watch_hashes
 
-        logger.debug(f"Loaded {len(watching)} watches")
-
-    def _load_tags(self):
-        """
-        Load all tags from storage.
-
-        File backend implementation: reads individual tag.json files.
-        Tags loaded from files override any tags in settings (migration path).
-        """
-        from ..model import Tag
-
-        def rehydrate_tag(uuid, entity_dict):
-            """Rehydrate tag as Tag object with forced restock_diff processor."""
-            entity_dict['uuid'] = uuid
-            entity_dict['processor'] = 'restock_diff'  # Force processor for override functionality
-
-            return Tag.model(
-                datastore_path=self.datastore_path,
-                __datastore=self.__data,
-                default=entity_dict
-            )
-
-        tags = load_all_tags(
-            self.datastore_path,
-            rehydrate_tag
-        )
-
-        # Override settings tags with loaded tags
-        # This ensures tag.json files take precedence over settings
-        if tags:
-            self.__data['settings']['application']['tags'].update(tags)
-            logger.info(f"Loaded {len(tags)} tags from individual tag.json files")
+        # Verify all watches have hashes
+        missing_hashes = [uuid for uuid in watching.keys() if uuid not in watch_hashes]
+        if missing_hashes:
+            logger.error(f"WARNING: {len(missing_hashes)} watches missing hashes after load: {missing_hashes[:5]}")
+        else:
+            logger.debug(f"All {len(watching)} watches have valid hashes")
 
     def _delete_watch(self, uuid):
         """
@@ -485,7 +400,7 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
     def set_last_viewed(self, uuid, timestamp):
         logger.debug(f"Setting watch UUID: {uuid} last viewed to {int(timestamp)}")
         self.data['watching'][uuid].update({'last_viewed': int(timestamp)})
-        self.data['watching'][uuid].commit()
+        self.mark_watch_dirty(uuid)
 
         watch_check_update = signal('watch_check_update')
         if watch_check_update:
@@ -493,22 +408,7 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
 
     def remove_password(self):
         self.__data['settings']['application']['password'] = False
-        self.commit()
-
-    def commit(self):
-        """
-        Save settings immediately to disk using atomic write.
-
-        Uses atomic write pattern (temp file + rename) for crash safety.
-
-        Fire-and-forget: Logs errors but does not raise exceptions.
-        Settings data remains in memory even if save fails, so next commit will retry.
-        """
-        try:
-            self._save_settings()
-            logger.debug("Committed settings")
-        except Exception as e:
-            logger.error(f"Failed to commit settings: {e}")
+        self.mark_settings_dirty()
 
     def update_watch(self, uuid, update_obj):
 
@@ -527,8 +427,7 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
 
             self.__data['watching'][uuid].update(update_obj)
 
-        # Immediate save
-        self.__data['watching'][uuid].commit()
+        self.mark_watch_dirty(uuid)
 
     @property
     def threshold_seconds(self):
@@ -589,6 +488,10 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
                     except Exception as e:
                         logger.error(f"Failed to delete watch {watch_uuid} from storage: {e}")
 
+                    # Clean up tracking data
+                    self._watch_hashes.pop(watch_uuid, None)
+                    self._dirty_watches.discard(watch_uuid)
+
                     # Send delete signal
                     watch_delete_signal = signal('watch_deleted')
                     if watch_delete_signal:
@@ -610,19 +513,21 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
                 # Remove from watching dict
                 del self.data['watching'][uuid]
 
+                # Clean up tracking data
+                self._watch_hashes.pop(uuid, None)
+                self._dirty_watches.discard(uuid)
+
                 # Send delete signal
                 watch_delete_signal = signal('watch_deleted')
                 if watch_delete_signal:
                     watch_delete_signal.send(watch_uuid=uuid)
 
+        self.needs_write_urgent = True
+
     # Clone a watch by UUID
     def clone(self, uuid):
         url = self.data['watching'][uuid].get('url')
-        # No need to deepcopy here - add_watch() will deepcopy extras anyway (line 569)
-        # Just pass a dict copy (with lock for thread safety)
-        # NOTE: dict() is shallow copy but safe since add_watch() deepcopies it
-        with self.lock:
-            extras = dict(self.data['watching'][uuid])
+        extras = deepcopy(self.data['watching'][uuid])
         new_uuid = self.add_watch(url=url, extras=extras)
         watch = self.data['watching'][new_uuid]
         return new_uuid
@@ -639,7 +544,7 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
     # Remove a watchs data but keep the entry (URL etc)
     def clear_watch_history(self, uuid):
         self.__data['watching'][uuid].clear_watch()
-        self.__data['watching'][uuid].commit()
+        self.needs_write_urgent = True
 
     def add_watch(self, url, tag='', extras=None, tag_uuids=None, save_immediately=True):
 
@@ -734,7 +639,7 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
 
         # If the processor also has its own Watch implementation
         watch_class = get_custom_watch_obj_for_processor(apply_extras.get('processor'))
-        new_watch = watch_class(datastore_path=self.datastore_path, __datastore=self.__data, url=url)
+        new_watch = watch_class(datastore_path=self.datastore_path, url=url)
 
         new_uuid = new_watch.get('uuid')
 
@@ -752,9 +657,16 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
         self.__data['watching'][new_uuid] = new_watch
 
         if save_immediately:
-            # Save immediately using commit
-            new_watch.commit()
-            logger.debug(f"Saved new watch {new_uuid}")
+            # Save immediately using polymorphic method
+            try:
+                self.save_watch(new_uuid, force=True)
+                logger.debug(f"Saved new watch {new_uuid}")
+            except Exception as e:
+                logger.error(f"Failed to save new watch {new_uuid}: {e}")
+                # Mark dirty for retry
+                self.mark_watch_dirty(new_uuid)
+        else:
+            self.mark_watch_dirty(new_uuid)
 
         logger.debug(f"Added '{url}'")
 
@@ -789,6 +701,25 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
 
     # Old sync_to_json and save_datastore methods removed - now handled by FileSavingDataStore parent class
 
+    # Go through the datastore path and remove any snapshots that are not mentioned in the index
+    # This usually is not used, but can be handy.
+    def remove_unused_snapshots(self):
+        logger.info("Removing snapshots from datastore that are not in the index..")
+
+        index = []
+        for uuid in self.data['watching']:
+            for id in self.data['watching'][uuid].history:
+                index.append(self.data['watching'][uuid].history[str(id)])
+
+        import pathlib
+
+        # Only in the sub-directories
+        for uuid in self.data['watching']:
+            for item in pathlib.Path(self.datastore_path).rglob(uuid + "/*.txt"):
+                if not str(item) in index:
+                    logger.info(f"Removing {item}")
+                    unlink(item)
+
     @property
     def proxy_list(self):
         proxy_list = {}
@@ -880,7 +811,7 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
         if watch:
 
             # In /datastore/xyz-xyz/headers.txt
-            filepath = os.path.join(watch.data_dir, 'headers.txt')
+            filepath = os.path.join(watch.watch_data_dir, 'headers.txt')
             try:
                 if os.path.isfile(filepath):
                     headers.update(parse_headers_from_text_file(filepath))
@@ -927,21 +858,16 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
         # So we use the same model as a Watch
         with self.lock:
             from ..model import Tag
-            new_tag = Tag.model(
-                datastore_path=self.datastore_path,
-                __datastore=self.__data,
-                default={
-                    'title': title.strip(),
-                    'date_created': int(time.time())
-                }
-            )
+            new_tag = Tag.model(datastore_path=self.datastore_path, default={
+                'title': title.strip(),
+                'date_created': int(time.time())
+            })
 
             new_uuid = new_tag.get('uuid')
 
             self.__data['settings']['application']['tags'][new_uuid] = new_tag
 
-        # Save tag to its own tag.json file instead of settings
-        new_tag.commit()
+        self.mark_settings_dirty()
         return new_uuid
 
     def get_all_tags_for_watch(self, uuid):
@@ -1058,7 +984,7 @@ class ChangeDetectionStore(DatastoreUpdatesMixin, FileSavingDataStore):
             notification_urls.append(notification_url)
             self.__data['settings']['application']['notification_urls'] = notification_urls
 
-        self.commit()
+        self.mark_settings_dirty()
         return notification_url
 
     # Schema update methods moved to store/updates.py (DatastoreUpdatesMixin)

changedetectionio/store/base.py

@@ -81,3 +81,20 @@ class DataStore(ABC):
         """
         pass
 
+    @abstractmethod
+    def force_save_all(self):
+        """
+        Force immediate synchronous save of all data to storage.
+
+        This is the abstract method for forcing a complete save.
+        Different backends implement this differently:
+        - File backend: Mark all watches/settings dirty, then save
+        - Redis backend: SAVE command or pipeline flush
+        - SQL backend: COMMIT transaction
+
+        Used by:
+        - Backup creation (ensure everything is saved before backup)
+        - Shutdown (ensure all changes are persisted)
+        - Manual save operations
+        """
+        pass

changedetectionio/store/file_saving_datastore.py

@@ -1,17 +1,22 @@
 """
-File-based datastore with individual watch persistence and immediate commits.
+File-based datastore with individual watch persistence and dirty tracking.
 
 This module provides the FileSavingDataStore abstract class that implements:
 - Individual watch.json file persistence
-- Immediate commit-based persistence (watch.commit(), datastore.commit())
+- Hash-based change detection (only save what changed)
+- Periodic audit scan (catches unmarked changes)
+- Background save thread with batched parallel saves
 - Atomic file writes safe for NFS/NAS
 """
 
 import glob
+import hashlib
 import json
 import os
 import tempfile
 import time
+from concurrent.futures import ThreadPoolExecutor, as_completed
+from threading import Thread
 from loguru import logger
 
 from .base import DataStore
@@ -29,6 +34,19 @@ except ImportError:
 # Set to True for mission-critical deployments requiring crash consistency
 FORCE_FSYNC_DATA_IS_CRITICAL = bool(strtobool(os.getenv('FORCE_FSYNC_DATA_IS_CRITICAL', 'False')))
 
+# Save interval configuration: How often the background thread saves dirty items
+# Default 10 seconds - increase for less frequent saves, decrease for more frequent
+DATASTORE_SCAN_DIRTY_SAVE_INTERVAL_SECONDS = int(os.getenv('DATASTORE_SCAN_DIRTY_SAVE_INTERVAL_SECONDS', '10'))
+
+# Rolling audit configuration: Scans a fraction of watches each cycle
+# Default: Run audit every 10s, split into 5 shards
+# Full audit completes every 50s (10s × 5 shards)
+# With 56k watches: 56k / 5 = ~11k watches per cycle (~60ms vs 316ms for all)
+# Handles dynamic watch count - recalculates shard boundaries each cycle
+DATASTORE_AUDIT_INTERVAL_SECONDS = int(os.getenv('DATASTORE_AUDIT_INTERVAL_SECONDS', '10'))
+DATASTORE_AUDIT_SHARDS = int(os.getenv('DATASTORE_AUDIT_SHARDS', '5'))
+
+
 # ============================================================================
 # Helper Functions for Atomic File Operations
 # ============================================================================
@@ -43,9 +61,6 @@ def save_json_atomic(file_path, data_dict, label="file", max_size_mb=10):
     - Size validation
     - Proper error handling
 
-    Thread safety: Caller must hold datastore.lock to prevent concurrent modifications.
-    Multi-process safety: Not supported - run only one app instance per datastore.
-
     Args:
         file_path: Full path to target JSON file
         data_dict: Dictionary to serialize
@@ -175,46 +190,23 @@ def save_json_atomic(file_path, data_dict, label="file", max_size_mb=10):
         raise e
 
 
-def save_entity_atomic(entity_dir, uuid, entity_dict, filename, entity_type, max_size_mb):
-    """
-    Save an entity (watch/tag) to disk using atomic write pattern.
-
-    Generic function for saving any watch_base subclass (Watch, Tag, etc.).
-
-    Args:
-        entity_dir: Directory for this entity (e.g., /datastore/{uuid})
-        uuid: Entity UUID (for logging)
-        entity_dict: Dictionary representation of the entity
-        filename: JSON filename (e.g., 'watch.json', 'tag.json')
-        entity_type: Type label for logging (e.g., 'watch', 'tag')
-        max_size_mb: Maximum allowed file size in MB
-
-    Raises:
-        ValueError: If serialized data exceeds max_size_mb
-        OSError: If disk is full (ENOSPC) or other I/O error
-    """
-    entity_json = os.path.join(entity_dir, filename)
-    save_json_atomic(entity_json, entity_dict, label=f"{entity_type} {uuid}", max_size_mb=max_size_mb)
-
-
 def save_watch_atomic(watch_dir, uuid, watch_dict):
     """
     Save a watch to disk using atomic write pattern.
 
-    Convenience wrapper around save_entity_atomic for watches.
-    Kept for backwards compatibility.
-    """
-    save_entity_atomic(watch_dir, uuid, watch_dict, "watch.json", "watch", max_size_mb=10)
+    Convenience wrapper around save_json_atomic for watches.
 
+    Args:
+        watch_dir: Directory for this watch (e.g., /datastore/{uuid})
+        uuid: Watch UUID (for logging)
+        watch_dict: Dictionary representation of the watch
 
-def save_tag_atomic(tag_dir, uuid, tag_dict):
+    Raises:
+        ValueError: If serialized data exceeds 10MB (indicates bug or corruption)
+        OSError: If disk is full (ENOSPC) or other I/O error
     """
-    Save a tag to disk using atomic write pattern.
-
-    Convenience wrapper around save_entity_atomic for tags.
-    Kept for backwards compatibility.
-    """
-    save_entity_atomic(tag_dir, uuid, tag_dict, "tag.json", "tag", max_size_mb=1)
+    watch_json = os.path.join(watch_dir, "watch.json")
+    save_json_atomic(watch_json, watch_dict, label=f"watch {uuid}", max_size_mb=10)
 
 
 def load_watch_from_file(watch_json, uuid, rehydrate_entity_func):
@@ -227,7 +219,8 @@ def load_watch_from_file(watch_json, uuid, rehydrate_entity_func):
         rehydrate_entity_func: Function to convert dict to Watch object
 
     Returns:
-        Watch object or None if failed
+        Tuple of (Watch object, raw_data_dict) or (None, None) if failed
+        The raw_data_dict is needed to compute the hash before rehydration
     """
     try:
         # Check file size before reading
@@ -240,7 +233,7 @@ def load_watch_from_file(watch_json, uuid, rehydrate_entity_func):
                 f"File: {watch_json}. This indicates a bug or data corruption. "
                 f"Watch will be skipped."
             )
-            return None
+            return None, None
 
         if HAS_ORJSON:
             with open(watch_json, 'rb') as f:
@@ -249,9 +242,15 @@ def load_watch_from_file(watch_json, uuid, rehydrate_entity_func):
             with open(watch_json, 'r', encoding='utf-8') as f:
                 watch_data = json.load(f)
 
-        # Rehydrate and return watch object
+        if watch_data.get('time_schedule_limit'):
+            del watch_data['time_schedule_limit']
+        if watch_data.get('time_between_check'):
+            del watch_data['time_between_check']
+
+        # Return both the raw data and the rehydrated watch
+        # Raw data is needed to compute hash before rehydration changes anything
         watch_obj = rehydrate_entity_func(uuid, watch_data)
-        return watch_obj
+        return watch_obj, watch_data
 
     except json.JSONDecodeError as e:
         logger.critical(
@@ -259,7 +258,7 @@ def load_watch_from_file(watch_json, uuid, rehydrate_entity_func):
             f"File: {watch_json}. Error: {e}. "
             f"Watch will be skipped and may need manual recovery from backup."
         )
-        return None
+        return None, None
     except ValueError as e:
         # orjson raises ValueError for invalid JSON
         if "invalid json" in str(e).lower() or HAS_ORJSON:
@@ -268,18 +267,18 @@ def load_watch_from_file(watch_json, uuid, rehydrate_entity_func):
                 f"File: {watch_json}. Error: {e}. "
                 f"Watch will be skipped and may need manual recovery from backup."
             )
-            return None
+            return None, None
         # Re-raise if it's not a JSON parsing error
         raise
     except FileNotFoundError:
         logger.error(f"Watch file not found: {watch_json} for watch {uuid}")
-        return None
+        return None, None
     except Exception as e:
         logger.error(f"Failed to load watch {uuid} from {watch_json}: {e}")
-        return None
+        return None, None
 
 
-def load_all_watches(datastore_path, rehydrate_entity_func):
+def load_all_watches(datastore_path, rehydrate_entity_func, compute_hash_func):
     """
     Load all watches from individual watch.json files.
 
@@ -290,17 +289,21 @@ def load_all_watches(datastore_path, rehydrate_entity_func):
     Args:
         datastore_path: Path to the datastore directory
         rehydrate_entity_func: Function to convert dict to Watch object
+        compute_hash_func: Function to compute hash from raw watch dict
 
     Returns:
-        Dictionary of uuid -> Watch object
+        Tuple of (watching_dict, hashes_dict)
+        - watching_dict: uuid -> Watch object
+        - hashes_dict: uuid -> hash string (computed from raw data)
     """
     start_time = time.time()
     logger.info("Loading watches from individual watch.json files...")
 
     watching = {}
+    watch_hashes = {}
 
     if not os.path.exists(datastore_path):
-        return watching
+        return watching, watch_hashes
 
     # Find all watch.json files using glob (faster than manual directory traversal)
     glob_start = time.time()
@@ -316,9 +319,12 @@ def load_all_watches(datastore_path, rehydrate_entity_func):
     for watch_json in watch_files:
         # Extract UUID from path: /datastore/{uuid}/watch.json
         uuid_dir = os.path.basename(os.path.dirname(watch_json))
-        watch = load_watch_from_file(watch_json, uuid_dir, rehydrate_entity_func)
-        if watch:
+        watch, raw_data = load_watch_from_file(watch_json, uuid_dir, rehydrate_entity_func)
+        if watch and raw_data:
             watching[uuid_dir] = watch
+            # Compute hash from rehydrated Watch object (as dict) to match how we compute on save
+            # This ensures hash matches what audit will compute from dict(watch)
+            watch_hashes[uuid_dir] = compute_hash_func(dict(watch))
             loaded += 1
 
             if loaded % 100 == 0:
@@ -338,123 +344,7 @@ def load_all_watches(datastore_path, rehydrate_entity_func):
     else:
         logger.info(f"Loaded {loaded} watches from disk in {elapsed:.2f}s ({loaded/elapsed:.0f} watches/sec)")
 
-    return watching
-
-
-def load_tag_from_file(tag_json, uuid, rehydrate_entity_func):
-    """
-    Load a tag from its JSON file.
-
-    Args:
-        tag_json: Path to the tag.json file
-        uuid: Tag UUID
-        rehydrate_entity_func: Function to convert dict to Tag object
-
-    Returns:
-        Tag object or None if failed
-    """
-    try:
-        # Check file size before reading
-        file_size = os.path.getsize(tag_json)
-        MAX_TAG_SIZE = 1 * 1024 * 1024  # 1MB
-        if file_size > MAX_TAG_SIZE:
-            logger.critical(
-                f"CORRUPTED TAG DATA: Tag {uuid} file is unexpectedly large: "
-                f"{file_size / 1024 / 1024:.2f}MB (max: {MAX_TAG_SIZE / 1024 / 1024}MB). "
-                f"File: {tag_json}. This indicates a bug or data corruption. "
-                f"Tag will be skipped."
-            )
-            return None
-
-        if HAS_ORJSON:
-            with open(tag_json, 'rb') as f:
-                tag_data = orjson.loads(f.read())
-        else:
-            with open(tag_json, 'r', encoding='utf-8') as f:
-                tag_data = json.load(f)
-
-        tag_data['processor'] = 'restock_diff'
-        # Rehydrate tag (convert dict to Tag object)
-        # processor_override is set inside the rehydration function
-        tag_obj = rehydrate_entity_func(uuid, tag_data)
-        return tag_obj
-
-    except json.JSONDecodeError as e:
-        logger.critical(
-            f"CORRUPTED TAG DATA: Failed to parse JSON for tag {uuid}. "
-            f"File: {tag_json}. Error: {e}. "
-            f"Tag will be skipped and may need manual recovery from backup."
-        )
-        return None
-    except ValueError as e:
-        # orjson raises ValueError for invalid JSON
-        if "invalid json" in str(e).lower() or HAS_ORJSON:
-            logger.critical(
-                f"CORRUPTED TAG DATA: Failed to parse JSON for tag {uuid}. "
-                f"File: {tag_json}. Error: {e}. "
-                f"Tag will be skipped and may need manual recovery from backup."
-            )
-            return None
-        # Re-raise if it's not a JSON parsing error
-        raise
-    except FileNotFoundError:
-        logger.debug(f"Tag file not found: {tag_json} for tag {uuid}")
-        return None
-    except Exception as e:
-        logger.error(f"Failed to load tag {uuid} from {tag_json}: {e}")
-        return None
-
-
-def load_all_tags(datastore_path, rehydrate_entity_func):
-    """
-    Load all tags from individual tag.json files.
-
-    Tags are stored separately from settings in {uuid}/tag.json files.
-
-    Args:
-        datastore_path: Path to the datastore directory
-        rehydrate_entity_func: Function to convert dict to Tag object
-
-    Returns:
-        Dictionary of uuid -> Tag object
-    """
-    logger.info("Loading tags from individual tag.json files...")
-
-    tags = {}
-
-    if not os.path.exists(datastore_path):
-        return tags
-
-    # Find all tag.json files using glob
-    tag_files = glob.glob(os.path.join(datastore_path, "*", "tag.json"))
-
-    total = len(tag_files)
-    if total == 0:
-        logger.debug("No tag.json files found")
-        return tags
-
-    logger.debug(f"Found {total} tag.json files")
-
-    loaded = 0
-    failed = 0
-
-    for tag_json in tag_files:
-        # Extract UUID from path: /datastore/{uuid}/tag.json
-        uuid_dir = os.path.basename(os.path.dirname(tag_json))
-        tag = load_tag_from_file(tag_json, uuid_dir, rehydrate_entity_func)
-        if tag:
-            tags[uuid_dir] = tag
-            loaded += 1
-        else:
-            # load_tag_from_file already logged the specific error
-            failed += 1
-
-    if failed > 0:
-        logger.warning(f"Loaded {loaded} tags, {failed} tags FAILED to load")
-    else:
-        logger.info(f"Loaded {loaded} tags from disk")
-
-    return tags
+    return watching, watch_hashes
 
 
 # ============================================================================
@@ -463,20 +353,151 @@ def load_all_tags(datastore_path, rehydrate_entity_func):
 
 class FileSavingDataStore(DataStore):
     """
-    Abstract datastore that provides file persistence with immediate commits.
+    Abstract datastore that provides file persistence with change tracking.
 
     Features:
     - Individual watch.json files (one per watch)
-    - Immediate persistence via watch.commit() and datastore.commit()
-    - Atomic file writes for crash safety
+    - Dirty tracking: Only saves items that have changed
+    - Hash-based change detection: Prevents unnecessary writes
+    - Background save thread: Non-blocking persistence
+    - Two-tier urgency: Standard (60s) and urgent (immediate) saves
 
     Subclasses must implement:
     - rehydrate_entity(): Convert dict to Watch object
     - Access to internal __data structure for watch management
     """
 
+    needs_write = False
+    needs_write_urgent = False
+    stop_thread = False
+
+    # Change tracking
+    _dirty_watches = set()      # Watch UUIDs that need saving
+    _dirty_settings = False     # Settings changed
+    _watch_hashes = {}          # UUID -> SHA256 hash for change detection
+
+    # Health monitoring
+    _last_save_time = 0         # Timestamp of last successful save
+    _last_audit_time = 0        # Timestamp of last audit scan
+    _save_cycle_count = 0       # Number of save cycles completed
+    _total_saves = 0            # Total watches saved (lifetime)
+    _save_errors = 0            # Total save errors (lifetime)
+    _audit_count = 0            # Number of audit scans completed
+    _audit_found_changes = 0    # Total unmarked changes found by audits
+    _audit_shard_index = 0      # Current shard being audited (rolling audit)
+
     def __init__(self):
         super().__init__()
+        self.save_data_thread = None
+        self._last_save_time = time.time()
+        self._last_audit_time = time.time()
+
+
+    def mark_watch_dirty(self, uuid):
+        """
+        Mark a watch as needing save.
+
+        Args:
+            uuid: Watch UUID
+        """
+        with self.lock:
+            self._dirty_watches.add(uuid)
+            dirty_count = len(self._dirty_watches)
+
+        # Backpressure detection - warn if dirty set grows too large
+        if dirty_count > 1000:
+            logger.critical(
+                f"BACKPRESSURE WARNING: {dirty_count} watches pending save! "
+                f"Save thread may not be keeping up with write rate. "
+                f"This could indicate disk I/O bottleneck or save thread failure."
+            )
+        elif dirty_count > 500:
+            logger.warning(
+                f"Dirty watch count high: {dirty_count} watches pending save. "
+                f"Monitoring for potential backpressure."
+            )
+
+        self.needs_write = True
+
+    def mark_settings_dirty(self):
+        """Mark settings as needing save."""
+        with self.lock:
+            self._dirty_settings = True
+        self.needs_write = True
+
+    def _compute_hash(self, watch_dict):
+        """
+        Compute SHA256 hash of watch for change detection.
+
+        Args:
+            watch_dict: Dictionary representation of watch
+
+        Returns:
+            Hex string of SHA256 hash
+        """
+        # Use orjson for deterministic serialization if available
+        if HAS_ORJSON:
+            json_bytes = orjson.dumps(watch_dict, option=orjson.OPT_SORT_KEYS)
+        else:
+            json_str = json.dumps(watch_dict, sort_keys=True, ensure_ascii=False)
+            json_bytes = json_str.encode('utf-8')
+
+        return hashlib.sha256(json_bytes).hexdigest()
+
+    def save_watch(self, uuid, force=False, watch_dict=None, current_hash=None):
+        """
+        Save a single watch if it has changed (polymorphic method).
+
+        Args:
+            uuid: Watch UUID
+            force: If True, skip hash check and save anyway
+            watch_dict: Pre-computed watch dictionary (optimization)
+            current_hash: Pre-computed hash (optimization)
+
+        Returns:
+            True if saved, False if skipped (unchanged)
+        """
+        if not self._watch_exists(uuid):
+            logger.warning(f"Cannot save watch {uuid} - does not exist")
+            return False
+
+        # Get watch dict if not provided
+        if watch_dict is None:
+            watch_dict = self._get_watch_dict(uuid)
+
+        # Compute hash if not provided
+        if current_hash is None:
+            current_hash = self._compute_hash(watch_dict)
+
+        # Skip save if unchanged (unless forced)
+        if not force and current_hash == self._watch_hashes.get(uuid):
+            return False
+
+        try:
+            self._save_watch(uuid, watch_dict)
+            self._watch_hashes[uuid] = current_hash
+            logger.debug(f"Saved watch {uuid}")
+            return True
+        except Exception as e:
+            logger.error(f"Failed to save watch {uuid}: {e}")
+            raise
+
+    def _save_watch(self, uuid, watch_dict):
+        """
+        Save a single watch to storage (polymorphic).
+
+        Backend-specific implementation. Subclasses override for different storage:
+        - File backend: Writes to {uuid}/watch.json
+        - Redis backend: SET watch:{uuid}
+        - SQL backend: UPDATE watches WHERE uuid=?
+
+        Args:
+            uuid: Watch UUID
+            watch_dict: Dictionary representation of watch
+        """
+        # Default file implementation
+        watch_dir = os.path.join(self.datastore_path, uuid)
+        save_watch_atomic(watch_dir, uuid, watch_dict)
 
     def _save_settings(self):
         """
@@ -489,7 +510,6 @@ class FileSavingDataStore(DataStore):
         """
         raise NotImplementedError("Subclass must implement _save_settings")
 
-
     def _load_watches(self):
         """
         Load all watches from storage (polymorphic).
@@ -515,4 +535,364 @@ class FileSavingDataStore(DataStore):
         """
         raise NotImplementedError("Subclass must implement _delete_watch")
 
+    def _save_dirty_items(self):
+        """
+        Save dirty watches and settings.
 
+        This is the core optimization: instead of saving the entire datastore,
+        we only save watches that were marked dirty and settings if changed.
+        """
+        start_time = time.time()
+
+        # Capture dirty sets under lock
+        with self.lock:
+            dirty_watches = list(self._dirty_watches)
+            dirty_settings = self._dirty_settings
+            self._dirty_watches.clear()
+            self._dirty_settings = False
+
+        if not dirty_watches and not dirty_settings:
+            return
+
+        logger.trace(f"Saving {len(dirty_watches)} dirty watches, settings_dirty={dirty_settings}")
+
+        # Save each dirty watch using the polymorphic save method
+        saved_count = 0
+        error_count = 0
+        skipped_unchanged = 0
+
+        # Process in batches of 50, using thread pool for parallel saves
+        BATCH_SIZE = 50
+        MAX_WORKERS = 20  # Number of parallel save threads
+
+        def save_single_watch(uuid):
+            """Helper function for thread pool execution."""
+            try:
+                # Check if watch still exists (might have been deleted)
+                if not self._watch_exists(uuid):
+                    # Watch was deleted, remove hash
+                    self._watch_hashes.pop(uuid, None)
+                    return {'status': 'deleted', 'uuid': uuid}
+
+                # Pre-check hash to avoid unnecessary save_watch() calls
+                watch_dict = self._get_watch_dict(uuid)
+                current_hash = self._compute_hash(watch_dict)
+
+                if current_hash == self._watch_hashes.get(uuid):
+                    # Watch hasn't actually changed, skip
+                    return {'status': 'unchanged', 'uuid': uuid}
+
+                # Pass pre-computed values to avoid redundant serialization/hashing
+                if self.save_watch(uuid, force=True, watch_dict=watch_dict, current_hash=current_hash):
+                    return {'status': 'saved', 'uuid': uuid}
+                else:
+                    return {'status': 'skipped', 'uuid': uuid}
+            except Exception as e:
+                logger.error(f"Error saving watch {uuid}: {e}")
+                return {'status': 'error', 'uuid': uuid, 'error': e}
+
+        # Process dirty watches in batches
+        for batch_start in range(0, len(dirty_watches), BATCH_SIZE):
+            batch = dirty_watches[batch_start:batch_start + BATCH_SIZE]
+            batch_num = (batch_start // BATCH_SIZE) + 1
+            total_batches = (len(dirty_watches) + BATCH_SIZE - 1) // BATCH_SIZE
+
+            if len(dirty_watches) > BATCH_SIZE:
+                logger.trace(f"Save batch {batch_num}/{total_batches} ({len(batch)} watches)")
+
+            # Use thread pool to save watches in parallel
+            with ThreadPoolExecutor(max_workers=MAX_WORKERS) as executor:
+                # Submit all save tasks
+                future_to_uuid = {executor.submit(save_single_watch, uuid): uuid for uuid in batch}
+
+                # Collect results as they complete
+                for future in as_completed(future_to_uuid):
+                    result = future.result()
+                    status = result['status']
+
+                    if status == 'saved':
+                        saved_count += 1
+                    elif status == 'unchanged':
+                        skipped_unchanged += 1
+                    elif status == 'error':
+                        error_count += 1
+                        # Re-mark for retry
+                        with self.lock:
+                            self._dirty_watches.add(result['uuid'])
+                    # 'deleted' and 'skipped' don't need special handling
+
+        # Save settings if changed
+        if dirty_settings:
+            try:
+                self._save_settings()
+                logger.debug("Saved settings")
+            except Exception as e:
+                logger.error(f"Failed to save settings: {e}")
+                error_count += 1
+                with self.lock:
+                    self._dirty_settings = True
+
+        # Update metrics
+        elapsed = time.time() - start_time
+        self._save_cycle_count += 1
+        self._total_saves += saved_count
+        self._save_errors += error_count
+        self._last_save_time = time.time()
+
+        # Log performance metrics
+        if saved_count > 0:
+            avg_time_per_watch = (elapsed / saved_count) * 1000  # milliseconds
+            skipped_msg = f", {skipped_unchanged} unchanged" if skipped_unchanged > 0 else ""
+            parallel_msg = f" [parallel: {MAX_WORKERS} workers]" if saved_count > 1 else ""
+            logger.info(
+                f"Successfully saved {saved_count} watches in {elapsed:.2f}s "
+                f"(avg {avg_time_per_watch:.1f}ms per watch{skipped_msg}){parallel_msg}. "
+                f"Total: {self._total_saves} saves, {self._save_errors} errors (lifetime)"
+            )
+        elif skipped_unchanged > 0:
+            logger.debug(f"Save cycle: {skipped_unchanged} watches verified unchanged (hash match), nothing saved")
+
+        if error_count > 0:
+            logger.error(f"Save cycle completed with {error_count} errors")
+
+        self.needs_write = False
+        self.needs_write_urgent = False
+
+    def _watch_exists(self, uuid):
+        """
+        Check if watch exists. Subclass must implement.
+
+        Args:
+            uuid: Watch UUID
+
+        Returns:
+            bool
+        """
+        raise NotImplementedError("Subclass must implement _watch_exists")
+
+    def _get_watch_dict(self, uuid):
+        """
+        Get watch as dictionary. Subclass must implement.
+
+        Args:
+            uuid: Watch UUID
+
+        Returns:
+            Dictionary representation of watch
+        """
+        raise NotImplementedError("Subclass must implement _get_watch_dict")
+
+    def _audit_all_watches(self):
+        """
+        Rolling audit: Scans a fraction of watches to detect unmarked changes.
+
+        Instead of scanning ALL watches at once, this scans 1/N shards per cycle.
+        The shard rotates each cycle, completing a full audit every N cycles.
+
+        Handles dynamic watch count - recalculates shard boundaries each cycle,
+        so newly added watches will be audited in subsequent cycles.
+
+        Benefits:
+        - Lower CPU per cycle (56k / 5 = ~11k watches vs all 56k)
+        - More frequent audits overall (every 50s vs every 10s)
+        - Spreads load evenly across time
+        """
+        audit_start = time.time()
+
+        # Get list of all watch UUIDs (read-only, no lock needed)
+        try:
+            all_uuids = list(self.data['watching'].keys())
+        except (KeyError, AttributeError, RuntimeError):
+            # Data structure not ready or being modified
+            return
+
+        if not all_uuids:
+            return
+
+        total_watches = len(all_uuids)
+
+        # Calculate this cycle's shard boundaries
+        # Example: 56,278 watches / 5 shards = 11,255 watches per shard
+        # Shard 0: [0:11255], Shard 1: [11255:22510], etc.
+        shard_size = (total_watches + DATASTORE_AUDIT_SHARDS - 1) // DATASTORE_AUDIT_SHARDS
+        start_idx = self._audit_shard_index * shard_size
+        end_idx = min(start_idx + shard_size, total_watches)
+
+        # Handle wrap-around (shouldn't happen normally, but defensive)
+        if start_idx >= total_watches:
+            self._audit_shard_index = 0
+            start_idx = 0
+            end_idx = min(shard_size, total_watches)
+
+        # Audit only this shard's watches
+        shard_uuids = all_uuids[start_idx:end_idx]
+
+        changes_found = 0
+        errors = 0
+
+        for uuid in shard_uuids:
+            try:
+                # Get current watch dict and compute hash
+                watch_dict = self._get_watch_dict(uuid)
+                current_hash = self._compute_hash(watch_dict)
+                stored_hash = self._watch_hashes.get(uuid)
+
+                # If hash changed and not already marked dirty, mark it
+                if current_hash != stored_hash:
+                    with self.lock:
+                        if uuid not in self._dirty_watches:
+                            self._dirty_watches.add(uuid)
+                            changes_found += 1
+                            logger.warning(
+                                f"Audit detected unmarked change in watch {uuid[:8]}... current {current_hash:8} stored hash {stored_hash[:8]}"
+                                f"(hash changed but not marked dirty)"
+                            )
+                            self.needs_write = True
+            except Exception as e:
+                errors += 1
+                logger.trace(f"Audit error for watch {uuid[:8]}...: {e}")
+
+        audit_elapsed = (time.time() - audit_start) * 1000  # milliseconds
+
+        # Advance to next shard (wrap around after last shard)
+        self._audit_shard_index = (self._audit_shard_index + 1) % DATASTORE_AUDIT_SHARDS
+
+        # Update metrics
+        self._audit_count += 1
+        self._audit_found_changes += changes_found
+        self._last_audit_time = time.time()
+
+        if changes_found > 0:
+            logger.warning(
+                f"Audit shard {self._audit_shard_index}/{DATASTORE_AUDIT_SHARDS} found {changes_found} "
+                f"unmarked changes in {len(shard_uuids)}/{total_watches} watches ({audit_elapsed:.1f}ms)"
+            )
+        else:
+            logger.trace(
+                f"Audit shard {self._audit_shard_index}/{DATASTORE_AUDIT_SHARDS}: "
+                f"{len(shard_uuids)}/{total_watches} watches checked, 0 changes ({audit_elapsed:.1f}ms)"
+            )
+
+    def save_datastore(self):
+        """
+        Background thread that periodically saves dirty items and audits watches.
+
+        Runs two independent cycles:
+        1. Save dirty items every DATASTORE_SCAN_DIRTY_SAVE_INTERVAL_SECONDS (default 10s)
+        2. Rolling audit: every DATASTORE_AUDIT_INTERVAL_SECONDS (default 10s)
+           - Scans 1/DATASTORE_AUDIT_SHARDS watches per cycle (default 1/5)
+           - Full audit completes every 50s (10s × 5 shards)
+           - Automatically handles new/deleted watches
+
+        Uses 0.5s sleep intervals for responsiveness to urgent saves.
+        """
+        while True:
+            if self.stop_thread:
+                # Graceful shutdown: flush any remaining dirty items before stopping
+                if self.needs_write or self._dirty_watches or self._dirty_settings:
+                    logger.warning("Datastore save thread stopping - flushing remaining dirty items...")
+                    try:
+                        self._save_dirty_items()
+                        logger.info("Graceful shutdown complete - all data saved")
+                    except Exception as e:
+                        logger.critical(f"FAILED to save dirty items during shutdown: {e}")
+                else:
+                    logger.info("Datastore save thread stopping - no dirty items")
+                return
+
+            # Check if it's time to run audit scan (every N seconds)
+            if time.time() - self._last_audit_time >= DATASTORE_AUDIT_INTERVAL_SECONDS:
+                try:
+                    self._audit_all_watches()
+                except Exception as e:
+                    logger.error(f"Error in audit cycle: {e}")
+
+            # Save dirty items if needed
+            if self.needs_write or self.needs_write_urgent:
+                try:
+                    self._save_dirty_items()
+                except Exception as e:
+                    logger.error(f"Error in save cycle: {e}")
+
+            # Timer with early break for urgent saves
+            # Each iteration is 0.5 seconds, so iterations = DATASTORE_SCAN_DIRTY_SAVE_INTERVAL_SECONDS * 2
+            for i in range(DATASTORE_SCAN_DIRTY_SAVE_INTERVAL_SECONDS * 2):
+                time.sleep(0.5)
+                if self.stop_thread or self.needs_write_urgent:
+                    break
+
+    def start_save_thread(self):
+        """Start the background save thread."""
+        if not self.save_data_thread or not self.save_data_thread.is_alive():
+            self.save_data_thread = Thread(target=self.save_datastore, daemon=True, name="DatastoreSaver")
+            self.save_data_thread.start()
+            logger.info("Datastore save thread started")
+
+    def force_save_all(self):
+        """
+        Force immediate synchronous save of all changes to storage.
+
+        File backend implementation of the abstract force_save_all() method.
+        Marks all watches and settings as dirty, then saves immediately.
+
+        Used by:
+        - Backup creation (ensure everything is saved before backup)
+        - Shutdown (ensure all changes are persisted)
+        - Manual save operations
+        """
+        logger.info("Force saving all data to storage...")
+
+        # Mark everything as dirty to ensure complete save
+        for uuid in self.data['watching'].keys():
+            self.mark_watch_dirty(uuid)
+        self.mark_settings_dirty()
+
+        # Save immediately (synchronous)
+        self._save_dirty_items()
+
+        logger.success("All data saved to storage")
+
+    def get_health_status(self):
+        """
+        Get datastore health status for monitoring.
+
+        Returns:
+            dict with health metrics and status
+        """
+        now = time.time()
+        time_since_last_save = now - self._last_save_time
+
+        with self.lock:
+            dirty_count = len(self._dirty_watches)
+
+        is_thread_alive = self.save_data_thread and self.save_data_thread.is_alive()
+
+        # Determine health status
+        if not is_thread_alive:
+            status = "CRITICAL"
+            message = "Save thread is DEAD"
+        elif time_since_last_save > 300:  # 5 minutes
+            status = "WARNING"
+            message = f"No save activity for {time_since_last_save:.0f}s"
+        elif dirty_count > 1000:
+            status = "WARNING"
+            message = f"High backpressure: {dirty_count} watches pending"
+        elif self._save_errors > 0 and (self._save_errors / max(self._total_saves, 1)) > 0.01:
+            status = "WARNING"
+            message = f"High error rate: {self._save_errors} errors"
+        else:
+            status = "HEALTHY"
+            message = "Operating normally"
+
+        return {
+            "status": status,
+            "message": message,
+            "thread_alive": is_thread_alive,
+            "dirty_watches": dirty_count,
+            "dirty_settings": self._dirty_settings,
+            "last_save_seconds_ago": int(time_since_last_save),
+            "save_cycles": self._save_cycle_count,
+            "total_saves": self._total_saves,
+            "total_errors": self._save_errors,
+            "error_rate_percent": round((self._save_errors / max(self._total_saves, 1)) * 100, 2)
+        }

changedetectionio/store/updates.py

@@ -29,7 +29,6 @@ def create_backup_tarball(datastore_path, update_number):
 
     Includes:
     - All {uuid}/watch.json files
-    - All {uuid}/tag.json files
     - changedetection.json (settings, if it exists)
     - url-watches.json (legacy format, if it exists)
     - Directory structure preserved
@@ -45,7 +44,7 @@ def create_backup_tarball(datastore_path, update_number):
     To restore from a backup:
         cd /path/to/datastore
         tar -xzf before-update-N-timestamp.tar.gz
-    This will restore all watch.json and tag.json files and settings to their pre-update state.
+    This will restore all watch.json files and settings to their pre-update state.
     """
     timestamp = int(time.time())
     backup_filename = f"before-update-{update_number}-{timestamp}.tar.gz"
@@ -67,10 +66,9 @@ def create_backup_tarball(datastore_path, update_number):
                 tar.add(url_watches_json, arcname="url-watches.json")
                 logger.debug("Added url-watches.json to backup")
 
-            # Backup all watch/tag directories with their JSON files
+            # Backup all watch directories with their watch.json files
             # This preserves the UUID directory structure
             watch_count = 0
-            tag_count = 0
             for entry in os.listdir(datastore_path):
                 entry_path = os.path.join(datastore_path, entry)
 
@@ -82,22 +80,17 @@ def create_backup_tarball(datastore_path, update_number):
                 if entry.startswith('.') or entry.startswith('before-update-'):
                     continue
 
-                # Backup watch.json if exists
+                # Check if this directory has a watch.json (indicates it's a watch UUID directory)
                 watch_json = os.path.join(entry_path, "watch.json")
                 if os.path.isfile(watch_json):
+                    # Add the watch.json file preserving directory structure
                     tar.add(watch_json, arcname=f"{entry}/watch.json")
                     watch_count += 1
 
                     if watch_count % 100 == 0:
                         logger.debug(f"Backed up {watch_count} watch.json files...")
 
-                # Backup tag.json if exists
-                tag_json = os.path.join(entry_path, "tag.json")
-                if os.path.isfile(tag_json):
-                    tar.add(tag_json, arcname=f"{entry}/tag.json")
-                    tag_count += 1
-
-            logger.success(f"Backup created: {backup_filename} ({watch_count} watches, {tag_count} tags)")
+            logger.success(f"Backup created: {backup_filename} ({watch_count} watches)")
             return backup_path
 
     except Exception as e:
@@ -154,10 +147,10 @@ class DatastoreUpdatesMixin:
         2. For each update > current schema version:
            - Create backup of datastore
            - Run update method
-           - Update schema version and commit settings
-           - Commit all watches and tags
+           - Update schema version
+           - Mark settings and watches dirty
         3. If any update fails, stop processing
-        4. All changes saved via individual .commit() calls
+        4. Save all changes immediately
         """
         updates_available = self.get_updates_available()
 
@@ -175,7 +168,7 @@ class DatastoreUpdatesMixin:
                     latest_update = updates_available[-1] if updates_available else 0
                     logger.info(f"No schema version found and no watches exist - assuming fresh install, setting schema_version to {latest_update}")
                     self.data['settings']['application']['schema_version'] = latest_update
-                    self.commit()
+                    self.mark_settings_dirty()
                     return  # No updates needed for fresh install
                 else:
                     # Has watches but no schema version - likely old datastore, run all updates
@@ -206,11 +199,26 @@ class DatastoreUpdatesMixin:
                     # Don't run any more updates
                     return
                 else:
-                    # Bump the version
+                    # Bump the version, important
                     self.data['settings']['application']['schema_version'] = update_n
-                    self.commit()
+                    self.mark_settings_dirty()
 
-                    logger.success(f"Update {update_n} completed")
+                    # CRITICAL: Mark all watches as dirty so changes are persisted
+                    # Most updates modify watches, and in the new individual watch.json structure,
+                    # we need to ensure those changes are saved
+                    logger.info(f"Marking all {len(self.data['watching'])} watches as dirty after update_{update_n} (so that it saves them to disk)")
+                    for uuid in self.data['watching'].keys():
+                        self.mark_watch_dirty(uuid)
+
+                    # Save changes immediately after each update (more resilient than batching)
+                    logger.critical(f"Saving all changes after update_{update_n}")
+                    try:
+                        self._save_dirty_items()
+                        logger.success(f"Update {update_n} changes saved successfully")
+                    except Exception as e:
+                        logger.error(f"Failed to save update_{update_n} changes: {e}")
+                        # Don't raise - update already ran, but changes might not be persisted
+                        # The update will try to run again on next startup
 
                     # Track which updates ran
                     updates_ran.append(update_n)
@@ -460,14 +468,6 @@ class DatastoreUpdatesMixin:
                 del self.data['watching'][uuid]['extract_title_as_title']
 
         if self.data['settings']['application'].get('extract_title_as_title'):
-            # Ensure 'ui' key exists (defensive for edge cases where base_config merge didn't happen)
-            if 'ui' not in self.data['settings']['application']:
-                self.data['settings']['application']['ui'] = {
-                    'use_page_title_in_list': True,
-                    'open_diff_in_new_tab': True,
-                    'socket_io_enabled': True,
-                    'favicons_enabled': True
-                }
             self.data['settings']['application']['ui']['use_page_title_in_list'] = self.data['settings']['application'].get('extract_title_as_title')
 
     def update_21(self):
@@ -648,6 +648,23 @@ class DatastoreUpdatesMixin:
         logger.critical("Reloading datastore from new format...")
         self._load_state() # Includes load_watches
         logger.success("Datastore reloaded from new format successfully")
+
+
+        # Verify all watches have hashes after migration
+        missing_hashes = [uuid for uuid in self.data['watching'].keys() if uuid not in self._watch_hashes]
+        if missing_hashes:
+            logger.error(f"WARNING: {len(missing_hashes)} watches missing hashes after migration: {missing_hashes[:5]}")
+        else:
+            logger.success(f"All {len(self.data['watching'])} watches have valid hashes after migration")
+
+        # Set schema version to latest available update
+        # This prevents re-running updates and re-marking all watches as dirty
+        updates_available = self.get_updates_available()
+        latest_schema = updates_available[-1] if updates_available else 26
+        self.data['settings']['application']['schema_version'] = latest_schema
+        self.mark_settings_dirty()
+        logger.info(f"Set schema_version to {latest_schema} (migration complete, all watches already saved)")
+
         logger.critical("=" * 80)
         logger.critical("MIGRATION COMPLETED SUCCESSFULLY!")
         logger.critical("=" * 80)
@@ -666,76 +683,4 @@ class DatastoreUpdatesMixin:
         logger.info("")
 
     def update_26(self):
-        self.migrate_legacy_db_format()
-
-    def update_28(self):
-        """
-        Migrate tags to individual tag.json files.
-
-        Tags are currently saved only in changedetection.json (settings).
-        This migration ALSO saves them to individual {uuid}/tag.json files,
-        similar to how watches are stored (dual storage).
-
-        Benefits:
-        - Allows atomic tag updates without rewriting entire settings
-        - Enables independent tag versioning/backup
-        - Maintains backwards compatibility (tags stay in settings too)
-        """
-        logger.critical("=" * 80)
-        logger.critical("Running migration: Individual tag persistence (update_28)")
-        logger.critical("Creating individual tag.json files (tags remain in settings too)")
-        logger.critical("=" * 80)
-
-        tags = self.data['settings']['application'].get('tags', {})
-        tag_count = len(tags)
-
-        if tag_count == 0:
-            logger.info("No tags found, skipping migration")
-            return
-
-        logger.info(f"Migrating {tag_count} tags to individual tag.json files...")
-
-        saved_count = 0
-        failed_count = 0
-
-        for uuid, tag_data in tags.items():
-            try:
-                # Force save as tag.json (not watch.json) even if object is corrupted
-                from changedetectionio.store.file_saving_datastore import save_entity_atomic
-                import os
-
-                tag_dir = os.path.join(self.datastore_path, uuid)
-                os.makedirs(tag_dir, exist_ok=True)
-
-                # Convert to dict if it's an object
-                tag_dict = dict(tag_data) if hasattr(tag_data, '__iter__') else tag_data
-
-                # Save explicitly as tag.json
-                save_entity_atomic(
-                    tag_dir,
-                    uuid,
-                    tag_dict,
-                    filename='tag.json',
-                    entity_type='tag',
-                    max_size_mb=1
-                )
-                saved_count += 1
-
-                if saved_count % 10 == 0:
-                    logger.info(f"  Progress: {saved_count}/{tag_count} tags migrated...")
-
-            except Exception as e:
-                logger.error(f"Failed to save tag {uuid} ({tag_data.get('title', 'unknown')}): {e}")
-                failed_count += 1
-
-        if failed_count > 0:
-            logger.warning(f"Migration complete: {saved_count} tags saved, {failed_count} tags FAILED")
-        else:
-            logger.success(f"Migration complete: {saved_count} tags saved to individual tag.json files")
-
-        # Tags remain in settings for backwards compatibility AND easy access
-        # On next load, _load_tags() will read from tag.json files and merge with settings
-        logger.info("Tags saved to both settings AND individual tag.json files")
-        logger.info("Future tag edits will update both locations (dual storage)")
-
-        logger.critical("=" * 80)
+        self.migrate_legacy_db_format()

changedetectionio/tests/conftest.py

@@ -308,6 +308,10 @@ def prepare_test_function(live_server, datastore_path):
 
 
 
+    # Prevent background thread from writing during cleanup/reload
+    datastore.needs_write = False
+    datastore.needs_write_urgent = False
+
     # CRITICAL: Clean up any files from previous tests
     # This ensures a completely clean directory
     cleanup(datastore_path)
@@ -340,6 +344,7 @@ def prepare_test_function(live_server, datastore_path):
                 break
 
         datastore.data['watching'] = {}
+        datastore.needs_write = True
     except Exception as e:
         logger.warning(f"Error during datastore cleanup: {e}")
 

changedetectionio/tests/test_api.py

@@ -465,10 +465,7 @@ def test_api_watch_PUT_update(client, live_server, measure_memory_usage, datasto
 
     assert res.status_code == 400, "Should get error 400 when we give a field that doesnt exist"
     # Message will come from `flask_expects_json`
-    # With patternProperties for processor_config_*, the error message format changed slightly
-    assert (b'Additional properties are not allowed' in res.data or
-            b'does not match any of the regexes' in res.data), \
-            "Should reject unknown fields with schema validation error"
+    assert b'Additional properties are not allowed' in res.data
 
 
     # Try a XSS URL

changedetectionio/tests/test_api_openapi.py

@@ -80,10 +80,7 @@ def test_openapi_validation_invalid_field_in_request_body(client, live_server, m
     # Should get 400 error due to invalid field (this will be caught by internal validation)
     # Note: This tests the flow where OpenAPI validation passes but internal validation catches it
     assert res.status_code == 400, f"Expected 400 but got {res.status_code}"
-    # With patternProperties for processor_config_*, the error message format changed slightly
-    assert (b"Additional properties are not allowed" in res.data or
-            b"does not match any of the regexes" in res.data), \
-            "Should contain validation error about additional/invalid properties"
+    assert b"Additional properties are not allowed" in res.data, "Should contain validation error about additional properties"
 
 
 def test_openapi_validation_import_wrong_content_type(client, live_server, measure_memory_usage, datastore_path):

changedetectionio/tests/test_commit_persistence.py

@@ -1,661 +0,0 @@
-#!/usr/bin/env python3
-"""
-Tests for immediate commit-based persistence system.
-
-Tests cover:
-- Watch.commit() persistence to disk
-- Concurrent commit safety (race conditions)
-- Processor config separation
-- Data loss prevention (settings, tags, watch modifications)
-"""
-
-import json
-import os
-import threading
-import time
-from flask import url_for
-from .util import wait_for_all_checks
-
-
-# ==============================================================================
-# 2. Commit() Persistence Tests
-# ==============================================================================
-
-def test_watch_commit_persists_to_disk(client, live_server):
-    """Test that watch.commit() actually writes to watch.json immediately"""
-    datastore = client.application.config.get('DATASTORE')
-
-    # Create a watch
-    uuid = datastore.add_watch(url='http://example.com', extras={'title': 'Original Title'})
-    watch = datastore.data['watching'][uuid]
-
-    # Modify and commit
-    watch['title'] = 'Modified Title'
-    watch['paused'] = True
-    watch.commit()
-
-    # Read directly from disk (bypass datastore cache)
-    watch_json_path = os.path.join(watch.data_dir, 'watch.json')
-    assert os.path.exists(watch_json_path), "watch.json should exist on disk"
-
-    with open(watch_json_path, 'r') as f:
-        disk_data = json.load(f)
-
-    assert disk_data['title'] == 'Modified Title', "Title should be persisted to disk"
-    assert disk_data['paused'] == True, "Paused state should be persisted to disk"
-    assert disk_data['uuid'] == uuid, "UUID should match"
-
-
-def test_watch_commit_survives_reload(client, live_server):
-    """Test that committed changes survive datastore reload"""
-    from changedetectionio.store import ChangeDetectionStore
-
-    datastore = client.application.config.get('DATASTORE')
-    datastore_path = datastore.datastore_path
-
-    # Create and modify a watch
-    uuid = datastore.add_watch(url='http://example.com', extras={'title': 'Test Watch'})
-    watch = datastore.data['watching'][uuid]
-    watch['title'] = 'Persisted Title'
-    watch['paused'] = True
-    watch['tags'] = ['tag-1', 'tag-2']
-    watch.commit()
-
-    # Simulate app restart - create new datastore instance
-    datastore2 = ChangeDetectionStore(datastore_path=datastore_path)
-    datastore2.reload_state(
-        datastore_path=datastore_path,
-        include_default_watches=False,
-        version_tag='test'
-    )
-
-    # Check data survived
-    assert uuid in datastore2.data['watching'], "Watch should exist after reload"
-    reloaded_watch = datastore2.data['watching'][uuid]
-    assert reloaded_watch['title'] == 'Persisted Title', "Title should survive reload"
-    assert reloaded_watch['paused'] == True, "Paused state should survive reload"
-    assert reloaded_watch['tags'] == ['tag-1', 'tag-2'], "Tags should survive reload"
-
-
-def test_watch_commit_atomic_on_crash(client, live_server):
-    """Test that atomic writes prevent corruption (temp file pattern)"""
-    datastore = client.application.config.get('DATASTORE')
-
-    uuid = datastore.add_watch(url='http://example.com', extras={'title': 'Original'})
-    watch = datastore.data['watching'][uuid]
-
-    # First successful commit
-    watch['title'] = 'First Save'
-    watch.commit()
-
-    # Verify watch.json exists and is valid
-    watch_json_path = os.path.join(watch.data_dir, 'watch.json')
-    with open(watch_json_path, 'r') as f:
-        data = json.load(f)  # Should not raise JSONDecodeError
-        assert data['title'] == 'First Save'
-
-    # Second commit - even if interrupted, original file should be intact
-    # (atomic write uses temp file + rename, so original is never corrupted)
-    watch['title'] = 'Second Save'
-    watch.commit()
-
-    with open(watch_json_path, 'r') as f:
-        data = json.load(f)
-        assert data['title'] == 'Second Save'
-
-
-def test_multiple_watches_commit_independently(client, live_server):
-    """Test that committing one watch doesn't affect others"""
-    datastore = client.application.config.get('DATASTORE')
-
-    # Create multiple watches
-    uuid1 = datastore.add_watch(url='http://example1.com', extras={'title': 'Watch 1'})
-    uuid2 = datastore.add_watch(url='http://example2.com', extras={'title': 'Watch 2'})
-    uuid3 = datastore.add_watch(url='http://example3.com', extras={'title': 'Watch 3'})
-
-    watch1 = datastore.data['watching'][uuid1]
-    watch2 = datastore.data['watching'][uuid2]
-    watch3 = datastore.data['watching'][uuid3]
-
-    # Modify and commit only watch2
-    watch2['title'] = 'Modified Watch 2'
-    watch2['paused'] = True
-    watch2.commit()
-
-    # Read all from disk
-    def read_watch_json(uuid):
-        watch = datastore.data['watching'][uuid]
-        path = os.path.join(watch.data_dir, 'watch.json')
-        with open(path, 'r') as f:
-            return json.load(f)
-
-    data1 = read_watch_json(uuid1)
-    data2 = read_watch_json(uuid2)
-    data3 = read_watch_json(uuid3)
-
-    # Only watch2 should have changes
-    assert data1['title'] == 'Watch 1', "Watch 1 should be unchanged"
-    assert data1['paused'] == False, "Watch 1 should not be paused"
-
-    assert data2['title'] == 'Modified Watch 2', "Watch 2 should be modified"
-    assert data2['paused'] == True, "Watch 2 should be paused"
-
-    assert data3['title'] == 'Watch 3', "Watch 3 should be unchanged"
-    assert data3['paused'] == False, "Watch 3 should not be paused"
-
-
-# ==============================================================================
-# 3. Concurrency/Race Condition Tests
-# ==============================================================================
-
-def test_concurrent_watch_commits_dont_corrupt(client, live_server):
-    """Test that simultaneous commits to same watch don't corrupt JSON"""
-    datastore = client.application.config.get('DATASTORE')
-
-    uuid = datastore.add_watch(url='http://example.com', extras={'title': 'Test'})
-    watch = datastore.data['watching'][uuid]
-
-    errors = []
-
-    def modify_and_commit(field, value):
-        try:
-            watch[field] = value
-            watch.commit()
-        except Exception as e:
-            errors.append(e)
-
-    # Run 10 concurrent commits
-    threads = []
-    for i in range(10):
-        t = threading.Thread(target=modify_and_commit, args=('title', f'Title {i}'))
-        threads.append(t)
-        t.start()
-
-    for t in threads:
-        t.join()
-
-    # Should not have any errors
-    assert len(errors) == 0, f"Expected no errors, got: {errors}"
-
-    # JSON file should still be valid (not corrupted)
-    watch_json_path = os.path.join(watch.data_dir, 'watch.json')
-    with open(watch_json_path, 'r') as f:
-        data = json.load(f)  # Should not raise JSONDecodeError
-        assert data['uuid'] == uuid, "UUID should still be correct"
-        assert 'Title' in data['title'], "Title should contain 'Title'"
-
-
-def test_concurrent_modifications_during_commit(client, live_server):
-    """Test that modifying watch during commit doesn't cause RuntimeError"""
-    datastore = client.application.config.get('DATASTORE')
-
-    uuid = datastore.add_watch(url='http://example.com', extras={'title': 'Test'})
-    watch = datastore.data['watching'][uuid]
-
-    errors = []
-    stop_flag = threading.Event()
-
-    def keep_modifying():
-        """Continuously modify watch"""
-        try:
-            i = 0
-            while not stop_flag.is_set():
-                watch['title'] = f'Title {i}'
-                watch['paused'] = i % 2 == 0
-                i += 1
-                time.sleep(0.001)
-        except Exception as e:
-            errors.append(('modifier', e))
-
-    def keep_committing():
-        """Continuously commit watch"""
-        try:
-            for _ in range(20):
-                watch.commit()
-                time.sleep(0.005)
-        except Exception as e:
-            errors.append(('committer', e))
-
-    # Start concurrent modification and commits
-    modifier = threading.Thread(target=keep_modifying)
-    committer = threading.Thread(target=keep_committing)
-
-    modifier.start()
-    committer.start()
-
-    committer.join()
-    stop_flag.set()
-    modifier.join()
-
-    # Should not have RuntimeError from dict changing during iteration
-    runtime_errors = [e for source, e in errors if isinstance(e, RuntimeError)]
-    assert len(runtime_errors) == 0, f"Should not have RuntimeError, got: {runtime_errors}"
-
-
-def test_datastore_lock_protects_commit_snapshot(client, live_server):
-    """Test that datastore.lock prevents race conditions during deepcopy"""
-    datastore = client.application.config.get('DATASTORE')
-
-    uuid = datastore.add_watch(url='http://example.com', extras={'title': 'Test'})
-    watch = datastore.data['watching'][uuid]
-
-    # Add some complex nested data
-    watch['browser_steps'] = [
-        {'operation': 'click', 'selector': '#foo'},
-        {'operation': 'wait', 'seconds': 5}
-    ]
-
-    errors = []
-    commits_succeeded = [0]
-
-    def rapid_commits():
-        try:
-            for i in range(50):
-                watch['title'] = f'Title {i}'
-                watch.commit()
-                commits_succeeded[0] += 1
-                time.sleep(0.001)
-        except Exception as e:
-            errors.append(e)
-
-    # Multiple threads doing rapid commits
-    threads = [threading.Thread(target=rapid_commits) for _ in range(3)]
-
-    for t in threads:
-        t.start()
-    for t in threads:
-        t.join()
-
-    assert len(errors) == 0, f"Expected no errors, got: {errors}"
-    assert commits_succeeded[0] == 150, f"Expected 150 commits, got {commits_succeeded[0]}"
-
-    # Final JSON should be valid
-    watch_json_path = os.path.join(watch.data_dir, 'watch.json')
-    with open(watch_json_path, 'r') as f:
-        data = json.load(f)
-        assert data['uuid'] == uuid
-
-
-# ==============================================================================
-# 4. Processor Config Separation Tests
-# ==============================================================================
-
-def test_processor_config_never_in_watch_json(client, live_server):
-    """Test that processor_config_* fields are filtered out of watch.json"""
-    datastore = client.application.config.get('DATASTORE')
-
-    uuid = datastore.add_watch(
-        url='http://example.com',
-        extras={
-            'title': 'Test Watch',
-            'processor': 'restock_diff'
-        }
-    )
-
-    watch = datastore.data['watching'][uuid]
-
-    # Try to set processor config fields (these should be filtered during commit)
-    watch['processor_config_price_threshold'] = 10.0
-    watch['processor_config_some_setting'] = 'value'
-    watch['processor_config_another'] = {'nested': 'data'}
-    watch.commit()
-
-    # Read watch.json from disk
-    watch_json_path = os.path.join(watch.data_dir, 'watch.json')
-    with open(watch_json_path, 'r') as f:
-        data = json.load(f)
-
-    # Verify processor_config_* fields are NOT in watch.json
-    for key in data.keys():
-        assert not key.startswith('processor_config_'), \
-            f"Found {key} in watch.json - processor configs should be in separate file!"
-
-    # Normal fields should still be there
-    assert data['title'] == 'Test Watch'
-    assert data['processor'] == 'restock_diff'
-
-
-def test_api_post_saves_processor_config_separately(client, live_server):
-    """Test that API POST saves processor configs to {processor}.json"""
-    import json
-    from changedetectionio.processors import extract_processor_config_from_form_data
-
-    # Get API key
-    api_key = live_server.app.config['DATASTORE'].data['settings']['application'].get('api_access_token')
-
-    # Create watch via API with processor config
-    response = client.post(
-        url_for("createwatch"),
-        data=json.dumps({
-            'url': 'http://example.com',
-            'processor': 'restock_diff',
-            'processor_config_price_threshold': 10.0,
-            'processor_config_in_stock_only': True
-        }),
-        headers={'content-type': 'application/json', 'x-api-key': api_key}
-    )
-
-    assert response.status_code in (200, 201), f"Expected 200/201, got {response.status_code}"
-    uuid = response.json.get('uuid')
-    assert uuid, "Should return UUID"
-
-    datastore = client.application.config.get('DATASTORE')
-    watch = datastore.data['watching'][uuid]
-
-    # Check that processor config file exists
-    processor_config_path = os.path.join(watch.data_dir, 'restock_diff.json')
-    assert os.path.exists(processor_config_path), "Processor config file should exist"
-
-    with open(processor_config_path, 'r') as f:
-        config = json.load(f)
-
-    # Verify fields are saved WITHOUT processor_config_ prefix
-    assert config.get('price_threshold') == 10.0, "Should have price_threshold (no prefix)"
-    assert config.get('in_stock_only') == True, "Should have in_stock_only (no prefix)"
-    assert 'processor_config_price_threshold' not in config, "Should NOT have prefixed keys"
-
-
-def test_api_put_saves_processor_config_separately(client, live_server):
-    """Test that API PUT updates processor configs in {processor}.json"""
-    import json
-    datastore = client.application.config.get('DATASTORE')
-
-    # Get API key
-    api_key = live_server.app.config['DATASTORE'].data['settings']['application'].get('api_access_token')
-
-    # Create watch
-    uuid = datastore.add_watch(
-        url='http://example.com',
-        extras={'processor': 'restock_diff'}
-    )
-
-    # Update via API with processor config
-    response = client.put(
-        url_for("watch", uuid=uuid),
-        data=json.dumps({
-            'processor_config_price_threshold': 15.0,
-            'processor_config_min_stock': 5
-        }),
-        headers={'content-type': 'application/json', 'x-api-key': api_key}
-    )
-
-    # PUT might return different status codes, 200 or 204 are both OK
-    assert response.status_code in (200, 204), f"Expected 200/204, got {response.status_code}: {response.data}"
-
-    watch = datastore.data['watching'][uuid]
-
-    # Check processor config file
-    processor_config_path = os.path.join(watch.data_dir, 'restock_diff.json')
-    assert os.path.exists(processor_config_path), "Processor config file should exist"
-
-    with open(processor_config_path, 'r') as f:
-        config = json.load(f)
-
-    assert config.get('price_threshold') == 15.0, "Should have updated price_threshold"
-    assert config.get('min_stock') == 5, "Should have min_stock"
-
-
-def test_ui_edit_saves_processor_config_separately(client, live_server):
-    """Test that processor_config_* fields never appear in watch.json (even from UI)"""
-    datastore = client.application.config.get('DATASTORE')
-
-    # Create watch
-    uuid = datastore.add_watch(
-        url='http://example.com',
-        extras={'processor': 'text_json_diff', 'title': 'Test'}
-    )
-
-    watch = datastore.data['watching'][uuid]
-
-    # Simulate someone accidentally trying to set processor_config fields directly
-    watch['processor_config_should_not_save'] = 'test_value'
-    watch['processor_config_another_field'] = 123
-    watch['normal_field'] = 'this_should_save'
-    watch.commit()
-
-    # Check watch.json has NO processor_config_* fields (main point of this test)
-    watch_json_path = os.path.join(watch.data_dir, 'watch.json')
-    with open(watch_json_path, 'r') as f:
-        watch_data = json.load(f)
-
-    for key in watch_data.keys():
-        assert not key.startswith('processor_config_'), \
-            f"Found {key} in watch.json - processor configs should be filtered during commit"
-
-    # Verify normal fields still save
-    assert watch_data['normal_field'] == 'this_should_save', "Normal fields should save"
-    assert watch_data['title'] == 'Test', "Original fields should still be there"
-
-
-def test_browser_steps_normalized_to_empty_list(client, live_server):
-    """Test that meaningless browser_steps are normalized to [] during commit"""
-    datastore = client.application.config.get('DATASTORE')
-
-    uuid = datastore.add_watch(url='http://example.com')
-    watch = datastore.data['watching'][uuid]
-
-    # Set browser_steps to meaningless values
-    watch['browser_steps'] = [
-        {'operation': 'Choose one', 'selector': ''},
-        {'operation': 'Goto site', 'selector': ''},
-        {'operation': '', 'selector': '#foo'}
-    ]
-    watch.commit()
-
-    # Read from disk
-    watch_json_path = os.path.join(watch.data_dir, 'watch.json')
-    with open(watch_json_path, 'r') as f:
-        data = json.load(f)
-
-    # Should be normalized to empty list
-    assert data['browser_steps'] == [], "Meaningless browser_steps should be normalized to []"
-
-
-# ==============================================================================
-# 5. Data Loss Prevention Tests
-# ==============================================================================
-
-def test_settings_persist_after_update(client, live_server):
-    """Test that settings updates are committed and survive restart"""
-    from changedetectionio.store import ChangeDetectionStore
-
-    datastore = client.application.config.get('DATASTORE')
-    datastore_path = datastore.datastore_path
-
-    # Update settings directly (bypass form validation issues)
-    datastore.data['settings']['application']['empty_pages_are_a_change'] = True
-    datastore.data['settings']['application']['fetch_backend'] = 'html_requests'
-    datastore.data['settings']['requests']['time_between_check']['minutes'] = 120
-    datastore.commit()
-
-    # Simulate restart
-    datastore2 = ChangeDetectionStore(datastore_path=datastore_path)
-    datastore2.reload_state(
-        datastore_path=datastore_path,
-        include_default_watches=False,
-        version_tag='test'
-    )
-
-    # Verify settings survived
-    assert datastore2.data['settings']['application']['empty_pages_are_a_change'] == True, "empty_pages_are_a_change should persist"
-    assert datastore2.data['settings']['application']['fetch_backend'] == 'html_requests', "fetch_backend should persist"
-    assert datastore2.data['settings']['requests']['time_between_check']['minutes'] == 120, "time_between_check should persist"
-
-
-def test_tag_mute_persists(client, live_server):
-    """Test that tag mute/unmute operations persist"""
-    from changedetectionio.store import ChangeDetectionStore
-
-    datastore = client.application.config.get('DATASTORE')
-    datastore_path = datastore.datastore_path
-
-    # Add a tag
-    tag_uuid = datastore.add_tag('Test Tag')
-
-    # Mute the tag
-    response = client.get(url_for("tags.mute", uuid=tag_uuid))
-    assert response.status_code == 302  # Redirect
-
-    # Verify muted in memory
-    assert datastore.data['settings']['application']['tags'][tag_uuid]['notification_muted'] == True
-
-    # Simulate restart
-    datastore2 = ChangeDetectionStore(datastore_path=datastore_path)
-    datastore2.reload_state(
-        datastore_path=datastore_path,
-        include_default_watches=False,
-        version_tag='test'
-    )
-
-    # Verify mute state survived
-    assert tag_uuid in datastore2.data['settings']['application']['tags']
-    assert datastore2.data['settings']['application']['tags'][tag_uuid]['notification_muted'] == True
-
-
-def test_tag_delete_removes_from_watches(client, live_server):
-    """Test that deleting a tag removes it from all watches"""
-    datastore = client.application.config.get('DATASTORE')
-
-    # Create a tag
-    tag_uuid = datastore.add_tag('Test Tag')
-
-    # Create watches with this tag
-    uuid1 = datastore.add_watch(url='http://example1.com')
-    uuid2 = datastore.add_watch(url='http://example2.com')
-    uuid3 = datastore.add_watch(url='http://example3.com')
-
-    watch1 = datastore.data['watching'][uuid1]
-    watch2 = datastore.data['watching'][uuid2]
-    watch3 = datastore.data['watching'][uuid3]
-
-    watch1['tags'] = [tag_uuid]
-    watch1.commit()
-    watch2['tags'] = [tag_uuid, 'other-tag']
-    watch2.commit()
-    # watch3 has no tags
-
-    # Delete the tag
-    response = client.get(url_for("tags.delete", uuid=tag_uuid))
-    assert response.status_code == 302
-
-    # Wait for background thread to complete
-    time.sleep(1)
-
-    # Tag should be removed from settings
-    assert tag_uuid not in datastore.data['settings']['application']['tags']
-
-    # Tag should be removed from watches and persisted
-    def check_watch_tags(uuid):
-        watch = datastore.data['watching'][uuid]
-        watch_json_path = os.path.join(watch.data_dir, 'watch.json')
-        with open(watch_json_path, 'r') as f:
-            return json.load(f)['tags']
-
-    assert tag_uuid not in check_watch_tags(uuid1), "Tag should be removed from watch1"
-    assert tag_uuid not in check_watch_tags(uuid2), "Tag should be removed from watch2"
-    assert 'other-tag' in check_watch_tags(uuid2), "Other tags should remain in watch2"
-    assert check_watch_tags(uuid3) == [], "Watch3 should still have empty tags"
-
-
-def test_watch_pause_unpause_persists(client, live_server):
-    """Test that pause/unpause operations commit and persist"""
-    datastore = client.application.config.get('DATASTORE')
-
-    # Get API key
-    api_key = live_server.app.config['DATASTORE'].data['settings']['application'].get('api_access_token')
-
-    uuid = datastore.add_watch(url='http://example.com')
-    watch = datastore.data['watching'][uuid]
-
-    # Pause via API
-    response = client.get(url_for("watch", uuid=uuid, paused='paused'), headers={'x-api-key': api_key})
-    assert response.status_code == 200
-
-    # Check persisted to disk
-    watch_json_path = os.path.join(watch.data_dir, 'watch.json')
-    with open(watch_json_path, 'r') as f:
-        data = json.load(f)
-    assert data['paused'] == True, "Pause should be persisted"
-
-    # Unpause
-    response = client.get(url_for("watch", uuid=uuid, paused='unpaused'), headers={'x-api-key': api_key})
-    assert response.status_code == 200
-
-    with open(watch_json_path, 'r') as f:
-        data = json.load(f)
-    assert data['paused'] == False, "Unpause should be persisted"
-
-
-def test_watch_mute_unmute_persists(client, live_server):
-    """Test that mute/unmute operations commit and persist"""
-    datastore = client.application.config.get('DATASTORE')
-
-    # Get API key
-    api_key = live_server.app.config['DATASTORE'].data['settings']['application'].get('api_access_token')
-
-    uuid = datastore.add_watch(url='http://example.com')
-    watch = datastore.data['watching'][uuid]
-
-    # Mute via API
-    response = client.get(url_for("watch", uuid=uuid, muted='muted'), headers={'x-api-key': api_key})
-    assert response.status_code == 200
-
-    # Check persisted to disk
-    watch_json_path = os.path.join(watch.data_dir, 'watch.json')
-    with open(watch_json_path, 'r') as f:
-        data = json.load(f)
-    assert data['notification_muted'] == True, "Mute should be persisted"
-
-    # Unmute
-    response = client.get(url_for("watch", uuid=uuid, muted='unmuted'), headers={'x-api-key': api_key})
-    assert response.status_code == 200
-
-    with open(watch_json_path, 'r') as f:
-        data = json.load(f)
-    assert data['notification_muted'] == False, "Unmute should be persisted"
-
-
-def test_ui_watch_edit_persists_all_fields(client, live_server):
-    """Test that UI watch edit form persists all modified fields"""
-    from changedetectionio.store import ChangeDetectionStore
-
-    datastore = client.application.config.get('DATASTORE')
-    datastore_path = datastore.datastore_path
-
-    # Create watch
-    uuid = datastore.add_watch(url='http://example.com')
-
-    # Edit via UI with multiple field changes
-    response = client.post(
-        url_for("ui.ui_edit.edit_page", uuid=uuid),
-        data={
-            'url': 'http://updated-example.com',
-            'title': 'Updated Watch Title',
-            'time_between_check-hours': '2',
-            'time_between_check-minutes': '30',
-            'include_filters': '#content',
-            'fetch_backend': 'html_requests',
-            'method': 'POST',
-            'ignore_text': 'Advertisement\nTracking'
-        },
-        follow_redirects=True
-    )
-
-    assert b"Updated watch" in response.data or b"Saved" in response.data
-
-    # Simulate restart
-    datastore2 = ChangeDetectionStore(datastore_path=datastore_path)
-    datastore2.reload_state(
-        datastore_path=datastore_path,
-        include_default_watches=False,
-        version_tag='test'
-    )
-
-    # Verify all fields survived
-    watch = datastore2.data['watching'][uuid]
-    assert watch['url'] == 'http://updated-example.com'
-    assert watch['title'] == 'Updated Watch Title'
-    assert watch['time_between_check']['hours'] == 2
-    assert watch['time_between_check']['minutes'] == 30
-    assert watch['fetch_backend'] == 'html_requests'
-    assert watch['method'] == 'POST'

changedetectionio/tests/test_group.py

@@ -474,147 +474,3 @@ the {test} appeared before. {test in res.data[:n]=}
         n += t_index + len(test)
 
     delete_all_watches(client)
-
-
-def test_tag_json_persistence(client, live_server, measure_memory_usage, datastore_path):
-    """
-    Test that tags are saved to individual tag.json files and loaded correctly.
-
-    This test verifies the update_27 tag storage refactoring:
-    - Tags are saved to {uuid}/tag.json files
-    - Tags persist across datastore restarts
-    - Tag edits write to tag.json
-    - Tag deletion removes tag.json file
-    """
-    import json
-    from changedetectionio.store import ChangeDetectionStore
-
-    datastore = client.application.config.get('DATASTORE')
-
-    # 1. Create a tag
-    res = client.post(
-        url_for("tags.form_tag_add"),
-        data={"name": "persistence-test-tag"},
-        follow_redirects=True
-    )
-    assert b"Tag added" in res.data
-
-    tag_uuid = get_UUID_for_tag_name(client, name="persistence-test-tag")
-    assert tag_uuid, "Tag UUID should exist"
-
-    # 2. Verify tag.json file was created
-    tag_json_path = os.path.join(datastore_path, tag_uuid, "tag.json")
-    assert os.path.exists(tag_json_path), f"tag.json should exist at {tag_json_path}"
-
-    # 3. Verify tag.json contains correct data
-    with open(tag_json_path, 'r') as f:
-        tag_data = json.load(f)
-    assert tag_data['title'] == 'persistence-test-tag'
-    assert tag_data['uuid'] == tag_uuid
-    assert 'date_created' in tag_data
-
-    # 4. Edit the tag
-    res = client.post(
-        url_for("tags.form_tag_edit_submit", uuid=tag_uuid),
-        data={
-            "name": "persistence-test-tag",
-            "notification_muted": True,
-            "include_filters": '#test-filter'
-        },
-        follow_redirects=True
-    )
-    assert b"Updated" in res.data
-
-    # 5. Verify tag.json was updated
-    with open(tag_json_path, 'r') as f:
-        tag_data = json.load(f)
-    assert tag_data['notification_muted'] == True
-    assert '#test-filter' in tag_data.get('include_filters', [])
-
-    # 5a. Verify tag is NOT in changedetection.json (tags should be in tag.json only)
-    changedetection_json_path = os.path.join(datastore_path, "changedetection.json")
-    with open(changedetection_json_path, 'r') as f:
-        settings_data = json.load(f)
-    # Tags dict should be empty in settings (all tags are in individual files)
-    assert settings_data['settings']['application']['tags'] == {}, \
-        "Tags should NOT be saved to changedetection.json (should be empty dict)"
-
-    # 6. Simulate restart - reload datastore
-    datastore2 = ChangeDetectionStore(datastore_path=datastore_path, include_default_watches=False, version_tag='test')
-
-    # 7. Verify tag was loaded from tag.json
-    assert tag_uuid in datastore2.data['settings']['application']['tags']
-    loaded_tag = datastore2.data['settings']['application']['tags'][tag_uuid]
-    assert loaded_tag['title'] == 'persistence-test-tag'
-    assert loaded_tag['notification_muted'] == True
-    assert '#test-filter' in loaded_tag.get('include_filters', [])
-
-    # 8. Delete the tag via API
-    res = client.get(url_for("tags.delete", uuid=tag_uuid), follow_redirects=True)
-    assert b"Tag deleted" in res.data
-
-    # 9. Verify tag.json file was deleted
-    assert not os.path.exists(tag_json_path), f"tag.json should be deleted at {tag_json_path}"
-
-    # 10. Verify tag is removed from settings
-    assert tag_uuid not in datastore.data['settings']['application']['tags']
-
-    delete_all_watches(client)
-
-
-def test_tag_json_migration_update_27(client, live_server, measure_memory_usage, datastore_path):
-    """
-    Test that update_27 migration correctly moves tags to individual files.
-
-    This simulates a pre-update_27 datastore and verifies migration works.
-    """
-    import json
-    from changedetectionio.store import ChangeDetectionStore
-
-    datastore = client.application.config.get('DATASTORE')
-
-    # 1. Create multiple tags
-    tag_names = ['migration-tag-1', 'migration-tag-2', 'migration-tag-3']
-    tag_uuids = []
-
-    for tag_name in tag_names:
-        res = client.post(
-            url_for("tags.form_tag_add"),
-            data={"name": tag_name},
-            follow_redirects=True
-        )
-        assert b"Tag added" in res.data
-        tag_uuid = get_UUID_for_tag_name(client, name=tag_name)
-        tag_uuids.append(tag_uuid)
-
-    # 2. Verify all tag.json files exist (update_27 already ran during add_tag)
-    for tag_uuid in tag_uuids:
-        tag_json_path = os.path.join(datastore_path, tag_uuid, "tag.json")
-        assert os.path.exists(tag_json_path), f"tag.json should exist for {tag_uuid}"
-
-    # 2a. Verify tags are NOT in changedetection.json
-    changedetection_json_path = os.path.join(datastore_path, "changedetection.json")
-    with open(changedetection_json_path, 'r') as f:
-        settings_data = json.load(f)
-    assert settings_data['settings']['application']['tags'] == {}, \
-        "Tags should NOT be in changedetection.json after migration"
-
-    # 3. Simulate restart
-    datastore2 = ChangeDetectionStore(datastore_path=datastore_path, include_default_watches=False, version_tag='test')
-
-    # 4. Verify all tags loaded from tag.json files
-    for idx, tag_uuid in enumerate(tag_uuids):
-        assert tag_uuid in datastore2.data['settings']['application']['tags']
-        loaded_tag = datastore2.data['settings']['application']['tags'][tag_uuid]
-        assert loaded_tag['title'] == tag_names[idx]
-
-    # Cleanup
-    res = client.get(url_for("tags.delete_all"), follow_redirects=True)
-    assert b'All tags deleted' in res.data
-
-    # Verify all tag.json files were deleted
-    for tag_uuid in tag_uuids:
-        tag_json_path = os.path.join(datastore_path, tag_uuid, "tag.json")
-        assert not os.path.exists(tag_json_path), f"tag.json should be deleted for {tag_uuid}"
-
-    delete_all_watches(client)

changedetectionio/tests/test_history_consistency.py

@@ -182,86 +182,3 @@ def test_check_text_history_view(client, live_server, measure_memory_usage, data
     assert b'test-one' not in res.data
 
     delete_all_watches(client)
-
-
-def test_history_trim_global_only(client, live_server, measure_memory_usage, datastore_path):
-    # Add our URL to the import page
-    test_url = url_for('test_endpoint', _external=True)
-    uuid = None
-    limit = 3
-
-    for i in range(0, 10):
-        with open(os.path.join(datastore_path, "endpoint-content.txt"), "w") as f:
-            f.write(f"<html>test {i}</html>")
-        if not uuid:
-            uuid = client.application.config.get('DATASTORE').add_watch(url=test_url)
-        client.get(url_for("ui.form_watch_checknow"), follow_redirects=True)
-        wait_for_all_checks(client)
-
-        if i ==8:
-            watch = live_server.app.config['DATASTORE'].data['watching'][uuid]
-            history_n = len(list(watch.history.keys()))
-            logger.debug(f"History length should be at limit {limit} and it is {history_n}")
-            assert history_n == limit
-
-        if i == 6:
-            res = client.post(
-                url_for("settings.settings_page"),
-                data={"application-history_snapshot_max_length": limit},
-                follow_redirects=True
-            )
-            # It will need to detect one more change to start trimming it, which is really at 'start of 7'
-            assert b'Settings updated' in res.data
-
-    delete_all_watches(client)
-
-
-def test_history_trim_global_override_in_watch(client, live_server, measure_memory_usage, datastore_path):
-    # Add our URL to the import page
-    test_url = url_for('test_endpoint', _external=True)
-    uuid = None
-    limit = 3
-    res = client.post(
-        url_for("settings.settings_page"),
-        data={"application-history_snapshot_max_length": 10000},
-        follow_redirects=True
-    )
-    # It will need to detect one more change to start trimming it, which is really at 'start of 7'
-    assert b'Settings updated' in res.data
-
-
-    for i in range(0, 10):
-        with open(os.path.join(datastore_path, "endpoint-content.txt"), "w") as f:
-            f.write(f"<html>test {i}</html>")
-        if not uuid:
-            uuid = client.application.config.get('DATASTORE').add_watch(url=test_url)
-            res = client.post(
-                url_for("ui.ui_edit.edit_page", uuid="first"),
-                data={"include_filters": "", "url": test_url, "tags": "", "headers": "", 'fetch_backend': "html_requests",
-                      "time_between_check_use_default": "y", "history_snapshot_max_length": str(limit)},
-                follow_redirects=True
-            )
-            assert b"Updated watch." in res.data
-
-            wait_for_all_checks(client)
-
-        client.get(url_for("ui.form_watch_checknow"), follow_redirects=True)
-        wait_for_all_checks(client)
-
-        if i == 8:
-            watch = live_server.app.config['DATASTORE'].data['watching'][uuid]
-            history_n = len(list(watch.history.keys()))
-            logger.debug(f"History length should be at limit {limit} and it is {history_n}")
-            assert history_n == limit
-
-        if i == 6:
-            res = client.post(
-                url_for("settings.settings_page"),
-                data={"application-history_snapshot_max_length": limit},
-                follow_redirects=True
-            )
-            # It will need to detect one more change to start trimming it, which is really at 'start of 7'
-            assert b'Settings updated' in res.data
-
-    delete_all_watches(client)
-

changedetectionio/tests/unit/test_watch_model.py

@@ -5,24 +5,15 @@
 
 import unittest
 import os
-import pickle
-from copy import deepcopy
 
-from changedetectionio.model import Watch, Tag
+from changedetectionio.model import Watch
 
 # mostly
 class TestDiffBuilder(unittest.TestCase):
 
     def test_watch_get_suggested_from_diff_timestamp(self):
         import uuid as uuid_builder
-        # Create minimal mock datastore for tests
-        mock_datastore = {
-            'settings': {
-                'application': {}
-            },
-            'watching': {}
-        }
-        watch = Watch.model(datastore_path='/tmp', __datastore=mock_datastore, default={})
+        watch = Watch.model(datastore_path='/tmp', default={})
         watch.ensure_data_dir_exists()
 
 
@@ -58,7 +49,7 @@ class TestDiffBuilder(unittest.TestCase):
         assert p == "109", "Correct when its the same time"
 
         # new empty one
-        watch = Watch.model(datastore_path='/tmp', __datastore=mock_datastore, default={})
+        watch = Watch.model(datastore_path='/tmp', default={})
         p = watch.get_from_version_based_on_last_viewed
         assert p == None, "None when no history available"
 
@@ -70,184 +61,5 @@ class TestDiffBuilder(unittest.TestCase):
         p = watch.get_from_version_based_on_last_viewed
         assert p == "100", "Correct with only one history snapshot"
 
-    def test_watch_deepcopy_doesnt_copy_datastore(self):
-        """
-        CRITICAL: Ensure deepcopy(watch) shares __datastore instead of copying it.
-
-        Without this, deepcopy causes exponential memory growth:
-        - 100 watches × deepcopy each = 10,000 watch objects in memory (100²)
-        - Memory grows from 120MB → 2GB
-
-        This test prevents regressions in the __deepcopy__ implementation.
-        """
-        # Create mock datastore with multiple watches
-        mock_datastore = {
-            'settings': {'application': {'history_snapshot_max_length': 10}},
-            'watching': {}
-        }
-
-        # Create 3 watches that all reference the same datastore
-        watches = []
-        for i in range(3):
-            watch = Watch.model(
-                __datastore=mock_datastore,
-                datastore_path='/tmp/test',
-                default={'url': f'https://example{i}.com', 'title': f'Watch {i}'}
-            )
-            mock_datastore['watching'][watch['uuid']] = watch
-            watches.append(watch)
-
-        # Test 1: Deepcopy shares datastore reference (doesn't copy it)
-        watch_copy = deepcopy(watches[0])
-
-        self.assertIsNotNone(watch_copy._datastore,
-                            "__datastore should exist in copied watch")
-        self.assertIs(watch_copy._datastore, watches[0]._datastore,
-                     "__datastore should be SHARED (same object), not copied")
-        self.assertIs(watch_copy._datastore, mock_datastore,
-                     "__datastore should reference the original datastore")
-
-        # Test 2: Dict data is properly copied (not shared)
-        self.assertEqual(watch_copy['title'], 'Watch 0', "Dict data should be copied")
-        watch_copy['title'] = 'MODIFIED'
-        self.assertNotEqual(watches[0]['title'], 'MODIFIED',
-                           "Modifying copy should not affect original")
-
-        # Test 3: Verify no nested datastore copies in watch dict
-        # The dict should only contain watch settings, not the datastore
-        watch_dict = dict(watch_copy)
-        self.assertNotIn('__datastore', watch_dict,
-                        "__datastore should not be in dict keys")
-        self.assertNotIn('_model__datastore', watch_dict,
-                        "_model__datastore should not be in dict keys")
-
-        # Test 4: Multiple deepcopies don't cause exponential memory growth
-        # If datastore was copied, each copy would contain 3 watches,
-        # and those watches would contain the datastore, etc. (infinite recursion)
-        copies = []
-        for _ in range(5):
-            copies.append(deepcopy(watches[0]))
-
-        # All copies should share the same datastore
-        for copy in copies:
-            self.assertIs(copy._datastore, mock_datastore,
-                         "All copies should share the original datastore")
-
-    def test_watch_pickle_doesnt_serialize_datastore(self):
-        """
-        Ensure pickle/unpickle doesn't serialize __datastore.
-
-        This is important for multiprocessing and caching - we don't want
-        to serialize the entire datastore when pickling a watch.
-        """
-        mock_datastore = {
-            'settings': {'application': {}},
-            'watching': {}
-        }
-
-        watch = Watch.model(
-            __datastore=mock_datastore,
-            datastore_path='/tmp/test',
-            default={'url': 'https://example.com', 'title': 'Test Watch'}
-        )
-
-        # Pickle and unpickle
-        pickled = pickle.dumps(watch)
-        unpickled_watch = pickle.loads(pickled)
-
-        # Test 1: Watch data is preserved
-        self.assertEqual(unpickled_watch['url'], 'https://example.com',
-                        "Dict data should be preserved after pickle/unpickle")
-
-        # Test 2: __datastore is NOT serialized (attribute shouldn't exist after unpickle)
-        self.assertFalse(hasattr(unpickled_watch, '_datastore'),
-                         "__datastore attribute should not exist after unpickle (not serialized)")
-
-        # Test 3: Pickled data shouldn't contain the large datastore object
-        # If datastore was serialized, the pickle size would be much larger
-        pickle_size = len(pickled)
-        # A single watch should be small (< 10KB), not include entire datastore
-        self.assertLess(pickle_size, 10000,
-                       f"Pickled watch too large ({pickle_size} bytes) - might include datastore")
-
-    def test_tag_deepcopy_works(self):
-        """
-        Ensure Tag objects (which also inherit from watch_base) can be deepcopied.
-
-        Tags now have optional __datastore for consistency with Watch objects.
-        """
-        mock_datastore = {
-            'settings': {'application': {}},
-            'watching': {}
-        }
-
-        # Test 1: Tag without datastore (backward compatibility)
-        tag_without_ds = Tag.model(
-            datastore_path='/tmp/test',
-            default={'title': 'Test Tag', 'overrides_watch': True}
-        )
-        tag_copy1 = deepcopy(tag_without_ds)
-        self.assertEqual(tag_copy1['title'], 'Test Tag', "Tag data should be copied")
-
-        # Test 2: Tag with datastore (new pattern for consistency)
-        tag_with_ds = Tag.model(
-            datastore_path='/tmp/test',
-            __datastore=mock_datastore,
-            default={'title': 'Test Tag With DS', 'overrides_watch': True}
-        )
-
-        # Deepcopy should work
-        tag_copy2 = deepcopy(tag_with_ds)
-
-        # Test 3: Dict data is copied
-        self.assertEqual(tag_copy2['title'], 'Test Tag With DS', "Tag data should be copied")
-
-        # Test 4: Modifications to copy don't affect original
-        tag_copy2['title'] = 'MODIFIED'
-        self.assertNotEqual(tag_with_ds['title'], 'MODIFIED',
-                           "Modifying copy should not affect original")
-
-        # Test 5: Tag with datastore shares it (doesn't copy it)
-        if hasattr(tag_with_ds, '_datastore'):
-            self.assertIs(tag_copy2._datastore, tag_with_ds._datastore,
-                         "Tag should share __datastore reference like Watch does")
-
-    def test_watch_copy_performance(self):
-        """
-        Verify that our __deepcopy__ implementation doesn't cause performance issues.
-
-        With the fix, deepcopy should be fast because we're sharing datastore
-        instead of copying it.
-        """
-        import time
-
-        # Create a watch with large datastore (many watches)
-        mock_datastore = {
-            'settings': {'application': {}},
-            'watching': {}
-        }
-
-        # Add 100 watches to the datastore
-        for i in range(100):
-            w = Watch.model(
-                __datastore=mock_datastore,
-                datastore_path='/tmp/test',
-                default={'url': f'https://example{i}.com'}
-            )
-            mock_datastore['watching'][w['uuid']] = w
-
-        # Time how long deepcopy takes
-        watch = list(mock_datastore['watching'].values())[0]
-
-        start = time.time()
-        for _ in range(10):
-            _ = deepcopy(watch)
-        elapsed = time.time() - start
-
-        # Should be fast (< 0.1 seconds for 10 copies)
-        # If datastore was copied, it would take much longer
-        self.assertLess(elapsed, 0.5,
-                       f"Deepcopy too slow ({elapsed:.3f}s for 10 copies) - might be copying datastore")
-
 if __name__ == '__main__':
     unittest.main()

changedetectionio/tests/util.py

@@ -161,6 +161,11 @@ def extract_UUID_from_client(client):
 
 def delete_all_watches(client=None):
 
+    # Change tracking
+    client.application.config.get('DATASTORE')._dirty_watches = set()      # Watch UUIDs that need saving
+    client.application.config.get('DATASTORE')._dirty_settings = False     # Settings changed
+    client.application.config.get('DATASTORE')._watch_hashes = {}          # UUID -> SHA256 hash for change detection
+
     uuids = list(client.application.config.get('DATASTORE').data['watching'])
     for uuid in uuids:
         client.application.config.get('DATASTORE').delete(uuid)

changedetectionio/translations/cs/LC_MESSAGES/messages.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PROJECT VERSION\n"
 "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
-"POT-Creation-Date: 2026-02-05 17:47+0100\n"
+"POT-Creation-Date: 2026-01-22 06:19+0100\n"
 "PO-Revision-Date: 2026-01-02 11:40+0100\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language: cs\n"
@@ -327,14 +327,6 @@ msgstr "Nastavit na"
 msgid "to disable"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html changedetectionio/blueprint/ui/templates/edit.html
-msgid "Limit collection of history snapshots for each watch to this number of history items."
-msgstr ""
-
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Set to empty to disable / no limit"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Password protection for your changedetection.io application."
 msgstr ""
@@ -353,10 +345,6 @@ msgstr ""
 msgid "When a request returns no content, or the HTML does not contain any text, is this considered a change?"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Choose a default proxy for all watches"
-msgstr "Vyberte výchozí proxy pro všechny monitory"
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Base URL used for the"
 msgstr ""
@@ -666,6 +654,10 @@ msgid ""
 "whitelist the IP access instead"
 msgstr ""
 
+#: changedetectionio/blueprint/settings/templates/settings.html
+msgid "Choose a default proxy for all watches"
+msgstr "Vyberte výchozí proxy pro všechny monitory"
+
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Python version:"
 msgstr "Verze Pythonu:"
@@ -991,12 +983,7 @@ msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
 #, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing. Please select a different processor."
-msgstr ""
-
-#: changedetectionio/blueprint/ui/edit.py
-#, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing."
+msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
 msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
@@ -1245,10 +1232,6 @@ msgid ""
 "your filter will not work anymore."
 msgstr ""
 
-#: changedetectionio/blueprint/ui/templates/edit.html
-msgid "Set to empty to use system settings default"
-msgstr ""
-
 #: changedetectionio/blueprint/ui/templates/edit.html
 msgid "method (default) where your watched site doesn't need Javascript to render."
 msgstr ""
@@ -1597,18 +1580,6 @@ msgstr "zobrazeno <b>{start} - {end}</b> {record_name} z celkem <b>{total}</b>"
 msgid "records"
 msgstr "záznamy"
 
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "Changedetection.io can monitor more than just web-pages! See our plugins!"
-msgstr ""
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "More info"
-msgstr "Více informací"
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "You can also add 'shared' watches."
-msgstr ""
-
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Add a new web page change detection watch"
 msgstr "Přidejte nové monitory zjišťování změn webové stránky"
@@ -1621,6 +1592,18 @@ msgstr "Monitorovat tuto URL!"
 msgid "Edit first then Watch"
 msgstr "Upravit a monitorovat"
 
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Create a shareable link"
+msgstr "Vytvořte odkaz ke sdílení"
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Tip: You can also add 'shared' watches."
+msgstr "Tip: Můžete také přidat „sdílené“ monitory."
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "More info"
+msgstr "Více informací"
+
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Pause"
 msgstr "Pauza"
@@ -2134,10 +2117,6 @@ msgstr "Přiřaďte kteroukoli z následujících možností"
 msgid "Use page <title> in list"
 msgstr "V seznamu použijte stránku <title>"
 
-#: changedetectionio/forms.py
-msgid "Number of history items per watch to keep"
-msgstr ""
-
 #: changedetectionio/forms.py
 msgid "Body must be empty when Request Method is set to GET"
 msgstr "Když je metoda požadavku nastavena na GET, tělo musí být prázdné"
@@ -2460,20 +2439,15 @@ msgstr "Změny textu webové stránky/HTML, JSON a PDF"
 msgid "Detects all text changes where possible"
 msgstr "Detekuje všechny změny textu, kde je to možné"
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 #, python-brace-format
 msgid "Error fetching metadata for {}"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 msgid "Watch protocol is not permitted or invalid URL format"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
-#, python-brace-format
-msgid "Watch limit reached ({}/{} watches). Cannot add more watches."
-msgstr ""
-
 #: changedetectionio/templates/_common_fields.html
 msgid "Body for all notifications — You can use"
 msgstr "Tělo pro všechna oznámení — Můžete použít"
@@ -3082,12 +3056,3 @@ msgstr "Hlavní nastavení"
 #~ msgid "Cleared snapshot history for all watches"
 #~ msgstr "Vymazat/resetovat historii"
 
-#~ msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
-#~ msgstr ""
-
-#~ msgid "Create a shareable link"
-#~ msgstr "Vytvořte odkaz ke sdílení"
-
-#~ msgid "Tip: You can also add 'shared' watches."
-#~ msgstr "Tip: Můžete také přidat „sdílené“ monitory."
-

changedetectionio/translations/de/LC_MESSAGES/messages.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PROJECT VERSION\n"
 "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
-"POT-Creation-Date: 2026-02-05 17:47+0100\n"
+"POT-Creation-Date: 2026-01-22 06:19+0100\n"
 "PO-Revision-Date: 2026-01-14 03:57+0100\n"
 "Last-Translator: \n"
 "Language: de\n"
@@ -333,14 +333,6 @@ msgstr "Setzen auf"
 msgid "to disable"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html changedetectionio/blueprint/ui/templates/edit.html
-msgid "Limit collection of history snapshots for each watch to this number of history items."
-msgstr ""
-
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Set to empty to disable / no limit"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Password protection for your changedetection.io application."
 msgstr ""
@@ -359,10 +351,6 @@ msgstr ""
 msgid "When a request returns no content, or the HTML does not contain any text, is this considered a change?"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Choose a default proxy for all watches"
-msgstr "Wählen Sie einen Standard-Proxy für alle Überwachungen"
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Base URL used for the"
 msgstr ""
@@ -676,6 +664,10 @@ msgid ""
 "whitelist the IP access instead"
 msgstr ""
 
+#: changedetectionio/blueprint/settings/templates/settings.html
+msgid "Choose a default proxy for all watches"
+msgstr "Wählen Sie einen Standard-Proxy für alle Überwachungen"
+
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Python version:"
 msgstr "Python-Version:"
@@ -1007,13 +999,8 @@ msgstr "In den Modus {} gewechselt."
 
 #: changedetectionio/blueprint/ui/edit.py
 #, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing. Please select a different processor."
-msgstr ""
-
-#: changedetectionio/blueprint/ui/edit.py
-#, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing."
-msgstr ""
+msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
+msgstr "Das Bearbeitungsformular für den Prozessor/das Plugin „{}“ kann nicht geladen werden. Fehlt das Plugin?"
 
 #: changedetectionio/blueprint/ui/edit.py
 msgid "Updated watch - unpaused!"
@@ -1267,10 +1254,6 @@ msgstr ""
 "Sendet eine Benachrichtigung, wenn der Filter auf der Seite nicht mehr sichtbar ist. So wissen Sie, wann sich die "
 "Seite geändert hat und Ihr Filter nicht mehr funktioniert."
 
-#: changedetectionio/blueprint/ui/templates/edit.html
-msgid "Set to empty to use system settings default"
-msgstr ""
-
 #: changedetectionio/blueprint/ui/templates/edit.html
 msgid "method (default) where your watched site doesn't need Javascript to render."
 msgstr "Methode (default), bei der Ihre überwachte Website kein Javascript zum Rendern benötigt."
@@ -1635,18 +1618,6 @@ msgstr "zeige <b>{start} - {end}</b> {record_name} von insgesamt <b>{total}</b>"
 msgid "records"
 msgstr "Einträge"
 
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "Changedetection.io can monitor more than just web-pages! See our plugins!"
-msgstr ""
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "More info"
-msgstr "Weitere Informationen"
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "You can also add 'shared' watches."
-msgstr ""
-
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Add a new web page change detection watch"
 msgstr "Fügen Sie eine neue Überwachung zur Erkennung von Webseitenänderungen hinzu"
@@ -1659,6 +1630,18 @@ msgstr "Diese URL überwachen!"
 msgid "Edit first then Watch"
 msgstr "Bearbeiten > Überwachen"
 
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Create a shareable link"
+msgstr "Erstellen Sie einen Link zum Teilen"
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Tip: You can also add 'shared' watches."
+msgstr "Tipp: Sie können auch „gemeinsame“ Überwachungen hinzufügen."
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "More info"
+msgstr "Weitere Informationen"
+
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Pause"
 msgstr "Pause"
@@ -2179,10 +2162,6 @@ msgstr "Entspricht einer der folgenden Bedingungen"
 msgid "Use page <title> in list"
 msgstr "Verwenden Sie Seite <Titel> in der Liste"
 
-#: changedetectionio/forms.py
-msgid "Number of history items per watch to keep"
-msgstr ""
-
 #: changedetectionio/forms.py
 msgid "Body must be empty when Request Method is set to GET"
 msgstr "Der Textkörper muss leer sein, wenn die Anforderungsmethode auf GET gesetzt ist"
@@ -2507,20 +2486,15 @@ msgstr "Änderungen an Webseitentext/HTML, JSON und PDF"
 msgid "Detects all text changes where possible"
 msgstr "Erkennt nach Möglichkeit alle Textänderungen"
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 #, python-brace-format
 msgid "Error fetching metadata for {}"
 msgstr "Fehler beim Abrufen der Metadaten für {}"
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 msgid "Watch protocol is not permitted or invalid URL format"
 msgstr "Das Protokoll wird nicht unterstützt oder das URL-Format ist ungültig."
 
-#: changedetectionio/store/__init__.py
-#, python-brace-format
-msgid "Watch limit reached ({}/{} watches). Cannot add more watches."
-msgstr ""
-
 #: changedetectionio/templates/_common_fields.html
 msgid "Body for all notifications — You can use"
 msgstr "Inhalt für alle Benachrichtigungen — Sie können verwenden"
@@ -3197,12 +3171,3 @@ msgstr "Haupteinstellungen"
 #~ msgid "No watches available to recheck."
 #~ msgstr "Keine Überwachungen verfügbar, um erneut zu überprüfen."
 
-#~ msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
-#~ msgstr "Das Bearbeitungsformular für den Prozessor/das Plugin „{}“ kann nicht geladen werden. Fehlt das Plugin?"
-
-#~ msgid "Create a shareable link"
-#~ msgstr "Erstellen Sie einen Link zum Teilen"
-
-#~ msgid "Tip: You can also add 'shared' watches."
-#~ msgstr "Tipp: Sie können auch „gemeinsame“ Überwachungen hinzufügen."
-

changedetectionio/translations/en_GB/LC_MESSAGES/messages.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version:  changedetection.io\n"
 "Report-Msgid-Bugs-To: https://github.com/dgtlmoon/changedetection.io\n"
-"POT-Creation-Date: 2026-02-05 17:47+0100\n"
+"POT-Creation-Date: 2026-01-22 06:19+0100\n"
 "PO-Revision-Date: 2026-01-12 16:33+0100\n"
 "Last-Translator: British English Translation Team\n"
 "Language: en_GB\n"
@@ -325,14 +325,6 @@ msgstr ""
 msgid "to disable"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html changedetectionio/blueprint/ui/templates/edit.html
-msgid "Limit collection of history snapshots for each watch to this number of history items."
-msgstr ""
-
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Set to empty to disable / no limit"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Password protection for your changedetection.io application."
 msgstr ""
@@ -349,10 +341,6 @@ msgstr ""
 msgid "When a request returns no content, or the HTML does not contain any text, is this considered a change?"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Choose a default proxy for all watches"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Base URL used for the"
 msgstr ""
@@ -662,6 +650,10 @@ msgid ""
 "whitelist the IP access instead"
 msgstr ""
 
+#: changedetectionio/blueprint/settings/templates/settings.html
+msgid "Choose a default proxy for all watches"
+msgstr ""
+
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Python version:"
 msgstr ""
@@ -987,12 +979,7 @@ msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
 #, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing. Please select a different processor."
-msgstr ""
-
-#: changedetectionio/blueprint/ui/edit.py
-#, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing."
+msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
 msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
@@ -1241,10 +1228,6 @@ msgid ""
 "your filter will not work anymore."
 msgstr ""
 
-#: changedetectionio/blueprint/ui/templates/edit.html
-msgid "Set to empty to use system settings default"
-msgstr ""
-
 #: changedetectionio/blueprint/ui/templates/edit.html
 msgid "method (default) where your watched site doesn't need Javascript to render."
 msgstr ""
@@ -1593,18 +1576,6 @@ msgstr ""
 msgid "records"
 msgstr ""
 
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "Changedetection.io can monitor more than just web-pages! See our plugins!"
-msgstr ""
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "More info"
-msgstr ""
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "You can also add 'shared' watches."
-msgstr ""
-
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Add a new web page change detection watch"
 msgstr ""
@@ -1617,6 +1588,18 @@ msgstr ""
 msgid "Edit first then Watch"
 msgstr ""
 
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Create a shareable link"
+msgstr ""
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Tip: You can also add 'shared' watches."
+msgstr ""
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "More info"
+msgstr ""
+
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Pause"
 msgstr ""
@@ -2130,10 +2113,6 @@ msgstr ""
 msgid "Use page <title> in list"
 msgstr ""
 
-#: changedetectionio/forms.py
-msgid "Number of history items per watch to keep"
-msgstr ""
-
 #: changedetectionio/forms.py
 msgid "Body must be empty when Request Method is set to GET"
 msgstr ""
@@ -2456,20 +2435,15 @@ msgstr ""
 msgid "Detects all text changes where possible"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 #, python-brace-format
 msgid "Error fetching metadata for {}"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 msgid "Watch protocol is not permitted or invalid URL format"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
-#, python-brace-format
-msgid "Watch limit reached ({}/{} watches). Cannot add more watches."
-msgstr ""
-
 #: changedetectionio/templates/_common_fields.html
 msgid "Body for all notifications — You can use"
 msgstr ""
@@ -3027,12 +3001,3 @@ msgstr ""
 #~ msgid "No watches available to recheck."
 #~ msgstr ""
 
-#~ msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
-#~ msgstr ""
-
-#~ msgid "Create a shareable link"
-#~ msgstr ""
-
-#~ msgid "Tip: You can also add 'shared' watches."
-#~ msgstr ""
-

changedetectionio/translations/en_US/LC_MESSAGES/messages.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PROJECT VERSION\n"
 "Report-Msgid-Bugs-To: https://github.com/dgtlmoon/changedetection.io\n"
-"POT-Creation-Date: 2026-02-05 17:47+0100\n"
+"POT-Creation-Date: 2026-01-22 06:19+0100\n"
 "PO-Revision-Date: 2026-01-12 16:37+0100\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language: en_US\n"
@@ -325,14 +325,6 @@ msgstr ""
 msgid "to disable"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html changedetectionio/blueprint/ui/templates/edit.html
-msgid "Limit collection of history snapshots for each watch to this number of history items."
-msgstr ""
-
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Set to empty to disable / no limit"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Password protection for your changedetection.io application."
 msgstr ""
@@ -349,10 +341,6 @@ msgstr ""
 msgid "When a request returns no content, or the HTML does not contain any text, is this considered a change?"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Choose a default proxy for all watches"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Base URL used for the"
 msgstr ""
@@ -662,6 +650,10 @@ msgid ""
 "whitelist the IP access instead"
 msgstr ""
 
+#: changedetectionio/blueprint/settings/templates/settings.html
+msgid "Choose a default proxy for all watches"
+msgstr ""
+
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Python version:"
 msgstr ""
@@ -987,12 +979,7 @@ msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
 #, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing. Please select a different processor."
-msgstr ""
-
-#: changedetectionio/blueprint/ui/edit.py
-#, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing."
+msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
 msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
@@ -1241,10 +1228,6 @@ msgid ""
 "your filter will not work anymore."
 msgstr ""
 
-#: changedetectionio/blueprint/ui/templates/edit.html
-msgid "Set to empty to use system settings default"
-msgstr ""
-
 #: changedetectionio/blueprint/ui/templates/edit.html
 msgid "method (default) where your watched site doesn't need Javascript to render."
 msgstr ""
@@ -1593,18 +1576,6 @@ msgstr ""
 msgid "records"
 msgstr ""
 
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "Changedetection.io can monitor more than just web-pages! See our plugins!"
-msgstr ""
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "More info"
-msgstr ""
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "You can also add 'shared' watches."
-msgstr ""
-
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Add a new web page change detection watch"
 msgstr ""
@@ -1617,6 +1588,18 @@ msgstr ""
 msgid "Edit first then Watch"
 msgstr ""
 
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Create a shareable link"
+msgstr ""
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Tip: You can also add 'shared' watches."
+msgstr ""
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "More info"
+msgstr ""
+
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Pause"
 msgstr ""
@@ -2130,10 +2113,6 @@ msgstr ""
 msgid "Use page <title> in list"
 msgstr ""
 
-#: changedetectionio/forms.py
-msgid "Number of history items per watch to keep"
-msgstr ""
-
 #: changedetectionio/forms.py
 msgid "Body must be empty when Request Method is set to GET"
 msgstr ""
@@ -2456,20 +2435,15 @@ msgstr ""
 msgid "Detects all text changes where possible"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 #, python-brace-format
 msgid "Error fetching metadata for {}"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 msgid "Watch protocol is not permitted or invalid URL format"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
-#, python-brace-format
-msgid "Watch limit reached ({}/{} watches). Cannot add more watches."
-msgstr ""
-
 #: changedetectionio/templates/_common_fields.html
 msgid "Body for all notifications — You can use"
 msgstr ""
@@ -3027,12 +3001,3 @@ msgstr ""
 #~ msgid "No watches available to recheck."
 #~ msgstr ""
 
-#~ msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
-#~ msgstr ""
-
-#~ msgid "Create a shareable link"
-#~ msgstr ""
-
-#~ msgid "Tip: You can also add 'shared' watches."
-#~ msgstr ""
-

changedetectionio/translations/fr/LC_MESSAGES/messages.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PROJECT VERSION\n"
 "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
-"POT-Creation-Date: 2026-02-05 17:47+0100\n"
+"POT-Creation-Date: 2026-01-22 06:19+0100\n"
 "PO-Revision-Date: 2026-01-02 11:40+0100\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language: fr\n"
@@ -327,14 +327,6 @@ msgstr "Définir à"
 msgid "to disable"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html changedetectionio/blueprint/ui/templates/edit.html
-msgid "Limit collection of history snapshots for each watch to this number of history items."
-msgstr ""
-
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Set to empty to disable / no limit"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Password protection for your changedetection.io application."
 msgstr ""
@@ -353,10 +345,6 @@ msgstr ""
 msgid "When a request returns no content, or the HTML does not contain any text, is this considered a change?"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Choose a default proxy for all watches"
-msgstr "Choisir un proxy par défaut pour tous les moniteurs"
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Base URL used for the"
 msgstr ""
@@ -666,6 +654,10 @@ msgid ""
 "whitelist the IP access instead"
 msgstr ""
 
+#: changedetectionio/blueprint/settings/templates/settings.html
+msgid "Choose a default proxy for all watches"
+msgstr "Choisir un proxy par défaut pour tous les moniteurs"
+
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Python version:"
 msgstr "Version Python :"
@@ -991,12 +983,7 @@ msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
 #, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing. Please select a different processor."
-msgstr ""
-
-#: changedetectionio/blueprint/ui/edit.py
-#, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing."
+msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
 msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
@@ -1247,10 +1234,6 @@ msgid ""
 "your filter will not work anymore."
 msgstr ""
 
-#: changedetectionio/blueprint/ui/templates/edit.html
-msgid "Set to empty to use system settings default"
-msgstr ""
-
 #: changedetectionio/blueprint/ui/templates/edit.html
 msgid "method (default) where your watched site doesn't need Javascript to render."
 msgstr ""
@@ -1599,18 +1582,6 @@ msgstr "affichage de <b>{start} - {end}</b> {record_name} sur un total de <b>{to
 msgid "records"
 msgstr "enregistrements"
 
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "Changedetection.io can monitor more than just web-pages! See our plugins!"
-msgstr ""
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "More info"
-msgstr "Plus d'informations"
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "You can also add 'shared' watches."
-msgstr ""
-
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Add a new web page change detection watch"
 msgstr "Ajouter une nouvelle surveillance de détection de changement de page Web"
@@ -1623,6 +1594,18 @@ msgstr "Surveillez cette URL !"
 msgid "Edit first then Watch"
 msgstr "Modifier > Surveiller"
 
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Create a shareable link"
+msgstr "Créer un lien partageable"
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Tip: You can also add 'shared' watches."
+msgstr "Astuce : Vous pouvez également ajouter des montres « partagées »."
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "More info"
+msgstr "Plus d'informations"
+
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Pause"
 msgstr "Pause"
@@ -2140,10 +2123,6 @@ msgstr "Faites correspondre l'un des éléments suivants"
 msgid "Use page <title> in list"
 msgstr "Utiliser la page <titre> dans la liste"
 
-#: changedetectionio/forms.py
-msgid "Number of history items per watch to keep"
-msgstr ""
-
 #: changedetectionio/forms.py
 msgid "Body must be empty when Request Method is set to GET"
 msgstr "Le corps doit être vide lorsque la méthode de requête est définie sur GET"
@@ -2466,20 +2445,15 @@ msgstr "Modifications du texte de la page Web/HTML, JSON et PDF"
 msgid "Detects all text changes where possible"
 msgstr "Détecte toutes les modifications de texte lorsque cela est possible"
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 #, python-brace-format
 msgid "Error fetching metadata for {}"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 msgid "Watch protocol is not permitted or invalid URL format"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
-#, python-brace-format
-msgid "Watch limit reached ({}/{} watches). Cannot add more watches."
-msgstr ""
-
 #: changedetectionio/templates/_common_fields.html
 msgid "Body for all notifications — You can use"
 msgstr "Corps pour toutes les notifications — Vous pouvez utiliser"
@@ -3090,12 +3064,3 @@ msgstr "Paramètres principaux"
 #~ msgid "Cleared snapshot history for all watches"
 #~ msgstr "Effacer/réinitialiser l'historique"
 
-#~ msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
-#~ msgstr ""
-
-#~ msgid "Create a shareable link"
-#~ msgstr "Créer un lien partageable"
-
-#~ msgid "Tip: You can also add 'shared' watches."
-#~ msgstr "Astuce : Vous pouvez également ajouter des montres « partagées »."
-

changedetectionio/translations/it/LC_MESSAGES/messages.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PROJECT VERSION\n"
 "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
-"POT-Creation-Date: 2026-02-05 17:47+0100\n"
+"POT-Creation-Date: 2026-01-22 06:19+0100\n"
 "PO-Revision-Date: 2026-01-02 15:32+0100\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language: it\n"
@@ -327,14 +327,6 @@ msgstr ""
 msgid "to disable"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html changedetectionio/blueprint/ui/templates/edit.html
-msgid "Limit collection of history snapshots for each watch to this number of history items."
-msgstr ""
-
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Set to empty to disable / no limit"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Password protection for your changedetection.io application."
 msgstr ""
@@ -351,10 +343,6 @@ msgstr "Consenti accesso alla pagina cronologia quando la password è attiva (ut
 msgid "When a request returns no content, or the HTML does not contain any text, is this considered a change?"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Choose a default proxy for all watches"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Base URL used for the"
 msgstr ""
@@ -664,6 +652,10 @@ msgid ""
 "whitelist the IP access instead"
 msgstr ""
 
+#: changedetectionio/blueprint/settings/templates/settings.html
+msgid "Choose a default proxy for all watches"
+msgstr ""
+
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Python version:"
 msgstr ""
@@ -989,12 +981,7 @@ msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
 #, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing. Please select a different processor."
-msgstr ""
-
-#: changedetectionio/blueprint/ui/edit.py
-#, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing."
+msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
 msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
@@ -1243,10 +1230,6 @@ msgid ""
 "your filter will not work anymore."
 msgstr ""
 
-#: changedetectionio/blueprint/ui/templates/edit.html
-msgid "Set to empty to use system settings default"
-msgstr ""
-
 #: changedetectionio/blueprint/ui/templates/edit.html
 msgid "method (default) where your watched site doesn't need Javascript to render."
 msgstr ""
@@ -1595,18 +1578,6 @@ msgstr "visualizzando <b>{start} - {end}</b> {record_name} su un totale di <b>{t
 msgid "records"
 msgstr "record"
 
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "Changedetection.io can monitor more than just web-pages! See our plugins!"
-msgstr ""
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "More info"
-msgstr "Maggiori informazioni"
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "You can also add 'shared' watches."
-msgstr ""
-
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Add a new web page change detection watch"
 msgstr "Aggiungi un nuovo monitoraggio modifiche pagina web"
@@ -1619,6 +1590,18 @@ msgstr "Monitora questo URL!"
 msgid "Edit first then Watch"
 msgstr "Modifica > Monitora"
 
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Create a shareable link"
+msgstr ""
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Tip: You can also add 'shared' watches."
+msgstr ""
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "More info"
+msgstr "Maggiori informazioni"
+
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Pause"
 msgstr "Pausa"
@@ -2132,10 +2115,6 @@ msgstr "Corrisponde a uno qualsiasi dei seguenti"
 msgid "Use page <title> in list"
 msgstr "Usa <title> pagina nell'elenco"
 
-#: changedetectionio/forms.py
-msgid "Number of history items per watch to keep"
-msgstr ""
-
 #: changedetectionio/forms.py
 msgid "Body must be empty when Request Method is set to GET"
 msgstr "Il corpo deve essere vuoto quando il metodo è impostato su GET"
@@ -2458,20 +2437,15 @@ msgstr "Modifiche testo/HTML, JSON e PDF"
 msgid "Detects all text changes where possible"
 msgstr "Rileva tutte le modifiche di testo possibili"
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 #, python-brace-format
 msgid "Error fetching metadata for {}"
 msgstr "Errore nel recupero metadati per {}"
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 msgid "Watch protocol is not permitted or invalid URL format"
 msgstr "Protocollo non consentito o formato URL non valido"
 
-#: changedetectionio/store/__init__.py
-#, python-brace-format
-msgid "Watch limit reached ({}/{} watches). Cannot add more watches."
-msgstr ""
-
 #: changedetectionio/templates/_common_fields.html
 msgid "Body for all notifications — You can use"
 msgstr "Corpo per tutte le notifiche — Puoi usare"
@@ -3062,12 +3036,3 @@ msgstr "Impostazioni principali"
 #~ msgid "Queue"
 #~ msgstr "In coda"
 
-#~ msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
-#~ msgstr ""
-
-#~ msgid "Create a shareable link"
-#~ msgstr ""
-
-#~ msgid "Tip: You can also add 'shared' watches."
-#~ msgstr ""
-

changedetectionio/translations/ko/LC_MESSAGES/messages.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PROJECT VERSION\n"
 "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
-"POT-Creation-Date: 2026-02-05 17:47+0100\n"
+"POT-Creation-Date: 2026-01-22 06:19+0100\n"
 "PO-Revision-Date: 2026-01-02 11:40+0100\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language: ko\n"
@@ -325,14 +325,6 @@ msgstr "설정:"
 msgid "to disable"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html changedetectionio/blueprint/ui/templates/edit.html
-msgid "Limit collection of history snapshots for each watch to this number of history items."
-msgstr ""
-
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Set to empty to disable / no limit"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Password protection for your changedetection.io application."
 msgstr ""
@@ -349,10 +341,6 @@ msgstr "비밀번호 활성화 시 변경 기록 페이지 액세스 허용 (dif
 msgid "When a request returns no content, or the HTML does not contain any text, is this considered a change?"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Choose a default proxy for all watches"
-msgstr "모든 모니터의 기본 프록시 선택"
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Base URL used for the"
 msgstr ""
@@ -662,6 +650,10 @@ msgid ""
 "whitelist the IP access instead"
 msgstr ""
 
+#: changedetectionio/blueprint/settings/templates/settings.html
+msgid "Choose a default proxy for all watches"
+msgstr "모든 모니터의 기본 프록시 선택"
+
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Python version:"
 msgstr "파이썬 버전:"
@@ -987,12 +979,7 @@ msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
 #, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing. Please select a different processor."
-msgstr ""
-
-#: changedetectionio/blueprint/ui/edit.py
-#, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing."
+msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
 msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
@@ -1241,10 +1228,6 @@ msgid ""
 "your filter will not work anymore."
 msgstr ""
 
-#: changedetectionio/blueprint/ui/templates/edit.html
-msgid "Set to empty to use system settings default"
-msgstr ""
-
 #: changedetectionio/blueprint/ui/templates/edit.html
 msgid "method (default) where your watched site doesn't need Javascript to render."
 msgstr ""
@@ -1593,18 +1576,6 @@ msgstr "총 <b>{total}</b>개 중 <b>{start} - {end}</b>개 {record_name} 표시
 msgid "records"
 msgstr "기록"
 
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "Changedetection.io can monitor more than just web-pages! See our plugins!"
-msgstr ""
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "More info"
-msgstr "추가 정보"
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "You can also add 'shared' watches."
-msgstr ""
-
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Add a new web page change detection watch"
 msgstr "새로운 웹 페이지 변경 감지 감시 추가"
@@ -1617,6 +1588,18 @@ msgstr "이 URL 모니터!"
 msgid "Edit first then Watch"
 msgstr "편집 후 모니터"
 
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Create a shareable link"
+msgstr "공유 가능한 링크 만들기"
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Tip: You can also add 'shared' watches."
+msgstr "팁: '공유' 시계를 추가할 수도 있습니다."
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "More info"
+msgstr "추가 정보"
+
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Pause"
 msgstr "정지시키다"
@@ -2130,10 +2113,6 @@ msgstr "다음 중 하나와 일치"
 msgid "Use page <title> in list"
 msgstr "목록의 <제목> 페이지 사용"
 
-#: changedetectionio/forms.py
-msgid "Number of history items per watch to keep"
-msgstr ""
-
 #: changedetectionio/forms.py
 msgid "Body must be empty when Request Method is set to GET"
 msgstr "요청 방법이 GET으로 설정된 경우 본문이 비어 있어야 합니다."
@@ -2456,20 +2435,15 @@ msgstr "웹페이지 텍스트/HTML, JSON 및 PDF 변경"
 msgid "Detects all text changes where possible"
 msgstr "가능한 경우 모든 텍스트 변경 사항을 감지합니다."
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 #, python-brace-format
 msgid "Error fetching metadata for {}"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 msgid "Watch protocol is not permitted or invalid URL format"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
-#, python-brace-format
-msgid "Watch limit reached ({}/{} watches). Cannot add more watches."
-msgstr ""
-
 #: changedetectionio/templates/_common_fields.html
 msgid "Body for all notifications — You can use"
 msgstr "모든 알림 본문 — 사용 가능:"
@@ -3183,12 +3157,3 @@ msgstr "기본 설정"
 #~ msgid "Cleared snapshot history for all watches"
 #~ msgstr "기록 지우기/재설정"
 
-#~ msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
-#~ msgstr ""
-
-#~ msgid "Create a shareable link"
-#~ msgstr "공유 가능한 링크 만들기"
-
-#~ msgid "Tip: You can also add 'shared' watches."
-#~ msgstr "팁: '공유' 시계를 추가할 수도 있습니다."
-

changedetectionio/translations/messages.pot

@@ -6,9 +6,9 @@
 #, fuzzy
 msgid ""
 msgstr ""
-"Project-Id-Version: changedetection.io 0.52.9\n"
+"Project-Id-Version: changedetection.io 0.52.8\n"
 "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
-"POT-Creation-Date: 2026-02-05 17:47+0100\n"
+"POT-Creation-Date: 2026-01-22 06:29+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
@@ -324,14 +324,6 @@ msgstr ""
 msgid "to disable"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html changedetectionio/blueprint/ui/templates/edit.html
-msgid "Limit collection of history snapshots for each watch to this number of history items."
-msgstr ""
-
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Set to empty to disable / no limit"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Password protection for your changedetection.io application."
 msgstr ""
@@ -348,10 +340,6 @@ msgstr ""
 msgid "When a request returns no content, or the HTML does not contain any text, is this considered a change?"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Choose a default proxy for all watches"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Base URL used for the"
 msgstr ""
@@ -661,6 +649,10 @@ msgid ""
 "whitelist the IP access instead"
 msgstr ""
 
+#: changedetectionio/blueprint/settings/templates/settings.html
+msgid "Choose a default proxy for all watches"
+msgstr ""
+
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Python version:"
 msgstr ""
@@ -986,12 +978,7 @@ msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
 #, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing. Please select a different processor."
-msgstr ""
-
-#: changedetectionio/blueprint/ui/edit.py
-#, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing."
+msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
 msgstr ""
 
 #: changedetectionio/blueprint/ui/edit.py
@@ -1240,10 +1227,6 @@ msgid ""
 "your filter will not work anymore."
 msgstr ""
 
-#: changedetectionio/blueprint/ui/templates/edit.html
-msgid "Set to empty to use system settings default"
-msgstr ""
-
 #: changedetectionio/blueprint/ui/templates/edit.html
 msgid "method (default) where your watched site doesn't need Javascript to render."
 msgstr ""
@@ -1592,18 +1575,6 @@ msgstr ""
 msgid "records"
 msgstr ""
 
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "Changedetection.io can monitor more than just web-pages! See our plugins!"
-msgstr ""
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "More info"
-msgstr ""
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "You can also add 'shared' watches."
-msgstr ""
-
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Add a new web page change detection watch"
 msgstr ""
@@ -1616,6 +1587,18 @@ msgstr ""
 msgid "Edit first then Watch"
 msgstr ""
 
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Create a shareable link"
+msgstr ""
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Tip: You can also add 'shared' watches."
+msgstr ""
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "More info"
+msgstr ""
+
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Pause"
 msgstr ""
@@ -2129,10 +2112,6 @@ msgstr ""
 msgid "Use page <title> in list"
 msgstr ""
 
-#: changedetectionio/forms.py
-msgid "Number of history items per watch to keep"
-msgstr ""
-
 #: changedetectionio/forms.py
 msgid "Body must be empty when Request Method is set to GET"
 msgstr ""
@@ -2455,20 +2434,15 @@ msgstr ""
 msgid "Detects all text changes where possible"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 #, python-brace-format
 msgid "Error fetching metadata for {}"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 msgid "Watch protocol is not permitted or invalid URL format"
 msgstr ""
 
-#: changedetectionio/store/__init__.py
-#, python-brace-format
-msgid "Watch limit reached ({}/{} watches). Cannot add more watches."
-msgstr ""
-
 #: changedetectionio/templates/_common_fields.html
 msgid "Body for all notifications — You can use"
 msgstr ""

changedetectionio/translations/zh/LC_MESSAGES/messages.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PROJECT VERSION\n"
 "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
-"POT-Creation-Date: 2026-02-05 17:47+0100\n"
+"POT-Creation-Date: 2026-01-22 06:19+0100\n"
 "PO-Revision-Date: 2026-01-18 21:31+0800\n"
 "Last-Translator: 吾爱分享 <admin@wuaishare.cn>\n"
 "Language: zh\n"
@@ -325,14 +325,6 @@ msgstr "设置为"
 msgid "to disable"
 msgstr "以禁用"
 
-#: changedetectionio/blueprint/settings/templates/settings.html changedetectionio/blueprint/ui/templates/edit.html
-msgid "Limit collection of history snapshots for each watch to this number of history items."
-msgstr ""
-
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Set to empty to disable / no limit"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Password protection for your changedetection.io application."
 msgstr "为你的 changedetection.io 应用启用密码保护。"
@@ -349,10 +341,6 @@ msgstr "启用密码时允许访问监视器更改历史页面(便于共享差
 msgid "When a request returns no content, or the HTML does not contain any text, is this considered a change?"
 msgstr "当请求无内容返回，或 HTML 不包含任何文本时，是否视为变更？"
 
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Choose a default proxy for all watches"
-msgstr "为所有监视器选择默认代理"
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Base URL used for the"
 msgstr "用于通知链接中的"
@@ -662,6 +650,10 @@ msgid ""
 "whitelist the IP access instead"
 msgstr "带认证的 SOCKS5 代理仅支持“明文请求”抓取器，其他抓取器请改为白名单 IP"
 
+#: changedetectionio/blueprint/settings/templates/settings.html
+msgid "Choose a default proxy for all watches"
+msgstr "为所有监视器选择默认代理"
+
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Python version:"
 msgstr "Python 版本："
@@ -987,13 +979,8 @@ msgstr "已切换到模式 - {}。"
 
 #: changedetectionio/blueprint/ui/edit.py
 #, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing. Please select a different processor."
-msgstr ""
-
-#: changedetectionio/blueprint/ui/edit.py
-#, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing."
-msgstr ""
+msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
+msgstr "无法加载处理器/插件 '{}' 的编辑表单，插件是否缺失？"
 
 #: changedetectionio/blueprint/ui/edit.py
 msgid "Updated watch - unpaused!"
@@ -1241,10 +1228,6 @@ msgid ""
 "your filter will not work anymore."
 msgstr "当页面上找不到该过滤器时发送通知，便于知晓页面已变化且过滤器不再适用。"
 
-#: changedetectionio/blueprint/ui/templates/edit.html
-msgid "Set to empty to use system settings default"
-msgstr ""
-
 #: changedetectionio/blueprint/ui/templates/edit.html
 msgid "method (default) where your watched site doesn't need Javascript to render."
 msgstr "方式（默认），适用于无需 JavaScript 渲染的网站。"
@@ -1593,18 +1576,6 @@ msgstr "显示第 <b>{start} - {end}</b> 条{record_name}，共 <b>{total}</b>
 msgid "records"
 msgstr "记录"
 
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "Changedetection.io can monitor more than just web-pages! See our plugins!"
-msgstr ""
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "More info"
-msgstr "更多信息"
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "You can also add 'shared' watches."
-msgstr ""
-
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Add a new web page change detection watch"
 msgstr "新增网页变更监控"
@@ -1617,6 +1588,18 @@ msgstr "监控此 URL！"
 msgid "Edit first then Watch"
 msgstr "先编辑，再监控"
 
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Create a shareable link"
+msgstr "创建可分享链接"
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Tip: You can also add 'shared' watches."
+msgstr "提示：你也可以添加“共享”的监控项。"
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "More info"
+msgstr "更多信息"
+
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Pause"
 msgstr "暂停"
@@ -2130,10 +2113,6 @@ msgstr "匹配以下任意"
 msgid "Use page <title> in list"
 msgstr "列表中使用页面 <title>"
 
-#: changedetectionio/forms.py
-msgid "Number of history items per watch to keep"
-msgstr ""
-
 #: changedetectionio/forms.py
 msgid "Body must be empty when Request Method is set to GET"
 msgstr "当请求方法为 GET 时，请求正文必须为空"
@@ -2456,20 +2435,15 @@ msgstr "网页文本/HTML、JSON 和 PDF 变更"
 msgid "Detects all text changes where possible"
 msgstr "尽可能检测所有文本变更"
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 #, python-brace-format
 msgid "Error fetching metadata for {}"
 msgstr "获取 {} 的元数据失败"
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 msgid "Watch protocol is not permitted or invalid URL format"
 msgstr "监控协议不允许或 URL 格式无效"
 
-#: changedetectionio/store/__init__.py
-#, python-brace-format
-msgid "Watch limit reached ({}/{} watches). Cannot add more watches."
-msgstr ""
-
 #: changedetectionio/templates/_common_fields.html
 msgid "Body for all notifications — You can use"
 msgstr "所有通知的正文 — 您可以使用"
@@ -3012,12 +2986,3 @@ msgstr "否"
 msgid "Main settings"
 msgstr "主设置"
 
-#~ msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
-#~ msgstr "无法加载处理器/插件 '{}' 的编辑表单，插件是否缺失？"
-
-#~ msgid "Create a shareable link"
-#~ msgstr "创建可分享链接"
-
-#~ msgid "Tip: You can also add 'shared' watches."
-#~ msgstr "提示：你也可以添加“共享”的监控项。"
-

changedetectionio/translations/zh_Hant_TW/LC_MESSAGES/messages.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PROJECT VERSION\n"
 "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
-"POT-Creation-Date: 2026-02-05 17:47+0100\n"
+"POT-Creation-Date: 2026-01-22 06:19+0100\n"
 "PO-Revision-Date: 2026-01-15 12:00+0800\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language: zh_Hant_TW\n"
@@ -325,14 +325,6 @@ msgstr "設置為"
 msgid "to disable"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html changedetectionio/blueprint/ui/templates/edit.html
-msgid "Limit collection of history snapshots for each watch to this number of history items."
-msgstr ""
-
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Set to empty to disable / no limit"
-msgstr ""
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Password protection for your changedetection.io application."
 msgstr ""
@@ -349,10 +341,6 @@ msgstr "啟用密碼時允許匿名存取監測歷史頁面"
 msgid "When a request returns no content, or the HTML does not contain any text, is this considered a change?"
 msgstr ""
 
-#: changedetectionio/blueprint/settings/templates/settings.html
-msgid "Choose a default proxy for all watches"
-msgstr "為所有監測任務選擇預設代理伺服器"
-
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Base URL used for the"
 msgstr ""
@@ -662,6 +650,10 @@ msgid ""
 "whitelist the IP access instead"
 msgstr ""
 
+#: changedetectionio/blueprint/settings/templates/settings.html
+msgid "Choose a default proxy for all watches"
+msgstr "為所有監測任務選擇預設代理伺服器"
+
 #: changedetectionio/blueprint/settings/templates/settings.html
 msgid "Python version:"
 msgstr "Python 版本："
@@ -987,13 +979,8 @@ msgstr "已切換至模式 - {}。"
 
 #: changedetectionio/blueprint/ui/edit.py
 #, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing. Please select a different processor."
-msgstr ""
-
-#: changedetectionio/blueprint/ui/edit.py
-#, python-brace-format
-msgid "Could not load '{}' processor, processor plugin might be missing."
-msgstr ""
+msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
+msgstr "無法載入處理器 / 外掛 '{}' 的編輯表單，外掛是否遺失？"
 
 #: changedetectionio/blueprint/ui/edit.py
 msgid "Updated watch - unpaused!"
@@ -1241,10 +1228,6 @@ msgid ""
 "your filter will not work anymore."
 msgstr "當頁面上找不到過濾器時發送通知，這有助於了解頁面何時變更導致您的過濾器失效。"
 
-#: changedetectionio/blueprint/ui/templates/edit.html
-msgid "Set to empty to use system settings default"
-msgstr ""
-
 #: changedetectionio/blueprint/ui/templates/edit.html
 msgid "method (default) where your watched site doesn't need Javascript to render."
 msgstr "方法（預設），適用於您監測的網站不需要 Javascript 渲染的情況。"
@@ -1593,18 +1576,6 @@ msgstr "顯示第 <b>{start} - {end}</b> 條{record_name}，共 <b>{total}</b>
 msgid "records"
 msgstr "記錄"
 
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "Changedetection.io can monitor more than just web-pages! See our plugins!"
-msgstr ""
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "More info"
-msgstr "更多資訊"
-
-#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
-msgid "You can also add 'shared' watches."
-msgstr ""
-
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Add a new web page change detection watch"
 msgstr "新增網頁變更檢測任務"
@@ -1617,6 +1588,18 @@ msgstr "監測此 URL！"
 msgid "Edit first then Watch"
 msgstr "先編輯後監測"
 
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Create a shareable link"
+msgstr "建立可分享連結"
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "Tip: You can also add 'shared' watches."
+msgstr "提示：您也可以新增「共享」監測任務。"
+
+#: changedetectionio/blueprint/watchlist/templates/watch-overview.html
+msgid "More info"
+msgstr "更多資訊"
+
 #: changedetectionio/blueprint/watchlist/templates/watch-overview.html
 msgid "Pause"
 msgstr "暫停"
@@ -2130,10 +2113,6 @@ msgstr "符合以下任一條件"
 msgid "Use page <title> in list"
 msgstr "在列表中使用頁面 <title>"
 
-#: changedetectionio/forms.py
-msgid "Number of history items per watch to keep"
-msgstr ""
-
 #: changedetectionio/forms.py
 msgid "Body must be empty when Request Method is set to GET"
 msgstr "當請求方法設為 GET 時，內容必須為空"
@@ -2456,20 +2435,15 @@ msgstr "網頁文字 / HTML、JSON 和 PDF 變更"
 msgid "Detects all text changes where possible"
 msgstr "盡可能檢測所有文字變更"
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 #, python-brace-format
 msgid "Error fetching metadata for {}"
 msgstr "讀取 {} 的中繼資料時發生錯誤"
 
-#: changedetectionio/store/__init__.py
+#: changedetectionio/store.py
 msgid "Watch protocol is not permitted or invalid URL format"
 msgstr "監測協定不被允許或 URL 格式無效"
 
-#: changedetectionio/store/__init__.py
-#, python-brace-format
-msgid "Watch limit reached ({}/{} watches). Cannot add more watches."
-msgstr ""
-
 #: changedetectionio/templates/_common_fields.html
 msgid "Body for all notifications — You can use"
 msgstr "所有通知的內文 — 您可以使用"
@@ -3141,12 +3115,3 @@ msgstr "主設定"
 #~ msgid "No watches available to recheck."
 #~ msgstr "沒有可複查的監測任務。"
 
-#~ msgid "Cannot load the edit form for processor/plugin '{}', plugin missing?"
-#~ msgstr "無法載入處理器 / 外掛 '{}' 的編輯表單，外掛是否遺失？"
-
-#~ msgid "Create a shareable link"
-#~ msgstr "建立可分享連結"
-
-#~ msgid "Tip: You can also add 'shared' watches."
-#~ msgstr "提示：您也可以新增「共享」監測任務。"
-

changedetectionio/worker.py

@@ -370,7 +370,8 @@ async def async_update_worker(worker_id, q, notification_q, app, datastore, exec
                 except Exception as e:
                     import traceback
                     logger.error(f"Worker {worker_id} exception processing watch UUID: {uuid}")
-                    logger.exception(f"Worker {worker_id} full exception details:")
+                    logger.error(str(e))
+                    logger.error(traceback.format_exc())
                     datastore.update_watch(uuid=uuid, update_obj={'last_error': "Exception: " + str(e)})
                     process_changedetection_results = False
 
@@ -434,9 +435,8 @@ async def async_update_worker(worker_id, q, notification_q, app, datastore, exec
                                     await send_content_changed_notification(uuid, notification_q, datastore)
 
                     except Exception as e:
-
                         logger.critical(f"Worker {worker_id} exception in process_changedetection_results")
-                        logger.exception(f"Worker {worker_id} full exception details:")
+                        logger.critical(str(e))
                         datastore.update_watch(uuid=uuid, update_obj={'last_error': str(e)})
 
                 # Always record attempt count
@@ -451,7 +451,6 @@ async def async_update_worker(worker_id, q, notification_q, app, datastore, exec
                                 logger.debug(f"UUID: {uuid} Page <title> is '{page_title}'")
                                 datastore.update_watch(uuid=uuid, update_obj={'page_title': page_title})
                         except Exception as e:
-                            logger.exception(f"Worker {worker_id} full exception details:")
                             logger.warning(f"UUID: {uuid} Exception when extracting <title> - {str(e)}")
 
                     # Record server header
@@ -481,15 +480,22 @@ async def async_update_worker(worker_id, q, notification_q, app, datastore, exec
                         del update_handler
                         update_handler = None
 
-                # Force garbage collection
+                # Force aggressive memory cleanup after clearing
                 import gc
                 gc.collect()
+                try:
+                    import ctypes
+                    ctypes.CDLL('libc.so.6').malloc_trim(0)
+                except Exception:
+                    pass
 
         except Exception as e:
+            import traceback
+            logger.error(traceback.format_exc())
 
             logger.error(f"Worker {worker_id} unexpected error processing {uuid}: {e}")
-            logger.exception(f"Worker {worker_id} full exception details:")
-
+            logger.error(f"Worker {worker_id} traceback:", exc_info=True)
+            
             # Also update the watch with error information
             if datastore and uuid in datastore.data['watching']:
                 datastore.update_watch(uuid=uuid, update_obj={'last_error': f"Worker error: {str(e)}"})
@@ -497,43 +503,49 @@ async def async_update_worker(worker_id, q, notification_q, app, datastore, exec
         finally:
             # Always cleanup - this runs whether there was an exception or not
             if uuid:
-                # Call quit() as backup (Puppeteer/Playwright have internal cleanup, but this acts as safety net)
                 try:
                     if update_handler and hasattr(update_handler, 'fetcher') and update_handler.fetcher:
                         await update_handler.fetcher.quit(watch=watch)
                 except Exception as e:
                     logger.error(f"Exception while cleaning/quit after calling browser: {e}")
-                    logger.exception(f"Worker {worker_id} full exception details:")
-
                 try:
                     # Release UUID from processing (thread-safe)
                     worker_pool.release_uuid_from_processing(uuid, worker_id=worker_id)
-
+                    
                     # Send completion signal
                     if watch:
+                        #logger.info(f"Worker {worker_id} sending completion signal for UUID {watch['uuid']}")
                         watch_check_update.send(watch_uuid=watch['uuid'])
 
-                    # Clean up all memory references BEFORE garbage collection
+                    # Explicitly clean up update_handler and all its references
                     if update_handler:
+                        # Clear fetcher content using the proper method
                         if hasattr(update_handler, 'fetcher') and update_handler.fetcher:
                             update_handler.fetcher.clear_content()
+
+                        # Clear processor references
                         if hasattr(update_handler, 'content_processor'):
                             update_handler.content_processor = None
-                        del update_handler
+
                         update_handler = None
 
-                    # Clear large content variables
+                    # Clear local contents variable if it still exists
                     if 'contents' in locals():
                         del contents
 
-                    # Force garbage collection after all references are cleared
+                    # Note: We don't set watch = None here because:
+                    # 1. watch is just a local reference to datastore.data['watching'][uuid]
+                    # 2. Setting it to None doesn't affect the datastore
+                    # 3. GC can't collect the object anyway (still referenced by datastore)
+                    # 4. It would just cause confusion
+
+                    # Force garbage collection after cleanup
                     import gc
                     gc.collect()
 
                     logger.debug(f"Worker {worker_id} completed watch {uuid} in {time.time()-fetch_start_time:.2f}s")
                 except Exception as cleanup_error:
                     logger.error(f"Worker {worker_id} error during cleanup: {cleanup_error}")
-                    logger.exception(f"Worker {worker_id} full exception details:")
 
             del(uuid)
 

requirements.txt

@@ -70,7 +70,7 @@ lxml >=4.8.0,!=5.2.0,!=5.2.1,<7
 
 # XPath 2.0-3.1 support - 4.2.0 had issues, 4.1.5 stable
 # Consider updating to latest stable version periodically
-elementpath==5.1.1
+elementpath==5.1.0
 
 # For fast image comparison in screenshot change detection
 # opencv-python-headless is OPTIONAL (excluded from requirements.txt)
@@ -91,7 +91,7 @@ jq~=1.3; python_version >= "3.8" and sys_platform == "linux"
 
 # playwright is installed at Dockerfile build time because it's not available on all platforms
 
-pyppeteer-ng==2.0.0rc13
+pyppeteer-ng==2.0.0rc12
 pyppeteerstealth>=0.0.4
 
 # Include pytest, so if theres a support issue we can ask them to run these tests on their setup
@@ -148,7 +148,7 @@ tzdata
 pluggy ~= 1.6
 
 # Needed for testing, cross-platform for process and system monitoring
-psutil==7.2.2
+psutil==7.2.1
 
 ruff >= 0.11.2
 pre_commit >= 4.2.0