mirror of
https://github.com/dgtlmoon/changedetection.io.git
synced 2026-09-19 11:55:59 +00:00
* Browser fetchers - Judge a fetch on the document we end up extracting, not the first navigation
The goal is to compare the text of the page the browser lands on, even when the site navigates
again after the first response. Both fetchers were bound to the first navigation, which shows up
as two different bugs:
1. pyppeteer hangs until the hard processing timeout. Its navigation watcher is bound to the
loaderId of the navigation it started, so when the site replaces that document the 'load' it
waits for never arrives for that loaderId. With timeout=0 and setDefaultNavigationTimeout(0)
there is nothing to break the wait, so goto() blocks until
PUPPETEER_MAX_PROCESSING_TIMEOUT_SECONDS (180s) kills the fetch and the watch records an empty
xpath_data - while the browser is sitting on a fully loaded page. Traced on slated.com:
0.24s goto start
0.74s main frame networkIdle loaderId=A0E0E0B2 <- never gets 'load'
2.72s main frame init loaderId=56D2B5EF <- re-navigated to get.slated.com
3.49s main frame load loaderId=56D2B5EF <- fires for the new document
25.2s goto still hanging, frame._loaderId is now 56D2B5EF
Now the navigation races goto() against the main frame firing 'load', bounded by
BROWSER_NAVIGATION_TIMEOUT_SECONDS (default 30), and falls back to the document we can see.
slated.com / getastra.com / addupsolutions.com went from a 180s timeout with no content to
200 with full content in 5-35s.
2. Both fetchers reported the status of the interstitial. A site that gates unseen visitors with
an error status plus a client-side redirect (reported against fotokoch.de: 503 + meta refresh,
then a 200 with the real page) failed the watch even though the content was present, and the
only workaround was ignore_status_codes, which also hides genuine 404s and 500s forever.
The fetchers now keep the latest main-frame document response and judge on that - the refresh
lands during the existing extra_wait, so the 200 wins.
Playwright also waits for a settled load state before extracting, which is what produced
"Execution context was destroyed, most likely because of a navigation" when the refresh collided
with extraction.
The navigation-response tracker is installed once per page and shared between the fetcher and
action_goto_url() rather than each navigation adding its own listener - 'response' fires once per
HTTP response, hundreds of times on a heavy page, so the callbacks are worth not duplicating.
Verified one listener remains after an install plus four navigations.
Selenium is unaffected either way - it hardcodes status_code = 200 because WebDriver cannot see
the HTTP status.
Tested: new test_renavigation.py covers the interstitial case end to end and was checked to fail
without the fix and pass with it, on both fetchers. The test endpoint gates on last-seen time
rather than a hit count, because a counter lets the second check see a clean 200 and the test
then passes without the fix. Full browser suite 11 passed on playwright and on pyppeteer, 494
unit tests pass.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* Puppeteer fetcher - One content-ready deadline instead of a stopLoading watchdog per frame event
Page.stopLoading is what stops a page that would otherwise load forever waiting on a subresource
that never answers, so that we can still screenshot and scrape what rendered. That intent was
right, but it was implemented as a fire-and-forget task armed by every frame event, which measured
on a single fetch of an iframe-heavy page came to:
14 watchdog tasks spawned
11 page-wide Page.stopLoading calls
3 tasks outliving the fetch and firing against a closed page
Page.stopLoading takes no frame or loader argument - it is the Stop button, and it stops the whole
page. Verified directly: one call stopped a pending main frame and a pending iframe in the same
instant. So the other 10 calls were redundant, and because they landed at arbitrary later times
they could stop a *subsequent* navigation we actually wanted - which is the likeliest reason the
same URL fetched in 8s on one run and 35s on the next.
Replaced with a single deadline, awaited inline so nothing can outlive the fetch (there is no
create_task left in this file at all):
navigate (bounded) -> wait the configured delay -> Page.stopLoading -> extract
The delay is measured from when navigation finished, not from when it started. Anchoring it to the
start would quietly rob a slow-loading page of its settle time, and letting JS-rendered content
appear after load is the whole point of the setting. Verified with a server that takes 5s to answer
and renders via JS 2s after load: total 9.6s for a 4s delay, and the late content is captured.
Because a page is never reliably "finished" - many sites navigate as part of their normal design -
the delay restarts when the MAIN frame replaces its document, so a redirect or interstitial gets
the same settle time the first document got. Iframes do not restart it, and it is capped by
BROWSER_CONTENT_READY_MAX_RESETS (default 2).
Only the existing "wait n seconds before extracting text" stays user-facing;
BROWSER_NAVIGATION_TIMEOUT_SECONDS is a safety net with a sane default rather than a second knob
for users to reason about. This matches what other scrapers do: bound the navigation, do not fail
when it times out, settle, then extract.
Timings are also more predictable now - the four reported URLs went from 5-35s of variance to
4.6-7.2s at a 3s delay, all with full content and a 200.
Tested: 11 passed pyppeteer browser suite, 7 passed playwright, 494 unit + llm.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
856 lines
33 KiB
YAML
856 lines
33 KiB
YAML
name: ChangeDetection.io App Test
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
python-version:
|
|
description: 'Python version to use'
|
|
required: true
|
|
type: string
|
|
default: '3.11'
|
|
skip-pypuppeteer:
|
|
description: 'Skip PyPuppeteer (not supported in 3.11/3.12)'
|
|
required: false
|
|
type: boolean
|
|
default: false
|
|
|
|
jobs:
|
|
# Build the Docker image once and share it with all test jobs
|
|
build:
|
|
runs-on: ubuntu-latest
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Set up Python ${{ env.PYTHON_VERSION }}
|
|
uses: actions/setup-python@v7
|
|
with:
|
|
python-version: ${{ env.PYTHON_VERSION }}
|
|
|
|
- name: Cache pip packages
|
|
uses: actions/cache@v6
|
|
with:
|
|
path: ~/.cache/pip
|
|
key: ${{ runner.os }}-pip-py${{ env.PYTHON_VERSION }}-${{ hashFiles('requirements.txt') }}
|
|
restore-keys: |
|
|
${{ runner.os }}-pip-py${{ env.PYTHON_VERSION }}-
|
|
${{ runner.os }}-pip-
|
|
|
|
- name: Get current date for cache key
|
|
id: date
|
|
run: echo "date=$(date +'%Y-%m-%d')" >> $GITHUB_OUTPUT
|
|
|
|
- name: Set up Docker Buildx
|
|
uses: docker/setup-buildx-action@v4
|
|
|
|
- name: Build changedetection.io container for testing under Python ${{ env.PYTHON_VERSION }}
|
|
uses: docker/build-push-action@v7
|
|
with:
|
|
context: ./
|
|
file: ./Dockerfile
|
|
build-args: |
|
|
PYTHON_VERSION=${{ env.PYTHON_VERSION }}
|
|
LOGGER_LEVEL=TRACE
|
|
tags: test-changedetectionio
|
|
load: true
|
|
cache-from: type=gha,scope=build-${{ github.ref_name }}-py${{ env.PYTHON_VERSION }}-${{ hashFiles('requirements.txt', 'Dockerfile') }}-${{ steps.date.outputs.date }}
|
|
cache-to: type=gha,mode=max,scope=build-${{ github.ref_name }}-py${{ env.PYTHON_VERSION }}-${{ hashFiles('requirements.txt', 'Dockerfile') }}-${{ steps.date.outputs.date }}
|
|
|
|
- name: Verify build
|
|
run: |
|
|
echo "---- Built for Python ${{ env.PYTHON_VERSION }} -----"
|
|
docker run test-changedetectionio bash -c 'pip list'
|
|
|
|
- name: We should be Python ${{ env.PYTHON_VERSION }} ...
|
|
run: |
|
|
docker run test-changedetectionio bash -c 'python3 --version'
|
|
|
|
- name: Save Docker image
|
|
run: |
|
|
docker save test-changedetectionio -o /tmp/test-changedetectionio.tar
|
|
|
|
- name: Upload Docker image artifact
|
|
uses: actions/upload-artifact@v7
|
|
with:
|
|
name: test-changedetectionio-${{ env.PYTHON_VERSION }}
|
|
path: /tmp/test-changedetectionio.tar
|
|
retention-days: 1
|
|
|
|
# Unit tests (lightweight, no ancillary services needed)
|
|
unit-tests:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
timeout-minutes: 10
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Download Docker image artifact
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: test-changedetectionio-${{ env.PYTHON_VERSION }}
|
|
path: /tmp
|
|
|
|
- name: Load Docker image
|
|
run: |
|
|
docker load -i /tmp/test-changedetectionio.tar
|
|
|
|
- name: Run Unit Tests
|
|
run: |
|
|
docker run test-changedetectionio bash -c 'cd changedetectionio;pytest tests/unit/ tests/llm/'
|
|
|
|
# Basic pytest tests with ancillary services
|
|
basic-tests:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
timeout-minutes: 25
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Download Docker image artifact
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: test-changedetectionio-${{ env.PYTHON_VERSION }}
|
|
path: /tmp
|
|
|
|
- name: Load Docker image
|
|
run: |
|
|
docker load -i /tmp/test-changedetectionio.tar
|
|
|
|
- name: Test built container with Pytest
|
|
run: |
|
|
docker network inspect changedet-network >/dev/null 2>&1 || docker network create changedet-network
|
|
docker run --name test-cdio-basic-tests --network changedet-network test-changedetectionio bash -c 'cd changedetectionio && ./run_basic_tests.sh'
|
|
|
|
- name: Test CLI options
|
|
run: |
|
|
docker network inspect changedet-network >/dev/null 2>&1 || docker network create changedet-network
|
|
docker run --name test-cdio-cli-opts --network changedet-network test-changedetectionio bash -c 'changedetectionio/test_cli_opts.sh' &> cli-opts-output.txt
|
|
echo "=== CLI Options Test Output ==="
|
|
cat cli-opts-output.txt
|
|
|
|
- name: CLI Memory Test
|
|
run: |
|
|
echo "=== Checking CLI batch mode memory usage ==="
|
|
# Extract RSS memory value from output
|
|
RSS_MB=$(grep -oP "Memory consumption before worker shutdown: RSS=\K[\d.]+" cli-opts-output.txt | head -1 || echo "0")
|
|
echo "RSS Memory: ${RSS_MB} MB"
|
|
|
|
# Check if RSS is less than 100MB
|
|
if [ -n "$RSS_MB" ]; then
|
|
if (( $(echo "$RSS_MB < 100" | bc -l) )); then
|
|
echo "✓ Memory usage is acceptable: ${RSS_MB} MB < 100 MB"
|
|
else
|
|
echo "✗ Memory usage too high: ${RSS_MB} MB >= 100 MB"
|
|
exit 1
|
|
fi
|
|
else
|
|
echo "⚠ Could not extract memory usage, skipping check"
|
|
fi
|
|
|
|
- name: Extract memory report and logs
|
|
if: always()
|
|
uses: ./.github/actions/extract-memory-report
|
|
with:
|
|
container-name: test-cdio-basic-tests
|
|
python-version: ${{ env.PYTHON_VERSION }}
|
|
|
|
- name: Store test artifacts
|
|
if: always()
|
|
uses: actions/upload-artifact@v7
|
|
with:
|
|
name: test-cdio-basic-tests-output-py${{ env.PYTHON_VERSION }}
|
|
path: output-logs
|
|
|
|
- name: Store CLI test output
|
|
if: always()
|
|
uses: actions/upload-artifact@v7
|
|
with:
|
|
name: test-cdio-cli-opts-output-py${{ env.PYTHON_VERSION }}
|
|
path: cli-opts-output.txt
|
|
|
|
# Playwright tests
|
|
playwright-tests:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
timeout-minutes: 10
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Download Docker image artifact
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: test-changedetectionio-${{ env.PYTHON_VERSION }}
|
|
path: /tmp
|
|
|
|
- name: Load Docker image
|
|
run: |
|
|
docker load -i /tmp/test-changedetectionio.tar
|
|
|
|
- name: Spin up ancillary services
|
|
run: |
|
|
docker network create changedet-network
|
|
docker run --network changedet-network -d -e "LOG_LEVEL=TRACE" --cap-add=SYS_ADMIN --name sockpuppetbrowser --hostname sockpuppetbrowser --rm -p 3000:3000 dgtlmoon/sockpuppetbrowser:latest
|
|
docker run --network changedet-network -d -e "LOG_LEVEL=TRACE" --cap-add=SYS_ADMIN --name sockpuppetbrowser-custom-url --hostname sockpuppetbrowser-custom-url -p 3001:3000 --rm dgtlmoon/sockpuppetbrowser:latest
|
|
|
|
- name: Playwright - Specific tests in built container
|
|
run: |
|
|
# Deliberately fail fast - the first failure is nearly always the real problem and it
|
|
# keeps the run short. Each file is wrapped in its own log group and the failing one is
|
|
# named explicitly, because everything after it is SKIPPED rather than run, and that is
|
|
# otherwise easy to misread as "the whole browser suite broke".
|
|
for t in tests/fetchers/test_content.py tests/test_errorhandling.py tests/visualselector/test_fetch_data.py tests/fetchers/test_custom_js_before_content.py tests/fetchers/test_renavigation.py; do
|
|
echo "::group::pytest $t"
|
|
if ! docker run --rm -e "FLASK_SERVER_NAME=cdio" -e "PLAYWRIGHT_DRIVER_URL=ws://sockpuppetbrowser:3000" --network changedet-network --hostname=cdio test-changedetectionio \
|
|
bash -c "cd changedetectionio;pytest -vv --capture=tee-sys --showlocals --tb=long --live-server-host=0.0.0.0 --live-server-port=5004 $t"; then
|
|
echo "::endgroup::"
|
|
echo "::error::$t FAILED - stopping here. Any later test file and the remaining steps of this job were SKIPPED, not failed."
|
|
exit 1
|
|
fi
|
|
echo "::endgroup::"
|
|
done
|
|
|
|
- name: Playwright - Headers and requests
|
|
run: |
|
|
docker run --name "changedet" --hostname changedet --rm -e "FLASK_SERVER_NAME=changedet" -e "PLAYWRIGHT_DRIVER_URL=ws://sockpuppetbrowser:3000?dumpio=true" --network changedet-network test-changedetectionio bash -c 'find .; cd changedetectionio; pytest --live-server-host=0.0.0.0 --live-server-port=5004 tests/test_request.py; pwd;find .'
|
|
|
|
- name: Playwright - Restock detection
|
|
run: |
|
|
docker run --rm --name "changedet" -e "FLASK_SERVER_NAME=changedet" -e "PLAYWRIGHT_DRIVER_URL=ws://sockpuppetbrowser:3000" --network changedet-network test-changedetectionio bash -c 'cd changedetectionio;pytest --live-server-port=5004 --live-server-host=0.0.0.0 tests/restock/test_restock.py'
|
|
|
|
# Pyppeteer tests
|
|
pyppeteer-tests:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
if: ${{ inputs.skip-pypuppeteer == false }}
|
|
timeout-minutes: 10
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Download Docker image artifact
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: test-changedetectionio-${{ env.PYTHON_VERSION }}
|
|
path: /tmp
|
|
|
|
- name: Load Docker image
|
|
run: |
|
|
docker load -i /tmp/test-changedetectionio.tar
|
|
|
|
- name: Spin up ancillary services
|
|
run: |
|
|
docker network create changedet-network
|
|
docker run --network changedet-network -d -e "LOG_LEVEL=TRACE" --cap-add=SYS_ADMIN --name sockpuppetbrowser --hostname sockpuppetbrowser --rm -p 3000:3000 dgtlmoon/sockpuppetbrowser:latest
|
|
|
|
- name: Pyppeteer - Specific tests in built container
|
|
run: |
|
|
# Fail fast, but name the file that failed - see the note in the playwright job above
|
|
for t in tests/fetchers/test_content.py tests/test_errorhandling.py tests/visualselector/test_fetch_data.py tests/fetchers/test_custom_js_before_content.py tests/fetchers/test_renavigation.py; do
|
|
echo "::group::pytest $t"
|
|
if ! docker run --rm -e "FLASK_SERVER_NAME=cdio" -e "FAST_PUPPETEER_CHROME_FETCHER=True" -e "PLAYWRIGHT_DRIVER_URL=ws://sockpuppetbrowser:3000" --network changedet-network --hostname=cdio test-changedetectionio \
|
|
bash -c "cd changedetectionio;pytest --live-server-host=0.0.0.0 --live-server-port=5004 $t"; then
|
|
echo "::endgroup::"
|
|
echo "::error::$t FAILED - stopping here. Any later test file and the remaining steps of this job were SKIPPED, not failed."
|
|
exit 1
|
|
fi
|
|
echo "::endgroup::"
|
|
done
|
|
|
|
- name: Pyppeteer - Headers and requests checks
|
|
run: |
|
|
docker run --name "changedet" --hostname changedet --rm -e "FAST_PUPPETEER_CHROME_FETCHER=True" -e "FLASK_SERVER_NAME=changedet" -e "PLAYWRIGHT_DRIVER_URL=ws://sockpuppetbrowser:3000?dumpio=true" --network changedet-network test-changedetectionio bash -c 'cd changedetectionio; pytest --live-server-host=0.0.0.0 --live-server-port=5004 tests/test_request.py'
|
|
|
|
- name: Pyppeteer - Restock detection
|
|
run: |
|
|
docker run --rm --name "changedet" -e "FLASK_SERVER_NAME=changedet" -e "FAST_PUPPETEER_CHROME_FETCHER=True" -e "PLAYWRIGHT_DRIVER_URL=ws://sockpuppetbrowser:3000" --network changedet-network test-changedetectionio bash -c 'cd changedetectionio;pytest --live-server-port=5004 --live-server-host=0.0.0.0 tests/restock/test_restock.py'
|
|
|
|
# Selenium tests
|
|
selenium-tests:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
timeout-minutes: 10
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Download Docker image artifact
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: test-changedetectionio-${{ env.PYTHON_VERSION }}
|
|
path: /tmp
|
|
|
|
- name: Load Docker image
|
|
run: |
|
|
docker load -i /tmp/test-changedetectionio.tar
|
|
|
|
- name: Spin up ancillary services
|
|
run: |
|
|
docker network create changedet-network
|
|
docker run --network changedet-network -d --hostname selenium -p 4444:4444 --rm --shm-size="2g" selenium/standalone-chrome:4
|
|
sleep 3
|
|
|
|
- name: Specific tests for headers and requests checks with Selenium
|
|
run: |
|
|
|
|
docker run --name "changedet" --hostname changedet --rm -e "FLASK_SERVER_NAME=changedet" -e "WEBDRIVER_URL=http://selenium:4444/wd/hub" --network changedet-network test-changedetectionio bash -c 'cd changedetectionio; pytest --live-server-host=0.0.0.0 --live-server-port=5004 tests/test_request.py'
|
|
|
|
- name: Specific tests in built container for Selenium
|
|
run: |
|
|
docker run --rm -e "WEBDRIVER_URL=http://selenium:4444/wd/hub" --network changedet-network test-changedetectionio bash -c 'cd changedetectionio;pytest tests/fetchers/test_content.py && pytest tests/test_errorhandling.py'
|
|
|
|
|
|
# SMTP tests
|
|
smtp-tests:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
timeout-minutes: 10
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Download Docker image artifact
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: test-changedetectionio-${{ env.PYTHON_VERSION }}
|
|
path: /tmp
|
|
|
|
- name: Load Docker image
|
|
run: |
|
|
docker load -i /tmp/test-changedetectionio.tar
|
|
|
|
- name: Spin up SMTP test server
|
|
run: |
|
|
docker network create changedet-network
|
|
docker run --network changedet-network -d -p 11025:11025 -p 11080:11080 --hostname mailserver test-changedetectionio bash -c 'pip3 install aiosmtpd && python changedetectionio/tests/smtp/smtp-test-server.py'
|
|
|
|
- name: Test SMTP notification mime types
|
|
run: |
|
|
docker run --rm --network changedet-network test-changedetectionio bash -c 'cd changedetectionio;pytest tests/smtp/test_notification_smtp.py'
|
|
|
|
nginx-reverse-proxy:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
timeout-minutes: 10
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Download Docker image artifact
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: test-changedetectionio-${{ env.PYTHON_VERSION }}
|
|
path: /tmp
|
|
|
|
- name: Load Docker image
|
|
run: |
|
|
docker load -i /tmp/test-changedetectionio.tar
|
|
|
|
- name: Spin up services
|
|
run: |
|
|
docker network create changedet-network
|
|
|
|
# Start changedetection.io container with X-Forwarded headers support
|
|
docker run --name changedet-app --hostname changedet-app --network changedet-network \
|
|
-e USE_X_SETTINGS=true \
|
|
-d test-changedetectionio
|
|
sleep 3
|
|
|
|
- name: Start nginx reverse proxy
|
|
run: |
|
|
# Start nginx with our test configuration
|
|
docker run --name nginx-proxy --network changedet-network -d -p 8080:80 --rm \
|
|
-v ${{ github.workspace }}/.github/nginx-reverse-proxy-test.conf:/etc/nginx/conf.d/default.conf:ro \
|
|
nginx:alpine
|
|
sleep 2
|
|
|
|
- name: Test reverse proxy - root path
|
|
run: |
|
|
echo "=== Testing nginx reverse proxy at root path ==="
|
|
curl --retry-connrefused --retry 6 -s http://localhost:8080/ > /tmp/nginx-test-root.html
|
|
|
|
# Check for changedetection.io UI elements
|
|
if grep -q "checkbox-uuid" /tmp/nginx-test-root.html; then
|
|
echo "✓ Found checkbox-uuid in response"
|
|
else
|
|
echo "ERROR: checkbox-uuid not found in response"
|
|
cat /tmp/nginx-test-root.html
|
|
exit 1
|
|
fi
|
|
|
|
# Check for watchlist content
|
|
if grep -q -i "watch" /tmp/nginx-test-root.html; then
|
|
echo "✓ Found watch/watchlist content in response"
|
|
else
|
|
echo "ERROR: watchlist content not found"
|
|
cat /tmp/nginx-test-root.html
|
|
exit 1
|
|
fi
|
|
|
|
echo "✓ Root path reverse proxy working correctly"
|
|
|
|
- name: Test reverse proxy - subpath with X-Forwarded-Prefix
|
|
run: |
|
|
echo "=== Testing nginx reverse proxy at subpath /changedet-sub/ ==="
|
|
curl --retry-connrefused --retry 6 -s http://localhost:8080/changedet-sub/ > /tmp/nginx-test-subpath.html
|
|
|
|
# Check for changedetection.io UI elements
|
|
if grep -q "checkbox-uuid" /tmp/nginx-test-subpath.html; then
|
|
echo "✓ Found checkbox-uuid in subpath response"
|
|
else
|
|
echo "ERROR: checkbox-uuid not found in subpath response"
|
|
cat /tmp/nginx-test-subpath.html
|
|
exit 1
|
|
fi
|
|
|
|
echo "✓ Subpath reverse proxy working correctly"
|
|
|
|
- name: Test API through reverse proxy subpath
|
|
run: |
|
|
echo "=== Testing API endpoints through nginx subpath /changedet-sub/ ==="
|
|
|
|
# Extract API key from the changedetection.io datastore
|
|
API_KEY=$(docker exec changedet-app cat /datastore/changedetection.json | grep -o '"api_access_token": *"[^"]*"' | cut -d'"' -f4)
|
|
|
|
if [ -z "$API_KEY" ]; then
|
|
echo "ERROR: Could not extract API key from datastore"
|
|
docker exec changedet-app cat /datastore/changedetection.json
|
|
exit 1
|
|
fi
|
|
|
|
echo "✓ Extracted API key: ${API_KEY:0:8}..."
|
|
|
|
# Create a watch via API through nginx proxy subpath
|
|
echo "Creating watch via POST to /changedet-sub/api/v1/watch"
|
|
RESPONSE=$(curl -s -w "\n%{http_code}" -X POST "http://localhost:8080/changedet-sub/api/v1/watch" \
|
|
-H "x-api-key: ${API_KEY}" \
|
|
-H "Content-Type: application/json" \
|
|
-d '{
|
|
"url": "https://example.com/test-nginx-proxy",
|
|
"tag": "nginx-test"
|
|
}')
|
|
|
|
HTTP_CODE=$(echo "$RESPONSE" | tail -n1)
|
|
BODY=$(echo "$RESPONSE" | head -n-1)
|
|
|
|
if [ "$HTTP_CODE" != "201" ]; then
|
|
echo "ERROR: Expected HTTP 201, got $HTTP_CODE"
|
|
echo "Response: $BODY"
|
|
exit 1
|
|
fi
|
|
|
|
echo "✓ Watch created successfully (HTTP 201)"
|
|
|
|
# Extract the watch UUID from response
|
|
WATCH_UUID=$(echo "$BODY" | grep -o '"uuid": *"[^"]*"' | cut -d'"' -f4)
|
|
echo "✓ Watch UUID: $WATCH_UUID"
|
|
|
|
# Update the watch via PUT through nginx proxy subpath
|
|
echo "Updating watch via PUT to /changedet-sub/api/v1/watch/${WATCH_UUID}"
|
|
RESPONSE=$(curl -s -w "\n%{http_code}" -X PUT "http://localhost:8080/changedet-sub/api/v1/watch/${WATCH_UUID}" \
|
|
-H "x-api-key: ${API_KEY}" \
|
|
-H "Content-Type: application/json" \
|
|
-d '{
|
|
"paused": true
|
|
}')
|
|
|
|
HTTP_CODE=$(echo "$RESPONSE" | tail -n1)
|
|
BODY=$(echo "$RESPONSE" | head -n-1)
|
|
|
|
if [ "$HTTP_CODE" != "200" ]; then
|
|
echo "ERROR: Expected HTTP 200, got $HTTP_CODE"
|
|
echo "Response: $BODY"
|
|
exit 1
|
|
fi
|
|
|
|
if echo "$BODY" | grep -q 'OK'; then
|
|
echo "✓ Watch updated successfully (HTTP 200, response: OK)"
|
|
else
|
|
echo "ERROR: Expected response 'OK', got: $BODY"
|
|
echo "Response: $BODY"
|
|
exit 1
|
|
fi
|
|
|
|
# Verify the watch is paused via GET
|
|
echo "Verifying watch is paused via GET"
|
|
RESPONSE=$(curl -s "http://localhost:8080/changedet-sub/api/v1/watch/${WATCH_UUID}" \
|
|
-H "x-api-key: ${API_KEY}")
|
|
|
|
if echo "$RESPONSE" | grep -q '"paused": *true'; then
|
|
echo "✓ Watch is paused as expected"
|
|
else
|
|
echo "ERROR: Watch paused state not confirmed"
|
|
echo "Response: $RESPONSE"
|
|
exit 1
|
|
fi
|
|
|
|
echo "✓ API tests through nginx subpath completed successfully"
|
|
|
|
- name: Cleanup nginx test
|
|
if: always()
|
|
run: |
|
|
docker logs nginx-proxy || true
|
|
docker logs changedet-app || true
|
|
docker stop nginx-proxy changedet-app || true
|
|
docker rm nginx-proxy changedet-app || true
|
|
|
|
|
|
|
|
# Proxy tests
|
|
proxy-tests:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
timeout-minutes: 10
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Download Docker image artifact
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: test-changedetectionio-${{ env.PYTHON_VERSION }}
|
|
path: /tmp
|
|
|
|
- name: Load Docker image
|
|
run: |
|
|
docker load -i /tmp/test-changedetectionio.tar
|
|
|
|
- name: Spin up services
|
|
run: |
|
|
docker network create changedet-network
|
|
docker run --network changedet-network -d --hostname selenium -p 4444:4444 --rm --shm-size="2g" selenium/standalone-chrome:4
|
|
docker run --network changedet-network -d -e "LOG_LEVEL=TRACE" --cap-add=SYS_ADMIN --name sockpuppetbrowser --hostname sockpuppetbrowser --rm -p 3000:3000 dgtlmoon/sockpuppetbrowser:latest
|
|
docker run --network changedet-network -d -e "LOG_LEVEL=TRACE" --cap-add=SYS_ADMIN --name sockpuppetbrowser-custom-url --hostname sockpuppetbrowser-custom-url -p 3001:3000 --rm dgtlmoon/sockpuppetbrowser:latest
|
|
|
|
- name: Test proxy Squid style interaction
|
|
run: |
|
|
cd changedetectionio
|
|
./run_proxy_tests.sh
|
|
docker ps
|
|
cd ..
|
|
|
|
- name: Test proxy SOCKS5 style interaction
|
|
run: |
|
|
cd changedetectionio
|
|
./run_socks_proxy_tests.sh
|
|
cd ..
|
|
|
|
# Custom browser URL tests
|
|
custom-browser-tests:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
timeout-minutes: 10
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Download Docker image artifact
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: test-changedetectionio-${{ env.PYTHON_VERSION }}
|
|
path: /tmp
|
|
|
|
- name: Load Docker image
|
|
run: |
|
|
docker load -i /tmp/test-changedetectionio.tar
|
|
|
|
- name: Spin up ancillary services
|
|
run: |
|
|
docker network create changedet-network
|
|
docker run --network changedet-network -d -e "LOG_LEVEL=TRACE" --cap-add=SYS_ADMIN --name sockpuppetbrowser --hostname sockpuppetbrowser --rm -p 3000:3000 dgtlmoon/sockpuppetbrowser:latest
|
|
docker run --network changedet-network -d -e "LOG_LEVEL=TRACE" --cap-add=SYS_ADMIN --name sockpuppetbrowser-custom-url --hostname sockpuppetbrowser-custom-url -p 3001:3000 --rm dgtlmoon/sockpuppetbrowser:latest
|
|
|
|
- name: Test custom browser URL
|
|
run: |
|
|
cd changedetectionio
|
|
./run_custom_browser_url_tests.sh
|
|
|
|
processor-plugin-tests:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
timeout-minutes: 20
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Download Docker image artifact
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: test-changedetectionio-${{ env.PYTHON_VERSION }}
|
|
path: /tmp
|
|
|
|
- name: Load Docker image
|
|
run: |
|
|
docker load -i /tmp/test-changedetectionio.tar
|
|
|
|
- name: Basic processor plugin registration and checks
|
|
run: |
|
|
docker run -e EXTRA_PACKAGES=changedetection.io-osint-processor test-changedetectionio bash -c 'cd changedetectionio;pytest -vvv -s tests/plugins/test_processor.py::test_check_plugin_processor'
|
|
|
|
- name: Plugin get_html_head_extras hook injects into base.html
|
|
run: |
|
|
docker run test-changedetectionio bash -c 'cd changedetectionio;pytest -vvv -s tests/plugins/test_html_head_extras.py'
|
|
|
|
# Container startup tests
|
|
container-tests:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
timeout-minutes: 10
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Download Docker image artifact
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: test-changedetectionio-${{ env.PYTHON_VERSION }}
|
|
path: /tmp
|
|
|
|
- name: Load Docker image
|
|
run: |
|
|
docker load -i /tmp/test-changedetectionio.tar
|
|
|
|
- name: Test container starts+runs basically without error
|
|
run: |
|
|
docker run --name test-changedetectionio -p 5556:5000 -d test-changedetectionio
|
|
sleep 3
|
|
curl --retry-connrefused --retry 6 -s http://localhost:5556 |grep -q checkbox-uuid
|
|
curl --retry-connrefused --retry 6 -s -g -6 "http://[::1]:5556"|grep -q checkbox-uuid
|
|
docker logs test-changedetectionio 2>/dev/null | grep 'TRACE log is enabled' || exit 1
|
|
docker logs test-changedetectionio 2>/dev/null | grep 'DEBUG' || exit 1
|
|
docker kill test-changedetectionio
|
|
|
|
- name: Test HTTPS SSL mode
|
|
run: |
|
|
openssl req -x509 -newkey rsa:4096 -keyout privkey.pem -out cert.pem -days 365 -nodes -subj "/CN=localhost"
|
|
docker run --name test-changedetectionio-ssl --rm -e SSL_CERT_FILE=cert.pem -e SSL_PRIVKEY_FILE=privkey.pem -p 5000:5000 -v ./cert.pem:/app/cert.pem -v ./privkey.pem:/app/privkey.pem -d test-changedetectionio
|
|
sleep 3
|
|
curl --retry-connrefused --retry 6 -k https://localhost:5000 -v|grep -q checkbox-uuid
|
|
docker kill test-changedetectionio-ssl
|
|
|
|
- name: Test IPv6 Mode
|
|
run: |
|
|
docker run --name test-changedetectionio-ipv6 --rm -p 5000:5000 -e LISTEN_HOST=:: -d test-changedetectionio
|
|
sleep 3
|
|
curl --retry-connrefused --retry 6 http://[::1]:5000 -v|grep -q checkbox-uuid
|
|
docker kill test-changedetectionio-ipv6
|
|
|
|
# Signal tests
|
|
signal-tests:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
timeout-minutes: 10
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Download Docker image artifact
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: test-changedetectionio-${{ env.PYTHON_VERSION }}
|
|
path: /tmp
|
|
|
|
- name: Load Docker image
|
|
run: |
|
|
docker load -i /tmp/test-changedetectionio.tar
|
|
|
|
- name: Test SIGTERM and SIGINT signal shutdown
|
|
run: |
|
|
echo SIGINT Shutdown request test
|
|
docker run --name sig-test -d test-changedetectionio
|
|
sleep 3
|
|
echo ">>> Sending SIGINT to sig-test container"
|
|
docker kill --signal=SIGINT sig-test
|
|
sleep 3
|
|
docker ps
|
|
docker logs sig-test 2>&1 | grep 'Shutdown: Got Signal - SIGINT' || exit 1
|
|
test -z "`docker ps|grep sig-test`"
|
|
if [ $? -ne 0 ]; then
|
|
echo "Looks like container was running when it shouldnt be"
|
|
docker ps
|
|
exit 1
|
|
fi
|
|
docker rm sig-test
|
|
|
|
echo SIGTERM Shutdown request test
|
|
docker run --name sig-test -d test-changedetectionio
|
|
sleep 3
|
|
echo ">>> Sending SIGTERM to sig-test container"
|
|
docker kill --signal=SIGTERM sig-test
|
|
sleep 3
|
|
docker ps
|
|
docker logs sig-test 2>&1 | grep 'Shutdown: Got Signal - SIGTERM' || exit 1
|
|
test -z "`docker ps|grep sig-test`"
|
|
if [ $? -ne 0 ]; then
|
|
echo "Looks like container was running when it shouldnt be"
|
|
docker ps
|
|
exit 1
|
|
fi
|
|
docker rm sig-test
|
|
|
|
# Upgrade path test
|
|
upgrade-path-test:
|
|
runs-on: ubuntu-latest
|
|
needs: build
|
|
timeout-minutes: 25
|
|
env:
|
|
PYTHON_VERSION: ${{ inputs.python-version }}
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
with:
|
|
fetch-depth: 0 # Fetch all history and tags for upgrade testing
|
|
|
|
- name: Set up Python ${{ env.PYTHON_VERSION }}
|
|
uses: actions/setup-python@v7
|
|
with:
|
|
python-version: ${{ env.PYTHON_VERSION }}
|
|
|
|
- name: Check upgrade works without error
|
|
run: |
|
|
echo "=== Testing upgrade path from 0.49.1 to ${{ github.ref_name }} (${{ github.sha }}) ==="
|
|
sudo apt-get update && sudo apt-get install -y --no-install-recommends \
|
|
g++ \
|
|
gcc \
|
|
libc-dev \
|
|
libffi-dev \
|
|
libjpeg-dev \
|
|
libssl-dev \
|
|
libxslt-dev \
|
|
make \
|
|
patch \
|
|
pkg-config \
|
|
zlib1g-dev
|
|
|
|
# Checkout old version and create datastore
|
|
git checkout 0.49.1
|
|
python3 -m venv .venv
|
|
source .venv/bin/activate
|
|
pip install -r requirements.txt
|
|
pip install 'pyOpenSSL>=23.2.0'
|
|
|
|
echo "=== Running version 0.49.1 to create datastore ==="
|
|
ALLOW_IANA_RESTRICTED_ADDRESSES=true python3 ./changedetection.py -C -d /tmp/data &
|
|
APP_PID=$!
|
|
|
|
# Wait for app to be ready
|
|
echo "Waiting for 0.49.1 to be ready..."
|
|
sleep 6
|
|
|
|
# Extract API key from datastore (0.49.1 uses url-watches.json)
|
|
API_KEY=$(jq -r '.settings.application.api_access_token // empty' /tmp/data/url-watches.json)
|
|
echo "API Key: ${API_KEY:0:8}..."
|
|
|
|
# Create a watch with tag "github-group-test" via API
|
|
echo "Creating test watch with tag via API..."
|
|
curl -X POST "http://127.0.0.1:5000/api/v1/watch" \
|
|
-H "x-api-key: ${API_KEY}" \
|
|
-H "Content-Type: application/json" \
|
|
--show-error --fail \
|
|
--retry 6 --retry-delay 1 --retry-connrefused \
|
|
-d '{
|
|
"url": "https://example.com/upgrade-test",
|
|
"tag": "github-group-test"
|
|
}'
|
|
|
|
echo "✓ Created watch with tag 'github-group-test'"
|
|
|
|
# Create a specific test URL watch
|
|
echo "Creating test URL watch via API..."
|
|
curl -X POST "http://127.0.0.1:5000/api/v1/watch" \
|
|
-H "x-api-key: ${API_KEY}" \
|
|
-H "Content-Type: application/json" \
|
|
--show-error --fail \
|
|
-d '{
|
|
"url": "http://localhost/test.txt"
|
|
}'
|
|
|
|
echo "✓ Created watch for 'http://localhost/test.txt' in version 0.49.1"
|
|
|
|
# Stop the old version gracefully
|
|
kill $APP_PID
|
|
wait $APP_PID || true
|
|
echo "✓ Version 0.49.1 stopped"
|
|
|
|
# Upgrade to current version (use commit SHA since we're in detached HEAD)
|
|
echo "Upgrading to commit ${{ github.sha }}"
|
|
git checkout ${{ github.sha }}
|
|
pip install -r requirements.txt
|
|
|
|
echo "=== Running current version (commit ${{ github.sha }}) with old datastore (testing mode) ==="
|
|
ALLOW_IANA_RESTRICTED_ADDRESSES=true TESTING_SHUTDOWN_AFTER_DATASTORE_LOAD=1 python3 ./changedetection.py -d /tmp/data > /tmp/upgrade-test.log 2>&1
|
|
|
|
echo "=== Upgrade test output ==="
|
|
cat /tmp/upgrade-test.log
|
|
echo "✓ Datastore upgraded successfully"
|
|
|
|
# Now start the current version normally to verify the tag survived
|
|
echo "=== Starting current version to verify tag exists after upgrade ==="
|
|
ALLOW_IANA_RESTRICTED_ADDRESSES=true timeout 20 python3 ./changedetection.py -d /tmp/data > /tmp/ui-test.log 2>&1 &
|
|
APP_PID=$!
|
|
|
|
# Wait for app to be ready and fetch UI
|
|
echo "Waiting for current version to be ready..."
|
|
sleep 5
|
|
curl --retry 6 --retry-delay 1 --retry-connrefused --silent http://127.0.0.1:5000 > /tmp/ui-output.html
|
|
|
|
# Verify tag exists in UI
|
|
if grep -q "github-group-test" /tmp/ui-output.html; then
|
|
echo "✓ Tag 'github-group-test' found in UI after upgrade"
|
|
else
|
|
echo "ERROR: Tag 'github-group-test' not found in UI after upgrade"
|
|
echo "=== UI Output ==="
|
|
cat /tmp/ui-output.html
|
|
echo "=== App Log ==="
|
|
cat /tmp/ui-test.log
|
|
kill $APP_PID || true
|
|
exit 1
|
|
fi
|
|
|
|
# Verify test URL exists in UI
|
|
if grep -q "http://localhost/test.txt" /tmp/ui-output.html; then
|
|
echo "✓ Watch URL 'http://localhost/test.txt' found in UI after upgrade"
|
|
else
|
|
echo "ERROR: Watch URL 'http://localhost/test.txt' not found in UI after upgrade"
|
|
echo "=== UI Output ==="
|
|
cat /tmp/ui-output.html
|
|
echo "=== App Log ==="
|
|
cat /tmp/ui-test.log
|
|
kill $APP_PID || true
|
|
exit 1
|
|
fi
|
|
|
|
# Cleanup
|
|
kill $APP_PID || true
|
|
wait $APP_PID || true
|
|
|
|
echo ""
|
|
echo "✓✓✓ Upgrade test passed: 0.49.1 → ${{ github.ref_name }} ✓✓✓"
|
|
echo " - Commit: ${{ github.sha }}"
|
|
echo " - Datastore migrated successfully"
|
|
echo " - Tag 'github-group-test' survived upgrade"
|
|
echo " - Watch URL 'http://localhost/test.txt' survived upgrade"
|
|
|
|
echo "✓ Upgrade test passed: 0.49.1 → ${{ github.ref_name }}"
|
|
|
|
- name: Upload upgrade test logs
|
|
if: always()
|
|
uses: actions/upload-artifact@v7
|
|
with:
|
|
name: upgrade-test-logs-py${{ env.PYTHON_VERSION }}
|
|
path: /tmp/upgrade-test.log
|