lee/container
1
0
Fork 0
mirror of https://github.com/apple/container.git synced 2026-09-13 03:05:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

LinuxContainer: Give a bit of overhead memory (#472)

Browse Source 
The guest agent isn't free, and today we were sizing the VMs memory
allotment and the containers cgroup to the same value. This change gives
some overhead memory to the VM (50MB for now) for the guest agent.
This commit is contained in:
Danny Canter
2026-01-14 13:31:34 -08:00
committed by GitHub
parent 8446f895ee
commit bbe4159649
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Sources/Containerization/LinuxContainer.swift
+14 -1
View File
@@ -404,9 +404,22 @@ extension LinuxContainer {
var modifiedRootfs = self.rootfs
modifiedRootfs.options.removeAll(where: { $0 == "ro" })
// Calculate VM memory with overhead for the guest agent.
// The container cgroup limit stays at the requested memory, but the VM
// gets an additional 50MB for the guest agent (could be higher, could be lower
// but this is a decent baseline for now).
//
// Clamp to system RAM if the total would exceed it as Virtualization.framework
// bounds us to this.
let guestAgentOverhead: UInt64 = 50.mib()
let vmMemory = min(
self.memoryInBytes + guestAgentOverhead,
ProcessInfo.processInfo.physicalMemory
)
let vmConfig = VMConfiguration(
cpus: self.cpus,
memoryInBytes: self.memoryInBytes,
memoryInBytes: vmMemory,
interfaces: self.interfaces,
mountsByID: [self.id: [modifiedRootfs] + self.config.mounts],
bootLog: self.config.bootLog,