lee/graphify
1
0
Fork 0
mirror of https://github.com/safishamsi/graphify.git synced 2026-08-28 01:06:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(llm): correct bedrock max_attempts semantics + stub botocore.config in the reasoning test (follow-up to #2283/#2288)

Browse Source 
botocore max_attempts counts the initial call, so GRAPHIFY_MAX_RETRIES must
map to _resolve_max_retries() + 1 (a value of 6 -> 7 total attempts; 0 ->
1, i.e. no retry). Also stub botocore.config in the #2288 reasoning-model
test, which broke once #2283 added the botocore.config import.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
safishamsi
2026-07-29 17:25:08 +01:00
co-authored by Claude Opus 4.8
parent 3c332ba72a
commit ffc6dc0207
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
graphify/llm.py
+2 -2
View File
@@ -1653,7 +1653,7 @@ def _call_bedrock(model: str, user_message: str, max_tokens: int = 8192, *, deep
config=botocore.config.Config(
read_timeout=_resolve_api_timeout(),
connect_timeout=10,
retries={"max_attempts": _resolve_max_retries(), "mode": "adaptive"},
retries={"max_attempts": _resolve_max_retries() + 1, "mode": "adaptive"},
),
)
@@ -2613,7 +2613,7 @@ def _call_llm(
config=botocore.config.Config(
read_timeout=_resolve_api_timeout(),
connect_timeout=10,
retries={"max_attempts": _resolve_max_retries(), "mode": "adaptive"},
retries={"max_attempts": _resolve_max_retries() + 1, "mode": "adaptive"},
),
)
resp = client.converse(
tests/test_image_vision.py
+5 -1
View File
@@ -420,9 +420,13 @@ def test_call_bedrock_parses_reasoning_model_response(monkeypatch):
botocore = types.ModuleType("botocore")
exc = types.ModuleType("botocore.exceptions")
exc.ClientError = type("ClientError", (Exception,), {})
config_mod = types.ModuleType("botocore.config")
config_mod.Config = lambda **kw: SimpleNamespace(**kw)
botocore.exceptions = exc
botocore.config = config_mod
monkeypatch.setitem(sys.modules, "botocore", botocore)
monkeypatch.setitem(sys.modules, "botocore.exceptions", exc)
monkeypatch.setitem(sys.modules, "botocore.config", config_mod)
_fake(monkeypatch)
result = llm._call_bedrock("model", "CORPUS")
@@ -442,7 +446,7 @@ def test_call_bedrock_honors_api_timeout(monkeypatch):
assert cfg is not None, "bedrock client built without a botocore config"
assert cfg.read_timeout == 1800.0
assert cfg.connect_timeout == 10
assert cfg.retries == {"max_attempts": 6, "mode": "adaptive"}
assert cfg.retries == {"max_attempts": 7, "mode": "adaptive"} # retries + initial attempt
def test_call_bedrock_api_timeout_defaults_when_unset(monkeypatch):