lee/gsmartcontrol
1
0
Fork 0
mirror of https://github.com/ashaduri/gsmartcontrol.git synced 2026-09-24 21:05:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Windows: Use Adwaita theme by default, win32 theme has too many problems (with Classic theme and with fractional dpi scaling).

Browse Source
This commit is contained in:
Alexander Shaduri
2024-11-06 14:11:08 +04:00
parent 746ebf9b02
commit 066eaec993
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packaging/gtk/etc/gtk-3.0/settings.ini
+4 -1
View File
@@ -1,2 +1,5 @@
[Settings]
gtk-theme-name=win32
# Uncomment this to enable "native" look on Windows.
# This does not work if "Classic" theme is enabled in Windows, or
# if there is fractional system scaling (e.g. 250%).
#gtk-theme-name=win32
src/gui/gsc_init.cpp
+5 -2
View File
@@ -479,11 +479,13 @@ bool app_init_and_loop(int& argc, char**& argv)
}
}
// Windows "Classic" theme is broken under GTK+3's "win32" theme.
// GTK+3's "win32" theme is broken when Windows "Classic" theme is used.
// Make sure we fall back to Adwaita (which works, but looks non-native)
// for platforms which support "Classic" theme - Windows Server and Windows Vista / 7.
// Windows 8 / 10 don't support "Classic" so native look is preferred.
{
// Note: Win32 theme is also incompatible with fractional scaling.
// Note: Win32 theme is disabled for now, and the default built-in Adwaita is used.
/* if constexpr(BuildEnv::is_kernel_family_windows()) {
Glib::RefPtr<Gtk::Settings> gtk_settings = Gtk::Settings::get_default();
if (gtk_settings) {
const Glib::ustring theme_name = gtk_settings->property_gtk_theme_name().get_value();
@@ -498,6 +500,7 @@ bool app_init_and_loop(int& argc, char**& argv)
}
}
}
*/
// The application is dpi-aware in Windows.
// However, Gtk3 does not support fractional scaling, so at 250% scaling in system settings, the UI will use 200%.