lee/gsmartcontrol
1
0
Fork 0
mirror of https://github.com/ashaduri/gsmartcontrol.git synced 2026-09-24 21:05:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed Codacy warnings in shell scripts.

Browse Source
This commit is contained in:
Alexander Shaduri
2022-01-29 21:12:36 +04:00
parent fa16ff964e
commit 90eb339a05
3 changed files with 13 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
contrib/cron-based_noadmin/cron_gather_smart.sh
+4 -4
View File
@@ -2,8 +2,8 @@
###############################################################################
# License: BSD Zero Clause License file
# Copyright:
# (C) 2008 - 2021 Alex Butcher <alex dot butcher 'at' assursys.co.uk>
# (C) 2008 - 2021 Alexander Shaduri <ashaduri@gmail.com>
# (C) 2008 - 2022 Alex Butcher <alex dot butcher 'at' assursys.co.uk>
# (C) 2008 - 2022 Alexander Shaduri <ashaduri@gmail.com>
###############################################################################
device="$1";
@@ -13,10 +13,10 @@ if [ "$device" = "" ]; then
exit 1;
fi
dev_base="`basename \"$device\"`"
dev_base=$(basename "$device")
out_file=/var/run/smart-"$dev_base"
# Change the path to smartctl if necessary.
smartctl -x "$device" 2>&1 > "$out_file"
smartctl -x "$device" > "$out_file" 2>&1
chmod 644 "$out_file"
contrib/cron-based_noadmin/smartctl_subst.sh
+3 -3
View File
@@ -2,8 +2,8 @@
###############################################################################
# License: BSD Zero Clause License file
# Copyright:
# (C) 2008 - 2021 Alex Butcher <alex dot butcher 'at' assursys.co.uk>
# (C) 2008 - 2021 Alexander Shaduri <ashaduri@gmail.com>
# (C) 2008 - 2022 Alex Butcher <alex dot butcher 'at' assursys.co.uk>
# (C) 2008 - 2022 Alexander Shaduri <ashaduri@gmail.com>
###############################################################################
if [ "$1" = "-V" ]; then
@@ -21,7 +21,7 @@ if [ "$device" = "" ]; then
exit 1;
fi
dev_base="`basename \"$device\"`"
dev_base=$(basename "$device")
out_file=/var/run/smart-"$dev_base"
cat "$out_file"
data/gsmartcontrol-root.in.sh
+6 -9
View File
@@ -2,14 +2,14 @@
###############################################################################
# License: Zlib
# Copyright:
# (C) 2008 - 2021 Alexander Shaduri <ashaduri@gmail.com>
# (C) 2008 - 2022 Alexander Shaduri <ashaduri@gmail.com>
###############################################################################
# Run gsmartcontrol with root, asking for root password first.
# export GSMARTCONTROL_SU to override a su command (e.g. "kdesu -c").
EXEC_BIN="@CMAKE_INSTALL_FULL_SBINDIR@/gsmartcontrol";
prog_name="gsmartcontrol"
program_name="gsmartcontrol"
# Preserve quotes in arguments
@@ -30,7 +30,7 @@ else
# New syntax:
# gsmartcontrol-root [--desktop=<auto|kde|gnome|other>] [program_options]
for arg in $*; do
for arg in "$@"; do
case $arg in
--desktop=*)
DESKTOP="${arg#*=}";
@@ -45,7 +45,7 @@ fi
if [ "$DESKTOP" != "auto" ] && [ "$DESKTOP" != "kde" ] && \
[ "$DESKTOP" != "gnome" ] && [ "$DESKTOP" != "other" ]; then
echo "Usage: $0 [--desktop=<auto|kde|gnome|other>] [<${prog_name}_options>]";
echo "Usage: $0 [--desktop=<auto|kde|gnome|other>] [<${program_name}_options>]";
exit 1;
fi
@@ -101,7 +101,7 @@ if [ "$GSMARTCONTROL_SU" = "" ]; then
done
if [ "$found_su" = "" ]; then
xmessage "Error launching ${prog_name}: No suitable su mechanism found.
xmessage "Error launching ${program_name}: No suitable su mechanism found.
Try installing PolKit, kdesu, gnomesu, gksu, beesu or sux first.";
exit 1;
fi
@@ -164,8 +164,5 @@ fi
# echo $full_cmd
eval $full_cmd
eval "$full_cmd"