lee/gsmartcontrol
1
0
Fork 0
mirror of https://github.com/ashaduri/gsmartcontrol.git synced 2026-09-27 14:25:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clarify Type attribute explanation and remove bold formatting

Browse Source 
- Updated tooltip to clearly explain Type indicates alarm meaning
- Removed bold formatting for "pre-failure" to reduce visual alarm
- Changed text to emphasize Type is about alarm interpretation, not current status

Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com>
This commit is contained in:
anthropic-code-agent[bot]
2026-03-06 14:52:28 +00:00
co-authored by ashaduri
parent 480e060682
commit d1d64693db
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gui/gsc_info_window.cpp
+9 -8
View File
@@ -1139,7 +1139,7 @@ void GscInfoWindow::fill_ui_ata_attributes(const StoragePropertyRepository& prop
model_columns.add(columns_->ata_attribute_table_columns.type);
num_tree_col = app_gtkmm_create_tree_view_column(columns_->ata_attribute_table_columns.type, *treeview,
_("Type"), _("Alarm condition is reached when normalized value becomes less than or equal to threshold. Type indicates whether it's a signal of drive's pre-failure time or just an old age."), false, true);
_("Type"), _("Indicates whether an alarm for this attribute signals imminent drive failure (pre-failure) or normal wear from drive age (old age)."), false, true);
// Doesn't carry that much info. Advanced users can look at the flags.
// model_columns.add(attribute_table_columns.updated);
@@ -2097,13 +2097,14 @@ void GscInfoWindow::cell_renderer_for_ata_attributes(Gtk::CellRenderer* cr,
if (column_index == columns_->ata_attribute_table_columns.displayable_name.index()) {
crt->property_weight() = Pango::WEIGHT_BOLD;
}
if (column_index == columns_->ata_attribute_table_columns.type.index()) {
if (attribute.attr_type == AtaStorageAttribute::AttributeType::Prefail) {
crt->property_weight() = Pango::WEIGHT_BOLD;
} else { // reset to default value if reloading
crt->property_weight().reset_value();
}
}
// Type column: no bold formatting needed
// if (column_index == columns_->ata_attribute_table_columns.type.index()) {
// if (attribute.attr_type == AtaStorageAttribute::AttributeType::Prefail) {
// crt->property_weight() = Pango::WEIGHT_BOLD;
// } else { // reset to default value if reloading
// crt->property_weight().reset_value();
// }
// }
if (column_index == columns_->ata_attribute_table_columns.when_failed.index()) {
if (attribute.when_failed != AtaStorageAttribute::FailTime::None) {
crt->property_weight() = Pango::WEIGHT_BOLD;