lee/heritrix3
1
0
Fork 0
mirror of https://github.com/internetarchive/heritrix3.git synced 2026-08-28 09:26:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

BrowserProcessor: guard stop() against a partially failed start()

Browse Source 
If start() throws after the proxy is started but before the browser
launches, stop() could NPE on the null fields.
This commit is contained in:
Alex Osborne
2026-07-10 15:59:47 +09:00
parent d03a43266a
commit 1b107f06c1
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
engine/src/main/java/org/archive/crawler/processor/BrowserProcessor.java
+12 -8
View File
@@ -109,15 +109,19 @@ public class BrowserProcessor extends Processor {
public void stop() {
if (!isRunning) return;
super.stop();
try {
proxy.stop();
} catch (Exception e) {
logger.log(ERROR, "Error stopping proxy server", e);
if (proxy != null) {
try {
proxy.stop();
} catch (Exception e) {
logger.log(ERROR, "Error stopping proxy server", e);
}
}
try {
webdriver.close();
} catch (Exception e) {
logger.log(ERROR, "Error closing WebDriverBiDi", e);
if (webdriver != null) {
try {
webdriver.close();
} catch (Exception e) {
logger.log(ERROR, "Error closing WebDriverBiDi", e);
}
}
}