lee/heritrix3
1
0
Fork 0
mirror of https://github.com/internetarchive/heritrix3.git synced 2026-08-29 01:46:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

[HER-1655] Excessive charset/character-encoding exceptions; is fallback behavior correct?

Browse Source 
* ReplayCharSequence.java, GenericReplayCharSequence.java, InMemoryReplayCharSequence.java
    refactor to put fallback-encoding in single place
This commit is contained in:
gojomo
2009-08-27 00:12:15 +00:00
parent 3f9ecc4dfa
commit 783ecfd9d7
3 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
commons/src/main/java/org/archive/io/GenericReplayCharSequence.java
+1 -1
View File
@@ -154,7 +154,7 @@ public class GenericReplayCharSequence implements ReplayCharSequence {
} catch (IllegalArgumentException e) {
logger.log(Level.WARNING,"charset problem: "+charsetName,e);
// TODO: better detection or default
charset = Charset.forName("UTF-8");
charset = Charset.forName(FALLBACK_CHARSET_NAME);
}
if (charset.newEncoder().maxBytesPerChar() == 1.0) {
logger.info("charset=" + charsetName
commons/src/main/java/org/archive/io/InMemoryReplayCharSequence.java
+1 -1
View File
@@ -91,7 +91,7 @@ public class InMemoryReplayCharSequence implements ReplayCharSequence {
} catch (IllegalArgumentException e) {
logger.log(Level.WARNING,"charset problem: "+encoding,e);
// TODO: better detection or default
charset = Charset.forName("UTF-8");
charset = Charset.forName(FALLBACK_CHARSET_NAME);
}
return charset.decode(bb).asReadOnlyBuffer();
}
commons/src/main/java/org/archive/io/ReplayCharSequence.java
+5
View File
@@ -37,6 +37,11 @@ import java.io.IOException;
*/
public interface ReplayCharSequence extends CharSequence, Closeable {
/** charset to use in replay when declared value
* is absent/illegal/unavailable */
String FALLBACK_CHARSET_NAME = "UTF-8";
// String FALLBACK_CHARSET_NAME = "ISO8859_1";
/**
* Call this method when done so implementation has chance to clean up
* resources.