lee/pentagi
1
0
Fork 0
mirror of https://github.com/vxcontrol/pentagi.git synced 2026-09-26 12:15:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(knowledges): trim performSave doc-comment to the load-bearing invariant

Browse Source 
Drop the function-behavior restatement; keep the actionable invariant (navigation
stays with the caller, else the guard↔onSaveFromDialog↔performSave cycle returns).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Sergey Kozyrenko
2026-06-27 15:45:58 +07:00
co-authored by Claude Opus 4.8
parent 0cd37effed
commit 4472daa0d1
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/features/knowledges/knowledge-form.tsx
+3 -5
View File
@@ -229,11 +229,9 @@ export function KnowledgeForm({ initialValues, isNew, knowledge, onSubmit }: Kno
const { control, formState, handleSubmit, reset } = form;
const { isDirty, isValid } = formState;
// Saves and resets the form; returns the page's submit result (with an
// optional `redirectTo`) so the *caller* owns navigation. Keeping navigation
// out of here lets `onSaveFromDialog` feed the guard without depending on
// `guard.skipNextBlock` — which would otherwise form a real cycle
// (guard ← onSaveFromDialog ← performSave ← guard.skipNextBlock).
// Navigation is the caller's job — it reads `redirectTo` off the returned result.
// Pulling it in here would make onSaveFromDialog depend on guard.skipNextBlock and
// form a real cycle (guard ← onSaveFromDialog ← performSave ← guard.skipNextBlock).
const performSave = useCallback(
async (values: FormValues): Promise<null | SubmitResult> => {
try {