lee/pentagi
1
0
Fork 0
mirror of https://github.com/vxcontrol/pentagi.git synced 2026-08-24 12:06:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(firecrawl): thread user query into summarizer prompt

Browse Source 
The summarizer prompt asked the model to 'directly answer the user query'
but never rendered the query — Firecrawl's /v2/search response, unlike
Tavily's, doesn't echo the query back, so it was dropped when adapting the
prompt. Every summarized result (the common path, since scrapeOptions
requests markdown) was therefore a generic page summary instead of a
query-focused one.

Thread the query through search -> parseHTTPResponse -> buildFirecrawlResult
-> getSummarizePrompt and restore the USER QUERY line, matching Tavily.
Add a test asserting the query is present in the prompt.
This commit is contained in:
rramprakash
2026-07-16 12:53:11 +05:30
parent 7ffa30ddc9
commit b32dde8f01
2 changed files with 18 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/pkg/tools/firecrawl.go
+9 -6
View File
@@ -201,10 +201,10 @@ func (f *firecrawl) search(ctx context.Context, query string, maxResults int) (s
}
defer resp.Body.Close()
return f.parseHTTPResponse(ctx, resp)
return f.parseHTTPResponse(ctx, query, resp)
}
func (f *firecrawl) parseHTTPResponse(ctx context.Context, resp *http.Response) (string, error) {
func (f *firecrawl) parseHTTPResponse(ctx context.Context, query string, resp *http.Response) (string, error) {
switch resp.StatusCode {
case http.StatusOK:
var respBody firecrawlSearchResult
@@ -217,7 +217,7 @@ func (f *firecrawl) parseHTTPResponse(ctx context.Context, resp *http.Response)
}
return "", fmt.Errorf("request failed")
}
return f.buildFirecrawlResult(ctx, &respBody), nil
return f.buildFirecrawlResult(ctx, query, &respBody), nil
case http.StatusBadRequest:
return "", fmt.Errorf("request is invalid")
case http.StatusUnauthorized:
@@ -247,7 +247,7 @@ func (f *firecrawl) parseHTTPResponse(ctx context.Context, resp *http.Response)
}
}
func (f *firecrawl) buildFirecrawlResult(ctx context.Context, result *firecrawlSearchResult) string {
func (f *firecrawl) buildFirecrawlResult(ctx context.Context, query string, result *firecrawlSearchResult) string {
var writer strings.Builder
writer.WriteString("# Links\n\n")
@@ -264,7 +264,7 @@ func (f *firecrawl) buildFirecrawlResult(ctx context.Context, result *firecrawlS
}
if isMarkdownExists && f.summarizer != nil {
summarizePrompt, err := f.getSummarizePrompt(result)
summarizePrompt, err := f.getSummarizePrompt(query, result)
if err != nil {
writer.WriteString(f.getContentFromResults(result.Data.Web))
} else {
@@ -305,10 +305,12 @@ type firecrawlPromptDoc struct {
Markdown string
}
func (f *firecrawl) getSummarizePrompt(result *firecrawlSearchResult) (string, error) {
func (f *firecrawl) getSummarizePrompt(query string, result *firecrawlSearchResult) (string, error) {
templateText := `<instructions>
TASK: Summarize web search results for the following user query:
USER QUERY: "{{.Query}}"
DATA:
- <raw_content> tags contain web page content with attributes: id, title, url
- Content may include HTML, structured data, tables, or plain text
@@ -355,6 +357,7 @@ The summary MUST provide complete answers to the user's query, preserving all re
}
templateContext := map[string]any{
"Query": query,
"MaxLength": maxRawContentLength,
"Results": docs,
}
backend/pkg/tools/firecrawl_test.go
+9 -5
View File
@@ -329,7 +329,7 @@ func TestFirecrawlParseHTTPResponse_StatusAndDecodeErrors(t *testing.T) {
StatusCode: tt.statusCode,
Body: io.NopCloser(strings.NewReader(tt.body)),
}
result, err := fc.parseHTTPResponse(t.Context(), resp)
result, err := fc.parseHTTPResponse(t.Context(), "test query", resp)
if !tt.wantErr {
if err != nil {
@@ -358,6 +358,10 @@ func TestFirecrawlBuildResult_WithSummarizer(t *testing.T) {
if !strings.Contains(prompt, "<raw_content") {
t.Fatalf("summarizer prompt must include raw content, got: %q", prompt)
}
// The user query must be rendered so the model can answer it.
if !strings.Contains(prompt, `USER QUERY: "test query"`) {
t.Fatalf("summarizer prompt must include the user query, got: %q", prompt)
}
// Source IDs must be one-based to line up with the numbered links.
if !strings.Contains(prompt, `id="1"`) {
t.Fatalf("summarizer prompt must use one-based source ids, got: %q", prompt)
@@ -369,7 +373,7 @@ func TestFirecrawlBuildResult_WithSummarizer(t *testing.T) {
},
}
out := fc.buildFirecrawlResult(t.Context(), &firecrawlSearchResult{
out := fc.buildFirecrawlResult(t.Context(), "test query", &firecrawlSearchResult{
Success: true,
Data: firecrawlData{
Web: []firecrawlResult{
@@ -394,7 +398,7 @@ func TestFirecrawlBuildResult_WithSummarizer(t *testing.T) {
t.Run("falls back to markdown content when no summarizer", func(t *testing.T) {
fc := &firecrawl{}
out := fc.buildFirecrawlResult(t.Context(), &firecrawlSearchResult{
out := fc.buildFirecrawlResult(t.Context(), "test query", &firecrawlSearchResult{
Success: true,
Data: firecrawlData{
Web: []firecrawlResult{
@@ -419,7 +423,7 @@ func TestFirecrawlBuildResult_WithSummarizer(t *testing.T) {
t.Run("no content sections when markdown is empty", func(t *testing.T) {
fc := &firecrawl{}
out := fc.buildFirecrawlResult(t.Context(), &firecrawlSearchResult{
out := fc.buildFirecrawlResult(t.Context(), "test query", &firecrawlSearchResult{
Success: true,
Data: firecrawlData{
Web: []firecrawlResult{
@@ -443,7 +447,7 @@ func TestFirecrawlBuildResult_WithSummarizer(t *testing.T) {
t.Run("falls back to metadata url and title", func(t *testing.T) {
fc := &firecrawl{}
out := fc.buildFirecrawlResult(t.Context(), &firecrawlSearchResult{
out := fc.buildFirecrawlResult(t.Context(), "test query", &firecrawlSearchResult{
Success: true,
Data: firecrawlData{
Web: []firecrawlResult{