lee/pentagi
1
0
Fork 0
mirror of https://github.com/vxcontrol/pentagi.git synced 2026-08-28 05:56:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci(e2e): flag an advisory visual diff as a warning, not a mock-tier failure

Browse Source 
The sticky PR comment took its header from the whole-workflow conclusion, so a
visual-snapshot diff — advisory, never a required check — rendered a red ❌ over a
"62 passed, 0 failed" mock-tier stats line, reading as a gate failure it isn't.

Track the header on the mock gate instead (✅ pass / ❌ real failure) and surface a
differing visual job as a separate ⚠️ line pointing at the diff artifact.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Sergey Kozyrenko
2026-07-21 19:18:16 +07:00
co-authored by Claude Opus 4.8
parent 07a2d1fa2d
commit c48876cd22
1 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/e2e-report.yml
+23 -1
View File
@@ -59,22 +59,44 @@ jobs:
}
let statsLine = 'The run produced no results file (it likely failed before the tests started).';
let mockPassed = false;
try {
const report = JSON.parse(fs.readFileSync('results/results.json', 'utf8'));
const n = (value) => Number(value) || 0;
const { expected, unexpected, flaky, skipped } = report.stats ?? {};
statsLine = `**${n(expected)} passed**, ${n(unexpected)} failed, ${n(flaky)} flaky, ${n(skipped)} skipped.`;
mockPassed = n(unexpected) === 0;
} catch (error) {
core.info(`results.json unavailable: ${error}`);
}
const conclusion = run.conclusion === 'success' ? '✅' : '❌';
// The visual job is advisory (never a required check), so the header must
// track the mock gate, not the whole-run conclusion — otherwise a visual-only
// diff reads as a mock failure over a "0 failed" stats line.
let visualDiffers = false;
try {
const { data: jobs } = await github.rest.actions.listJobsForWorkflowRun({
owner: context.repo.owner,
repo: context.repo.repo,
run_id: run.id,
per_page: 100,
});
visualDiffers = jobs.jobs.some((job) => /visual/.test(job.name) && job.conclusion === 'failure');
} catch (error) {
core.info(`run jobs unavailable: ${error}`);
}
const conclusion = !mockPassed ? '❌' : visualDiffers ? '⚠️' : '✅';
const marker = '<!-- e2e-report -->';
const advisoryLine = visualDiffers
? '⚠️ **Visual snapshots differ** — advisory only, does not block merge. Download the `e2e-visual-diffs` artifact to compare expected / actual / diff.'
: null;
const body = [
marker,
`### ${conclusion} E2E (mock tier)`,
'',
statsLine,
...(advisoryLine ? ['', advisoryLine] : []),
'',
`[Run + report/trace artifacts](${run.html_url}) · commit ${run.head_sha.slice(0, 7)}`,
'',