lee/pentagi
1
0
Fork 0
mirror of https://github.com/vxcontrol/pentagi.git synced 2026-08-28 05:56:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): make placeholder mount-only instead of a dead reactive dep

Browse Source 
extensions was memoized on [placeholder], implying a live placeholder update,
but useEditor runs with empty deps and tiptap's setOptions merges options
without re-registering extensions — so a changed placeholder never reaches the
already-installed Placeholder plugin (verified: data-placeholder stays at the
mount value across a prop change). Drop placeholder from the deps to match the
autoFocus mount-only decision, removing the misleading reactivity signal and the
per-change rebuild of the whole extension array.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Sergey Kozyrenko
2026-07-02 02:26:34 +07:00
co-authored by Claude Opus 4.8
parent 4ddb76f9ff
commit c4eb983c44
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/components/shared/markdown-editor/markdown-editor.tsx
+6 -1
View File
@@ -114,7 +114,12 @@ function MarkdownEditor({
const hasResetInitialHistoryRef = useRef(false);
const extensions = useMemo(() => createMarkdownExtensions(placeholder), [placeholder]);
// `placeholder` is captured at mount, like the native <input placeholder>. tiptap's setOptions merges
// options without re-registering extensions, so a later change can't reach the already-built Placeholder
// plugin regardless; keeping it out of the deps makes that explicit and stops rebuilding the whole
// extension array on every placeholder change.
// eslint-disable-next-line react-hooks/exhaustive-deps
const extensions = useMemo(() => createMarkdownExtensions(placeholder), []);
// tiptap invokes onBlur/onUpdate from its live options ref, so these closures always read the latest props.
const editor = useEditor({