lee/puter
1
0
Fork 0
mirror of https://github.com/HeyPuter/puter.git synced 2026-05-06 01:20:41 +00:00
Code Issues Actions 14 Packages Projects Releases Wiki Activity

fix: bad acl check returning early (#1789)

Browse Source
This commit is contained in:
Daniel Salazar
2025-10-20 20:13:43 -07:00
committed by GitHub
parent 0260a9cbce
commit 760bc22743
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/backend/src/filesystem/ll_operations/ll_read.js
+6 -4
View File
@@ -27,7 +27,10 @@ const { buffer_to_stream } = require('../../util/streamutil');
const { TYPE_SYMLINK, TYPE_DIRECTORY } = require('../FSNodeContext');
const { LLFilesystemOperation } = require('./definitions');
const checkACLForRead = async (aclService, actor, fsNode) => {
const checkACLForRead = async (aclService, actor, fsNode, skip = false) => {
if ( skip ) {
return;
}
if ( !await aclService.check(actor, fsNode, 'read') ) {
throw await aclService.get_safe_acl_error(actor, fsNode, 'read');
}
@@ -51,11 +54,10 @@ class LLRead extends LLFilesystemOperation {
if ( !await fsNode.exists() ){
throw APIError.create('subject_does_not_exist');
}
if ( no_acl ) return;
// validate initial node
await checkACLForRead(aclService, actor, fsNode);
await checkACLForRead(aclService, actor, fsNode, no_acl);
await typeCheckForRead(fsNode);
let type = await fsNode.get('type');
while ( type === TYPE_SYMLINK ) {
fsNode = await fsNode.getTarget();