tweak(phoenix): Only take auth params from config message

Having the parent app send us arbitrary config values was a holdover
from when phoenix was an embedded iframe and not a separate app. It led
to a security issue previously. Let's only take the auth parameters
since we can't get those otherwise, and they're safe to read.
Everything else should be available in our own URL params.
This commit is contained in:
Sam Atkins
2024-06-28 15:45:25 +01:00
committed by Eric Dubé
parent b7133760df
commit e2ea57fcf9
+7 -5
View File
@@ -25,7 +25,10 @@ import { CreateEnvProvider } from './platform/puter/env.js';
import { CreateSystemProvider } from './platform/puter/system.js';
window.main_shell = async () => {
const config = {};
const config = Object.fromEntries(
new URLSearchParams(window.location.search)
.entries()
);
let resolveConfigured = null;
const configured_ = new Promise(rslv => {
@@ -41,10 +44,9 @@ window.main_shell = async () => {
terminal.on('message', message => {
if (message.$ === 'config') {
const configValues = { ...message };
delete configValues.$;
for ( const k in configValues ) {
config[k] = configValues[k];
}
// Only copy the config that we actually need
config['puter.auth.username'] = configValues['puter.auth.username'];
config['puter.auth.token'] = configValues['puter.auth.token'];
resolveConfigured();
}
});