lee/puter
1
0
Fork 0
mirror of https://github.com/HeyPuter/puter.git synced 2026-05-11 20:10:36 +00:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

dev(data-access): misc improvements to .update()

Browse Source 
DRY some redundant code and use guard clauses where applicable.
This commit is contained in:
KernelDeimos
2025-12-30 12:59:15 -05:00
committed by Eric Dubé
parent 464241e743
commit fc03fafab9
1 changed files with 12 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/backend/src/modules/data-access/AppService.js
+12 -17
View File
@@ -531,19 +531,12 @@ export default class AppService extends BaseService {
values.push(value);
}
if ( set_clauses.length === 0 ) {
// Nothing to update in the main table
// Fetch the internal ID for file associations
const rows = await this.db.read('SELECT id FROM apps WHERE uid = ?',
[old_app.uid]);
return { insert_id: rows[0]?.id };
if ( set_clauses.length > 0 ) {
values.push(old_app.uid);
const stmt = `UPDATE apps SET ${set_clauses.join(', ')} WHERE uid = ? LIMIT 1`;
await this.db_write.write(stmt, values);
}
values.push(old_app.uid);
const stmt = `UPDATE apps SET ${set_clauses.join(', ')} WHERE uid = ?`;
await this.db_write.write(stmt, values);
// Fetch the internal ID
const rows = await this.db.read('SELECT id FROM apps WHERE uid = ?',
[old_app.uid]);
@@ -556,13 +549,15 @@ export default class AppService extends BaseService {
[app_id]);
// Add new file associations
if ( filetype_associations && filetype_associations.length > 0 ) {
const stmt =
`INSERT INTO app_filetype_association (app_id, type) VALUES ${
filetype_associations.map(() => '(?, ?)').join(', ')}`;
const values = filetype_associations.flatMap(ft => [app_id, ft.toLowerCase()]);
await this.db_write.write(stmt, values);
if ( !filetype_associations || !(filetype_associations.length > 0) ) {
return;
}
const stmt =
`INSERT INTO app_filetype_association (app_id, type) VALUES ${
filetype_associations.map(() => '(?, ?)').join(', ')}`;
const values = filetype_associations.flatMap(ft => [app_id, ft.toLowerCase()]);
await this.db_write.write(stmt, values);
}
async #emit_change_events (object, old_app) {