lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-06 01:50:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix setting adb setprop debug.vulkan.layers to empty string.

Browse Source 
Workaround inconsistent CreateProcessW string parsing by setting the
property to the Vulkan layer delimiter character. On some PCs it would
remove the quotes before sending to adb, and on others they would remain.

The quotes were interpreted by the Android loader as a layer name, and the
replay context's vkCreateInstance returned VK_ERROR_LAYER_NOT_PRESENT.
This commit is contained in:
Michael Rennie
2017-01-30 16:27:47 +00:00
committed by Baldur Karlsson
parent e8c2189dc8
commit 0a119e58f3
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/replay/entry_points.cpp
+2 -2
View File
@@ -748,7 +748,7 @@ uint32_t StartAndroidPackageForCapture(const char *host, const char *package)
}
// Let the app pickup the setprop before we turn it back off for replaying.
adbExecCommand("shell setprop debug.vulkan.layers \\\"\\\"");
adbExecCommand("shell setprop debug.vulkan.layers :");
return ret;
}
@@ -786,7 +786,7 @@ extern "C" RENDERDOC_API void RENDERDOC_CC RENDERDOC_StartAndroidRemoteServer()
{
adbExecCommand("shell am force-stop org.renderdoc.renderdoccmd");
adbForwardPorts();
adbExecCommand("shell setprop debug.vulkan.layers \\\"\\\"");
adbExecCommand("shell setprop debug.vulkan.layers :");
adbExecCommand(
"shell am start -n org.renderdoc.renderdoccmd/.Loader -e renderdoccmd remoteserver");
}