lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-29 21:30:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't create 4GB empty string if logfile fails to read properly.

Browse Source
This commit is contained in:
baldurk
2018-03-08 23:17:44 +00:00
parent 1e4a78d140
commit 11b2baf83d
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/os/win32/win32_stringio.cpp
+11 -3
View File
@@ -648,11 +648,19 @@ std::string logfile_readall(const char *filename)
{
DWORD len = GetFileSize(h, NULL);
ret.resize(len);
if(len == INVALID_FILE_SIZE)
{
DWORD err = GetLastError();
ret = StringFormat::Fmt("Failed to read logfile, GetFileSize() threw %u", err);
}
else
{
ret.resize(len);
DWORD dummy = len;
DWORD dummy = len;
ReadFile(h, &ret[0], len, &dummy, NULL);
ReadFile(h, &ret[0], len, &dummy, NULL);
}
CloseHandle(h);
}