lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-06 01:50:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ignore location decorations that shouldn't be used in GL

Browse Source
This commit is contained in:
baldurk
2021-04-12 11:07:24 +01:00
parent dcfe7596a1
commit 14698bb451
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/shaders/spirv/spirv_reflect.cpp
+8 -3
View File
@@ -910,10 +910,15 @@ void Reflector::MakeReflection(const GraphicsAPI sourceAPI, const ShaderStage st
bindmap.bind = GetBinding(decorations[global.id].binding);
// On GL if we have a location, put that in as the bind. It will be overwritten
// dynamically with the actual value.
if(sourceAPI == GraphicsAPI::OpenGL && decorations[global.id].location != ~0U)
// On GL if we have a location and no binding, put that in as the bind. It will be overwritten
// dynamically with the actual value read from glGetUniform. This should only happen for
// bare uniforms and not for texture/buffer type uniforms which should have a binding
if(sourceAPI == GraphicsAPI::OpenGL &&
(decorations[global.id].flags & Decorations::HasLocation | Decorations::HasBinding) ==
Decorations::HasLocation)
{
bindmap.bind = -int32_t(decorations[global.id].location);
}
bindmap.arraySize = isArray ? arraySize : 1;
bindmap.used = usedIds.find(global.id) != usedIds.end();