lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-23 06:56:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ExecuteIndirect state decoding not properly respecting stride

Browse Source 
* It was also broken even for tightly packed argument signatures because it
  wasn't incrementing the data pointer over the dispatch/draw arguments.
This commit is contained in:
baldurk
2024-06-25 17:25:15 +01:00
parent e2a03f5d23
commit 1a1437ee19
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/d3d12/d3d12_state.cpp
+11 -4
View File
@@ -80,12 +80,12 @@ void D3D12RenderState::ResolvePendingIndirectState(WrappedID3D12Device *device)
{
byte *data = mapPtr + indirectState.argsOffs;
mapPtr += comSig->sig.ByteStride;
for(uint32_t argIdx = 0; argIdx < indirectState.argsToProcess; argIdx++)
{
uint32_t a = argIdx % comSig->sig.arguments.size();
const D3D12_INDIRECT_ARGUMENT_DESC &arg = comSig->sig.arguments[a];
size_t execIdx = argIdx / comSig->sig.arguments.size();
uint32_t argWithinExecIdx = argIdx % comSig->sig.arguments.size();
const D3D12_INDIRECT_ARGUMENT_DESC &arg = comSig->sig.arguments[argWithinExecIdx];
switch(arg.Type)
{
@@ -93,7 +93,14 @@ void D3D12RenderState::ResolvePendingIndirectState(WrappedID3D12Device *device)
case D3D12_INDIRECT_ARGUMENT_TYPE_DRAW_INDEXED:
case D3D12_INDIRECT_ARGUMENT_TYPE_DISPATCH:
case D3D12_INDIRECT_ARGUMENT_TYPE_DISPATCH_MESH:
case D3D12_INDIRECT_ARGUMENT_TYPE_DISPATCH_RAYS: break;
case D3D12_INDIRECT_ARGUMENT_TYPE_DISPATCH_RAYS:
{
// we know this is the final argument in the signature. Set the data pointer to the start
// of the next execute with the proper stride. This may be unused if we are only
// processing one execute's worth of arguments
data = mapPtr + indirectState.argsOffs + comSig->sig.ByteStride * (execIdx + 1);
break;
}
case D3D12_INDIRECT_ARGUMENT_TYPE_CONSTANT:
{
size_t argSize = sizeof(uint32_t) * arg.Constant.Num32BitValuesToSet;