lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-07-31 11:51:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Protect against captures that try to allocate memory from invalid types

Browse Source
This commit is contained in:
baldurk
2020-10-06 16:11:22 +01:00
parent 96ab4c25d6
commit 1cbd062aa7
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/wrappers/vk_resource_funcs.cpp
+10
View File
@@ -289,6 +289,16 @@ bool WrappedVulkan::Serialise_vkAllocateMemory(SerialiserType &ser, VkDevice dev
UnwrapNextChain(m_State, "VkMemoryAllocateInfo", tempMem, (VkBaseInStructure *)&patched);
if(patched.memoryTypeIndex >= m_PhysicalDeviceData.memProps.memoryTypeCount)
{
RDCERR(
"Tried to allocate memory from index %u, but on replay we only have %u memory types.\n"
"This is most likely caused by incompatible hardware or drivers between capture and "
"replay, causing a change in memory requirements.",
patched.memoryTypeIndex, m_PhysicalDeviceData.memProps.memoryTypeCount);
return false;
}
VkResult ret = ObjDisp(device)->AllocateMemory(Unwrap(device), &patched, NULL, &mem);
if(ret != VK_SUCCESS)