lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-06 01:50:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove some VKTODOs that are judged not relevant anymore

Browse Source
This commit is contained in:
baldurk
2015-10-29 18:39:27 +01:00
parent 7b952c53ef
commit 1d092f6b87
5 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/api/replay/vk_pipestate.h
+1 -1
View File
@@ -91,7 +91,7 @@ struct VulkanPipelineState
struct Binding
{
Binding() : vbufferBinding(0), bytestride(0), perInstance(false) {}
uint32_t vbufferBinding; // VKTODOLOW I believe this is the meaning
uint32_t vbufferBinding;
uint32_t bytestride;
bool32 perInstance;
};
renderdoc/driver/vulkan/vk_core.cpp
-1
View File
@@ -771,7 +771,6 @@ bool WrappedVulkan::EndFrameCapture(void *dev, void *wnd)
{ imInfo.extent.width, imInfo.extent.height, 1 },
};
// VKTODOLOW back buffer must be in this layout right?
VkImageMemoryBarrier bbTrans = {
VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER, NULL,
0, 0, VK_IMAGE_LAYOUT_PRESENT_SOURCE_KHR, VK_IMAGE_LAYOUT_TRANSFER_SOURCE_OPTIMAL,
renderdoc/driver/vulkan/vk_core.h
-2
View File
@@ -267,8 +267,6 @@ private:
// vkCmd chunks) is NOT unique.
// However, a single baked command list can be submitted multiple
// times - so we have to have a list of base events
// VKTODOLOW change this to a sorted vector similar to the image
// states
// Map from bakeID -> vector<baseEventID>
map<ResourceId, vector<uint32_t> > cmdBufferSubmits;
renderdoc/driver/vulkan/vk_info.h
+1 -1
View File
@@ -69,7 +69,7 @@ struct VulkanCreationInfo
// VkPipelineVertexInputStateCreateInfo
struct Binding
{
uint32_t vbufferBinding; // VKTODO I believe this is the meaning
uint32_t vbufferBinding;
uint32_t bytestride;
bool perInstance;
};
renderdoc/driver/vulkan/vk_initstate.cpp
+11 -6
View File
@@ -397,12 +397,17 @@ void WrappedVulkan::Create_InitialState(ResourceId id, WrappedVkRes *live, bool
if(type == eResDescriptorSet)
{
// VKTODOMED need to create some default initial state for descriptor sets.
// if a descriptor set is alloc'd then used in frame we won't have prepared anything,
// but likewise all writes must happen within that frame so the initial state doesn't
// technically matter. We assume the app doesn't try to read from an uninitialised
// descriptor, so for now we can leave the initial state empty.
VULKANNOTIMP("Need to create initial state for descriptor set");
// There is no sensible default for a descriptor set to create. The contents are
// undefined until written to. This means if a descriptor set was alloc'd within a
// frame (the only time we won't have initial contents tracked for it) then the
// contents are undefined, so using whatever is currently in the set is fine. Reading
// from it (and thus getting data from later in the frame potentially) is an error.
//
// Note the same kind of problem applies if a descriptor set is alloc'd before the
// frame and then say slot 5 is never written to until the middle of the frame, then
// used. The initial states we have prepared won't have anything valid for 5 so when
// we apply we won't even write anything into slot 5 - the same case as if we had
// no initial states at all for that descriptor set
}
else if(type == eResImage)
{