lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-04 17:10:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix off-by-one error converting strings

Browse Source 
* The length returned by PyBytes_AsStringAndSize isn't the byte size
  including null terminator, but the number of bytes in the string.
This commit is contained in:
baldurk
2017-04-18 14:52:51 +01:00
parent 2a4596e06a
commit 1d1b7d8c55
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Code/pyrenderdoc/pyconversion.h
+4 -4
View File
@@ -454,9 +454,9 @@ struct TypeConversion<rdctype::str, false>
if(ret == 0)
{
out.count = (int)size - 1;
out.elems = (char *)out.allocate(size);
memcpy(out.elems, buf, size - 1);
out.count = (int)size;
out.elems = (char *)out.allocate(size + 1);
memcpy(out.elems, buf, size);
out.elems[size] = 0;
Py_DecRef(bytes);
@@ -508,7 +508,7 @@ struct TypeConversion<QString, false>
if(ret == 0)
{
out = QString::fromUtf8(buf, (int)(size - 1));
out = QString::fromUtf8(buf, (int)size);
Py_DecRef(bytes);