lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-05 01:20:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix row count calculation when writing block-compressed DDS data

Browse Source 
Block-compressed textures with dimensions that are not evenly divisible
by the block size are typically padded internally to align with the
block size. load_dds_from_file() was previously corrected to account for
this alignment when calculating the number of rows of blocks to read
from a DDS file, but the fix was not applied to write_dds_to_file(),
resulting in missing rows of texels or loading failures when attempting
to open a DDS file generated by RenderDoc from a texture whose
dimensions are not a multiple of four.
This commit is contained in:
Theodore Cipicchio
2021-04-25 22:24:00 -07:00
committed by Baldur Karlsson
parent e8cfbd5a6f
commit 1e3fc0e320
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/common/dds_readwrite.cpp
+1 -1
View File
@@ -924,7 +924,7 @@ bool write_dds_to_file(FILE *f, const write_dds_data &data)
// pitch/rows are in blocks, not pixels, for block formats.
if(blockFormat)
{
numRows = RDCMAX(1U, numRows / 4);
numRows = RDCMAX(1U, (numRows + 3) / 4);
uint32_t blockSize = (data.format.type == ResourceFormatType::BC1 ||
data.format.type == ResourceFormatType::BC4)