lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-06 23:00:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't bounds check instruction numbers against disassembly line count

Browse Source
This commit is contained in:
baldurk
2020-04-17 16:52:35 +01:00
parent 67edb36efc
commit 1ec3320e99
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Windows/ShaderViewer.cpp
+5 -2
View File
@@ -3241,6 +3241,9 @@ void ShaderViewer::SetCurrentStep(uint32_t step)
void ShaderViewer::ToggleBreakpoint(int instruction)
{
if(!m_Trace || m_States.empty())
return;
sptr_t instLine = -1;
if(instruction == -1)
@@ -3286,12 +3289,12 @@ void ShaderViewer::ToggleBreakpoint(int instruction)
}
}
if(instruction < 0 || instruction >= m_DisassemblyView->lineCount())
if(instruction < 0 || instruction >= m_Trace->lineInfo.count())
return;
if(instLine == -1)
{
if(m_Trace && instruction < m_Trace->lineInfo.count())
if(instruction < m_Trace->lineInfo.count())
instLine = m_Trace->lineInfo[instruction].disassemblyLine - 1;
}