lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-07-08 16:50:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle empty infinite loops in SPIR-V disassembler

Browse Source
This commit is contained in:
baldurk
2021-03-23 11:39:14 +00:00
parent 47ebc9f5c2
commit 261be0e597
1 changed files with 25 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/shaders/spirv/spirv_disassemble.cpp
+25 -19
View File
@@ -799,27 +799,33 @@ rdcstr Reflector::Disassemble(const rdcstr &entryPoint,
{
OpBranch decodedbranch(it);
ConstIter nextit = it;
nextit++;
while(nextit.opcode() == Op::Line || nextit.opcode() == Op::NoLine)
nextit++;
// we can now ignore everything between us and the label of this branch, which is almost
// always going to be the very next label.
//
// The reasoning is this:
// - assume the next block is not the one we are jumping to
// - all blocks inside the loop must only ever branch backwards to the header block
// (that's this one) so the block can't be jumped to from within the loop
// - it's also illegal to jump into a structured control flow construct from outside, so
// it can't be jumped to from outside the loop
// - that means it is completely inaccessible from everywhere, so we can skip it
while(nextit.opcode() != Op::Label || OpLabel(nextit).result != decodedbranch.targetLabel)
// if the first branch after the loopmerge is to the continue target, this is an empty
// infinite loop. Don't try and detect the branch, just make an empty loop and exit.
if(decodedbranch.targetLabel != decoded.continueTarget)
{
ConstIter nextit = it;
nextit++;
it++;
instructionLines[it.offs()] = lineNum;
while(nextit.opcode() == Op::Line || nextit.opcode() == Op::NoLine)
nextit++;
// we can now ignore everything between us and the label of this branch, which is
// almost always going to be the very next label.
//
// The reasoning is this:
// - assume the next block is not the one we are jumping to
// - all blocks inside the loop must only ever branch backwards to the header block
// (that's this one) so the block can't be jumped to from within the loop
// - it's also illegal to jump into a structured control flow construct from outside,
// so it can't be jumped to from outside the loop
// - that means it is completely inaccessible from everywhere, so we can skip it
while(nextit.opcode() != Op::Label ||
OpLabel(nextit).result != decodedbranch.targetLabel)
{
nextit++;
it++;
instructionLines[it.offs()] = lineNum;
}
}
}
else