lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-07-28 18:31:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix disassembly of SPIR-V loop continues

Browse Source 
* An actual continue will need to print a goto to the increment block as we
  don't try to disassemble for loops
This commit is contained in:
baldurk
2026-07-15 11:00:37 +01:00
parent 899cf98fd1
commit 274042a1a7
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/shaders/spirv/spirv_disassemble.cpp
+13 -2
View File
@@ -289,6 +289,8 @@ rdcstr Reflector::Disassemble(const rdcstr &entryPoint,
// set of labels that must be printed because we have gotos for them
std::set<Id> printLabels;
uint32_t loop_continue = 0;
Id currentBlock;
ret = StringFormat::Fmt(
@@ -1137,15 +1139,24 @@ rdcstr Reflector::Disassemble(const rdcstr &entryPoint,
continue;
}
// if we're in a loop, branches to the continue target are printed as 'continue'
// if we're in a loop, branches to the header target are printed as 'continue' - notably
// branches to the continue block are _not_ because they may contain the increment code
if(lastLoopSwitch && lastLoopSwitch->type == StructuredCFG::Loop &&
lastLoopSwitch->continueTarget == decoded.targetLabel)
lastLoopSwitch->headerBlock == decoded.targetLabel)
{
ret += indent + "continue;\n";
lineNum++;
continue;
}
if(lastLoopSwitch && lastLoopSwitch->type == StructuredCFG::Loop &&
lastLoopSwitch->continueTarget == decoded.targetLabel)
{
if(dynamicNames.find(decoded.targetLabel) == dynamicNames.end())
dynamicNames[decoded.targetLabel] =
StringFormat::Fmt("loop_continue%u", ++loop_continue);
}
// if we're in a switch and we're about to print a goto, see if it's a case label and
// print a 'nicer' goto. Fallthrough to the next case would be handled above as a
// redundant goto