Tidy up VKTODOs a bit

This commit is contained in:
baldurk
2016-02-07 18:50:38 +01:00
parent 2b8c7cae64
commit 29abeb51d8
4 changed files with 4 additions and 5 deletions
+4 -1
View File
@@ -450,7 +450,10 @@ void WrappedVulkan::SubmitSemaphores()
void WrappedVulkan::FlushQ()
{
// VKTODOLOW could do away with the need for this function by keeping
// commands until N presents later, or something, or checking on fences
// commands until N presents later, or something, or checking on fences.
// If we do so, then check each use for FlushQ to see if it needs a
// CPU-GPU sync or whether it is just looking to recycle command buffers
// (Particularly the one in vkQueuePresentKHR drawing the overlay)
ObjDisp(m_Queue)->QueueWaitIdle(Unwrap(m_Queue));
-1
View File
@@ -238,7 +238,6 @@ string VulkanDebugManager::GetSPIRVBlob(SPIRVShaderStage shadType, const std::ve
VulkanDebugManager::VulkanDebugManager(WrappedVulkan *driver, VkDevice dev)
{
// VKTODOLOW needs tidy up - isn't scalable. Needs more classes like UBO above.
m_pDriver = driver;
m_State = m_pDriver->GetState();
-1
View File
@@ -152,7 +152,6 @@ class VulkanDebugManager
VulkanResourceManager *m_ResourceManager;
};
// VKTODOLOW make this all private/wrapped up
VkDescriptorPool m_DescriptorPool;
VkSampler m_LinearSampler, m_PointSampler;
@@ -623,8 +623,6 @@ VkResult WrappedVulkan::vkQueuePresentKHR(
SubmitCmds();
// VKTODOLOW once we have a more sophisticated way of re-using submitted command
// buffers once they've executed and are safe to recycle, this can be removed
FlushQ();
}
}