lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-04 17:10:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Highlight stale/unrecognised settings in the config editor

Browse Source
This commit is contained in:
baldurk
2020-04-03 15:10:49 +01:00
parent 9ce74cbc39
commit 2bb278b9fd
1 changed files with 32 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Windows/Dialogs/ConfigEditor.cpp
+32 -6
View File
@@ -257,7 +257,19 @@ public:
{
SDObject *desc = o->FindChild("description");
if(desc)
return desc->AsString();
{
rdcstr ret = desc->AsString();
if(o->FindChild("key") == NULL)
{
ret =
"WARNING: Unknown setting, possibly it has been removed or from a different "
"build.\n\n" +
ret;
}
return ret;
}
}
else if(role == Qt::FontRole)
{
@@ -267,6 +279,14 @@ public:
font.setBold(true);
return font;
}
// if this is a value but has no key, it's an unrecognised setting (stale/removed, or from
// a different or future build).
if(o->FindChild("description") && o->FindChild("key") == NULL)
{
QFont font;
font.setItalic(true);
return font;
}
}
}
@@ -468,6 +488,14 @@ QWidget *SettingDelegate::createEditor(QWidget *parent, const QStyleOptionViewIt
return ret;
}
QString settingName;
SDObject *key = o->FindChild("key");
if(key)
settingName = key->AsString();
else
settingName = tr("Unknown Setting %1").arg(o->name);
// for numbers, provide a spinbox
if(val->type.basetype == SDBasic::UnsignedInteger || val->type.basetype == SDBasic::SignedInteger)
{
@@ -491,8 +519,7 @@ QWidget *SettingDelegate::createEditor(QWidget *parent, const QStyleOptionViewIt
{
if(QString(o->name).contains(lit("DirPath"), Qt::CaseSensitive))
{
QString dir = RDDialog::getExistingDirectory(
m_Editor, tr("Browse for %1").arg(o->FindChild("key")->AsString()));
QString dir = RDDialog::getExistingDirectory(m_Editor, tr("Browse for %1").arg(settingName));
if(!dir.isEmpty())
{
@@ -507,8 +534,7 @@ QWidget *SettingDelegate::createEditor(QWidget *parent, const QStyleOptionViewIt
}
else if(QString(o->name).contains(lit("Path"), Qt::CaseSensitive))
{
QString file = RDDialog::getOpenFileName(
m_Editor, tr("Browse for %1").arg(o->FindChild("key")->AsString()));
QString file = RDDialog::getOpenFileName(m_Editor, tr("Browse for %1").arg(settingName));
if(!file.isEmpty())
{
@@ -534,7 +560,7 @@ QWidget *SettingDelegate::createEditor(QWidget *parent, const QStyleOptionViewIt
// only support arrays of strings. Pop up a separate editor to handle this
QDialog listEditor;
listEditor.setWindowTitle(tr("Edit values of %1").arg(QString(o->FindChild("key")->AsString())));
listEditor.setWindowTitle(tr("Edit values of %1").arg(QString(settingName)));
listEditor.setWindowFlags(listEditor.windowFlags() & ~Qt::WindowContextHelpButtonHint);
BrowseMode mode = BrowseMode::None;