lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-05 17:40:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cannot run functional tests using Python >= 3.10

Browse Source 
In replay/entry_points.cpp RENDERDOC_RunFunctionalTests(..), it uses a simple char-replacement algorithm for finding the Python modules depending on the Python minor version.

Unfortunately that mechanism relies on there being only a single character to replace which doesn't work once we reach double figures.
This commit is contained in:
Cam Mannett
2023-09-18 13:48:05 +01:00
committed by Baldur Karlsson
parent d88eff15f3
commit 30a013907d
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/replay/entry_points.cpp
+7 -2
View File
@@ -945,8 +945,13 @@ extern "C" RENDERDOC_API int RENDERDOC_CC RENDERDOC_RunFunctionalTests(int pytho
for(rdcstr py : pythonlibs)
{
// patch up the python minor version
char *ver = strchr(&py[0], '?');
*ver = char('0' + pythonMinorVersion);
const int32_t idx = py.find('?');
if(idx == -1)
{
TestPrintMsg(StringFormat::Fmt("Python library pattern missing placeholder: %s\n", py.c_str()));
return 1;
}
py.replace(idx, 1, StringFormat::Fmt("%d", pythonMinorVersion));
handle = Process::LoadModule(py);
if(handle)