lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-29 13:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Updated TODO: about BinaryArchive & DynamicLibrary

Browse Source 
They will both need to be wrapped.
When WrappedMTLBinaryArchive and WrappedMTLDynamicLibrary exist then can serialize:
binaryArchives
vertexPreloadedLibraries
fragmentPreloadedLibraries
This commit is contained in:
Jake Turner
2022-06-01 07:16:11 +01:00
committed by Baldur Karlsson
parent 22b2272812
commit 31b97ab0e8
3 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/metal/metal_serialise.cpp
+2 -2
View File
@@ -244,9 +244,9 @@ void DoSerialise(SerialiserType &ser, RDMTL::RenderPipelineDescriptor &el)
SERIALISE_MEMBER(vertexBuffers);
SERIALISE_MEMBER(fragmentBuffers);
SERIALISE_MEMBER(supportIndirectCommandBuffers);
// TODO: will MTL::BinaryArchive need to be a wrapped resource
// TODO: when WrappedMTLBinaryArchive exists
// SERIALISE_MEMBER(binaryArchives);
// TODO: will MTL::DynamicLibrary need to be a wrapped resource
// TODO: when WrappedMTLDynamicLibrary exists
// SERIALISE_MEMBER(vertexPreloadedLibraries);
// SERIALISE_MEMBER(fragmentPreloadedLibraries);
SERIALISE_MEMBER(vertexLinkedFunctions);
renderdoc/driver/metal/metal_types.cpp
+12 -10
View File
@@ -371,11 +371,11 @@ RenderPipelineDescriptor::RenderPipelineDescriptor(MTL::RenderPipelineDescriptor
ValidData);
GETOBJCARRAY(PipelineBufferDescriptor, MAX_RENDER_PASS_BUFFER_ATTACHMENTS, fragmentBuffers,
ValidData);
// TODO: will MTL::BinaryArchive need to be a wrapped resource
// rdcarray<MTL::BinaryArchive*> binaryArchives;
// TODO: will MTL::DynamicLibrary need to be a wrapped resource
// rdcarray<MTL::DynamicLibrary*> vertexPreloadedLibraries;
// rdcarray<MTL::DynamicLibrary*> fragmentPreloadedLibraries;
// TODO: when WrappedMTLBinaryArchive exists
// GETWRAPPEDNSARRAY(BinaryArchive, binaryArchives);
// TODO: when WrappedMTLDynamicLibrary exists
// GETWRAPPEDNSARRAY(DynamicLibrary, vertexPreloadedLibraries);
// GETWRAPPEDNSARRAY(DynamicLibrary, fragmentPreloadedLibraries);
}
RenderPipelineDescriptor::operator MTL::RenderPipelineDescriptor *()
@@ -408,11 +408,13 @@ RenderPipelineDescriptor::operator MTL::RenderPipelineDescriptor *()
COPYTOOBJCARRAY(PipelineBufferDescriptor, vertexBuffers);
COPYTOOBJCARRAY(PipelineBufferDescriptor, fragmentBuffers);
objc->setSupportIndirectCommandBuffers(supportIndirectCommandBuffers);
// TODO: will MTL::BinaryArchive need to be a wrapped resource
// rdcarray<MTL::BinaryArchive*> binaryArchives;
// TODO: will MTL::DynamicLibrary need to be a wrapped resource
// rdcarray<MTL::DynamicLibrary*> vertexPreloadedLibraries;
// rdcarray<MTL::DynamicLibrary*> fragmentPreloadedLibraries;
// TODO: when WrappedMTLBinaryArchive exists
// objc->setBinaryArchives(CreateUnwrappedNSArray<MTL::BinaryArchive *>(binaryArchives));
// TODO: when WrappedMTLDynamicLibrary exists
// objc->setVertexPreloadedLibraries(CreateUnwrappedNSArray<MTL::DynamicLibrary
// *>(vertexPreloadedLibraries));
// objc->setFragmentPreloadedLibraries(CreateUnwrappedNSArray<MTL::DynamicLibrary
// *>(fragmentPreloadedLibraries));
vertexLinkedFunctions.CopyTo(objc->vertexLinkedFunctions());
fragmentLinkedFunctions.CopyTo(objc->fragmentLinkedFunctions());
objc->setSupportAddingVertexBinaryFunctions(supportAddingVertexBinaryFunctions);
renderdoc/driver/metal/metal_types.h
+5 -5
View File
@@ -266,11 +266,11 @@ struct RenderPipelineDescriptor
rdcarray<PipelineBufferDescriptor> vertexBuffers;
rdcarray<PipelineBufferDescriptor> fragmentBuffers;
bool supportIndirectCommandBuffers = false;
// TODO: will MTL::BinaryArchive need to be a wrapped resource
// rdcarray<MTL::BinaryArchive*> binaryArchives;
// TODO: will MTL::DynamicLibrary need to be a wrapped resource
// rdcarray<MTL::DynamicLibrary*> vertexPreloadedLibraries;
// rdcarray<MTL::DynamicLibrary*> fragmentPreloadedLibraries;
// TODO: when WrappedMTLBinaryArchive exists
// rdcarray<WrappedMTLBinaryArchive*> binaryArchives;
// TODO: when WrappedMTLDynamicLibrary exists
// rdcarray<WrappedMTLDynamicLibrary*> vertexPreloadedLibraries;
// rdcarray<WrappedMTLDynamicLibrary*> fragmentPreloadedLibraries;
LinkedFunctions vertexLinkedFunctions;
LinkedFunctions fragmentLinkedFunctions;
bool supportAddingVertexBinaryFunctions = false;