lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-27 12:21:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

D3D11 Discard bug fix for Dynamic, Staging Buffers

Browse Source 
Staging buffers can't use D3D11_MAP_WRITE_DISCARD.
The memory copy loop was counting in bytes but copying in 4-byte chunks leading to memory trampling.
This commit is contained in:
Jake Turner
2023-12-14 11:39:09 +00:00
parent d33ad62a26
commit 3766b9fa2f
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/d3d11/d3d11_debug.cpp
+6 -3
View File
@@ -403,17 +403,20 @@ void D3D11DebugManager::FillWithDiscardPattern(DiscardType type, ID3D11Resource
if(desc.CPUAccessFlags & D3D11_CPU_ACCESS_WRITE)
{
D3D11_MAPPED_SUBRESOURCE mapped = {};
HRESULT hr = m_pImmediateContext->Map(res, 0, D3D11_MAP_WRITE_DISCARD, 0, &mapped);
D3D11_MAP mapping =
(desc.Usage == D3D11_USAGE_DYNAMIC) ? D3D11_MAP_WRITE_DISCARD : D3D11_MAP_WRITE;
HRESULT hr = m_pImmediateContext->Map(res, 0, mapping, 0, &mapped);
m_pDevice->CheckHRESULT(hr);
if(SUCCEEDED(hr))
{
byte *dst = (byte *)mapped.pData;
dst += pRect[r].left;
for(size_t i = 0; i < size; i++)
size_t copyStride = sizeof(uint32_t);
for(size_t i = 0; i < size; i += copyStride)
{
memcpy(dst, &value, RDCMIN(sizeof(uint32_t), size - i));
dst += sizeof(uint32_t);
dst += copyStride;
}
m_pImmediateContext->Unmap(res, 0);