lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-09-02 20:05:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash if doing AccessChain or CompositeExtract on unknown id

Browse Source
This commit is contained in:
baldurk
2016-02-07 18:41:51 +01:00
parent 2bf4db2c1c
commit 3e8d4edf6d
1 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/shaders/spirv/spirv_disassemble.cpp
+16 -3
View File
@@ -652,6 +652,22 @@ struct SPVInstruction
case spv::OpAccessChain:
{
RDCASSERT(op);
string composite;
op->GetArg(ids, 0, composite);
// unknown argument, we can't access chain it
if(op->arguments[0]->var == NULL && op->arguments[0]->op == NULL)
{
string ret = "";
if(!inlineOp)
ret = StringFormat::Fmt("%s %s = ", op->type->GetName().c_str(), GetIDName().c_str());
ret += composite + "....";
return ret;
}
SPVTypeData *type = op->arguments[0]->var ? op->arguments[0]->var->type : op->arguments[0]->op->type;
@@ -760,9 +776,6 @@ struct SPVInstruction
string ret = "";
string composite;
op->GetArg(ids, 0, composite);
if(opcode == spv::OpCompositeInsert)
{
string insertObj;