lee/renderdoc
1
0 Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-11-15 18:31:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

DXIL Debugger more error checking when getting inputs for BufferLoad

Browse Source 
Be more explicit about which inputs to get based on opcode and not if the UAV has texture
This commit is contained in:
Jake Turner committed 2024-12-16 12:16:28 +00:00
1 parent 69a0272e11
commit 479fcce4c2
1 file changed
+15 -2
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/shaders/dxil/dxil_debug.cpp
+15 -2
View File
@@ -2062,15 +2062,28 @@ bool ThreadState::ExecuteInstruction(DebugAPIWrapper *apiWrapper,
uint32_t texCoords[3] = {0, 0, 0};
uint32_t elemIdx = 0;
ShaderVariable arg;
if(!texData)
if((dxOpCode == DXOp::BufferLoad) || (dxOpCode == DXOp::RawBufferLoad) ||
(dxOpCode == DXOp::RawBufferStore) || (dxOpCode == DXOp::BufferStore))
{
// BufferLoad(res,index,wot)
// BufferStore(uav,coord0,coord1,value0,value1,value2,value3,mask)
// RawBufferLoad(srv,index,elementOffset,mask,alignment)
// RawBufferStore(uav,index,elementOffset,value0,value1,value2,value3,mask,alignment)
if(GetShaderVariable(inst.args[2], opCode, dxOpCode, arg))
elemIdx = arg.value.u32v[0];
if(GetShaderVariable(inst.args[3], opCode, dxOpCode, arg))
dataOffset = arg.value.u64v[0];
if(texData)
{
texCoords[0] = elemIdx;
texCoords[1] = (uint32_t)dataOffset;
}
}
else
else if((dxOpCode == DXOp::TextureLoad) || (dxOpCode == DXOp::TextureStore))
{
RDCASSERT(texData);
// TextureLoad(srv,mipLevelOrSampleCount,coord0,coord1,coord2,offset0,offset1,offset2)
// TextureStore(srv,coord0,coord1,coord2,value0,value1,value2,value3,mask)
size_t offsetStart = (dxOpCode == DXOp::TextureLoad) ? 3 : 2;
if(GetShaderVariable(inst.args[offsetStart], opCode, dxOpCode, arg))
texCoords[0] = (int8_t)arg.value.u32v[0];