lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-04 17:10:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix QString warning about calling .arg() too many times

Browse Source
This commit is contained in:
baldurk
2017-02-17 13:25:04 +00:00
parent b76ca0f060
commit 486f8d4441
1 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Windows/PipelineState/GLPipelineStateViewer.cpp
+23 -20
View File
@@ -984,34 +984,37 @@ QString GLPipelineStateViewer::MakeGenericValueString(
uint32_t compCount, FormatComponentType compType,
const GLPipelineState::VertexInput::VertexAttribute &val)
{
QString fmtstr = "";
QString ret = "";
if(compCount == 1)
fmtstr = "<%1>";
ret = "<%1>";
else if(compCount == 2)
fmtstr = "<%1, %2>";
ret = "<%1, %2>";
else if(compCount == 3)
fmtstr = "<%1, %2, %3>";
ret = "<%1, %2, %3>";
else if(compCount == 4)
fmtstr = "<%1, %2, %3, %4>";
ret = "<%1, %2, %3, %4>";
if(compType == eCompType_UInt)
return QString(fmtstr)
.arg(val.GenericValue.u[0])
.arg(val.GenericValue.u[1])
.arg(val.GenericValue.u[2])
.arg(val.GenericValue.u[3]);
{
for(uint32_t i = 0; i < compCount; i++)
ret = ret.arg(val.GenericValue.u[i]);
return ret;
}
else if(compType == eCompType_SInt)
return QString(fmtstr)
.arg(val.GenericValue.i[0])
.arg(val.GenericValue.i[1])
.arg(val.GenericValue.i[2])
.arg(val.GenericValue.i[3]);
{
for(uint32_t i = 0; i < compCount; i++)
ret = ret.arg(val.GenericValue.i[i]);
return ret;
}
else
return QString(fmtstr)
.arg(val.GenericValue.f[0])
.arg(val.GenericValue.f[1])
.arg(val.GenericValue.f[2])
.arg(val.GenericValue.f[3]);
{
for(uint32_t i = 0; i < compCount; i++)
ret = ret.arg(val.GenericValue.f[i]);
return ret;
}
}
GLPipelineStateViewer::GLReadWriteType GLPipelineStateViewer::GetGLReadWriteType(ShaderResource res)