lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-29 13:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make sure all SSA lifetimes extend to a uniform block (not a loop block)

Browse Source 
* Update any SSA max points which are inside a loop to the next uniform block
* This covers the case of SSA IDs that are assigned to but never accessed
This commit is contained in:
Jake Turner
2025-05-08 15:20:24 +01:00
parent d48f217119
commit 4940451e4b
1 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/shaders/dxil/dxil_debug.cpp
+15 -7
View File
@@ -8741,14 +8741,7 @@ ShaderDebugTrace *Debugger::BeginDebug(uint32_t eventId, const DXBC::DXBCContain
if(inst.op == Operation::Phi)
continue;
// If the current block is in a loop, set the execution point to the next uniform block
ExecPointReference maxPoint(curBlock, maxInst);
if(loopBlocks.contains(curBlock))
{
uint32_t nextUniformBlock = controlFlow.GetNextUniformBlock(curBlock);
maxPoint.block = nextUniformBlock;
maxPoint.instruction = f->blocks[nextUniformBlock]->startInstructionIdx + 1;
}
for(uint32_t a = 0; a < inst.args.size(); ++a)
{
DXIL::Value *arg = inst.args[a];
@@ -8780,6 +8773,21 @@ ShaderDebugTrace *Debugger::BeginDebug(uint32_t eventId, const DXBC::DXBCContain
// If these do not match in size that means there is a result SSA that is never read
RDCASSERTEQUAL(ssaRefs.size(), ssaMaxExecPoints.size());
// Update any SSA max points which are inside a loop to the next uniform block
// This covers the case of SSA IDs that are assigned to but never accessed
for(auto &it : ssaMaxExecPoints)
{
ExecPointReference &maxPoint = it.second;
uint32_t block = maxPoint.block;
// If the current block is in a loop, set the execution point to the next uniform block
if(loopBlocks.contains(block))
{
uint32_t nextUniformBlock = controlFlow.GetNextUniformBlock(block);
maxPoint.block = nextUniformBlock;
maxPoint.instruction = f->blocks[nextUniformBlock]->startInstructionIdx + 1;
}
}
// store the block captured SSA IDs used as arguments to phi nodes
FunctionInfo::PhiReferencedIdsPerBlock &phiReferencedIdsPerBlock =
info.phiReferencedIdsPerBlock;